Support whitespace options when measuring text - #24
Merged
Conversation
It can be useful to have control over whitespace. At the moment the `measure` function in `lib/measure/index.js` assumes you want "normal" HTML/SVG whitespace handling (like CSS's `white-space: normal`). This PR adds two arguments to the function that allow the caller to control whether the whitespace is trimmed or collapsed. It also makes the three measuring handlers consistent: before now, only the canvas handler trimmed and collapsed whitespace; the SVG and "dumb" handler left the text as-is. When there are line breaks in the text but we're either not trimming whitespace or not collapsing whitespace, the function does what HTML's input element does and convert all "\n" to " ". Fixes#23.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It can be useful to have control over whitespace. At the moment the
measurefunction inlib/measure/index.jsassumes you want "normal" HTML/SVG whitespace handling (like CSS'swhite-space: normal). This PR adds two arguments to the function that allow the caller to control whether the whitespace is trimmed or collapsed. It also makes the three measuring handlers consistent: before now, only the canvas handler trimmed and collapsed whitespace; the SVG and "dumb" handler left the text as-is.When there are line breaks in the text but we're either not trimming whitespace or not collapsing whitespace, the function does what HTML's input element does and converts all "\n" to " ".
Fixes#23.