feat: add link to the logs folder in borg warnings - #1609
Conversation
real-yfprojects
left a comment
There was a problem hiding this comment.
What purpose serves the last commit? You don't have to modify any translation files. That's all done automatically in preparation of a release. There is a rule for that in our make file.
You will need to use translate instead of trans_late else the translations won't be loaded at runtime. Please tell me if any part of the contributing docs is unclear.
This reverts commit dfc5bff.
real-yfprojects
left a comment
There was a problem hiding this comment.
In my local testing Qt won't recognise the translate statements spanning over multiple lines
Luckily it seems to work again/with this PR.
…/vorta into feat/link-logs-in-warnings
…k-logs-in-warnings
…/vorta into feat/link-logs-in-warnings
|
@diivi Can you rebase onto master and adjust this PR. |
ThomasWaldmann
left a comment
There was a problem hiding this comment.
Guess the checking for rc 0, 1, 2 could be improved, but that is not in scope of this PR.
0 == OK
1 == Warning
2 == Error
Any messages derived from this should use a corresponding wording.
In case a borg job finishes with warning, vorta will display it and tell the user to have a look in the logs. This adds a clickable link to the log message that opens the default file explorer at the log location. * src/vorta/application.py (VortaApp.check_failed_response): Improve wording of warning message and link logs. * src/vorta/borg/create.py (BorgCreateJob.process_result): Link logs. * src/vorta/borg/compact.py (BorgCompactJob.finished_event): ^^ * src/vorta/borg/check.py (BorgCheckJob.finished_event): ^^ * src/vorta/assets/UI/mainwindow.ui : Enable `openExternalLinks` for `progressText` label.
Description
Adds a link to the vorta logs folder on the user's device in the
progressTextqLabel.Please let me know in what state I should leave the strings for translation, thanks.
Related Issue
#1486
Motivation and Context
Easier to open the logs folder without having to look for it (better UX).
Screenshots (if appropriate):
Types of changes
Checklist:
I provide my contribution under the terms of the license of this repository and I affirm the Developer Certificate of Origin.