feat: assign names to repos - #1665
Conversation
real-yfprojects
left a comment
There was a problem hiding this comment.
I think the repo id should be used when the user didn't specify a repo name.
|
I'd still show the repo URL behind the name in the dropdown and on the archives tab. Maybe And have "optional" in the placeholder. E.g. |
|
I think a tooltip showing the complete repo path would be useful since it sometimes doesn't fit into the displaying widget. |
|
Looking good. However I am unsure whether I like using the repo id as a repo name for existing repos. I don't see any value in having 1,2,3 and so on in front of my repo paths/urls. I believe its better to only show the name if the user specified one. And we should provide a way to edit the repo name. This could be a task for a future PR. |
Co-authored-by: yfprojects <62463991+real-yfprojects@users.noreply.github.com>
… into feat/add-name-to-repos
|
With separators (2e27718) |
|
I think it's great like this. |
|
I propose this, in accordance to the HIG: |
|
This is OK to merge for me, but has pending feedback from @real-yfprojects regarding the small UI thing. |
Can you share the code/property? |
23b1d68 to
5ade789
Compare
|
Right. I had to update some icons due to licensing and forgot to adjust the
This is needed for all icons, so they can be colored light/dark. I still need to make a change for Google's Material icons license, so could also make the change there, if it doesn't fit this PR. |
|
Done |
|
Thanks for sneaking this in. Will test locally in a few hours and then merge. |
|
Works as expected locally and implementation looks reasonable. Congrats on another successful PR, @diivi 👏 |





Description
Adds a "name" field in the new repo creation form and displays it where I thought it was suitable.
Related Issue
Fixes #1388
Motivation and Context
Easier to remember and tag repos.
How Has This Been Tested?
Tried creating a repo and looking at the places where I rendered the name instead of the url.
Screenshots (if appropriate):
Types of changes
Checklist:
I provide my contribution under the terms of the license of this repository and I affirm the Developer Certificate of Origin.