Skip to content

Add profile name to error notification - #1703

Closed
mrwsl wants to merge 2 commits into
borgbase:masterfrom
mrwsl:patch
Closed

mrwsl wants to merge 2 commits into
borgbase:masterfrom
mrwsl:patch

Conversation

@mrwsl

@mrwsl mrwsl commented Apr 26, 2023

Copy link
Copy Markdown
Contributor

Description

In a similar fashion like #1637 the commit adds the profile name to the error notification

Related Issue

None

Motivation and Context

Provide further details about the profile in the notification.

How Has This Been Tested?

Tested locally with manually created error.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING guide.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

I provide my contribution under the terms of the license of this repository and I affirm the Developer Certificate of Origin.

@real-yfprojects real-yfprojects left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 💯

@real-yfprojects
real-yfprojects requested a review from m3nu April 29, 2023 17:46
@mrwsl mrwsl closed this Jun 1, 2023
@mrwsl
mrwsl deleted the patch branch June 1, 2023 12:20
@m3nu

m3nu commented Jun 1, 2023

Copy link
Copy Markdown
Contributor

Is this already resolved elsewhere?

@mrwsl

mrwsl commented Jun 1, 2023

Copy link
Copy Markdown
Contributor Author

Oh, no. I did this accidentally. I thought it was already merged and wanted to delete the branch in my fork. Any idea on how to revert this?

@Hofer-Julian

Copy link
Copy Markdown
Collaborator

Oh, no. I did this accidentally. I thought it was already merged and wanted to delete the branch in my fork. Any idea on how to revert this?

It is just one line of code, it's probably the easiest to just create a new pull request 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants