Exclude GUI II (without exclude-if-present) - #1846
Conversation
Co-authored-by: yfprojects <62463991+real-yfprojects@users.noreply.github.com>
…patterns using shift
|
Hey, thanks! I'm out for Diwali holidays so I couldn't get back to you. Happy to see this move forward though. I'll try to help with the exclude if present dialog in the future. |
|
Just a few final edits here. If anyone has time for testing, that would be great and speed up the next beta release.
|
|
Upon thinking about it, it may be better to have an internal ID/slug for each exclusion preset and not the name. Since we may want to change or translate the name later. If there are no more change suggestions, I'll merge this and do another beta, Since it seems hard to get any testing of a PR right now. |
|
I'll have a look tomorrow |
real-yfprojects
left a comment
There was a problem hiding this comment.
The issue with dropping the exclude-if-present widget is that its contents still apply although the user is neither aware of it nor can he edit those entries.
The rest looks good and seems to be working.
Thanks for looking into this! I've also disabled processing this setting by Borg. Until we may add it back in some other way. |
|
MacOS tests seem to work again 🎉 |

Continues #1742 with original scope only.
All based on @diivi work, who couldn't finish this GSoC subproject.