feat: relist offer - #596

Merged
albertfolch-redeemeum merged 3 commits into
mainfrom
568-offer-relist
Apr 24, 2023
Merged

feat: relist offer#596
albertfolch-redeemeum merged 3 commits into
mainfrom
568-offer-relist

Conversation

@albertfolch-redeemeum

@albertfolch-redeemeumalbertfolch-redeemeum commented Apr 21, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor
  • feat: relist offer
  • improved types
  • fixed width of draft modal: it got too big in big screens
  • fix loading spinner when you want to export exchanges with delivery data: if you clicked on the button and then cancel the confirmation of the transaction to enable identity, then the loading spinner was not removed
  • fix datepicker so that if you dont specify an initial date, you see the "Choose date..." text & if you click on a disable date, you see the same text
  • extracted the logic to create an offer/s into an useCreateOffers hook
  • remove useless code
  • fixed low priority error you get after creating an offer and seeing the success modal (BigNumber error in console if the offer is not token gated)
  • fix: in the modal to export the exchange delivery data, changed the initial value to the beginning of the month & remove disable behaviour on the export in option 2
  • fix: style/overflow of export exchanges with delivery data modal (calendar of the datepicker was being cut off)

@albertfolch-redeemeum
albertfolch-redeemeum requested a review from a teamApril 21, 2023 15:15
@albertfolch-redeemeumalbertfolch-redeemeum linked an issue Apr 21, 2023 that may be closed by this pull request
Offer Relist #568
Closed
@albertfolch-redeemeum
albertfolch-redeemeum marked this pull request as draft April 21, 2023 15:15
@cloudflare-workers-and-pages

cloudflare-workers-and-pagesBot commented Apr 21, 2023•
edited
Loading

Copy link
Copy Markdown

Deploying with Cloudflare Pages Cloudflare Pages

Latest commit:f61df30
Status: ✅ Deploy successful!
Preview URL:https://bdcb0ecd.interface-a9d.pages.dev
Branch Preview URL:https://568-offer-relist.interface-a9d.pages.dev

View logs

@albertfolch-redeemeum
albertfolch-redeemeum changed the base branch from main to mvfw-2023April 21, 2023 15:23
@albertfolch-redeemeum
albertfolch-redeemeum changed the base branch from mvfw-2023 to mainApril 21, 2023 15:24
@albertfolch-redeemeum
albertfolch-redeemeum marked this pull request as ready for review April 21, 2023 15:24
@levalleux-ludo

levalleux-ludo commented Apr 21, 2023•
edited
Loading

Copy link
Copy Markdown
Member

A bit confused here: https://api.thegraph.com/subgraphs/name/bosonprotocol/mumbai-testing/graphql?query=query+MyQuery+%7B%0A++productV1Products%28%0A++++where%3A+%7Buuid_in%3A+%5B"1584b4c-0217-68a0-e0a4-b82b02708fd2"%2C+"0b657a3-7302-e733-af74-37d08806cc7c"%5D%7D%0A++%29+%7B%0A++++id%0A++++variants+%7B%0A++++++offer+%7B%0A++++++++id%0A++++++++metadataUri%0A++++++++metadataHash%0A++++++++metadata+%7B%0A++++++++++name%0A++++++++++...+on+ProductV1MetadataEntity+%7B%0A++++++++++++id%0A++++++++++++name%0A++++++++++++uuid%0A++++++++++++productV1Seller+%7B%0A++++++++++++++name%0A++++++++++++++externalUrl%0A++++++++++++%7D%0A++++++++++++licenseUrl%0A++++++++++%7D%0A++++++++%7D%0A++++++%7D%0A++++%7D%0A++%7D%0A%7D

The 2 offers are the one that was expired and the relisted one.
The 2 offers have the same UUID
But the product UUID is different.
I think it should be the opposite:

  • offer UUID should be different as the offer ID are different on-chain
  • product UUID should be the same (?) as the offer just relist the same product with the same variations.

@levalleux-ludo

levalleux-ludo commented Apr 21, 2023

Copy link
Copy Markdown
Member

What happen if I relist an offer that is still valid?
Is the old one voided?
How is the dApp supporting such a case?

@albertfolch-redeemeum

albertfolch-redeemeum commented Apr 21, 2023

Copy link
Copy Markdown
ContributorAuthor

What happen if I relist an offer that is still valid? Is the old one voided? How is the dApp supporting such a case?

you can relist any offer, no restrictions and no side effects

@albertfolch-redeemeum

albertfolch-redeemeum commented Apr 21, 2023

Copy link
Copy Markdown
ContributorAuthor

A bit confused here: https://api.thegraph.com/subgraphs/name/bosonprotocol/mumbai-testing/graphql?query=query+MyQuery+%7B%0A++productV1Products%28%0A++++where%3A+%7Buuid_in%3A+%5B"1584b4c-0217-68a0-e0a4-b82b02708fd2"%2C+"0b657a3-7302-e733-af74-37d08806cc7c"%5D%7D%0A++%29+%7B%0A++++id%0A++++variants+%7B%0A++++++offer+%7B%0A++++++++id%0A++++++++metadataUri%0A++++++++metadataHash%0A++++++++metadata+%7B%0A++++++++++name%0A++++++++++...+on+ProductV1MetadataEntity+%7B%0A++++++++++++id%0A++++++++++++name%0A++++++++++++uuid%0A++++++++++++productV1Seller+%7B%0A++++++++++++++name%0A++++++++++++++externalUrl%0A++++++++++++%7D%0A++++++++++++licenseUrl%0A++++++++++%7D%0A++++++++%7D%0A++++++%7D%0A++++%7D%0A++%7D%0A%7D

The 2 offers are the one that was expired and the relisted one. The 2 offers have the same UUID But the product UUID is different. I think it should be the opposite:

  • offer UUID should be different as the offer ID are different on-chain
  • product UUID should be the same (?) as the offer just relist the same product with the same variations.

The 2 offers have the same UUID

this is a bug

product UUID should be the same (?) as the offer just relist the same product with the same variations.

why the same? I think it should be different, everything different, just different dates...basically the same behaviour as if you were to create the same product using local storage and setting the dates differently (no actual relationship with the 'old' offer) ...maybe it should be called 'duplicate' instead of 'relist' then

@levalleux-ludo

levalleux-ludo commented Apr 21, 2023•
edited
Loading

Copy link
Copy Markdown
Member

A bit confused here: https://api.thegraph.com/subgraphs/name/bosonprotocol/mumbai-testing/graphql?query=query+MyQuery+%7B%0A++productV1Products%28%0A++++where%3A+%7Buuid_in%3A+%5B"1584b4c-0217-68a0-e0a4-b82b02708fd2"%2C+"0b657a3-7302-e733-af74-37d08806cc7c"%5D%7D%0A++%29+%7B%0A++++id%0A++++variants+%7B%0A++++++offer+%7B%0A++++++++id%0A++++++++metadataUri%0A++++++++metadataHash%0A++++++++metadata+%7B%0A++++++++++name%0A++++++++++...+on+ProductV1MetadataEntity+%7B%0A++++++++++++id%0A++++++++++++name%0A++++++++++++uuid%0A++++++++++++productV1Seller+%7B%0A++++++++++++++name%0A++++++++++++++externalUrl%0A++++++++++++%7D%0A++++++++++++licenseUrl%0A++++++++++%7D%0A++++++++%7D%0A++++++%7D%0A++++%7D%0A++%7D%0A%7D

The 2 offers are the one that was expired and the relisted one. The 2 offers have the same UUID But the product UUID is different. I think it should be the opposite:

  • offer UUID should be different as the offer ID are different on-chain
  • product UUID should be the same (?) as the offer just relist the same product with the same variations.

As a consequence of having the same offer UUID, the licenseURL and externalURL set in the new offer metadata are still referencing the old expired offer.
Check here: https://api.thegraph.com/subgraphs/name/bosonprotocol/mumbai-testing/graphql?query=query+MyQuery+%7B%0A++productV1Products%28where%3A+%7Buuid_in%3A+%5B"15dc403-714-57bf-e35b-44610bff33e4"%2C+"4e823-c447-be75-d05a-f36270e5afe"%5D%7D%29+%7B%0A++++id%0A++++variants+%7B%0A++++++offer+%7B%0A++++++++id%0A++++++++metadataUri%0A++++++++metadataHash%0A++++++++metadata+%7B%0A++++++++++name%0A++++++++++...+on+ProductV1MetadataEntity+%7B%0A++++++++++++id%0A++++++++++++name%0A++++++++++++uuid%0A++++++++++++productV1Seller+%7B%0A++++++++++++++name%0A++++++++++++++externalUrl%0A++++++++++++%7D%0A++++++++++++licenseUrl%0A++++++++++++productUuid%0A++++++++++++product+%7B%0A++++++++++++++uuid%0A++++++++++++%7D%0A++++++++++%7D%0A++++++++++licenseUrl%0A++++++++++externalUrl%0A++++++++%7D%0A++++++%7D%0A++++%7D%0A++%7D%0A%7D

@albertfolch-redeemeum

albertfolch-redeemeum commented Apr 24, 2023

Copy link
Copy Markdown
ContributorAuthor

A bit confused here: https://api.thegraph.com/subgraphs/name/bosonprotocol/mumbai-testing/graphql?query=query+MyQuery+%7B%0A++productV1Products%28%0A++++where%3A+%7Buuid_in%3A+%5B"1584b4c-0217-68a0-e0a4-b82b02708fd2"%2C+"0b657a3-7302-e733-af74-37d08806cc7c"%5D%7D%0A++%29+%7B%0A++++id%0A++++variants+%7B%0A++++++offer+%7B%0A++++++++id%0A++++++++metadataUri%0A++++++++metadataHash%0A++++++++metadata+%7B%0A++++++++++name%0A++++++++++...+on+ProductV1MetadataEntity+%7B%0A++++++++++++id%0A++++++++++++name%0A++++++++++++uuid%0A++++++++++++productV1Seller+%7B%0A++++++++++++++name%0A++++++++++++++externalUrl%0A++++++++++++%7D%0A++++++++++++licenseUrl%0A++++++++++%7D%0A++++++++%7D%0A++++++%7D%0A++++%7D%0A++%7D%0A%7D
The 2 offers are the one that was expired and the relisted one. The 2 offers have the same UUID But the product UUID is different. I think it should be the opposite:

  • offer UUID should be different as the offer ID are different on-chain
  • product UUID should be the same (?) as the offer just relist the same product with the same variations.

As a consequence of having the same offer UUID, the licenseURL and externalURL set in the new offer metadata are still referencing the old expired offer. Check here: https://api.thegraph.com/subgraphs/name/bosonprotocol/mumbai-testing/graphql?query=query+MyQuery+%7B%0A++productV1Products%28where%3A+%7Buuid_in%3A+%5B"15dc403-714-57bf-e35b-44610bff33e4"%2C+"4e823-c447-be75-d05a-f36270e5afe"%5D%7D%29+%7B%0A++++id%0A++++variants+%7B%0A++++++offer+%7B%0A++++++++id%0A++++++++metadataUri%0A++++++++metadataHash%0A++++++++metadata+%7B%0A++++++++++name%0A++++++++++...+on+ProductV1MetadataEntity+%7B%0A++++++++++++id%0A++++++++++++name%0A++++++++++++uuid%0A++++++++++++productV1Seller+%7B%0A++++++++++++++name%0A++++++++++++++externalUrl%0A++++++++++++%7D%0A++++++++++++licenseUrl%0A++++++++++++productUuid%0A++++++++++++product+%7B%0A++++++++++++++uuid%0A++++++++++++%7D%0A++++++++++%7D%0A++++++++++licenseUrl%0A++++++++++externalUrl%0A++++++++%7D%0A++++++%7D%0A++++%7D%0A++%7D%0A%7D

this should be fixed now, for example:
https://api.thegraph.com/subgraphs/name/bosonprotocol/mumbai-testing/graphql?query=query+MyQuery+%7B%0A++productV1Products%28orderBy%3A%22id%22%2C+orderDirection%3A%22desc%22%2C+where%3A+%7Buuid_in%3A+%5B%22a6361f3-34d-cc0a-1263-37bf0c050ae%22%2C+%2240a15bc-8b85-8617-515b-50cafb776a7%22%5D%7D%29+%7B%0A++++id%0A++++variants+%7B%0A++++++offer+%7B%0A++++++++createdAt%0A++++++++id%0A++++++++metadataUri%0A++++++++metadataHash%0A++++++++metadata+%7B%0A++++++++++name%0A++++++++++...+on+ProductV1MetadataEntity+%7B%0A++++++++++++id%0A++++++++++++name%0A++++++++++++uuid%0A++++++++++++productV1Seller+%7B%0A++++++++++++++name%0A++++++++++++++externalUrl%0A++++++++++++%7D%0A++++++++++++licenseUrl%0A++++++++++++productUuid%0A++++++++++++product+%7B%0A++++++++++++++uuid%0A++++++++++++%7D%0A++++++++++%7D%0A++++++++++licenseUrl%0A++++++++++externalUrl%0A++++++++%7D%0A++++++%7D%0A++++%7D%0A++%7D%0A%7D

@levalleux-ludo

@albertfolch-redeemeum
albertfolch-redeemeum deleted the 568-offer-relist branch April 24, 2023 14:16
albertfolch-redeemeum added a commit that referenced this pull request Apr 25, 2023
@albertfolch-redeemeumAlbert Folch
feat: relist offer (#596)
d925ad0
* feat: relist offer
* refactor: remove comments
* fix: uuids
albertfolch-redeemeum added a commit that referenced this pull request Apr 27, 2023
@albertfolch-redeemeum
feat: relist offer (#596) (#606)
ec355d2
* feat: relist offer (#596)
* feat: relist offer
* refactor: remove comments
* fix: uuids
* fix: disable relist button if you are not the operator
albertfolch-redeemeum added a commit that referenced this pull request May 11, 2023
@albertfolch-redeemeum@levalleux-ludo
feat: mvfw 2023 (#617)
3347d99
* chore: add sellers 184,190,191 in curation list
* chore: add seller id 195 in curation list
* add seller id 196 in curation list
* chore: upgrade to react-kit 0.16.2-alpha.16
* chore: add seller 202 in curation list (#574)
* chore: add seller 197 in seller curation list (#576)
* fix: custom fonts (#579)
* fix: custom font
* refactor: remove wrong import
* feat: add neuropolitical custom font (#587)
* chore: add seller 207 in seller curation list (#591)
* fix: tabnapping protection (#594)
* feat: change seller deposit copy (#603)
* feat: remove promotional banner (#601) (#604)
* feat: remove promotional banner
* fix: build
* feat: relist offer (#596) (#606)
* feat: relist offer (#596)
* feat: relist offer
* refactor: remove comments
* fix: uuids
* fix: disable relist button if you are not the operator
---------
Co-authored-by: Ludovic Levalleux <levalleux_ludo@hotmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@levalleux-ludolevalleux-ludolevalleux-ludo approved these changes

Assignees

@albertfolch-redeemeumalbertfolch-redeemeum

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Offer Relist

2 participants

@albertfolch-redeemeum@levalleux-ludo
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
feat: relist offer - #596
Merged
albertfolch-redeemeum merged 3 commits into
mainfrom 
568-offer-relist
Apr 24, 2023
Merged
feat: relist offer#596
albertfolch-redeemeum merged 3 commits into
mainfrom 
568-offer-relist
Conversation
@albertfolch-redeemeum
@albertfolch-redeemeumalbertfolch-redeemeum
commented
Apr 21, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
  • feat: relist offer
  • improved types
  • fixed width of draft modal: it got too big in big screens
  • fix loading spinner when you want to export exchanges with delivery data: if you clicked on the button and then cancel the confirmation of the transaction to enable identity, then the loading spinner was not removed
  • fix datepicker so that if you dont specify an initial date, you see the "Choose date..." text & if you click on a disable date, you see the same text
  • extracted the logic to create an offer/s into an useCreateOffers hook
  • remove useless code
  • fixed low priority error you get after creating an offer and seeing the success modal (BigNumber error in console if the offer is not token gated)
  • fix: in the modal to export the exchange delivery data, changed the initial value to the beginning of the month & remove disable behaviour on the export in option 2
  • fix: style/overflow of export exchanges with delivery data modal (calendar of the datepicker was being cut off)
@albertfolch-redeemeum
albertfolch-redeemeum
requested a review
from a teamApril 21, 2023 15:15
@albertfolch-redeemeumalbertfolch-redeemeum
linked an issue
Apr 21, 2023
that may be
closed
by this pull request


Offer Relist
#568

Closed

@albertfolch-redeemeum
albertfolch-redeemeum
marked this pull request as draft
April 21, 2023 15:15
@cloudflare-workers-and-pages
cloudflare-workers-and-pagesBot
commented
Apr 21, 2023•

edited

Loading

Copy link


Copy Markdown

Deploying with Cloudflare Pages Cloudflare Pages
Latest commit:f61df30
Status: ✅ Deploy successful!
Preview URL:https://bdcb0ecd.interface-a9d.pages.dev
Branch Preview URL:https://568-offer-relist.interface-a9d.pages.dev
View logs
@albertfolch-redeemeum
albertfolch-redeemeum
changed the base branch from
main
to
mvfw-2023April 21, 2023 15:23
@albertfolch-redeemeum
albertfolch-redeemeum
changed the base branch from
mvfw-2023
to
mainApril 21, 2023 15:24
@albertfolch-redeemeum
albertfolch-redeemeum
marked this pull request as ready for review
April 21, 2023 15:24
@levalleux-ludo
levalleux-ludo
commented
Apr 21, 2023•

edited

Loading

Copy link


Copy Markdown

Member
A bit confused here: https://api.thegraph.com/subgraphs/name/bosonprotocol/mumbai-testing/graphql?query=query+MyQuery+%7B%0A++productV1Products%28%0A++++where%3A+%7Buuid_in%3A+%5B"1584b4c-0217-68a0-e0a4-b82b02708fd2"%2C+"0b657a3-7302-e733-af74-37d08806cc7c"%5D%7D%0A++%29+%7B%0A++++id%0A++++variants+%7B%0A++++++offer+%7B%0A++++++++id%0A++++++++metadataUri%0A++++++++metadataHash%0A++++++++metadata+%7B%0A++++++++++name%0A++++++++++...+on+ProductV1MetadataEntity+%7B%0A++++++++++++id%0A++++++++++++name%0A++++++++++++uuid%0A++++++++++++productV1Seller+%7B%0A++++++++++++++name%0A++++++++++++++externalUrl%0A++++++++++++%7D%0A++++++++++++licenseUrl%0A++++++++++%7D%0A++++++++%7D%0A++++++%7D%0A++++%7D%0A++%7D%0A%7D
The 2 offers are the one that was expired and the relisted one.

The 2 offers have the same UUID

But the product UUID is different.

I think it should be the opposite:
  • offer UUID should be different as the offer ID are different on-chain
  • product UUID should be the same (?) as the offer just relist the same product with the same variations.
@levalleux-ludo
levalleux-ludo
commented
Apr 21, 2023

Copy link


Copy Markdown

Member
What happen if I relist an offer that is still valid?

Is the old one voided?

How is the dApp supporting such a case?
@albertfolch-redeemeum
albertfolch-redeemeum
commented
Apr 21, 2023

Copy link


Copy Markdown

ContributorAuthor
What happen if I relist an offer that is still valid? Is the old one voided? How is the dApp supporting such a case?
you can relist any offer, no restrictions and no side effects
@albertfolch-redeemeum
albertfolch-redeemeum
commented
Apr 21, 2023

Copy link


Copy Markdown

ContributorAuthor
A bit confused here: https://api.thegraph.com/subgraphs/name/bosonprotocol/mumbai-testing/graphql?query=query+MyQuery+%7B%0A++productV1Products%28%0A++++where%3A+%7Buuid_in%3A+%5B"1584b4c-0217-68a0-e0a4-b82b02708fd2"%2C+"0b657a3-7302-e733-af74-37d08806cc7c"%5D%7D%0A++%29+%7B%0A++++id%0A++++variants+%7B%0A++++++offer+%7B%0A++++++++id%0A++++++++metadataUri%0A++++++++metadataHash%0A++++++++metadata+%7B%0A++++++++++name%0A++++++++++...+on+ProductV1MetadataEntity+%7B%0A++++++++++++id%0A++++++++++++name%0A++++++++++++uuid%0A++++++++++++productV1Seller+%7B%0A++++++++++++++name%0A++++++++++++++externalUrl%0A++++++++++++%7D%0A++++++++++++licenseUrl%0A++++++++++%7D%0A++++++++%7D%0A++++++%7D%0A++++%7D%0A++%7D%0A%7D
The 2 offers are the one that was expired and the relisted one. The 2 offers have the same UUID But the product UUID is different. I think it should be the opposite:
  • offer UUID should be different as the offer ID are different on-chain
  • product UUID should be the same (?) as the offer just relist the same product with the same variations.
The 2 offers have the same UUID
this is a bug
product UUID should be the same (?) as the offer just relist the same product with the same variations.
why the same? I think it should be different, everything different, just different dates...basically the same behaviour as if you were to create the same product using local storage and setting the dates differently (no actual relationship with the 'old' offer) ...maybe it should be called 'duplicate' instead of 'relist' then
@levalleux-ludo
levalleux-ludo
commented
Apr 21, 2023•

edited

Loading

Copy link


Copy Markdown

Member
A bit confused here: https://api.thegraph.com/subgraphs/name/bosonprotocol/mumbai-testing/graphql?query=query+MyQuery+%7B%0A++productV1Products%28%0A++++where%3A+%7Buuid_in%3A+%5B"1584b4c-0217-68a0-e0a4-b82b02708fd2"%2C+"0b657a3-7302-e733-af74-37d08806cc7c"%5D%7D%0A++%29+%7B%0A++++id%0A++++variants+%7B%0A++++++offer+%7B%0A++++++++id%0A++++++++metadataUri%0A++++++++metadataHash%0A++++++++metadata+%7B%0A++++++++++name%0A++++++++++...+on+ProductV1MetadataEntity+%7B%0A++++++++++++id%0A++++++++++++name%0A++++++++++++uuid%0A++++++++++++productV1Seller+%7B%0A++++++++++++++name%0A++++++++++++++externalUrl%0A++++++++++++%7D%0A++++++++++++licenseUrl%0A++++++++++%7D%0A++++++++%7D%0A++++++%7D%0A++++%7D%0A++%7D%0A%7D
The 2 offers are the one that was expired and the relisted one. The 2 offers have the same UUID But the product UUID is different. I think it should be the opposite:
  • offer UUID should be different as the offer ID are different on-chain
  • product UUID should be the same (?) as the offer just relist the same product with the same variations.
As a consequence of having the same offer UUID, the licenseURL and externalURL set in the new offer metadata are still referencing the old expired offer.

Check here: https://api.thegraph.com/subgraphs/name/bosonprotocol/mumbai-testing/graphql?query=query+MyQuery+%7B%0A++productV1Products%28where%3A+%7Buuid_in%3A+%5B"15dc403-714-57bf-e35b-44610bff33e4"%2C+"4e823-c447-be75-d05a-f36270e5afe"%5D%7D%29+%7B%0A++++id%0A++++variants+%7B%0A++++++offer+%7B%0A++++++++id%0A++++++++metadataUri%0A++++++++metadataHash%0A++++++++metadata+%7B%0A++++++++++name%0A++++++++++...+on+ProductV1MetadataEntity+%7B%0A++++++++++++id%0A++++++++++++name%0A++++++++++++uuid%0A++++++++++++productV1Seller+%7B%0A++++++++++++++name%0A++++++++++++++externalUrl%0A++++++++++++%7D%0A++++++++++++licenseUrl%0A++++++++++++productUuid%0A++++++++++++product+%7B%0A++++++++++++++uuid%0A++++++++++++%7D%0A++++++++++%7D%0A++++++++++licenseUrl%0A++++++++++externalUrl%0A++++++++%7D%0A++++++%7D%0A++++%7D%0A++%7D%0A%7D
@albertfolch-redeemeum
albertfolch-redeemeum
commented
Apr 24, 2023

Copy link


Copy Markdown

ContributorAuthor
A bit confused here: https://api.thegraph.com/subgraphs/name/bosonprotocol/mumbai-testing/graphql?query=query+MyQuery+%7B%0A++productV1Products%28%0A++++where%3A+%7Buuid_in%3A+%5B"1584b4c-0217-68a0-e0a4-b82b02708fd2"%2C+"0b657a3-7302-e733-af74-37d08806cc7c"%5D%7D%0A++%29+%7B%0A++++id%0A++++variants+%7B%0A++++++offer+%7B%0A++++++++id%0A++++++++metadataUri%0A++++++++metadataHash%0A++++++++metadata+%7B%0A++++++++++name%0A++++++++++...+on+ProductV1MetadataEntity+%7B%0A++++++++++++id%0A++++++++++++name%0A++++++++++++uuid%0A++++++++++++productV1Seller+%7B%0A++++++++++++++name%0A++++++++++++++externalUrl%0A++++++++++++%7D%0A++++++++++++licenseUrl%0A++++++++++%7D%0A++++++++%7D%0A++++++%7D%0A++++%7D%0A++%7D%0A%7D

The 2 offers are the one that was expired and the relisted one. The 2 offers have the same UUID But the product UUID is different. I think it should be the opposite:
  • offer UUID should be different as the offer ID are different on-chain
  • product UUID should be the same (?) as the offer just relist the same product with the same variations.
As a consequence of having the same offer UUID, the licenseURL and externalURL set in the new offer metadata are still referencing the old expired offer. Check here: https://api.thegraph.com/subgraphs/name/bosonprotocol/mumbai-testing/graphql?query=query+MyQuery+%7B%0A++productV1Products%28where%3A+%7Buuid_in%3A+%5B"15dc403-714-57bf-e35b-44610bff33e4"%2C+"4e823-c447-be75-d05a-f36270e5afe"%5D%7D%29+%7B%0A++++id%0A++++variants+%7B%0A++++++offer+%7B%0A++++++++id%0A++++++++metadataUri%0A++++++++metadataHash%0A++++++++metadata+%7B%0A++++++++++name%0A++++++++++...+on+ProductV1MetadataEntity+%7B%0A++++++++++++id%0A++++++++++++name%0A++++++++++++uuid%0A++++++++++++productV1Seller+%7B%0A++++++++++++++name%0A++++++++++++++externalUrl%0A++++++++++++%7D%0A++++++++++++licenseUrl%0A++++++++++++productUuid%0A++++++++++++product+%7B%0A++++++++++++++uuid%0A++++++++++++%7D%0A++++++++++%7D%0A++++++++++licenseUrl%0A++++++++++externalUrl%0A++++++++%7D%0A++++++%7D%0A++++%7D%0A++%7D%0A%7D
this should be fixed now, for example:
https://api.thegraph.com/subgraphs/name/bosonprotocol/mumbai-testing/graphql?query=query+MyQuery+%7B%0A++productV1Products%28orderBy%3A%22id%22%2C+orderDirection%3A%22desc%22%2C+where%3A+%7Buuid_in%3A+%5B%22a6361f3-34d-cc0a-1263-37bf0c050ae%22%2C+%2240a15bc-8b85-8617-515b-50cafb776a7%22%5D%7D%29+%7B%0A++++id%0A++++variants+%7B%0A++++++offer+%7B%0A++++++++createdAt%0A++++++++id%0A++++++++metadataUri%0A++++++++metadataHash%0A++++++++metadata+%7B%0A++++++++++name%0A++++++++++...+on+ProductV1MetadataEntity+%7B%0A++++++++++++id%0A++++++++++++name%0A++++++++++++uuid%0A++++++++++++productV1Seller+%7B%0A++++++++++++++name%0A++++++++++++++externalUrl%0A++++++++++++%7D%0A++++++++++++licenseUrl%0A++++++++++++productUuid%0A++++++++++++product+%7B%0A++++++++++++++uuid%0A++++++++++++%7D%0A++++++++++%7D%0A++++++++++licenseUrl%0A++++++++++externalUrl%0A++++++++%7D%0A++++++%7D%0A++++%7D%0A++%7D%0A%7D
@levalleux-ludo
@albertfolch-redeemeum
albertfolch-redeemeum
deleted the

568-offer-relist

branch
April 24, 2023 14:16
albertfolch-redeemeum added a commit
that referenced
this pull request
Apr 25, 2023
@albertfolch-redeemeumAlbert Folch
feat: relist offer (#596)
d925ad0
* feat: relist offer
* refactor: remove comments
* fix: uuids
albertfolch-redeemeum added a commit
that referenced
this pull request
Apr 27, 2023
@albertfolch-redeemeum
feat: relist offer (#596) (#606)
ec355d2
* feat: relist offer (#596)
* feat: relist offer
* refactor: remove comments
* fix: uuids
* fix: disable relist button if you are not the operator
albertfolch-redeemeum added a commit
that referenced
this pull request
May 11, 2023
@albertfolch-redeemeum@levalleux-ludo
feat: mvfw 2023 (#617)
3347d99
* chore: add sellers 184,190,191 in curation list
* chore: add seller id 195 in curation list
* add seller id 196 in curation list
* chore: upgrade to react-kit 0.16.2-alpha.16
* chore: add seller 202 in curation list (#574)
* chore: add seller 197 in seller curation list (#576)
* fix: custom fonts (#579)
* fix: custom font
* refactor: remove wrong import
* feat: add neuropolitical custom font (#587)
* chore: add seller 207 in seller curation list (#591)
* fix: tabnapping protection (#594)
* feat: change seller deposit copy (#603)
* feat: remove promotional banner (#601) (#604)
* feat: remove promotional banner
* fix: build
* feat: relist offer (#596) (#606)
* feat: relist offer (#596)
* feat: relist offer
* refactor: remove comments
* fix: uuids
* fix: disable relist button if you are not the operator
---------
Co-authored-by: Ludovic Levalleux <levalleux_ludo@hotmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@levalleux-ludolevalleux-ludolevalleux-ludo approved these changes

Assignees

@albertfolch-redeemeumalbertfolch-redeemeum

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Offer Relist


2 participants

@albertfolch-redeemeum@levalleux-ludo

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat: relist offer - #596
Merged
albertfolch-redeemeum merged 3 commits into
mainfrom 
568-offer-relist
Apr 24, 2023
Merged
feat: relist offer#596
albertfolch-redeemeum merged 3 commits into
mainfrom 
568-offer-relist
Conversation
@albertfolch-redeemeum
@albertfolch-redeemeumalbertfolch-redeemeum
commented
Apr 21, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
  • feat: relist offer
  • improved types
  • fixed width of draft modal: it got too big in big screens
  • fix loading spinner when you want to export exchanges with delivery data: if you clicked on the button and then cancel the confirmation of the transaction to enable identity, then the loading spinner was not removed
  • fix datepicker so that if you dont specify an initial date, you see the "Choose date..." text & if you click on a disable date, you see the same text
  • extracted the logic to create an offer/s into an useCreateOffers hook
  • remove useless code
  • fixed low priority error you get after creating an offer and seeing the success modal (BigNumber error in console if the offer is not token gated)
  • fix: in the modal to export the exchange delivery data, changed the initial value to the beginning of the month & remove disable behaviour on the export in option 2
  • fix: style/overflow of export exchanges with delivery data modal (calendar of the datepicker was being cut off)
@albertfolch-redeemeum
albertfolch-redeemeum
requested a review
from a teamApril 21, 2023 15:15
@albertfolch-redeemeumalbertfolch-redeemeum
linked an issue
Apr 21, 2023
that may be
closed
by this pull request


Offer Relist
#568

Closed

@albertfolch-redeemeum
albertfolch-redeemeum
marked this pull request as draft
April 21, 2023 15:15
@cloudflare-workers-and-pages
cloudflare-workers-and-pagesBot
commented
Apr 21, 2023•

edited

Loading

Copy link


Copy Markdown

Deploying with Cloudflare Pages Cloudflare Pages
Latest commit:f61df30
Status: ✅ Deploy successful!
Preview URL:https://bdcb0ecd.interface-a9d.pages.dev
Branch Preview URL:https://568-offer-relist.interface-a9d.pages.dev
View logs
@albertfolch-redeemeum
albertfolch-redeemeum
changed the base branch from
main
to
mvfw-2023April 21, 2023 15:23
@albertfolch-redeemeum
albertfolch-redeemeum
changed the base branch from
mvfw-2023
to
mainApril 21, 2023 15:24
@albertfolch-redeemeum
albertfolch-redeemeum
marked this pull request as ready for review
April 21, 2023 15:24
@levalleux-ludo
levalleux-ludo
commented
Apr 21, 2023•

edited

Loading

Copy link


Copy Markdown

Member
A bit confused here: https://api.thegraph.com/subgraphs/name/bosonprotocol/mumbai-testing/graphql?query=query+MyQuery+%7B%0A++productV1Products%28%0A++++where%3A+%7Buuid_in%3A+%5B"1584b4c-0217-68a0-e0a4-b82b02708fd2"%2C+"0b657a3-7302-e733-af74-37d08806cc7c"%5D%7D%0A++%29+%7B%0A++++id%0A++++variants+%7B%0A++++++offer+%7B%0A++++++++id%0A++++++++metadataUri%0A++++++++metadataHash%0A++++++++metadata+%7B%0A++++++++++name%0A++++++++++...+on+ProductV1MetadataEntity+%7B%0A++++++++++++id%0A++++++++++++name%0A++++++++++++uuid%0A++++++++++++productV1Seller+%7B%0A++++++++++++++name%0A++++++++++++++externalUrl%0A++++++++++++%7D%0A++++++++++++licenseUrl%0A++++++++++%7D%0A++++++++%7D%0A++++++%7D%0A++++%7D%0A++%7D%0A%7D
The 2 offers are the one that was expired and the relisted one.

The 2 offers have the same UUID

But the product UUID is different.

I think it should be the opposite:
  • offer UUID should be different as the offer ID are different on-chain
  • product UUID should be the same (?) as the offer just relist the same product with the same variations.
@levalleux-ludo
levalleux-ludo
commented
Apr 21, 2023

Copy link


Copy Markdown

Member
What happen if I relist an offer that is still valid?

Is the old one voided?

How is the dApp supporting such a case?
@albertfolch-redeemeum
albertfolch-redeemeum
commented
Apr 21, 2023

Copy link


Copy Markdown

ContributorAuthor
What happen if I relist an offer that is still valid? Is the old one voided? How is the dApp supporting such a case?
you can relist any offer, no restrictions and no side effects
@albertfolch-redeemeum
albertfolch-redeemeum
commented
Apr 21, 2023

Copy link


Copy Markdown

ContributorAuthor
A bit confused here: https://api.thegraph.com/subgraphs/name/bosonprotocol/mumbai-testing/graphql?query=query+MyQuery+%7B%0A++productV1Products%28%0A++++where%3A+%7Buuid_in%3A+%5B"1584b4c-0217-68a0-e0a4-b82b02708fd2"%2C+"0b657a3-7302-e733-af74-37d08806cc7c"%5D%7D%0A++%29+%7B%0A++++id%0A++++variants+%7B%0A++++++offer+%7B%0A++++++++id%0A++++++++metadataUri%0A++++++++metadataHash%0A++++++++metadata+%7B%0A++++++++++name%0A++++++++++...+on+ProductV1MetadataEntity+%7B%0A++++++++++++id%0A++++++++++++name%0A++++++++++++uuid%0A++++++++++++productV1Seller+%7B%0A++++++++++++++name%0A++++++++++++++externalUrl%0A++++++++++++%7D%0A++++++++++++licenseUrl%0A++++++++++%7D%0A++++++++%7D%0A++++++%7D%0A++++%7D%0A++%7D%0A%7D
The 2 offers are the one that was expired and the relisted one. The 2 offers have the same UUID But the product UUID is different. I think it should be the opposite:
  • offer UUID should be different as the offer ID are different on-chain
  • product UUID should be the same (?) as the offer just relist the same product with the same variations.
The 2 offers have the same UUID
this is a bug
product UUID should be the same (?) as the offer just relist the same product with the same variations.
why the same? I think it should be different, everything different, just different dates...basically the same behaviour as if you were to create the same product using local storage and setting the dates differently (no actual relationship with the 'old' offer) ...maybe it should be called 'duplicate' instead of 'relist' then
@levalleux-ludo
levalleux-ludo
commented
Apr 21, 2023•

edited

Loading

Copy link


Copy Markdown

Member
A bit confused here: https://api.thegraph.com/subgraphs/name/bosonprotocol/mumbai-testing/graphql?query=query+MyQuery+%7B%0A++productV1Products%28%0A++++where%3A+%7Buuid_in%3A+%5B"1584b4c-0217-68a0-e0a4-b82b02708fd2"%2C+"0b657a3-7302-e733-af74-37d08806cc7c"%5D%7D%0A++%29+%7B%0A++++id%0A++++variants+%7B%0A++++++offer+%7B%0A++++++++id%0A++++++++metadataUri%0A++++++++metadataHash%0A++++++++metadata+%7B%0A++++++++++name%0A++++++++++...+on+ProductV1MetadataEntity+%7B%0A++++++++++++id%0A++++++++++++name%0A++++++++++++uuid%0A++++++++++++productV1Seller+%7B%0A++++++++++++++name%0A++++++++++++++externalUrl%0A++++++++++++%7D%0A++++++++++++licenseUrl%0A++++++++++%7D%0A++++++++%7D%0A++++++%7D%0A++++%7D%0A++%7D%0A%7D
The 2 offers are the one that was expired and the relisted one. The 2 offers have the same UUID But the product UUID is different. I think it should be the opposite:
  • offer UUID should be different as the offer ID are different on-chain
  • product UUID should be the same (?) as the offer just relist the same product with the same variations.
As a consequence of having the same offer UUID, the licenseURL and externalURL set in the new offer metadata are still referencing the old expired offer.

Check here: https://api.thegraph.com/subgraphs/name/bosonprotocol/mumbai-testing/graphql?query=query+MyQuery+%7B%0A++productV1Products%28where%3A+%7Buuid_in%3A+%5B"15dc403-714-57bf-e35b-44610bff33e4"%2C+"4e823-c447-be75-d05a-f36270e5afe"%5D%7D%29+%7B%0A++++id%0A++++variants+%7B%0A++++++offer+%7B%0A++++++++id%0A++++++++metadataUri%0A++++++++metadataHash%0A++++++++metadata+%7B%0A++++++++++name%0A++++++++++...+on+ProductV1MetadataEntity+%7B%0A++++++++++++id%0A++++++++++++name%0A++++++++++++uuid%0A++++++++++++productV1Seller+%7B%0A++++++++++++++name%0A++++++++++++++externalUrl%0A++++++++++++%7D%0A++++++++++++licenseUrl%0A++++++++++++productUuid%0A++++++++++++product+%7B%0A++++++++++++++uuid%0A++++++++++++%7D%0A++++++++++%7D%0A++++++++++licenseUrl%0A++++++++++externalUrl%0A++++++++%7D%0A++++++%7D%0A++++%7D%0A++%7D%0A%7D
@albertfolch-redeemeum
albertfolch-redeemeum
commented
Apr 24, 2023

Copy link


Copy Markdown

ContributorAuthor
A bit confused here: https://api.thegraph.com/subgraphs/name/bosonprotocol/mumbai-testing/graphql?query=query+MyQuery+%7B%0A++productV1Products%28%0A++++where%3A+%7Buuid_in%3A+%5B"1584b4c-0217-68a0-e0a4-b82b02708fd2"%2C+"0b657a3-7302-e733-af74-37d08806cc7c"%5D%7D%0A++%29+%7B%0A++++id%0A++++variants+%7B%0A++++++offer+%7B%0A++++++++id%0A++++++++metadataUri%0A++++++++metadataHash%0A++++++++metadata+%7B%0A++++++++++name%0A++++++++++...+on+ProductV1MetadataEntity+%7B%0A++++++++++++id%0A++++++++++++name%0A++++++++++++uuid%0A++++++++++++productV1Seller+%7B%0A++++++++++++++name%0A++++++++++++++externalUrl%0A++++++++++++%7D%0A++++++++++++licenseUrl%0A++++++++++%7D%0A++++++++%7D%0A++++++%7D%0A++++%7D%0A++%7D%0A%7D

The 2 offers are the one that was expired and the relisted one. The 2 offers have the same UUID But the product UUID is different. I think it should be the opposite:
  • offer UUID should be different as the offer ID are different on-chain
  • product UUID should be the same (?) as the offer just relist the same product with the same variations.
As a consequence of having the same offer UUID, the licenseURL and externalURL set in the new offer metadata are still referencing the old expired offer. Check here: https://api.thegraph.com/subgraphs/name/bosonprotocol/mumbai-testing/graphql?query=query+MyQuery+%7B%0A++productV1Products%28where%3A+%7Buuid_in%3A+%5B"15dc403-714-57bf-e35b-44610bff33e4"%2C+"4e823-c447-be75-d05a-f36270e5afe"%5D%7D%29+%7B%0A++++id%0A++++variants+%7B%0A++++++offer+%7B%0A++++++++id%0A++++++++metadataUri%0A++++++++metadataHash%0A++++++++metadata+%7B%0A++++++++++name%0A++++++++++...+on+ProductV1MetadataEntity+%7B%0A++++++++++++id%0A++++++++++++name%0A++++++++++++uuid%0A++++++++++++productV1Seller+%7B%0A++++++++++++++name%0A++++++++++++++externalUrl%0A++++++++++++%7D%0A++++++++++++licenseUrl%0A++++++++++++productUuid%0A++++++++++++product+%7B%0A++++++++++++++uuid%0A++++++++++++%7D%0A++++++++++%7D%0A++++++++++licenseUrl%0A++++++++++externalUrl%0A++++++++%7D%0A++++++%7D%0A++++%7D%0A++%7D%0A%7D
this should be fixed now, for example:
https://api.thegraph.com/subgraphs/name/bosonprotocol/mumbai-testing/graphql?query=query+MyQuery+%7B%0A++productV1Products%28orderBy%3A%22id%22%2C+orderDirection%3A%22desc%22%2C+where%3A+%7Buuid_in%3A+%5B%22a6361f3-34d-cc0a-1263-37bf0c050ae%22%2C+%2240a15bc-8b85-8617-515b-50cafb776a7%22%5D%7D%29+%7B%0A++++id%0A++++variants+%7B%0A++++++offer+%7B%0A++++++++createdAt%0A++++++++id%0A++++++++metadataUri%0A++++++++metadataHash%0A++++++++metadata+%7B%0A++++++++++name%0A++++++++++...+on+ProductV1MetadataEntity+%7B%0A++++++++++++id%0A++++++++++++name%0A++++++++++++uuid%0A++++++++++++productV1Seller+%7B%0A++++++++++++++name%0A++++++++++++++externalUrl%0A++++++++++++%7D%0A++++++++++++licenseUrl%0A++++++++++++productUuid%0A++++++++++++product+%7B%0A++++++++++++++uuid%0A++++++++++++%7D%0A++++++++++%7D%0A++++++++++licenseUrl%0A++++++++++externalUrl%0A++++++++%7D%0A++++++%7D%0A++++%7D%0A++%7D%0A%7D
@levalleux-ludo
@albertfolch-redeemeum
albertfolch-redeemeum
deleted the

568-offer-relist

branch
April 24, 2023 14:16
albertfolch-redeemeum added a commit
that referenced
this pull request
Apr 25, 2023
@albertfolch-redeemeumAlbert Folch
feat: relist offer (#596)
d925ad0
* feat: relist offer
* refactor: remove comments
* fix: uuids
albertfolch-redeemeum added a commit
that referenced
this pull request
Apr 27, 2023
@albertfolch-redeemeum
feat: relist offer (#596) (#606)
ec355d2
* feat: relist offer (#596)
* feat: relist offer
* refactor: remove comments
* fix: uuids
* fix: disable relist button if you are not the operator
albertfolch-redeemeum added a commit
that referenced
this pull request
May 11, 2023
@albertfolch-redeemeum@levalleux-ludo
feat: mvfw 2023 (#617)
3347d99
* chore: add sellers 184,190,191 in curation list
* chore: add seller id 195 in curation list
* add seller id 196 in curation list
* chore: upgrade to react-kit 0.16.2-alpha.16
* chore: add seller 202 in curation list (#574)
* chore: add seller 197 in seller curation list (#576)
* fix: custom fonts (#579)
* fix: custom font
* refactor: remove wrong import
* feat: add neuropolitical custom font (#587)
* chore: add seller 207 in seller curation list (#591)
* fix: tabnapping protection (#594)
* feat: change seller deposit copy (#603)
* feat: remove promotional banner (#601) (#604)
* feat: remove promotional banner
* fix: build
* feat: relist offer (#596) (#606)
* feat: relist offer (#596)
* feat: relist offer
* refactor: remove comments
* fix: uuids
* fix: disable relist button if you are not the operator
---------
Co-authored-by: Ludovic Levalleux <levalleux_ludo@hotmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@levalleux-ludolevalleux-ludolevalleux-ludo approved these changes

Assignees

@albertfolch-redeemeumalbertfolch-redeemeum

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Offer Relist


2 participants

@albertfolch-redeemeum@levalleux-ludo

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat: relist offer - #596
Merged
albertfolch-redeemeum merged 3 commits into
mainfrom 
568-offer-relist
Apr 24, 2023
Merged
feat: relist offer#596
albertfolch-redeemeum merged 3 commits into
mainfrom 
568-offer-relist
Conversation
@albertfolch-redeemeum
@albertfolch-redeemeumalbertfolch-redeemeum
commented
Apr 21, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
  • feat: relist offer
  • improved types
  • fixed width of draft modal: it got too big in big screens
  • fix loading spinner when you want to export exchanges with delivery data: if you clicked on the button and then cancel the confirmation of the transaction to enable identity, then the loading spinner was not removed
  • fix datepicker so that if you dont specify an initial date, you see the "Choose date..." text & if you click on a disable date, you see the same text
  • extracted the logic to create an offer/s into an useCreateOffers hook
  • remove useless code
  • fixed low priority error you get after creating an offer and seeing the success modal (BigNumber error in console if the offer is not token gated)
  • fix: in the modal to export the exchange delivery data, changed the initial value to the beginning of the month & remove disable behaviour on the export in option 2
  • fix: style/overflow of export exchanges with delivery data modal (calendar of the datepicker was being cut off)
@albertfolch-redeemeum
albertfolch-redeemeum
requested a review
from a teamApril 21, 2023 15:15
@albertfolch-redeemeumalbertfolch-redeemeum
linked an issue
Apr 21, 2023
that may be
closed
by this pull request


Offer Relist
#568

Closed

@albertfolch-redeemeum
albertfolch-redeemeum
marked this pull request as draft
April 21, 2023 15:15
@cloudflare-workers-and-pages
cloudflare-workers-and-pagesBot
commented
Apr 21, 2023•

edited

Loading

Copy link


Copy Markdown

Deploying with Cloudflare Pages Cloudflare Pages
Latest commit:f61df30
Status: ✅ Deploy successful!
Preview URL:https://bdcb0ecd.interface-a9d.pages.dev
Branch Preview URL:https://568-offer-relist.interface-a9d.pages.dev
View logs
@albertfolch-redeemeum
albertfolch-redeemeum
changed the base branch from
main
to
mvfw-2023April 21, 2023 15:23
@albertfolch-redeemeum
albertfolch-redeemeum
changed the base branch from
mvfw-2023
to
mainApril 21, 2023 15:24
@albertfolch-redeemeum
albertfolch-redeemeum
marked this pull request as ready for review
April 21, 2023 15:24
@levalleux-ludo
levalleux-ludo
commented
Apr 21, 2023•

edited

Loading

Copy link


Copy Markdown

Member
A bit confused here: https://api.thegraph.com/subgraphs/name/bosonprotocol/mumbai-testing/graphql?query=query+MyQuery+%7B%0A++productV1Products%28%0A++++where%3A+%7Buuid_in%3A+%5B"1584b4c-0217-68a0-e0a4-b82b02708fd2"%2C+"0b657a3-7302-e733-af74-37d08806cc7c"%5D%7D%0A++%29+%7B%0A++++id%0A++++variants+%7B%0A++++++offer+%7B%0A++++++++id%0A++++++++metadataUri%0A++++++++metadataHash%0A++++++++metadata+%7B%0A++++++++++name%0A++++++++++...+on+ProductV1MetadataEntity+%7B%0A++++++++++++id%0A++++++++++++name%0A++++++++++++uuid%0A++++++++++++productV1Seller+%7B%0A++++++++++++++name%0A++++++++++++++externalUrl%0A++++++++++++%7D%0A++++++++++++licenseUrl%0A++++++++++%7D%0A++++++++%7D%0A++++++%7D%0A++++%7D%0A++%7D%0A%7D
The 2 offers are the one that was expired and the relisted one.

The 2 offers have the same UUID

But the product UUID is different.

I think it should be the opposite:
  • offer UUID should be different as the offer ID are different on-chain
  • product UUID should be the same (?) as the offer just relist the same product with the same variations.
@levalleux-ludo
levalleux-ludo
commented
Apr 21, 2023

Copy link


Copy Markdown

Member
What happen if I relist an offer that is still valid?

Is the old one voided?

How is the dApp supporting such a case?
@albertfolch-redeemeum
albertfolch-redeemeum
commented
Apr 21, 2023

Copy link


Copy Markdown

ContributorAuthor
What happen if I relist an offer that is still valid? Is the old one voided? How is the dApp supporting such a case?
you can relist any offer, no restrictions and no side effects
@albertfolch-redeemeum
albertfolch-redeemeum
commented
Apr 21, 2023

Copy link


Copy Markdown

ContributorAuthor
A bit confused here: https://api.thegraph.com/subgraphs/name/bosonprotocol/mumbai-testing/graphql?query=query+MyQuery+%7B%0A++productV1Products%28%0A++++where%3A+%7Buuid_in%3A+%5B"1584b4c-0217-68a0-e0a4-b82b02708fd2"%2C+"0b657a3-7302-e733-af74-37d08806cc7c"%5D%7D%0A++%29+%7B%0A++++id%0A++++variants+%7B%0A++++++offer+%7B%0A++++++++id%0A++++++++metadataUri%0A++++++++metadataHash%0A++++++++metadata+%7B%0A++++++++++name%0A++++++++++...+on+ProductV1MetadataEntity+%7B%0A++++++++++++id%0A++++++++++++name%0A++++++++++++uuid%0A++++++++++++productV1Seller+%7B%0A++++++++++++++name%0A++++++++++++++externalUrl%0A++++++++++++%7D%0A++++++++++++licenseUrl%0A++++++++++%7D%0A++++++++%7D%0A++++++%7D%0A++++%7D%0A++%7D%0A%7D
The 2 offers are the one that was expired and the relisted one. The 2 offers have the same UUID But the product UUID is different. I think it should be the opposite:
  • offer UUID should be different as the offer ID are different on-chain
  • product UUID should be the same (?) as the offer just relist the same product with the same variations.
The 2 offers have the same UUID
this is a bug
product UUID should be the same (?) as the offer just relist the same product with the same variations.
why the same? I think it should be different, everything different, just different dates...basically the same behaviour as if you were to create the same product using local storage and setting the dates differently (no actual relationship with the 'old' offer) ...maybe it should be called 'duplicate' instead of 'relist' then
@levalleux-ludo
levalleux-ludo
commented
Apr 21, 2023•

edited

Loading

Copy link


Copy Markdown

Member
A bit confused here: https://api.thegraph.com/subgraphs/name/bosonprotocol/mumbai-testing/graphql?query=query+MyQuery+%7B%0A++productV1Products%28%0A++++where%3A+%7Buuid_in%3A+%5B"1584b4c-0217-68a0-e0a4-b82b02708fd2"%2C+"0b657a3-7302-e733-af74-37d08806cc7c"%5D%7D%0A++%29+%7B%0A++++id%0A++++variants+%7B%0A++++++offer+%7B%0A++++++++id%0A++++++++metadataUri%0A++++++++metadataHash%0A++++++++metadata+%7B%0A++++++++++name%0A++++++++++...+on+ProductV1MetadataEntity+%7B%0A++++++++++++id%0A++++++++++++name%0A++++++++++++uuid%0A++++++++++++productV1Seller+%7B%0A++++++++++++++name%0A++++++++++++++externalUrl%0A++++++++++++%7D%0A++++++++++++licenseUrl%0A++++++++++%7D%0A++++++++%7D%0A++++++%7D%0A++++%7D%0A++%7D%0A%7D
The 2 offers are the one that was expired and the relisted one. The 2 offers have the same UUID But the product UUID is different. I think it should be the opposite:
  • offer UUID should be different as the offer ID are different on-chain
  • product UUID should be the same (?) as the offer just relist the same product with the same variations.
As a consequence of having the same offer UUID, the licenseURL and externalURL set in the new offer metadata are still referencing the old expired offer.

Check here: https://api.thegraph.com/subgraphs/name/bosonprotocol/mumbai-testing/graphql?query=query+MyQuery+%7B%0A++productV1Products%28where%3A+%7Buuid_in%3A+%5B"15dc403-714-57bf-e35b-44610bff33e4"%2C+"4e823-c447-be75-d05a-f36270e5afe"%5D%7D%29+%7B%0A++++id%0A++++variants+%7B%0A++++++offer+%7B%0A++++++++id%0A++++++++metadataUri%0A++++++++metadataHash%0A++++++++metadata+%7B%0A++++++++++name%0A++++++++++...+on+ProductV1MetadataEntity+%7B%0A++++++++++++id%0A++++++++++++name%0A++++++++++++uuid%0A++++++++++++productV1Seller+%7B%0A++++++++++++++name%0A++++++++++++++externalUrl%0A++++++++++++%7D%0A++++++++++++licenseUrl%0A++++++++++++productUuid%0A++++++++++++product+%7B%0A++++++++++++++uuid%0A++++++++++++%7D%0A++++++++++%7D%0A++++++++++licenseUrl%0A++++++++++externalUrl%0A++++++++%7D%0A++++++%7D%0A++++%7D%0A++%7D%0A%7D
@albertfolch-redeemeum
albertfolch-redeemeum
commented
Apr 24, 2023

Copy link


Copy Markdown

ContributorAuthor
A bit confused here: https://api.thegraph.com/subgraphs/name/bosonprotocol/mumbai-testing/graphql?query=query+MyQuery+%7B%0A++productV1Products%28%0A++++where%3A+%7Buuid_in%3A+%5B"1584b4c-0217-68a0-e0a4-b82b02708fd2"%2C+"0b657a3-7302-e733-af74-37d08806cc7c"%5D%7D%0A++%29+%7B%0A++++id%0A++++variants+%7B%0A++++++offer+%7B%0A++++++++id%0A++++++++metadataUri%0A++++++++metadataHash%0A++++++++metadata+%7B%0A++++++++++name%0A++++++++++...+on+ProductV1MetadataEntity+%7B%0A++++++++++++id%0A++++++++++++name%0A++++++++++++uuid%0A++++++++++++productV1Seller+%7B%0A++++++++++++++name%0A++++++++++++++externalUrl%0A++++++++++++%7D%0A++++++++++++licenseUrl%0A++++++++++%7D%0A++++++++%7D%0A++++++%7D%0A++++%7D%0A++%7D%0A%7D

The 2 offers are the one that was expired and the relisted one. The 2 offers have the same UUID But the product UUID is different. I think it should be the opposite:
  • offer UUID should be different as the offer ID are different on-chain
  • product UUID should be the same (?) as the offer just relist the same product with the same variations.
As a consequence of having the same offer UUID, the licenseURL and externalURL set in the new offer metadata are still referencing the old expired offer. Check here: https://api.thegraph.com/subgraphs/name/bosonprotocol/mumbai-testing/graphql?query=query+MyQuery+%7B%0A++productV1Products%28where%3A+%7Buuid_in%3A+%5B"15dc403-714-57bf-e35b-44610bff33e4"%2C+"4e823-c447-be75-d05a-f36270e5afe"%5D%7D%29+%7B%0A++++id%0A++++variants+%7B%0A++++++offer+%7B%0A++++++++id%0A++++++++metadataUri%0A++++++++metadataHash%0A++++++++metadata+%7B%0A++++++++++name%0A++++++++++...+on+ProductV1MetadataEntity+%7B%0A++++++++++++id%0A++++++++++++name%0A++++++++++++uuid%0A++++++++++++productV1Seller+%7B%0A++++++++++++++name%0A++++++++++++++externalUrl%0A++++++++++++%7D%0A++++++++++++licenseUrl%0A++++++++++++productUuid%0A++++++++++++product+%7B%0A++++++++++++++uuid%0A++++++++++++%7D%0A++++++++++%7D%0A++++++++++licenseUrl%0A++++++++++externalUrl%0A++++++++%7D%0A++++++%7D%0A++++%7D%0A++%7D%0A%7D
this should be fixed now, for example:
https://api.thegraph.com/subgraphs/name/bosonprotocol/mumbai-testing/graphql?query=query+MyQuery+%7B%0A++productV1Products%28orderBy%3A%22id%22%2C+orderDirection%3A%22desc%22%2C+where%3A+%7Buuid_in%3A+%5B%22a6361f3-34d-cc0a-1263-37bf0c050ae%22%2C+%2240a15bc-8b85-8617-515b-50cafb776a7%22%5D%7D%29+%7B%0A++++id%0A++++variants+%7B%0A++++++offer+%7B%0A++++++++createdAt%0A++++++++id%0A++++++++metadataUri%0A++++++++metadataHash%0A++++++++metadata+%7B%0A++++++++++name%0A++++++++++...+on+ProductV1MetadataEntity+%7B%0A++++++++++++id%0A++++++++++++name%0A++++++++++++uuid%0A++++++++++++productV1Seller+%7B%0A++++++++++++++name%0A++++++++++++++externalUrl%0A++++++++++++%7D%0A++++++++++++licenseUrl%0A++++++++++++productUuid%0A++++++++++++product+%7B%0A++++++++++++++uuid%0A++++++++++++%7D%0A++++++++++%7D%0A++++++++++licenseUrl%0A++++++++++externalUrl%0A++++++++%7D%0A++++++%7D%0A++++%7D%0A++%7D%0A%7D
@levalleux-ludo
@albertfolch-redeemeum
albertfolch-redeemeum
deleted the

568-offer-relist

branch
April 24, 2023 14:16
albertfolch-redeemeum added a commit
that referenced
this pull request
Apr 25, 2023
@albertfolch-redeemeumAlbert Folch
feat: relist offer (#596)
d925ad0
* feat: relist offer
* refactor: remove comments
* fix: uuids
albertfolch-redeemeum added a commit
that referenced
this pull request
Apr 27, 2023
@albertfolch-redeemeum
feat: relist offer (#596) (#606)
ec355d2
* feat: relist offer (#596)
* feat: relist offer
* refactor: remove comments
* fix: uuids
* fix: disable relist button if you are not the operator
albertfolch-redeemeum added a commit
that referenced
this pull request
May 11, 2023
@albertfolch-redeemeum@levalleux-ludo
feat: mvfw 2023 (#617)
3347d99
* chore: add sellers 184,190,191 in curation list
* chore: add seller id 195 in curation list
* add seller id 196 in curation list
* chore: upgrade to react-kit 0.16.2-alpha.16
* chore: add seller 202 in curation list (#574)
* chore: add seller 197 in seller curation list (#576)
* fix: custom fonts (#579)
* fix: custom font
* refactor: remove wrong import
* feat: add neuropolitical custom font (#587)
* chore: add seller 207 in seller curation list (#591)
* fix: tabnapping protection (#594)
* feat: change seller deposit copy (#603)
* feat: remove promotional banner (#601) (#604)
* feat: remove promotional banner
* fix: build
* feat: relist offer (#596) (#606)
* feat: relist offer (#596)
* feat: relist offer
* refactor: remove comments
* fix: uuids
* fix: disable relist button if you are not the operator
---------
Co-authored-by: Ludovic Levalleux <levalleux_ludo@hotmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@levalleux-ludolevalleux-ludolevalleux-ludo approved these changes

Assignees

@albertfolch-redeemeumalbertfolch-redeemeum

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Offer Relist


2 participants

@albertfolch-redeemeum@levalleux-ludo

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
feat: relist offer - #596
Merged
albertfolch-redeemeum merged 3 commits into
mainfrom 
568-offer-relist
Apr 24, 2023
Merged
feat: relist offer#596
albertfolch-redeemeum merged 3 commits into
mainfrom 
568-offer-relist
Conversation
@albertfolch-redeemeum
@albertfolch-redeemeumalbertfolch-redeemeum
commented
Apr 21, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
  • feat: relist offer
  • improved types
  • fixed width of draft modal: it got too big in big screens
  • fix loading spinner when you want to export exchanges with delivery data: if you clicked on the button and then cancel the confirmation of the transaction to enable identity, then the loading spinner was not removed
  • fix datepicker so that if you dont specify an initial date, you see the "Choose date..." text & if you click on a disable date, you see the same text
  • extracted the logic to create an offer/s into an useCreateOffers hook
  • remove useless code
  • fixed low priority error you get after creating an offer and seeing the success modal (BigNumber error in console if the offer is not token gated)
  • fix: in the modal to export the exchange delivery data, changed the initial value to the beginning of the month & remove disable behaviour on the export in option 2
  • fix: style/overflow of export exchanges with delivery data modal (calendar of the datepicker was being cut off)
@albertfolch-redeemeum
albertfolch-redeemeum
requested a review
from a teamApril 21, 2023 15:15
@albertfolch-redeemeumalbertfolch-redeemeum
linked an issue
Apr 21, 2023
that may be
closed
by this pull request


Offer Relist
#568

Closed

@albertfolch-redeemeum
albertfolch-redeemeum
marked this pull request as draft
April 21, 2023 15:15
@cloudflare-workers-and-pages
cloudflare-workers-and-pagesBot
commented
Apr 21, 2023•

edited

Loading

Copy link


Copy Markdown

Deploying with Cloudflare Pages Cloudflare Pages
Latest commit:f61df30
Status: ✅ Deploy successful!
Preview URL:https://bdcb0ecd.interface-a9d.pages.dev
Branch Preview URL:https://568-offer-relist.interface-a9d.pages.dev
View logs
@albertfolch-redeemeum
albertfolch-redeemeum
changed the base branch from
main
to
mvfw-2023April 21, 2023 15:23
@albertfolch-redeemeum
albertfolch-redeemeum
changed the base branch from
mvfw-2023
to
mainApril 21, 2023 15:24
@albertfolch-redeemeum
albertfolch-redeemeum
marked this pull request as ready for review
April 21, 2023 15:24
@levalleux-ludo
levalleux-ludo
commented
Apr 21, 2023•

edited

Loading

Copy link


Copy Markdown

Member
A bit confused here: https://api.thegraph.com/subgraphs/name/bosonprotocol/mumbai-testing/graphql?query=query+MyQuery+%7B%0A++productV1Products%28%0A++++where%3A+%7Buuid_in%3A+%5B"1584b4c-0217-68a0-e0a4-b82b02708fd2"%2C+"0b657a3-7302-e733-af74-37d08806cc7c"%5D%7D%0A++%29+%7B%0A++++id%0A++++variants+%7B%0A++++++offer+%7B%0A++++++++id%0A++++++++metadataUri%0A++++++++metadataHash%0A++++++++metadata+%7B%0A++++++++++name%0A++++++++++...+on+ProductV1MetadataEntity+%7B%0A++++++++++++id%0A++++++++++++name%0A++++++++++++uuid%0A++++++++++++productV1Seller+%7B%0A++++++++++++++name%0A++++++++++++++externalUrl%0A++++++++++++%7D%0A++++++++++++licenseUrl%0A++++++++++%7D%0A++++++++%7D%0A++++++%7D%0A++++%7D%0A++%7D%0A%7D
The 2 offers are the one that was expired and the relisted one.

The 2 offers have the same UUID

But the product UUID is different.

I think it should be the opposite:
  • offer UUID should be different as the offer ID are different on-chain
  • product UUID should be the same (?) as the offer just relist the same product with the same variations.
@levalleux-ludo
levalleux-ludo
commented
Apr 21, 2023

Copy link


Copy Markdown

Member
What happen if I relist an offer that is still valid?

Is the old one voided?

How is the dApp supporting such a case?
@albertfolch-redeemeum
albertfolch-redeemeum
commented
Apr 21, 2023

Copy link


Copy Markdown

ContributorAuthor
What happen if I relist an offer that is still valid? Is the old one voided? How is the dApp supporting such a case?
you can relist any offer, no restrictions and no side effects
@albertfolch-redeemeum
albertfolch-redeemeum
commented
Apr 21, 2023

Copy link


Copy Markdown

ContributorAuthor
A bit confused here: https://api.thegraph.com/subgraphs/name/bosonprotocol/mumbai-testing/graphql?query=query+MyQuery+%7B%0A++productV1Products%28%0A++++where%3A+%7Buuid_in%3A+%5B"1584b4c-0217-68a0-e0a4-b82b02708fd2"%2C+"0b657a3-7302-e733-af74-37d08806cc7c"%5D%7D%0A++%29+%7B%0A++++id%0A++++variants+%7B%0A++++++offer+%7B%0A++++++++id%0A++++++++metadataUri%0A++++++++metadataHash%0A++++++++metadata+%7B%0A++++++++++name%0A++++++++++...+on+ProductV1MetadataEntity+%7B%0A++++++++++++id%0A++++++++++++name%0A++++++++++++uuid%0A++++++++++++productV1Seller+%7B%0A++++++++++++++name%0A++++++++++++++externalUrl%0A++++++++++++%7D%0A++++++++++++licenseUrl%0A++++++++++%7D%0A++++++++%7D%0A++++++%7D%0A++++%7D%0A++%7D%0A%7D
The 2 offers are the one that was expired and the relisted one. The 2 offers have the same UUID But the product UUID is different. I think it should be the opposite:
  • offer UUID should be different as the offer ID are different on-chain
  • product UUID should be the same (?) as the offer just relist the same product with the same variations.
The 2 offers have the same UUID
this is a bug
product UUID should be the same (?) as the offer just relist the same product with the same variations.
why the same? I think it should be different, everything different, just different dates...basically the same behaviour as if you were to create the same product using local storage and setting the dates differently (no actual relationship with the 'old' offer) ...maybe it should be called 'duplicate' instead of 'relist' then
@levalleux-ludo
levalleux-ludo
commented
Apr 21, 2023•

edited

Loading

Copy link


Copy Markdown

Member
A bit confused here: https://api.thegraph.com/subgraphs/name/bosonprotocol/mumbai-testing/graphql?query=query+MyQuery+%7B%0A++productV1Products%28%0A++++where%3A+%7Buuid_in%3A+%5B"1584b4c-0217-68a0-e0a4-b82b02708fd2"%2C+"0b657a3-7302-e733-af74-37d08806cc7c"%5D%7D%0A++%29+%7B%0A++++id%0A++++variants+%7B%0A++++++offer+%7B%0A++++++++id%0A++++++++metadataUri%0A++++++++metadataHash%0A++++++++metadata+%7B%0A++++++++++name%0A++++++++++...+on+ProductV1MetadataEntity+%7B%0A++++++++++++id%0A++++++++++++name%0A++++++++++++uuid%0A++++++++++++productV1Seller+%7B%0A++++++++++++++name%0A++++++++++++++externalUrl%0A++++++++++++%7D%0A++++++++++++licenseUrl%0A++++++++++%7D%0A++++++++%7D%0A++++++%7D%0A++++%7D%0A++%7D%0A%7D
The 2 offers are the one that was expired and the relisted one. The 2 offers have the same UUID But the product UUID is different. I think it should be the opposite:
  • offer UUID should be different as the offer ID are different on-chain
  • product UUID should be the same (?) as the offer just relist the same product with the same variations.
As a consequence of having the same offer UUID, the licenseURL and externalURL set in the new offer metadata are still referencing the old expired offer.

Check here: https://api.thegraph.com/subgraphs/name/bosonprotocol/mumbai-testing/graphql?query=query+MyQuery+%7B%0A++productV1Products%28where%3A+%7Buuid_in%3A+%5B"15dc403-714-57bf-e35b-44610bff33e4"%2C+"4e823-c447-be75-d05a-f36270e5afe"%5D%7D%29+%7B%0A++++id%0A++++variants+%7B%0A++++++offer+%7B%0A++++++++id%0A++++++++metadataUri%0A++++++++metadataHash%0A++++++++metadata+%7B%0A++++++++++name%0A++++++++++...+on+ProductV1MetadataEntity+%7B%0A++++++++++++id%0A++++++++++++name%0A++++++++++++uuid%0A++++++++++++productV1Seller+%7B%0A++++++++++++++name%0A++++++++++++++externalUrl%0A++++++++++++%7D%0A++++++++++++licenseUrl%0A++++++++++++productUuid%0A++++++++++++product+%7B%0A++++++++++++++uuid%0A++++++++++++%7D%0A++++++++++%7D%0A++++++++++licenseUrl%0A++++++++++externalUrl%0A++++++++%7D%0A++++++%7D%0A++++%7D%0A++%7D%0A%7D
@albertfolch-redeemeum
albertfolch-redeemeum
commented
Apr 24, 2023

Copy link


Copy Markdown

ContributorAuthor
A bit confused here: https://api.thegraph.com/subgraphs/name/bosonprotocol/mumbai-testing/graphql?query=query+MyQuery+%7B%0A++productV1Products%28%0A++++where%3A+%7Buuid_in%3A+%5B"1584b4c-0217-68a0-e0a4-b82b02708fd2"%2C+"0b657a3-7302-e733-af74-37d08806cc7c"%5D%7D%0A++%29+%7B%0A++++id%0A++++variants+%7B%0A++++++offer+%7B%0A++++++++id%0A++++++++metadataUri%0A++++++++metadataHash%0A++++++++metadata+%7B%0A++++++++++name%0A++++++++++...+on+ProductV1MetadataEntity+%7B%0A++++++++++++id%0A++++++++++++name%0A++++++++++++uuid%0A++++++++++++productV1Seller+%7B%0A++++++++++++++name%0A++++++++++++++externalUrl%0A++++++++++++%7D%0A++++++++++++licenseUrl%0A++++++++++%7D%0A++++++++%7D%0A++++++%7D%0A++++%7D%0A++%7D%0A%7D

The 2 offers are the one that was expired and the relisted one. The 2 offers have the same UUID But the product UUID is different. I think it should be the opposite:
  • offer UUID should be different as the offer ID are different on-chain
  • product UUID should be the same (?) as the offer just relist the same product with the same variations.
As a consequence of having the same offer UUID, the licenseURL and externalURL set in the new offer metadata are still referencing the old expired offer. Check here: https://api.thegraph.com/subgraphs/name/bosonprotocol/mumbai-testing/graphql?query=query+MyQuery+%7B%0A++productV1Products%28where%3A+%7Buuid_in%3A+%5B"15dc403-714-57bf-e35b-44610bff33e4"%2C+"4e823-c447-be75-d05a-f36270e5afe"%5D%7D%29+%7B%0A++++id%0A++++variants+%7B%0A++++++offer+%7B%0A++++++++id%0A++++++++metadataUri%0A++++++++metadataHash%0A++++++++metadata+%7B%0A++++++++++name%0A++++++++++...+on+ProductV1MetadataEntity+%7B%0A++++++++++++id%0A++++++++++++name%0A++++++++++++uuid%0A++++++++++++productV1Seller+%7B%0A++++++++++++++name%0A++++++++++++++externalUrl%0A++++++++++++%7D%0A++++++++++++licenseUrl%0A++++++++++++productUuid%0A++++++++++++product+%7B%0A++++++++++++++uuid%0A++++++++++++%7D%0A++++++++++%7D%0A++++++++++licenseUrl%0A++++++++++externalUrl%0A++++++++%7D%0A++++++%7D%0A++++%7D%0A++%7D%0A%7D
this should be fixed now, for example:
https://api.thegraph.com/subgraphs/name/bosonprotocol/mumbai-testing/graphql?query=query+MyQuery+%7B%0A++productV1Products%28orderBy%3A%22id%22%2C+orderDirection%3A%22desc%22%2C+where%3A+%7Buuid_in%3A+%5B%22a6361f3-34d-cc0a-1263-37bf0c050ae%22%2C+%2240a15bc-8b85-8617-515b-50cafb776a7%22%5D%7D%29+%7B%0A++++id%0A++++variants+%7B%0A++++++offer+%7B%0A++++++++createdAt%0A++++++++id%0A++++++++metadataUri%0A++++++++metadataHash%0A++++++++metadata+%7B%0A++++++++++name%0A++++++++++...+on+ProductV1MetadataEntity+%7B%0A++++++++++++id%0A++++++++++++name%0A++++++++++++uuid%0A++++++++++++productV1Seller+%7B%0A++++++++++++++name%0A++++++++++++++externalUrl%0A++++++++++++%7D%0A++++++++++++licenseUrl%0A++++++++++++productUuid%0A++++++++++++product+%7B%0A++++++++++++++uuid%0A++++++++++++%7D%0A++++++++++%7D%0A++++++++++licenseUrl%0A++++++++++externalUrl%0A++++++++%7D%0A++++++%7D%0A++++%7D%0A++%7D%0A%7D
@levalleux-ludo
@albertfolch-redeemeum
albertfolch-redeemeum
deleted the

568-offer-relist

branch
April 24, 2023 14:16
albertfolch-redeemeum added a commit
that referenced
this pull request
Apr 25, 2023
@albertfolch-redeemeumAlbert Folch
feat: relist offer (#596)
d925ad0
* feat: relist offer
* refactor: remove comments
* fix: uuids
albertfolch-redeemeum added a commit
that referenced
this pull request
Apr 27, 2023
@albertfolch-redeemeum
feat: relist offer (#596) (#606)
ec355d2
* feat: relist offer (#596)
* feat: relist offer
* refactor: remove comments
* fix: uuids
* fix: disable relist button if you are not the operator
albertfolch-redeemeum added a commit
that referenced
this pull request
May 11, 2023
@albertfolch-redeemeum@levalleux-ludo
feat: mvfw 2023 (#617)
3347d99
* chore: add sellers 184,190,191 in curation list
* chore: add seller id 195 in curation list
* add seller id 196 in curation list
* chore: upgrade to react-kit 0.16.2-alpha.16
* chore: add seller 202 in curation list (#574)
* chore: add seller 197 in seller curation list (#576)
* fix: custom fonts (#579)
* fix: custom font
* refactor: remove wrong import
* feat: add neuropolitical custom font (#587)
* chore: add seller 207 in seller curation list (#591)
* fix: tabnapping protection (#594)
* feat: change seller deposit copy (#603)
* feat: remove promotional banner (#601) (#604)
* feat: remove promotional banner
* fix: build
* feat: relist offer (#596) (#606)
* feat: relist offer (#596)
* feat: relist offer
* refactor: remove comments
* fix: uuids
* fix: disable relist button if you are not the operator
---------
Co-authored-by: Ludovic Levalleux <levalleux_ludo@hotmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@levalleux-ludolevalleux-ludolevalleux-ludo approved these changes

Assignees

@albertfolch-redeemeumalbertfolch-redeemeum

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Offer Relist


2 participants

@albertfolch-redeemeum@levalleux-ludo

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat: relist offer - #596
Merged
albertfolch-redeemeum merged 3 commits into
mainfrom 
568-offer-relist
Apr 24, 2023
Merged
feat: relist offer#596
albertfolch-redeemeum merged 3 commits into
mainfrom 
568-offer-relist
Conversation
@albertfolch-redeemeum
@albertfolch-redeemeumalbertfolch-redeemeum
commented
Apr 21, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
  • feat: relist offer
  • improved types
  • fixed width of draft modal: it got too big in big screens
  • fix loading spinner when you want to export exchanges with delivery data: if you clicked on the button and then cancel the confirmation of the transaction to enable identity, then the loading spinner was not removed
  • fix datepicker so that if you dont specify an initial date, you see the "Choose date..." text & if you click on a disable date, you see the same text
  • extracted the logic to create an offer/s into an useCreateOffers hook
  • remove useless code
  • fixed low priority error you get after creating an offer and seeing the success modal (BigNumber error in console if the offer is not token gated)
  • fix: in the modal to export the exchange delivery data, changed the initial value to the beginning of the month & remove disable behaviour on the export in option 2
  • fix: style/overflow of export exchanges with delivery data modal (calendar of the datepicker was being cut off)
@albertfolch-redeemeum
albertfolch-redeemeum
requested a review
from a teamApril 21, 2023 15:15
@albertfolch-redeemeumalbertfolch-redeemeum
linked an issue
Apr 21, 2023
that may be
closed
by this pull request


Offer Relist
#568

Closed

@albertfolch-redeemeum
albertfolch-redeemeum
marked this pull request as draft
April 21, 2023 15:15
@cloudflare-workers-and-pages
cloudflare-workers-and-pagesBot
commented
Apr 21, 2023•

edited

Loading

Copy link


Copy Markdown

Deploying with Cloudflare Pages Cloudflare Pages
Latest commit:f61df30
Status: ✅ Deploy successful!
Preview URL:https://bdcb0ecd.interface-a9d.pages.dev
Branch Preview URL:https://568-offer-relist.interface-a9d.pages.dev
View logs
@albertfolch-redeemeum
albertfolch-redeemeum
changed the base branch from
main
to
mvfw-2023April 21, 2023 15:23
@albertfolch-redeemeum
albertfolch-redeemeum
changed the base branch from
mvfw-2023
to
mainApril 21, 2023 15:24
@albertfolch-redeemeum
albertfolch-redeemeum
marked this pull request as ready for review
April 21, 2023 15:24
@levalleux-ludo
levalleux-ludo
commented
Apr 21, 2023•

edited

Loading

Copy link


Copy Markdown

Member
A bit confused here: https://api.thegraph.com/subgraphs/name/bosonprotocol/mumbai-testing/graphql?query=query+MyQuery+%7B%0A++productV1Products%28%0A++++where%3A+%7Buuid_in%3A+%5B"1584b4c-0217-68a0-e0a4-b82b02708fd2"%2C+"0b657a3-7302-e733-af74-37d08806cc7c"%5D%7D%0A++%29+%7B%0A++++id%0A++++variants+%7B%0A++++++offer+%7B%0A++++++++id%0A++++++++metadataUri%0A++++++++metadataHash%0A++++++++metadata+%7B%0A++++++++++name%0A++++++++++...+on+ProductV1MetadataEntity+%7B%0A++++++++++++id%0A++++++++++++name%0A++++++++++++uuid%0A++++++++++++productV1Seller+%7B%0A++++++++++++++name%0A++++++++++++++externalUrl%0A++++++++++++%7D%0A++++++++++++licenseUrl%0A++++++++++%7D%0A++++++++%7D%0A++++++%7D%0A++++%7D%0A++%7D%0A%7D
The 2 offers are the one that was expired and the relisted one.

The 2 offers have the same UUID

But the product UUID is different.

I think it should be the opposite:
  • offer UUID should be different as the offer ID are different on-chain
  • product UUID should be the same (?) as the offer just relist the same product with the same variations.
@levalleux-ludo
levalleux-ludo
commented
Apr 21, 2023

Copy link


Copy Markdown

Member
What happen if I relist an offer that is still valid?

Is the old one voided?

How is the dApp supporting such a case?
@albertfolch-redeemeum
albertfolch-redeemeum
commented
Apr 21, 2023

Copy link


Copy Markdown

ContributorAuthor
What happen if I relist an offer that is still valid? Is the old one voided? How is the dApp supporting such a case?
you can relist any offer, no restrictions and no side effects
@albertfolch-redeemeum
albertfolch-redeemeum
commented
Apr 21, 2023

Copy link


Copy Markdown

ContributorAuthor
A bit confused here: https://api.thegraph.com/subgraphs/name/bosonprotocol/mumbai-testing/graphql?query=query+MyQuery+%7B%0A++productV1Products%28%0A++++where%3A+%7Buuid_in%3A+%5B"1584b4c-0217-68a0-e0a4-b82b02708fd2"%2C+"0b657a3-7302-e733-af74-37d08806cc7c"%5D%7D%0A++%29+%7B%0A++++id%0A++++variants+%7B%0A++++++offer+%7B%0A++++++++id%0A++++++++metadataUri%0A++++++++metadataHash%0A++++++++metadata+%7B%0A++++++++++name%0A++++++++++...+on+ProductV1MetadataEntity+%7B%0A++++++++++++id%0A++++++++++++name%0A++++++++++++uuid%0A++++++++++++productV1Seller+%7B%0A++++++++++++++name%0A++++++++++++++externalUrl%0A++++++++++++%7D%0A++++++++++++licenseUrl%0A++++++++++%7D%0A++++++++%7D%0A++++++%7D%0A++++%7D%0A++%7D%0A%7D
The 2 offers are the one that was expired and the relisted one. The 2 offers have the same UUID But the product UUID is different. I think it should be the opposite:
  • offer UUID should be different as the offer ID are different on-chain
  • product UUID should be the same (?) as the offer just relist the same product with the same variations.
The 2 offers have the same UUID
this is a bug
product UUID should be the same (?) as the offer just relist the same product with the same variations.
why the same? I think it should be different, everything different, just different dates...basically the same behaviour as if you were to create the same product using local storage and setting the dates differently (no actual relationship with the 'old' offer) ...maybe it should be called 'duplicate' instead of 'relist' then
@levalleux-ludo
levalleux-ludo
commented
Apr 21, 2023•

edited

Loading

Copy link


Copy Markdown

Member
A bit confused here: https://api.thegraph.com/subgraphs/name/bosonprotocol/mumbai-testing/graphql?query=query+MyQuery+%7B%0A++productV1Products%28%0A++++where%3A+%7Buuid_in%3A+%5B"1584b4c-0217-68a0-e0a4-b82b02708fd2"%2C+"0b657a3-7302-e733-af74-37d08806cc7c"%5D%7D%0A++%29+%7B%0A++++id%0A++++variants+%7B%0A++++++offer+%7B%0A++++++++id%0A++++++++metadataUri%0A++++++++metadataHash%0A++++++++metadata+%7B%0A++++++++++name%0A++++++++++...+on+ProductV1MetadataEntity+%7B%0A++++++++++++id%0A++++++++++++name%0A++++++++++++uuid%0A++++++++++++productV1Seller+%7B%0A++++++++++++++name%0A++++++++++++++externalUrl%0A++++++++++++%7D%0A++++++++++++licenseUrl%0A++++++++++%7D%0A++++++++%7D%0A++++++%7D%0A++++%7D%0A++%7D%0A%7D
The 2 offers are the one that was expired and the relisted one. The 2 offers have the same UUID But the product UUID is different. I think it should be the opposite:
  • offer UUID should be different as the offer ID are different on-chain
  • product UUID should be the same (?) as the offer just relist the same product with the same variations.
As a consequence of having the same offer UUID, the licenseURL and externalURL set in the new offer metadata are still referencing the old expired offer.

Check here: https://api.thegraph.com/subgraphs/name/bosonprotocol/mumbai-testing/graphql?query=query+MyQuery+%7B%0A++productV1Products%28where%3A+%7Buuid_in%3A+%5B"15dc403-714-57bf-e35b-44610bff33e4"%2C+"4e823-c447-be75-d05a-f36270e5afe"%5D%7D%29+%7B%0A++++id%0A++++variants+%7B%0A++++++offer+%7B%0A++++++++id%0A++++++++metadataUri%0A++++++++metadataHash%0A++++++++metadata+%7B%0A++++++++++name%0A++++++++++...+on+ProductV1MetadataEntity+%7B%0A++++++++++++id%0A++++++++++++name%0A++++++++++++uuid%0A++++++++++++productV1Seller+%7B%0A++++++++++++++name%0A++++++++++++++externalUrl%0A++++++++++++%7D%0A++++++++++++licenseUrl%0A++++++++++++productUuid%0A++++++++++++product+%7B%0A++++++++++++++uuid%0A++++++++++++%7D%0A++++++++++%7D%0A++++++++++licenseUrl%0A++++++++++externalUrl%0A++++++++%7D%0A++++++%7D%0A++++%7D%0A++%7D%0A%7D
@albertfolch-redeemeum
albertfolch-redeemeum
commented
Apr 24, 2023

Copy link


Copy Markdown

ContributorAuthor
A bit confused here: https://api.thegraph.com/subgraphs/name/bosonprotocol/mumbai-testing/graphql?query=query+MyQuery+%7B%0A++productV1Products%28%0A++++where%3A+%7Buuid_in%3A+%5B"1584b4c-0217-68a0-e0a4-b82b02708fd2"%2C+"0b657a3-7302-e733-af74-37d08806cc7c"%5D%7D%0A++%29+%7B%0A++++id%0A++++variants+%7B%0A++++++offer+%7B%0A++++++++id%0A++++++++metadataUri%0A++++++++metadataHash%0A++++++++metadata+%7B%0A++++++++++name%0A++++++++++...+on+ProductV1MetadataEntity+%7B%0A++++++++++++id%0A++++++++++++name%0A++++++++++++uuid%0A++++++++++++productV1Seller+%7B%0A++++++++++++++name%0A++++++++++++++externalUrl%0A++++++++++++%7D%0A++++++++++++licenseUrl%0A++++++++++%7D%0A++++++++%7D%0A++++++%7D%0A++++%7D%0A++%7D%0A%7D

The 2 offers are the one that was expired and the relisted one. The 2 offers have the same UUID But the product UUID is different. I think it should be the opposite:
  • offer UUID should be different as the offer ID are different on-chain
  • product UUID should be the same (?) as the offer just relist the same product with the same variations.
As a consequence of having the same offer UUID, the licenseURL and externalURL set in the new offer metadata are still referencing the old expired offer. Check here: https://api.thegraph.com/subgraphs/name/bosonprotocol/mumbai-testing/graphql?query=query+MyQuery+%7B%0A++productV1Products%28where%3A+%7Buuid_in%3A+%5B"15dc403-714-57bf-e35b-44610bff33e4"%2C+"4e823-c447-be75-d05a-f36270e5afe"%5D%7D%29+%7B%0A++++id%0A++++variants+%7B%0A++++++offer+%7B%0A++++++++id%0A++++++++metadataUri%0A++++++++metadataHash%0A++++++++metadata+%7B%0A++++++++++name%0A++++++++++...+on+ProductV1MetadataEntity+%7B%0A++++++++++++id%0A++++++++++++name%0A++++++++++++uuid%0A++++++++++++productV1Seller+%7B%0A++++++++++++++name%0A++++++++++++++externalUrl%0A++++++++++++%7D%0A++++++++++++licenseUrl%0A++++++++++++productUuid%0A++++++++++++product+%7B%0A++++++++++++++uuid%0A++++++++++++%7D%0A++++++++++%7D%0A++++++++++licenseUrl%0A++++++++++externalUrl%0A++++++++%7D%0A++++++%7D%0A++++%7D%0A++%7D%0A%7D
this should be fixed now, for example:
https://api.thegraph.com/subgraphs/name/bosonprotocol/mumbai-testing/graphql?query=query+MyQuery+%7B%0A++productV1Products%28orderBy%3A%22id%22%2C+orderDirection%3A%22desc%22%2C+where%3A+%7Buuid_in%3A+%5B%22a6361f3-34d-cc0a-1263-37bf0c050ae%22%2C+%2240a15bc-8b85-8617-515b-50cafb776a7%22%5D%7D%29+%7B%0A++++id%0A++++variants+%7B%0A++++++offer+%7B%0A++++++++createdAt%0A++++++++id%0A++++++++metadataUri%0A++++++++metadataHash%0A++++++++metadata+%7B%0A++++++++++name%0A++++++++++...+on+ProductV1MetadataEntity+%7B%0A++++++++++++id%0A++++++++++++name%0A++++++++++++uuid%0A++++++++++++productV1Seller+%7B%0A++++++++++++++name%0A++++++++++++++externalUrl%0A++++++++++++%7D%0A++++++++++++licenseUrl%0A++++++++++++productUuid%0A++++++++++++product+%7B%0A++++++++++++++uuid%0A++++++++++++%7D%0A++++++++++%7D%0A++++++++++licenseUrl%0A++++++++++externalUrl%0A++++++++%7D%0A++++++%7D%0A++++%7D%0A++%7D%0A%7D
@levalleux-ludo
@albertfolch-redeemeum
albertfolch-redeemeum
deleted the

568-offer-relist

branch
April 24, 2023 14:16
albertfolch-redeemeum added a commit
that referenced
this pull request
Apr 25, 2023
@albertfolch-redeemeumAlbert Folch
feat: relist offer (#596)
d925ad0
* feat: relist offer
* refactor: remove comments
* fix: uuids
albertfolch-redeemeum added a commit
that referenced
this pull request
Apr 27, 2023
@albertfolch-redeemeum
feat: relist offer (#596) (#606)
ec355d2
* feat: relist offer (#596)
* feat: relist offer
* refactor: remove comments
* fix: uuids
* fix: disable relist button if you are not the operator
albertfolch-redeemeum added a commit
that referenced
this pull request
May 11, 2023
@albertfolch-redeemeum@levalleux-ludo
feat: mvfw 2023 (#617)
3347d99
* chore: add sellers 184,190,191 in curation list
* chore: add seller id 195 in curation list
* add seller id 196 in curation list
* chore: upgrade to react-kit 0.16.2-alpha.16
* chore: add seller 202 in curation list (#574)
* chore: add seller 197 in seller curation list (#576)
* fix: custom fonts (#579)
* fix: custom font
* refactor: remove wrong import
* feat: add neuropolitical custom font (#587)
* chore: add seller 207 in seller curation list (#591)
* fix: tabnapping protection (#594)
* feat: change seller deposit copy (#603)
* feat: remove promotional banner (#601) (#604)
* feat: remove promotional banner
* fix: build
* feat: relist offer (#596) (#606)
* feat: relist offer (#596)
* feat: relist offer
* refactor: remove comments
* fix: uuids
* fix: disable relist button if you are not the operator
---------
Co-authored-by: Ludovic Levalleux <levalleux_ludo@hotmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@levalleux-ludolevalleux-ludolevalleux-ludo approved these changes

Assignees

@albertfolch-redeemeumalbertfolch-redeemeum

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Offer Relist


2 participants

@albertfolch-redeemeum@levalleux-ludo

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat: relist offer - #596
Merged
albertfolch-redeemeum merged 3 commits into
mainfrom 
568-offer-relist
Apr 24, 2023
Merged
feat: relist offer#596
albertfolch-redeemeum merged 3 commits into
mainfrom 
568-offer-relist
Conversation
@albertfolch-redeemeum
@albertfolch-redeemeumalbertfolch-redeemeum
commented
Apr 21, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
  • feat: relist offer
  • improved types
  • fixed width of draft modal: it got too big in big screens
  • fix loading spinner when you want to export exchanges with delivery data: if you clicked on the button and then cancel the confirmation of the transaction to enable identity, then the loading spinner was not removed
  • fix datepicker so that if you dont specify an initial date, you see the "Choose date..." text & if you click on a disable date, you see the same text
  • extracted the logic to create an offer/s into an useCreateOffers hook
  • remove useless code
  • fixed low priority error you get after creating an offer and seeing the success modal (BigNumber error in console if the offer is not token gated)
  • fix: in the modal to export the exchange delivery data, changed the initial value to the beginning of the month & remove disable behaviour on the export in option 2
  • fix: style/overflow of export exchanges with delivery data modal (calendar of the datepicker was being cut off)
@albertfolch-redeemeum
albertfolch-redeemeum
requested a review
from a teamApril 21, 2023 15:15
@albertfolch-redeemeumalbertfolch-redeemeum
linked an issue
Apr 21, 2023
that may be
closed
by this pull request


Offer Relist
#568

Closed

@albertfolch-redeemeum
albertfolch-redeemeum
marked this pull request as draft
April 21, 2023 15:15
@cloudflare-workers-and-pages
cloudflare-workers-and-pagesBot
commented
Apr 21, 2023•

edited

Loading

Copy link


Copy Markdown

Deploying with Cloudflare Pages Cloudflare Pages
Latest commit:f61df30
Status: ✅ Deploy successful!
Preview URL:https://bdcb0ecd.interface-a9d.pages.dev
Branch Preview URL:https://568-offer-relist.interface-a9d.pages.dev
View logs
@albertfolch-redeemeum
albertfolch-redeemeum
changed the base branch from
main
to
mvfw-2023April 21, 2023 15:23
@albertfolch-redeemeum
albertfolch-redeemeum
changed the base branch from
mvfw-2023
to
mainApril 21, 2023 15:24
@albertfolch-redeemeum
albertfolch-redeemeum
marked this pull request as ready for review
April 21, 2023 15:24
@levalleux-ludo
levalleux-ludo
commented
Apr 21, 2023•

edited

Loading

Copy link


Copy Markdown

Member
A bit confused here: https://api.thegraph.com/subgraphs/name/bosonprotocol/mumbai-testing/graphql?query=query+MyQuery+%7B%0A++productV1Products%28%0A++++where%3A+%7Buuid_in%3A+%5B"1584b4c-0217-68a0-e0a4-b82b02708fd2"%2C+"0b657a3-7302-e733-af74-37d08806cc7c"%5D%7D%0A++%29+%7B%0A++++id%0A++++variants+%7B%0A++++++offer+%7B%0A++++++++id%0A++++++++metadataUri%0A++++++++metadataHash%0A++++++++metadata+%7B%0A++++++++++name%0A++++++++++...+on+ProductV1MetadataEntity+%7B%0A++++++++++++id%0A++++++++++++name%0A++++++++++++uuid%0A++++++++++++productV1Seller+%7B%0A++++++++++++++name%0A++++++++++++++externalUrl%0A++++++++++++%7D%0A++++++++++++licenseUrl%0A++++++++++%7D%0A++++++++%7D%0A++++++%7D%0A++++%7D%0A++%7D%0A%7D
The 2 offers are the one that was expired and the relisted one.

The 2 offers have the same UUID

But the product UUID is different.

I think it should be the opposite:
  • offer UUID should be different as the offer ID are different on-chain
  • product UUID should be the same (?) as the offer just relist the same product with the same variations.
@levalleux-ludo
levalleux-ludo
commented
Apr 21, 2023

Copy link


Copy Markdown

Member
What happen if I relist an offer that is still valid?

Is the old one voided?

How is the dApp supporting such a case?
@albertfolch-redeemeum
albertfolch-redeemeum
commented
Apr 21, 2023

Copy link


Copy Markdown

ContributorAuthor
What happen if I relist an offer that is still valid? Is the old one voided? How is the dApp supporting such a case?
you can relist any offer, no restrictions and no side effects
@albertfolch-redeemeum
albertfolch-redeemeum
commented
Apr 21, 2023

Copy link


Copy Markdown

ContributorAuthor
A bit confused here: https://api.thegraph.com/subgraphs/name/bosonprotocol/mumbai-testing/graphql?query=query+MyQuery+%7B%0A++productV1Products%28%0A++++where%3A+%7Buuid_in%3A+%5B"1584b4c-0217-68a0-e0a4-b82b02708fd2"%2C+"0b657a3-7302-e733-af74-37d08806cc7c"%5D%7D%0A++%29+%7B%0A++++id%0A++++variants+%7B%0A++++++offer+%7B%0A++++++++id%0A++++++++metadataUri%0A++++++++metadataHash%0A++++++++metadata+%7B%0A++++++++++name%0A++++++++++...+on+ProductV1MetadataEntity+%7B%0A++++++++++++id%0A++++++++++++name%0A++++++++++++uuid%0A++++++++++++productV1Seller+%7B%0A++++++++++++++name%0A++++++++++++++externalUrl%0A++++++++++++%7D%0A++++++++++++licenseUrl%0A++++++++++%7D%0A++++++++%7D%0A++++++%7D%0A++++%7D%0A++%7D%0A%7D
The 2 offers are the one that was expired and the relisted one. The 2 offers have the same UUID But the product UUID is different. I think it should be the opposite:
  • offer UUID should be different as the offer ID are different on-chain
  • product UUID should be the same (?) as the offer just relist the same product with the same variations.
The 2 offers have the same UUID
this is a bug
product UUID should be the same (?) as the offer just relist the same product with the same variations.
why the same? I think it should be different, everything different, just different dates...basically the same behaviour as if you were to create the same product using local storage and setting the dates differently (no actual relationship with the 'old' offer) ...maybe it should be called 'duplicate' instead of 'relist' then
@levalleux-ludo
levalleux-ludo
commented
Apr 21, 2023•

edited

Loading

Copy link


Copy Markdown

Member
A bit confused here: https://api.thegraph.com/subgraphs/name/bosonprotocol/mumbai-testing/graphql?query=query+MyQuery+%7B%0A++productV1Products%28%0A++++where%3A+%7Buuid_in%3A+%5B"1584b4c-0217-68a0-e0a4-b82b02708fd2"%2C+"0b657a3-7302-e733-af74-37d08806cc7c"%5D%7D%0A++%29+%7B%0A++++id%0A++++variants+%7B%0A++++++offer+%7B%0A++++++++id%0A++++++++metadataUri%0A++++++++metadataHash%0A++++++++metadata+%7B%0A++++++++++name%0A++++++++++...+on+ProductV1MetadataEntity+%7B%0A++++++++++++id%0A++++++++++++name%0A++++++++++++uuid%0A++++++++++++productV1Seller+%7B%0A++++++++++++++name%0A++++++++++++++externalUrl%0A++++++++++++%7D%0A++++++++++++licenseUrl%0A++++++++++%7D%0A++++++++%7D%0A++++++%7D%0A++++%7D%0A++%7D%0A%7D
The 2 offers are the one that was expired and the relisted one. The 2 offers have the same UUID But the product UUID is different. I think it should be the opposite:
  • offer UUID should be different as the offer ID are different on-chain
  • product UUID should be the same (?) as the offer just relist the same product with the same variations.
As a consequence of having the same offer UUID, the licenseURL and externalURL set in the new offer metadata are still referencing the old expired offer.

Check here: https://api.thegraph.com/subgraphs/name/bosonprotocol/mumbai-testing/graphql?query=query+MyQuery+%7B%0A++productV1Products%28where%3A+%7Buuid_in%3A+%5B"15dc403-714-57bf-e35b-44610bff33e4"%2C+"4e823-c447-be75-d05a-f36270e5afe"%5D%7D%29+%7B%0A++++id%0A++++variants+%7B%0A++++++offer+%7B%0A++++++++id%0A++++++++metadataUri%0A++++++++metadataHash%0A++++++++metadata+%7B%0A++++++++++name%0A++++++++++...+on+ProductV1MetadataEntity+%7B%0A++++++++++++id%0A++++++++++++name%0A++++++++++++uuid%0A++++++++++++productV1Seller+%7B%0A++++++++++++++name%0A++++++++++++++externalUrl%0A++++++++++++%7D%0A++++++++++++licenseUrl%0A++++++++++++productUuid%0A++++++++++++product+%7B%0A++++++++++++++uuid%0A++++++++++++%7D%0A++++++++++%7D%0A++++++++++licenseUrl%0A++++++++++externalUrl%0A++++++++%7D%0A++++++%7D%0A++++%7D%0A++%7D%0A%7D
@albertfolch-redeemeum
albertfolch-redeemeum
commented
Apr 24, 2023

Copy link


Copy Markdown

ContributorAuthor
A bit confused here: https://api.thegraph.com/subgraphs/name/bosonprotocol/mumbai-testing/graphql?query=query+MyQuery+%7B%0A++productV1Products%28%0A++++where%3A+%7Buuid_in%3A+%5B"1584b4c-0217-68a0-e0a4-b82b02708fd2"%2C+"0b657a3-7302-e733-af74-37d08806cc7c"%5D%7D%0A++%29+%7B%0A++++id%0A++++variants+%7B%0A++++++offer+%7B%0A++++++++id%0A++++++++metadataUri%0A++++++++metadataHash%0A++++++++metadata+%7B%0A++++++++++name%0A++++++++++...+on+ProductV1MetadataEntity+%7B%0A++++++++++++id%0A++++++++++++name%0A++++++++++++uuid%0A++++++++++++productV1Seller+%7B%0A++++++++++++++name%0A++++++++++++++externalUrl%0A++++++++++++%7D%0A++++++++++++licenseUrl%0A++++++++++%7D%0A++++++++%7D%0A++++++%7D%0A++++%7D%0A++%7D%0A%7D

The 2 offers are the one that was expired and the relisted one. The 2 offers have the same UUID But the product UUID is different. I think it should be the opposite:
  • offer UUID should be different as the offer ID are different on-chain
  • product UUID should be the same (?) as the offer just relist the same product with the same variations.
As a consequence of having the same offer UUID, the licenseURL and externalURL set in the new offer metadata are still referencing the old expired offer. Check here: https://api.thegraph.com/subgraphs/name/bosonprotocol/mumbai-testing/graphql?query=query+MyQuery+%7B%0A++productV1Products%28where%3A+%7Buuid_in%3A+%5B"15dc403-714-57bf-e35b-44610bff33e4"%2C+"4e823-c447-be75-d05a-f36270e5afe"%5D%7D%29+%7B%0A++++id%0A++++variants+%7B%0A++++++offer+%7B%0A++++++++id%0A++++++++metadataUri%0A++++++++metadataHash%0A++++++++metadata+%7B%0A++++++++++name%0A++++++++++...+on+ProductV1MetadataEntity+%7B%0A++++++++++++id%0A++++++++++++name%0A++++++++++++uuid%0A++++++++++++productV1Seller+%7B%0A++++++++++++++name%0A++++++++++++++externalUrl%0A++++++++++++%7D%0A++++++++++++licenseUrl%0A++++++++++++productUuid%0A++++++++++++product+%7B%0A++++++++++++++uuid%0A++++++++++++%7D%0A++++++++++%7D%0A++++++++++licenseUrl%0A++++++++++externalUrl%0A++++++++%7D%0A++++++%7D%0A++++%7D%0A++%7D%0A%7D
this should be fixed now, for example:
https://api.thegraph.com/subgraphs/name/bosonprotocol/mumbai-testing/graphql?query=query+MyQuery+%7B%0A++productV1Products%28orderBy%3A%22id%22%2C+orderDirection%3A%22desc%22%2C+where%3A+%7Buuid_in%3A+%5B%22a6361f3-34d-cc0a-1263-37bf0c050ae%22%2C+%2240a15bc-8b85-8617-515b-50cafb776a7%22%5D%7D%29+%7B%0A++++id%0A++++variants+%7B%0A++++++offer+%7B%0A++++++++createdAt%0A++++++++id%0A++++++++metadataUri%0A++++++++metadataHash%0A++++++++metadata+%7B%0A++++++++++name%0A++++++++++...+on+ProductV1MetadataEntity+%7B%0A++++++++++++id%0A++++++++++++name%0A++++++++++++uuid%0A++++++++++++productV1Seller+%7B%0A++++++++++++++name%0A++++++++++++++externalUrl%0A++++++++++++%7D%0A++++++++++++licenseUrl%0A++++++++++++productUuid%0A++++++++++++product+%7B%0A++++++++++++++uuid%0A++++++++++++%7D%0A++++++++++%7D%0A++++++++++licenseUrl%0A++++++++++externalUrl%0A++++++++%7D%0A++++++%7D%0A++++%7D%0A++%7D%0A%7D
@levalleux-ludo
@albertfolch-redeemeum
albertfolch-redeemeum
deleted the

568-offer-relist

branch
April 24, 2023 14:16
albertfolch-redeemeum added a commit
that referenced
this pull request
Apr 25, 2023
@albertfolch-redeemeumAlbert Folch
feat: relist offer (#596)
d925ad0
* feat: relist offer
* refactor: remove comments
* fix: uuids
albertfolch-redeemeum added a commit
that referenced
this pull request
Apr 27, 2023
@albertfolch-redeemeum
feat: relist offer (#596) (#606)
ec355d2
* feat: relist offer (#596)
* feat: relist offer
* refactor: remove comments
* fix: uuids
* fix: disable relist button if you are not the operator
albertfolch-redeemeum added a commit
that referenced
this pull request
May 11, 2023
@albertfolch-redeemeum@levalleux-ludo
feat: mvfw 2023 (#617)
3347d99
* chore: add sellers 184,190,191 in curation list
* chore: add seller id 195 in curation list
* add seller id 196 in curation list
* chore: upgrade to react-kit 0.16.2-alpha.16
* chore: add seller 202 in curation list (#574)
* chore: add seller 197 in seller curation list (#576)
* fix: custom fonts (#579)
* fix: custom font
* refactor: remove wrong import
* feat: add neuropolitical custom font (#587)
* chore: add seller 207 in seller curation list (#591)
* fix: tabnapping protection (#594)
* feat: change seller deposit copy (#603)
* feat: remove promotional banner (#601) (#604)
* feat: remove promotional banner
* fix: build
* feat: relist offer (#596) (#606)
* feat: relist offer (#596)
* feat: relist offer
* refactor: remove comments
* fix: uuids
* fix: disable relist button if you are not the operator
---------
Co-authored-by: Ludovic Levalleux <levalleux_ludo@hotmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@levalleux-ludolevalleux-ludolevalleux-ludo approved these changes

Assignees

@albertfolch-redeemeumalbertfolch-redeemeum

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Offer Relist


2 participants

@albertfolch-redeemeum@levalleux-ludo

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
feat: relist offer - #596
Merged
albertfolch-redeemeum merged 3 commits into
mainfrom 
568-offer-relist
Apr 24, 2023
Merged
feat: relist offer#596
albertfolch-redeemeum merged 3 commits into
mainfrom 
568-offer-relist
Conversation
@albertfolch-redeemeum
@albertfolch-redeemeumalbertfolch-redeemeum
commented
Apr 21, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
  • feat: relist offer
  • improved types
  • fixed width of draft modal: it got too big in big screens
  • fix loading spinner when you want to export exchanges with delivery data: if you clicked on the button and then cancel the confirmation of the transaction to enable identity, then the loading spinner was not removed
  • fix datepicker so that if you dont specify an initial date, you see the "Choose date..." text & if you click on a disable date, you see the same text
  • extracted the logic to create an offer/s into an useCreateOffers hook
  • remove useless code
  • fixed low priority error you get after creating an offer and seeing the success modal (BigNumber error in console if the offer is not token gated)
  • fix: in the modal to export the exchange delivery data, changed the initial value to the beginning of the month & remove disable behaviour on the export in option 2
  • fix: style/overflow of export exchanges with delivery data modal (calendar of the datepicker was being cut off)
@albertfolch-redeemeum
albertfolch-redeemeum
requested a review
from a teamApril 21, 2023 15:15
@albertfolch-redeemeumalbertfolch-redeemeum
linked an issue
Apr 21, 2023
that may be
closed
by this pull request


Offer Relist
#568

Closed

@albertfolch-redeemeum
albertfolch-redeemeum
marked this pull request as draft
April 21, 2023 15:15
@cloudflare-workers-and-pages
cloudflare-workers-and-pagesBot
commented
Apr 21, 2023•

edited

Loading

Copy link


Copy Markdown

Deploying with Cloudflare Pages Cloudflare Pages
Latest commit:f61df30
Status: ✅ Deploy successful!
Preview URL:https://bdcb0ecd.interface-a9d.pages.dev
Branch Preview URL:https://568-offer-relist.interface-a9d.pages.dev
View logs
@albertfolch-redeemeum
albertfolch-redeemeum
changed the base branch from
main
to
mvfw-2023April 21, 2023 15:23
@albertfolch-redeemeum
albertfolch-redeemeum
changed the base branch from
mvfw-2023
to
mainApril 21, 2023 15:24
@albertfolch-redeemeum
albertfolch-redeemeum
marked this pull request as ready for review
April 21, 2023 15:24
@levalleux-ludo
levalleux-ludo
commented
Apr 21, 2023•

edited

Loading

Copy link


Copy Markdown

Member
A bit confused here: https://api.thegraph.com/subgraphs/name/bosonprotocol/mumbai-testing/graphql?query=query+MyQuery+%7B%0A++productV1Products%28%0A++++where%3A+%7Buuid_in%3A+%5B"1584b4c-0217-68a0-e0a4-b82b02708fd2"%2C+"0b657a3-7302-e733-af74-37d08806cc7c"%5D%7D%0A++%29+%7B%0A++++id%0A++++variants+%7B%0A++++++offer+%7B%0A++++++++id%0A++++++++metadataUri%0A++++++++metadataHash%0A++++++++metadata+%7B%0A++++++++++name%0A++++++++++...+on+ProductV1MetadataEntity+%7B%0A++++++++++++id%0A++++++++++++name%0A++++++++++++uuid%0A++++++++++++productV1Seller+%7B%0A++++++++++++++name%0A++++++++++++++externalUrl%0A++++++++++++%7D%0A++++++++++++licenseUrl%0A++++++++++%7D%0A++++++++%7D%0A++++++%7D%0A++++%7D%0A++%7D%0A%7D
The 2 offers are the one that was expired and the relisted one.

The 2 offers have the same UUID

But the product UUID is different.

I think it should be the opposite:
  • offer UUID should be different as the offer ID are different on-chain
  • product UUID should be the same (?) as the offer just relist the same product with the same variations.
@levalleux-ludo
levalleux-ludo
commented
Apr 21, 2023

Copy link


Copy Markdown

Member
What happen if I relist an offer that is still valid?

Is the old one voided?

How is the dApp supporting such a case?
@albertfolch-redeemeum
albertfolch-redeemeum
commented
Apr 21, 2023

Copy link


Copy Markdown

ContributorAuthor
What happen if I relist an offer that is still valid? Is the old one voided? How is the dApp supporting such a case?
you can relist any offer, no restrictions and no side effects
@albertfolch-redeemeum
albertfolch-redeemeum
commented
Apr 21, 2023

Copy link


Copy Markdown

ContributorAuthor
A bit confused here: https://api.thegraph.com/subgraphs/name/bosonprotocol/mumbai-testing/graphql?query=query+MyQuery+%7B%0A++productV1Products%28%0A++++where%3A+%7Buuid_in%3A+%5B"1584b4c-0217-68a0-e0a4-b82b02708fd2"%2C+"0b657a3-7302-e733-af74-37d08806cc7c"%5D%7D%0A++%29+%7B%0A++++id%0A++++variants+%7B%0A++++++offer+%7B%0A++++++++id%0A++++++++metadataUri%0A++++++++metadataHash%0A++++++++metadata+%7B%0A++++++++++name%0A++++++++++...+on+ProductV1MetadataEntity+%7B%0A++++++++++++id%0A++++++++++++name%0A++++++++++++uuid%0A++++++++++++productV1Seller+%7B%0A++++++++++++++name%0A++++++++++++++externalUrl%0A++++++++++++%7D%0A++++++++++++licenseUrl%0A++++++++++%7D%0A++++++++%7D%0A++++++%7D%0A++++%7D%0A++%7D%0A%7D
The 2 offers are the one that was expired and the relisted one. The 2 offers have the same UUID But the product UUID is different. I think it should be the opposite:
  • offer UUID should be different as the offer ID are different on-chain
  • product UUID should be the same (?) as the offer just relist the same product with the same variations.
The 2 offers have the same UUID
this is a bug
product UUID should be the same (?) as the offer just relist the same product with the same variations.
why the same? I think it should be different, everything different, just different dates...basically the same behaviour as if you were to create the same product using local storage and setting the dates differently (no actual relationship with the 'old' offer) ...maybe it should be called 'duplicate' instead of 'relist' then
@levalleux-ludo
levalleux-ludo
commented
Apr 21, 2023•

edited

Loading

Copy link


Copy Markdown

Member
A bit confused here: https://api.thegraph.com/subgraphs/name/bosonprotocol/mumbai-testing/graphql?query=query+MyQuery+%7B%0A++productV1Products%28%0A++++where%3A+%7Buuid_in%3A+%5B"1584b4c-0217-68a0-e0a4-b82b02708fd2"%2C+"0b657a3-7302-e733-af74-37d08806cc7c"%5D%7D%0A++%29+%7B%0A++++id%0A++++variants+%7B%0A++++++offer+%7B%0A++++++++id%0A++++++++metadataUri%0A++++++++metadataHash%0A++++++++metadata+%7B%0A++++++++++name%0A++++++++++...+on+ProductV1MetadataEntity+%7B%0A++++++++++++id%0A++++++++++++name%0A++++++++++++uuid%0A++++++++++++productV1Seller+%7B%0A++++++++++++++name%0A++++++++++++++externalUrl%0A++++++++++++%7D%0A++++++++++++licenseUrl%0A++++++++++%7D%0A++++++++%7D%0A++++++%7D%0A++++%7D%0A++%7D%0A%7D
The 2 offers are the one that was expired and the relisted one. The 2 offers have the same UUID But the product UUID is different. I think it should be the opposite:
  • offer UUID should be different as the offer ID are different on-chain
  • product UUID should be the same (?) as the offer just relist the same product with the same variations.
As a consequence of having the same offer UUID, the licenseURL and externalURL set in the new offer metadata are still referencing the old expired offer.

Check here: https://api.thegraph.com/subgraphs/name/bosonprotocol/mumbai-testing/graphql?query=query+MyQuery+%7B%0A++productV1Products%28where%3A+%7Buuid_in%3A+%5B"15dc403-714-57bf-e35b-44610bff33e4"%2C+"4e823-c447-be75-d05a-f36270e5afe"%5D%7D%29+%7B%0A++++id%0A++++variants+%7B%0A++++++offer+%7B%0A++++++++id%0A++++++++metadataUri%0A++++++++metadataHash%0A++++++++metadata+%7B%0A++++++++++name%0A++++++++++...+on+ProductV1MetadataEntity+%7B%0A++++++++++++id%0A++++++++++++name%0A++++++++++++uuid%0A++++++++++++productV1Seller+%7B%0A++++++++++++++name%0A++++++++++++++externalUrl%0A++++++++++++%7D%0A++++++++++++licenseUrl%0A++++++++++++productUuid%0A++++++++++++product+%7B%0A++++++++++++++uuid%0A++++++++++++%7D%0A++++++++++%7D%0A++++++++++licenseUrl%0A++++++++++externalUrl%0A++++++++%7D%0A++++++%7D%0A++++%7D%0A++%7D%0A%7D
@albertfolch-redeemeum
albertfolch-redeemeum
commented
Apr 24, 2023

Copy link


Copy Markdown

ContributorAuthor
A bit confused here: https://api.thegraph.com/subgraphs/name/bosonprotocol/mumbai-testing/graphql?query=query+MyQuery+%7B%0A++productV1Products%28%0A++++where%3A+%7Buuid_in%3A+%5B"1584b4c-0217-68a0-e0a4-b82b02708fd2"%2C+"0b657a3-7302-e733-af74-37d08806cc7c"%5D%7D%0A++%29+%7B%0A++++id%0A++++variants+%7B%0A++++++offer+%7B%0A++++++++id%0A++++++++metadataUri%0A++++++++metadataHash%0A++++++++metadata+%7B%0A++++++++++name%0A++++++++++...+on+ProductV1MetadataEntity+%7B%0A++++++++++++id%0A++++++++++++name%0A++++++++++++uuid%0A++++++++++++productV1Seller+%7B%0A++++++++++++++name%0A++++++++++++++externalUrl%0A++++++++++++%7D%0A++++++++++++licenseUrl%0A++++++++++%7D%0A++++++++%7D%0A++++++%7D%0A++++%7D%0A++%7D%0A%7D

The 2 offers are the one that was expired and the relisted one. The 2 offers have the same UUID But the product UUID is different. I think it should be the opposite:
  • offer UUID should be different as the offer ID are different on-chain
  • product UUID should be the same (?) as the offer just relist the same product with the same variations.
As a consequence of having the same offer UUID, the licenseURL and externalURL set in the new offer metadata are still referencing the old expired offer. Check here: https://api.thegraph.com/subgraphs/name/bosonprotocol/mumbai-testing/graphql?query=query+MyQuery+%7B%0A++productV1Products%28where%3A+%7Buuid_in%3A+%5B"15dc403-714-57bf-e35b-44610bff33e4"%2C+"4e823-c447-be75-d05a-f36270e5afe"%5D%7D%29+%7B%0A++++id%0A++++variants+%7B%0A++++++offer+%7B%0A++++++++id%0A++++++++metadataUri%0A++++++++metadataHash%0A++++++++metadata+%7B%0A++++++++++name%0A++++++++++...+on+ProductV1MetadataEntity+%7B%0A++++++++++++id%0A++++++++++++name%0A++++++++++++uuid%0A++++++++++++productV1Seller+%7B%0A++++++++++++++name%0A++++++++++++++externalUrl%0A++++++++++++%7D%0A++++++++++++licenseUrl%0A++++++++++++productUuid%0A++++++++++++product+%7B%0A++++++++++++++uuid%0A++++++++++++%7D%0A++++++++++%7D%0A++++++++++licenseUrl%0A++++++++++externalUrl%0A++++++++%7D%0A++++++%7D%0A++++%7D%0A++%7D%0A%7D
this should be fixed now, for example:
https://api.thegraph.com/subgraphs/name/bosonprotocol/mumbai-testing/graphql?query=query+MyQuery+%7B%0A++productV1Products%28orderBy%3A%22id%22%2C+orderDirection%3A%22desc%22%2C+where%3A+%7Buuid_in%3A+%5B%22a6361f3-34d-cc0a-1263-37bf0c050ae%22%2C+%2240a15bc-8b85-8617-515b-50cafb776a7%22%5D%7D%29+%7B%0A++++id%0A++++variants+%7B%0A++++++offer+%7B%0A++++++++createdAt%0A++++++++id%0A++++++++metadataUri%0A++++++++metadataHash%0A++++++++metadata+%7B%0A++++++++++name%0A++++++++++...+on+ProductV1MetadataEntity+%7B%0A++++++++++++id%0A++++++++++++name%0A++++++++++++uuid%0A++++++++++++productV1Seller+%7B%0A++++++++++++++name%0A++++++++++++++externalUrl%0A++++++++++++%7D%0A++++++++++++licenseUrl%0A++++++++++++productUuid%0A++++++++++++product+%7B%0A++++++++++++++uuid%0A++++++++++++%7D%0A++++++++++%7D%0A++++++++++licenseUrl%0A++++++++++externalUrl%0A++++++++%7D%0A++++++%7D%0A++++%7D%0A++%7D%0A%7D
@levalleux-ludo
@albertfolch-redeemeum
albertfolch-redeemeum
deleted the

568-offer-relist

branch
April 24, 2023 14:16
albertfolch-redeemeum added a commit
that referenced
this pull request
Apr 25, 2023
@albertfolch-redeemeumAlbert Folch
feat: relist offer (#596)
d925ad0
* feat: relist offer
* refactor: remove comments
* fix: uuids
albertfolch-redeemeum added a commit
that referenced
this pull request
Apr 27, 2023
@albertfolch-redeemeum
feat: relist offer (#596) (#606)
ec355d2
* feat: relist offer (#596)
* feat: relist offer
* refactor: remove comments
* fix: uuids
* fix: disable relist button if you are not the operator
albertfolch-redeemeum added a commit
that referenced
this pull request
May 11, 2023
@albertfolch-redeemeum@levalleux-ludo
feat: mvfw 2023 (#617)
3347d99
* chore: add sellers 184,190,191 in curation list
* chore: add seller id 195 in curation list
* add seller id 196 in curation list
* chore: upgrade to react-kit 0.16.2-alpha.16
* chore: add seller 202 in curation list (#574)
* chore: add seller 197 in seller curation list (#576)
* fix: custom fonts (#579)
* fix: custom font
* refactor: remove wrong import
* feat: add neuropolitical custom font (#587)
* chore: add seller 207 in seller curation list (#591)
* fix: tabnapping protection (#594)
* feat: change seller deposit copy (#603)
* feat: remove promotional banner (#601) (#604)
* feat: remove promotional banner
* fix: build
* feat: relist offer (#596) (#606)
* feat: relist offer (#596)
* feat: relist offer
* refactor: remove comments
* fix: uuids
* fix: disable relist button if you are not the operator
---------
Co-authored-by: Ludovic Levalleux <levalleux_ludo@hotmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@levalleux-ludolevalleux-ludolevalleux-ludo approved these changes

Assignees

@albertfolch-redeemeumalbertfolch-redeemeum

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Offer Relist


2 participants

@albertfolch-redeemeum@levalleux-ludo