Conversation
ZedThree
requested changes
Aug 27, 2026
ZedThree
left a comment
Member
There was a problem hiding this comment.
Looks good, a few comments though. Also:
- please expand the docs
- needs tests -- should be pretty easy to add to
fv_mms? - please can we change the name? :)
Contributor
Author
I added some, if you want more, please let me know what.
No, it needs zoidberg to create the coefficients. Zoidberg has MMS tests, so a unit test should be fine?
Sure, do you have a good suggestion? |
Contributor
|
bendudson
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the DAGP_fv operator needed for boutproject/hermes-3#643