improv: freshen up dpp::snowflake and dpp::managed - #912
Merged
Merged
Conversation
✅ Deploy Preview for dpp-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Mishura4
commented
Oct 3, 2023
Mishura4
marked this pull request as ready for review
October 5, 2023 16:50
Jaskowicz1
requested changes
Oct 5, 2023
braindigitalis
requested changes
Oct 6, 2023
braindigitalis
left a comment
Contributor
There was a problem hiding this comment.
namespace doesnt need to be indented any more
Member
Author
|
Updated |
Jaskowicz1
approved these changes
Oct 6, 2023
braindigitalis
approved these changes
Oct 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modernizes dpp::snowflake and dpp::managed a little bit, and makes them constexpr-compatible
API is unchanged
Code change checklist