check for preSubmit errors

[sandello-alkr]

Solves #200.
TODO: error bubbling.

[florianeckerstorfer]

Thanks @sandello-alkr. I didn't knew that. Do you want to add error bubbling before I merge?

[sandello-alkr]

Yes, I'll watch into this little later. I don't like recursion in template, so I need some time for research about nested forms behavior.

[florianeckerstorfer]

@sandello-alkr Anything new on this PR? Should I merge it in its current form and we add error bubbling later?

[sandello-alkr]

I'm not sure right now if error bubbling is something good at all. It makes me crazy when I can't locate field with error, cause of whole form is "red". Maybe we should totally remove error bubbling?

[sandello-alkr]

Anyway, thx for this remind, I'v totally forgot about this (-_-")

[florianeckerstorfer]

There are some instances when it is useful. For example, in a login form where you don't want to say "username is wrong" or "password is wrong" but rather say "username/password combination is wrong". In that case the whole form should be marked as invalid.

[sandello-alkr]

I've added has-error class to form tag, so now if you need error bubbling for the whole form, you can use error_bubbling option. That would push error from specific input, to the form.
If you need to highlight virtual form, I suggest use custom validator, adding error to needed form child.
Also you need to be careful with collections, cause it have "error_bubbling" option true by default.

[florianeckerstorfer]

Thanks.