Uh oh!
There was an error while loading. Please reload this page.
Use shared release actions for JS package release - #202
Closed
David Elner (delner) wants to merge 1 commit into
Closed
Use shared release actions for JS package release#202David Elner (delner) wants to merge 1 commit into
David Elner (delner) wants to merge 1 commit into
Conversation
Braintrust eval report
|
David Elner (delner)
commented
Jun 23, 2026
CollaboratorAuthor
This is based on the |
Comment on lines
+172
to
+173
| slack_token: ${{ secrets.SLACK_BOT_TOKEN }} | ||
| slack_channel: ${{ vars.SLACK_SDK_RELEASE_CHANNEL }} |
There was a problem hiding this comment.
it's kind of annoying that you need to set up a slack token per repo.
Maybe we can make this action execute a trigger on the sdk-actions repo and have it trigger the slack action there? Might be too involved/complicated.
CollaboratorAuthor
There was a problem hiding this comment.
You don't need to set it up per repo if it's org level.
Uh oh!
There was an error while loading. Please reload this page.
David Elner (delner)force-pushed
the
ci/release_js_with_shared_action
branch
from
June 24, 2026 14:41
a8cf9bc to
b59171aCompareAbhijeet Prasad (AbhiPrasad)
approved these changes
Jun 26, 2026
David Elner (delner)force-pushed
the
ci/release_js_with_shared_action
branch
from
June 29, 2026 22:30
b59171a to
5ec9714CompareDavid Elner (delner)
commented
Jul 15, 2026
CollaboratorAuthor
Closed in favor of #204 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the
autoevalsnpm publish onto the canonical, centrally-maintained release actions inbraintrustdata/sdk-actions(pinned by SHA), and switches releases from branch-based to explicit-SHA dispatch so js and py publish the same reviewed commit.Changes
publish-js.yaml— rewritten to wrap the shared actions:compute-metadata → validate → prepare → notify-pending → publish. autoevals keeps only its glue (version-sync, version/channel computation, the prereleasepackage.jsonpatch); the shared jobs are just the pinned action + inputs. Adds:npm-publish/npm-publish-dry-runenvironments),dry_runinput (build/pack, no publish).publish.yaml(dispatcher) +publish-py.yaml—branchinput → requiredsha; the same commit is passed to both languages. Python's publish mechanics are otherwise unchanged (no shared-action adoption yet).docs/PUBLISHING.md: updated for the shared actions, the gate,dry_run, Slack, the npm trusted-publisher environment requirement, andbranch → sha.Unchanged:
version-sync.yaml,check_version_sync.py, OIDC trusted publishing + provenance, tag scheme (js-/py-), pnpm/node versions, PyPI publishing.Required setup before the first real publish
npm-publish(required reviewers,main-only) andnpm-publish-dry-run.npm-publishenvironment: the gated job's OIDC token carries anenvironmentclaim.dry_rundoes not exercise this..SLACK_SDK_RELEASE_CHANNELvar.Note
JS gains the approval gate + Slack; Python does not yet (follow-up once shared Python release actions exist).