Uh oh!
There was an error while loading. Please reload this page.
Isolate daemon sessions by coding-agent source - #40
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:3c6df13707
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
What this changes
A native session ID is only unique within a coding agent. The daemon previously used that ID alone for journals, locks, delivery keys, and deterministic span namespaces, so two agents reusing the same value could collide.
This PR makes the canonical agent source part of daemon session identity. It:
This is intentionally limited to source identity and daemon state isolation; it does not change translator checkpoint/finalization behavior, managed-run capture, transcript import, or package distribution.
Validation
cargo test --manifest-path bt-daemon/Cargo.toml --all-featurescargo clippy --manifest-path bt-daemon/Cargo.toml --all-targets --all-features -- -D warningscargo fmt --manifest-path bt-daemon/Cargo.toml -- --checkgit diff --checkThe full daemon suite passes, including 20 distributed-tracing tests and new coverage for same-ID cross-agent isolation, strict source rejection, and legacy journal migration. Real-agent tests remain ignored by the default suite because this slice changes daemon identity/recovery rather than agent adapters.