Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
Expand Up@@ -24,6 +24,9 @@
import java.io.InputStreamReader;
import java.io.OutputStream;
import java.nio.charset.StandardCharsets;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.atomic.AtomicBoolean;
import java.util.concurrent.atomic.AtomicLong;
Expand DownExpand Up@@ -260,10 +263,25 @@ private void onFirstByte() {

private void onStreamClosed() {
try {
// Scooped first and unconditionally: tagSpanFromBuffer bails on an empty body,
// and a failed request is both the likeliest source of one and the case where
// the vendor's request id is most worth having.
InstrumentationSemConv.tagLLMSpanIdHeaders(span, headersAsMap(delegate.headers()));

byte[] bytes;
synchronized (teeBuffer) {
bytes = teeBuffer.toByteArray();
}

// Recorded before tagging: the anthropic sdk raises above this layer, so the
// error status is ours alone to set, and losing it to a body-parsing problem is
// worse than losing the parsed output.
int statusCode = delegate.statusCode();
if (statusCode >= 400) {
InstrumentationSemConv.tagLLMSpanHttpError(
span, statusCode, new String(bytes, StandardCharsets.UTF_8));
}

// tagLLMSpanResponse also emits child spans for any server-side tool calls (web
// search, etc.) nested under the LLM span while it is still live.
tagSpanFromBuffer(tracer, span, bytes, timeToFirstTokenNanos.get());
Expand DownExpand Up@@ -387,6 +405,29 @@ private static void tagSpanFromBuffer(
}
}

/**
* Adapts the anthropic sdk's {@code Headers} to the vendor-neutral shape {@link
* InstrumentationSemConv} consumes. Returns null on failure so a header-shape change can never
* take down the response tagging that follows it.
*/
@Nullable
private static Map<String, List<String>> headersAsMap(
@Nullable com.anthropic.core.http.Headers headers) {
if (headers == null) {
return null;
}
try {
var map = new HashMap<String, List<String>>();
for (String name : headers.names()) {
map.put(name, headers.values(name));
}
return map;
} catch (Exception e) {
log.debug("could not read response headers", e);
return null;
}
}

private static String firstNonEmptyLine(byte[] bytes) {
int start = 0;
for (int i = 0; i <= bytes.length; i++) {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -562,4 +562,76 @@ void testWrappedClientObjectContract() {
wrapped.toString().contains("ContextCapturingProxy"),
"toString should identify the proxy, got: " + wrapped);
}

/**
* Anthropic returns its correlation ID as {@code request-id} (no {@code x-} prefix, unlike
* OpenAI) and its object ID as {@code msg_*}. Both must land on the span for streaming and
* non-streaming alike — the header comes off the HTTP response, the object ID out of the
* reassembled body, so the two travel independent paths.
*/
@Test
@SneakyThrows
void testCorrelationIdsCaptured() {
AnthropicClient anthropicClient =
AnthropicOkHttpClient.builder()
.baseUrl(testHarness.anthropicBaseUrl())
.apiKey(testHarness.anthropicApiKey())
.build();

var request =
MessageCreateParams.builder()
.model(Model.of(TEST_MODEL))
.system("You are a helpful assistant")
.addUserMessage("What is the capital of France?")
.maxTokens(50)
.temperature(0.0)
.build();

anthropicClient.messages().create(request);
assertAnthropicIdsCaptured(testHarness.awaitExportedSpans().get(0));
}

@Test
@SneakyThrows
void testCorrelationIdsCapturedStreaming() {
AnthropicClient anthropicClient =
AnthropicOkHttpClient.builder()
.baseUrl(testHarness.anthropicBaseUrl())
.apiKey(testHarness.anthropicApiKey())
.build();

var request =
MessageCreateParams.builder()
.model(Model.of(TEST_MODEL))
.system("You are a helpful assistant")
.addUserMessage("What is the capital of France?")
.maxTokens(50)
.temperature(0.0)
.build();

try (var stream = anthropicClient.messages().createStreaming(request)) {
stream.stream().forEach(event -> {});
}
assertAnthropicIdsCaptured(testHarness.awaitExportedSpans().get(0));
}

/**
* Asserts presence only for the header: its value is an opaque vendor string, so pinning its
* shape would encode an assumption the provider never made.
*/
private static void assertAnthropicIdsCaptured(io.opentelemetry.sdk.trace.data.SpanData span) {
var attributes = span.getAttributes();

String requestId = attributes.get(AttributeKey.stringKey("request-id"));
assertNotNull(requestId, "request-id header must be captured");
assertFalse(requestId.isBlank(), "request-id must not be blank");

String responseId = attributes.get(AttributeKey.stringKey("response_id"));
assertNotNull(responseId, "response_id must be captured from the response body");
assertTrue(responseId.startsWith("msg_"), "unexpected response_id: " + responseId);

assertNull(
attributes.get(AttributeKey.stringKey("x-request-id")),
"OpenAI's header name must not appear on an Anthropic span");
}
}
Original file line numberDiff line numberDiff line change
Expand Up@@ -20,6 +20,9 @@
import io.opentelemetry.context.Context;
import java.io.*;
import java.nio.charset.StandardCharsets;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.atomic.AtomicBoolean;
import java.util.concurrent.atomic.AtomicLong;
Expand DownExpand Up@@ -68,7 +71,7 @@ private static ExtractedRequest extractCallerContext(HttpRequest request) {
Context context = contextFromTraceparent(values.get(0));
HttpRequest stripped =
request.toBuilder()
.replaceHeaders(ContextCapturingProxy.CONTEXT_HEADER, java.util.List.of())
.replaceHeaders(ContextCapturingProxy.CONTEXT_HEADER, List.of())
.build();
return new ExtractedRequest(stripped, context);
}
Expand DownExpand Up@@ -259,6 +262,28 @@ private static void tagSpanFromBuffer(
}
}

/**
* Adapts openai-java's {@link Headers} to the vendor-neutral shape {@link
* InstrumentationSemConv} consumes. Returns null on failure so a header-shape change can never
* take down the response tagging that follows it.
*/
@Nullable
private static Map<String, List<String>> headersAsMap(@Nullable Headers headers) {
if (headers == null) {
return null;
}
try {
var map = new HashMap<String, List<String>>();
for (String name : headers.names()) {
map.put(name, headers.values(name));
}
return map;
} catch (Exception e) {
log.debug("could not read response headers", e);
return null;
}
}

private static String firstNonEmptyLine(byte[] bytes) {
int start = 0;
for (int i = 0; i <= bytes.length; i++) {
Expand DownExpand Up@@ -368,12 +393,27 @@ private void onFirstByte() {
/** Called back by {@link TeeInputStream} when the stream is fully drained or closed. */
private void onStreamClosed() {
try {
// Scooped first and unconditionally: tagSpanFromBuffer bails on an empty body,
// and a failed request is both the likeliest source of one and the case where
// the vendor's request id is most worth having.
InstrumentationSemConv.tagLLMSpanIdHeaders(span, headersAsMap(delegate.headers()));

// Synchronize on teeBuffer to ensure any write() that was in-flight on a
// concurrent read thread has fully completed before we snapshot the bytes.
byte[] bytes;
synchronized (teeBuffer) {
bytes = teeBuffer.toByteArray();
}

// Recorded before tagging: openai-java raises above this layer, so the error
// status is ours alone to set, and losing it to a body-parsing problem is worse
// than losing the parsed output.
int statusCode = delegate.statusCode();
if (statusCode >= 400) {
InstrumentationSemConv.tagLLMSpanHttpError(
span, statusCode, new String(bytes, StandardCharsets.UTF_8));
}

// tagLLMSpanResponse also emits child spans for any server-side tool calls (web
// search, etc.) nested under the LLM span while it is still live. No-op for Chat
// Completions responses (no `output` array).
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -24,6 +24,7 @@
import dev.braintrust.TestHarness;
import dev.braintrust.instrumentation.Instrumenter;
import io.opentelemetry.api.common.AttributeKey;
import io.opentelemetry.api.trace.StatusCode;
import io.opentelemetry.sdk.trace.data.SpanData;
import java.util.List;
import java.util.Map;
Expand DownExpand Up@@ -649,5 +650,65 @@ private static void assertValidOpenAISpan(SpanData span, boolean isStreaming) {
assertNotNull(
attributes.get(AttributeKey.stringKey("braintrust.output_json")),
"output must be set");
assertOpenAIIdsCaptured(span);
}

/**
* Both correlation IDs OpenAI hands back. Deliberately asserts only presence and the object-ID
* prefix: {@code x-request-id} is opaque, and OpenAI returns both {@code req_*} and bare UUIDs
* for it, so pinning its shape would be wrong.
*/
private static void assertOpenAIIdsCaptured(SpanData span) {
var attributes = span.getAttributes();

String requestId = attributes.get(AttributeKey.stringKey("x-request-id"));
assertNotNull(requestId, "x-request-id header must be captured");
assertFalse(requestId.isBlank(), "x-request-id must not be blank");

String responseId = attributes.get(AttributeKey.stringKey("response_id"));
assertNotNull(responseId, "response_id must be captured from the response body");
assertTrue(
responseId.startsWith("resp_") || responseId.startsWith("chatcmpl-"),
"unexpected response_id: " + responseId);
}

/**
* A failed call is the case where the vendor's request id matters most, and the only one where
* it is the *sole* ID available: an error body carries no object id of its own. openai-java
* raises its exception above the HTTP layer we instrument, so the error status on the span is
* ours alone to set.
*/
@Test
@SneakyThrows
void testHttpErrorTagsSpan() {
OpenAIClient openAIClient =
OpenAIOkHttpClient.builder()
.baseUrl(testHarness.openAiBaseUrl())
.apiKey(testHarness.openAiApiKey())
.build();

var request =
ChatCompletionCreateParams.builder()
.model("gpt-4o-mini-nonexistent-model")
.addUserMessage("What is the capital of France?")
.build();

assertThrows(Exception.class, () -> openAIClient.chat().completions().create(request));

var spans = testHarness.awaitExportedSpans();
assertEquals(1, spans.size());
var span = spans.get(0);

assertEquals(
StatusCode.ERROR,
span.getStatus().getStatusCode(),
"a non-2xx response must mark the span failed");

var attributes = span.getAttributes();
String requestId = attributes.get(AttributeKey.stringKey("x-request-id"));
assertNotNull(requestId, "x-request-id must still be captured on a failed call");
assertNull(
attributes.get(AttributeKey.stringKey("response_id")),
"an error body has no object id to capture");
}
}
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
Expand Up@@ -24,6 +24,9 @@
import java.io.InputStreamReader;
import java.io.OutputStream;
import java.nio.charset.StandardCharsets;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.atomic.AtomicBoolean;
import java.util.concurrent.atomic.AtomicLong;
Expand DownExpand Up@@ -260,10 +263,25 @@ private void onFirstByte() {

private void onStreamClosed() {
try {
// Scooped first and unconditionally: tagSpanFromBuffer bails on an empty body,
// and a failed request is both the likeliest source of one and the case where
// the vendor's request id is most worth having.
InstrumentationSemConv.tagLLMSpanIdHeaders(span, headersAsMap(delegate.headers()));

byte[] bytes;
synchronized (teeBuffer) {
bytes = teeBuffer.toByteArray();
}

// Recorded before tagging: the anthropic sdk raises above this layer, so the
// error status is ours alone to set, and losing it to a body-parsing problem is
// worse than losing the parsed output.
int statusCode = delegate.statusCode();
if (statusCode >= 400) {
InstrumentationSemConv.tagLLMSpanHttpError(
span, statusCode, new String(bytes, StandardCharsets.UTF_8));
}

// tagLLMSpanResponse also emits child spans for any server-side tool calls (web
// search, etc.) nested under the LLM span while it is still live.
tagSpanFromBuffer(tracer, span, bytes, timeToFirstTokenNanos.get());
Expand DownExpand Up@@ -387,6 +405,29 @@ private static void tagSpanFromBuffer(
}
}

/**
* Adapts the anthropic sdk's {@code Headers} to the vendor-neutral shape {@link
* InstrumentationSemConv} consumes. Returns null on failure so a header-shape change can never
* take down the response tagging that follows it.
*/
@Nullable
private static Map<String, List<String>> headersAsMap(
@Nullable com.anthropic.core.http.Headers headers) {
if (headers == null) {
return null;
}
try {
var map = new HashMap<String, List<String>>();
for (String name : headers.names()) {
map.put(name, headers.values(name));
}
return map;
} catch (Exception e) {
log.debug("could not read response headers", e);
return null;
}
}

private static String firstNonEmptyLine(byte[] bytes) {
int start = 0;
for (int i = 0; i <= bytes.length; i++) {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -562,4 +562,76 @@ void testWrappedClientObjectContract() {
wrapped.toString().contains("ContextCapturingProxy"),
"toString should identify the proxy, got: " + wrapped);
}

/**
* Anthropic returns its correlation ID as {@code request-id} (no {@code x-} prefix, unlike
* OpenAI) and its object ID as {@code msg_*}. Both must land on the span for streaming and
* non-streaming alike — the header comes off the HTTP response, the object ID out of the
* reassembled body, so the two travel independent paths.
*/
@Test
@SneakyThrows
void testCorrelationIdsCaptured() {
AnthropicClient anthropicClient =
AnthropicOkHttpClient.builder()
.baseUrl(testHarness.anthropicBaseUrl())
.apiKey(testHarness.anthropicApiKey())
.build();

var request =
MessageCreateParams.builder()
.model(Model.of(TEST_MODEL))
.system("You are a helpful assistant")
.addUserMessage("What is the capital of France?")
.maxTokens(50)
.temperature(0.0)
.build();

anthropicClient.messages().create(request);
assertAnthropicIdsCaptured(testHarness.awaitExportedSpans().get(0));
}

@Test
@SneakyThrows
void testCorrelationIdsCapturedStreaming() {
AnthropicClient anthropicClient =
AnthropicOkHttpClient.builder()
.baseUrl(testHarness.anthropicBaseUrl())
.apiKey(testHarness.anthropicApiKey())
.build();

var request =
MessageCreateParams.builder()
.model(Model.of(TEST_MODEL))
.system("You are a helpful assistant")
.addUserMessage("What is the capital of France?")
.maxTokens(50)
.temperature(0.0)
.build();

try (var stream = anthropicClient.messages().createStreaming(request)) {
stream.stream().forEach(event -> {});
}
assertAnthropicIdsCaptured(testHarness.awaitExportedSpans().get(0));
}

/**
* Asserts presence only for the header: its value is an opaque vendor string, so pinning its
* shape would encode an assumption the provider never made.
*/
private static void assertAnthropicIdsCaptured(io.opentelemetry.sdk.trace.data.SpanData span) {
var attributes = span.getAttributes();

String requestId = attributes.get(AttributeKey.stringKey("request-id"));
assertNotNull(requestId, "request-id header must be captured");
assertFalse(requestId.isBlank(), "request-id must not be blank");

String responseId = attributes.get(AttributeKey.stringKey("response_id"));
assertNotNull(responseId, "response_id must be captured from the response body");
assertTrue(responseId.startsWith("msg_"), "unexpected response_id: " + responseId);

assertNull(
attributes.get(AttributeKey.stringKey("x-request-id")),
"OpenAI's header name must not appear on an Anthropic span");
}
}
Original file line numberDiff line numberDiff line change
Expand Up@@ -20,6 +20,9 @@
import io.opentelemetry.context.Context;
import java.io.*;
import java.nio.charset.StandardCharsets;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.atomic.AtomicBoolean;
import java.util.concurrent.atomic.AtomicLong;
Expand DownExpand Up@@ -68,7 +71,7 @@ private static ExtractedRequest extractCallerContext(HttpRequest request) {
Context context = contextFromTraceparent(values.get(0));
HttpRequest stripped =
request.toBuilder()
.replaceHeaders(ContextCapturingProxy.CONTEXT_HEADER, java.util.List.of())
.replaceHeaders(ContextCapturingProxy.CONTEXT_HEADER, List.of())
.build();
return new ExtractedRequest(stripped, context);
}
Expand DownExpand Up@@ -259,6 +262,28 @@ private static void tagSpanFromBuffer(
}
}

/**
* Adapts openai-java's {@link Headers} to the vendor-neutral shape {@link
* InstrumentationSemConv} consumes. Returns null on failure so a header-shape change can never
* take down the response tagging that follows it.
*/
@Nullable
private static Map<String, List<String>> headersAsMap(@Nullable Headers headers) {
if (headers == null) {
return null;
}
try {
var map = new HashMap<String, List<String>>();
for (String name : headers.names()) {
map.put(name, headers.values(name));
}
return map;
} catch (Exception e) {
log.debug("could not read response headers", e);
return null;
}
}

private static String firstNonEmptyLine(byte[] bytes) {
int start = 0;
for (int i = 0; i <= bytes.length; i++) {
Expand DownExpand Up@@ -368,12 +393,27 @@ private void onFirstByte() {
/** Called back by {@link TeeInputStream} when the stream is fully drained or closed. */
private void onStreamClosed() {
try {
// Scooped first and unconditionally: tagSpanFromBuffer bails on an empty body,
// and a failed request is both the likeliest source of one and the case where
// the vendor's request id is most worth having.
InstrumentationSemConv.tagLLMSpanIdHeaders(span, headersAsMap(delegate.headers()));

// Synchronize on teeBuffer to ensure any write() that was in-flight on a
// concurrent read thread has fully completed before we snapshot the bytes.
byte[] bytes;
synchronized (teeBuffer) {
bytes = teeBuffer.toByteArray();
}

// Recorded before tagging: openai-java raises above this layer, so the error
// status is ours alone to set, and losing it to a body-parsing problem is worse
// than losing the parsed output.
int statusCode = delegate.statusCode();
if (statusCode >= 400) {
InstrumentationSemConv.tagLLMSpanHttpError(
span, statusCode, new String(bytes, StandardCharsets.UTF_8));
}

// tagLLMSpanResponse also emits child spans for any server-side tool calls (web
// search, etc.) nested under the LLM span while it is still live. No-op for Chat
// Completions responses (no `output` array).
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -24,6 +24,7 @@
import dev.braintrust.TestHarness;
import dev.braintrust.instrumentation.Instrumenter;
import io.opentelemetry.api.common.AttributeKey;
import io.opentelemetry.api.trace.StatusCode;
import io.opentelemetry.sdk.trace.data.SpanData;
import java.util.List;
import java.util.Map;
Expand DownExpand Up@@ -649,5 +650,65 @@ private static void assertValidOpenAISpan(SpanData span, boolean isStreaming) {
assertNotNull(
attributes.get(AttributeKey.stringKey("braintrust.output_json")),
"output must be set");
assertOpenAIIdsCaptured(span);
}

/**
* Both correlation IDs OpenAI hands back. Deliberately asserts only presence and the object-ID
* prefix: {@code x-request-id} is opaque, and OpenAI returns both {@code req_*} and bare UUIDs
* for it, so pinning its shape would be wrong.
*/
private static void assertOpenAIIdsCaptured(SpanData span) {
var attributes = span.getAttributes();

String requestId = attributes.get(AttributeKey.stringKey("x-request-id"));
assertNotNull(requestId, "x-request-id header must be captured");
assertFalse(requestId.isBlank(), "x-request-id must not be blank");

String responseId = attributes.get(AttributeKey.stringKey("response_id"));
assertNotNull(responseId, "response_id must be captured from the response body");
assertTrue(
responseId.startsWith("resp_") || responseId.startsWith("chatcmpl-"),
"unexpected response_id: " + responseId);
}

/**
* A failed call is the case where the vendor's request id matters most, and the only one where
* it is the *sole* ID available: an error body carries no object id of its own. openai-java
* raises its exception above the HTTP layer we instrument, so the error status on the span is
* ours alone to set.
*/
@Test
@SneakyThrows
void testHttpErrorTagsSpan() {
OpenAIClient openAIClient =
OpenAIOkHttpClient.builder()
.baseUrl(testHarness.openAiBaseUrl())
.apiKey(testHarness.openAiApiKey())
.build();

var request =
ChatCompletionCreateParams.builder()
.model("gpt-4o-mini-nonexistent-model")
.addUserMessage("What is the capital of France?")
.build();

assertThrows(Exception.class, () -> openAIClient.chat().completions().create(request));

var spans = testHarness.awaitExportedSpans();
assertEquals(1, spans.size());
var span = spans.get(0);

assertEquals(
StatusCode.ERROR,
span.getStatus().getStatusCode(),
"a non-2xx response must mark the span failed");

var attributes = span.getAttributes();
String requestId = attributes.get(AttributeKey.stringKey("x-request-id"));
assertNotNull(requestId, "x-request-id must still be captured on a failed call");
assertNull(
attributes.get(AttributeKey.stringKey("response_id")),
"an error body has no object id to capture");
}
}
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
Expand Up@@ -24,6 +24,9 @@
import java.io.InputStreamReader;
import java.io.OutputStream;
import java.nio.charset.StandardCharsets;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.atomic.AtomicBoolean;
import java.util.concurrent.atomic.AtomicLong;
Expand DownExpand Up@@ -260,10 +263,25 @@ private void onFirstByte() {

private void onStreamClosed() {
try {
// Scooped first and unconditionally: tagSpanFromBuffer bails on an empty body,
// and a failed request is both the likeliest source of one and the case where
// the vendor's request id is most worth having.
InstrumentationSemConv.tagLLMSpanIdHeaders(span, headersAsMap(delegate.headers()));

byte[] bytes;
synchronized (teeBuffer) {
bytes = teeBuffer.toByteArray();
}

// Recorded before tagging: the anthropic sdk raises above this layer, so the
// error status is ours alone to set, and losing it to a body-parsing problem is
// worse than losing the parsed output.
int statusCode = delegate.statusCode();
if (statusCode >= 400) {
InstrumentationSemConv.tagLLMSpanHttpError(
span, statusCode, new String(bytes, StandardCharsets.UTF_8));
}

// tagLLMSpanResponse also emits child spans for any server-side tool calls (web
// search, etc.) nested under the LLM span while it is still live.
tagSpanFromBuffer(tracer, span, bytes, timeToFirstTokenNanos.get());
Expand DownExpand Up@@ -387,6 +405,29 @@ private static void tagSpanFromBuffer(
}
}

/**
* Adapts the anthropic sdk's {@code Headers} to the vendor-neutral shape {@link
* InstrumentationSemConv} consumes. Returns null on failure so a header-shape change can never
* take down the response tagging that follows it.
*/
@Nullable
private static Map<String, List<String>> headersAsMap(
@Nullable com.anthropic.core.http.Headers headers) {
if (headers == null) {
return null;
}
try {
var map = new HashMap<String, List<String>>();
for (String name : headers.names()) {
map.put(name, headers.values(name));
}
return map;
} catch (Exception e) {
log.debug("could not read response headers", e);
return null;
}
}

private static String firstNonEmptyLine(byte[] bytes) {
int start = 0;
for (int i = 0; i <= bytes.length; i++) {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -562,4 +562,76 @@ void testWrappedClientObjectContract() {
wrapped.toString().contains("ContextCapturingProxy"),
"toString should identify the proxy, got: " + wrapped);
}

/**
* Anthropic returns its correlation ID as {@code request-id} (no {@code x-} prefix, unlike
* OpenAI) and its object ID as {@code msg_*}. Both must land on the span for streaming and
* non-streaming alike — the header comes off the HTTP response, the object ID out of the
* reassembled body, so the two travel independent paths.
*/
@Test
@SneakyThrows
void testCorrelationIdsCaptured() {
AnthropicClient anthropicClient =
AnthropicOkHttpClient.builder()
.baseUrl(testHarness.anthropicBaseUrl())
.apiKey(testHarness.anthropicApiKey())
.build();

var request =
MessageCreateParams.builder()
.model(Model.of(TEST_MODEL))
.system("You are a helpful assistant")
.addUserMessage("What is the capital of France?")
.maxTokens(50)
.temperature(0.0)
.build();

anthropicClient.messages().create(request);
assertAnthropicIdsCaptured(testHarness.awaitExportedSpans().get(0));
}

@Test
@SneakyThrows
void testCorrelationIdsCapturedStreaming() {
AnthropicClient anthropicClient =
AnthropicOkHttpClient.builder()
.baseUrl(testHarness.anthropicBaseUrl())
.apiKey(testHarness.anthropicApiKey())
.build();

var request =
MessageCreateParams.builder()
.model(Model.of(TEST_MODEL))
.system("You are a helpful assistant")
.addUserMessage("What is the capital of France?")
.maxTokens(50)
.temperature(0.0)
.build();

try (var stream = anthropicClient.messages().createStreaming(request)) {
stream.stream().forEach(event -> {});
}
assertAnthropicIdsCaptured(testHarness.awaitExportedSpans().get(0));
}

/**
* Asserts presence only for the header: its value is an opaque vendor string, so pinning its
* shape would encode an assumption the provider never made.
*/
private static void assertAnthropicIdsCaptured(io.opentelemetry.sdk.trace.data.SpanData span) {
var attributes = span.getAttributes();

String requestId = attributes.get(AttributeKey.stringKey("request-id"));
assertNotNull(requestId, "request-id header must be captured");
assertFalse(requestId.isBlank(), "request-id must not be blank");

String responseId = attributes.get(AttributeKey.stringKey("response_id"));
assertNotNull(responseId, "response_id must be captured from the response body");
assertTrue(responseId.startsWith("msg_"), "unexpected response_id: " + responseId);

assertNull(
attributes.get(AttributeKey.stringKey("x-request-id")),
"OpenAI's header name must not appear on an Anthropic span");
}
}
Original file line numberDiff line numberDiff line change
Expand Up@@ -20,6 +20,9 @@
import io.opentelemetry.context.Context;
import java.io.*;
import java.nio.charset.StandardCharsets;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.atomic.AtomicBoolean;
import java.util.concurrent.atomic.AtomicLong;
Expand DownExpand Up@@ -68,7 +71,7 @@ private static ExtractedRequest extractCallerContext(HttpRequest request) {
Context context = contextFromTraceparent(values.get(0));
HttpRequest stripped =
request.toBuilder()
.replaceHeaders(ContextCapturingProxy.CONTEXT_HEADER, java.util.List.of())
.replaceHeaders(ContextCapturingProxy.CONTEXT_HEADER, List.of())
.build();
return new ExtractedRequest(stripped, context);
}
Expand DownExpand Up@@ -259,6 +262,28 @@ private static void tagSpanFromBuffer(
}
}

/**
* Adapts openai-java's {@link Headers} to the vendor-neutral shape {@link
* InstrumentationSemConv} consumes. Returns null on failure so a header-shape change can never
* take down the response tagging that follows it.
*/
@Nullable
private static Map<String, List<String>> headersAsMap(@Nullable Headers headers) {
if (headers == null) {
return null;
}
try {
var map = new HashMap<String, List<String>>();
for (String name : headers.names()) {
map.put(name, headers.values(name));
}
return map;
} catch (Exception e) {
log.debug("could not read response headers", e);
return null;
}
}

private static String firstNonEmptyLine(byte[] bytes) {
int start = 0;
for (int i = 0; i <= bytes.length; i++) {
Expand DownExpand Up@@ -368,12 +393,27 @@ private void onFirstByte() {
/** Called back by {@link TeeInputStream} when the stream is fully drained or closed. */
private void onStreamClosed() {
try {
// Scooped first and unconditionally: tagSpanFromBuffer bails on an empty body,
// and a failed request is both the likeliest source of one and the case where
// the vendor's request id is most worth having.
InstrumentationSemConv.tagLLMSpanIdHeaders(span, headersAsMap(delegate.headers()));

// Synchronize on teeBuffer to ensure any write() that was in-flight on a
// concurrent read thread has fully completed before we snapshot the bytes.
byte[] bytes;
synchronized (teeBuffer) {
bytes = teeBuffer.toByteArray();
}

// Recorded before tagging: openai-java raises above this layer, so the error
// status is ours alone to set, and losing it to a body-parsing problem is worse
// than losing the parsed output.
int statusCode = delegate.statusCode();
if (statusCode >= 400) {
InstrumentationSemConv.tagLLMSpanHttpError(
span, statusCode, new String(bytes, StandardCharsets.UTF_8));
}

// tagLLMSpanResponse also emits child spans for any server-side tool calls (web
// search, etc.) nested under the LLM span while it is still live. No-op for Chat
// Completions responses (no `output` array).
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -24,6 +24,7 @@
import dev.braintrust.TestHarness;
import dev.braintrust.instrumentation.Instrumenter;
import io.opentelemetry.api.common.AttributeKey;
import io.opentelemetry.api.trace.StatusCode;
import io.opentelemetry.sdk.trace.data.SpanData;
import java.util.List;
import java.util.Map;
Expand DownExpand Up@@ -649,5 +650,65 @@ private static void assertValidOpenAISpan(SpanData span, boolean isStreaming) {
assertNotNull(
attributes.get(AttributeKey.stringKey("braintrust.output_json")),
"output must be set");
assertOpenAIIdsCaptured(span);
}

/**
* Both correlation IDs OpenAI hands back. Deliberately asserts only presence and the object-ID
* prefix: {@code x-request-id} is opaque, and OpenAI returns both {@code req_*} and bare UUIDs
* for it, so pinning its shape would be wrong.
*/
private static void assertOpenAIIdsCaptured(SpanData span) {
var attributes = span.getAttributes();

String requestId = attributes.get(AttributeKey.stringKey("x-request-id"));
assertNotNull(requestId, "x-request-id header must be captured");
assertFalse(requestId.isBlank(), "x-request-id must not be blank");

String responseId = attributes.get(AttributeKey.stringKey("response_id"));
assertNotNull(responseId, "response_id must be captured from the response body");
assertTrue(
responseId.startsWith("resp_") || responseId.startsWith("chatcmpl-"),
"unexpected response_id: " + responseId);
}

/**
* A failed call is the case where the vendor's request id matters most, and the only one where
* it is the *sole* ID available: an error body carries no object id of its own. openai-java
* raises its exception above the HTTP layer we instrument, so the error status on the span is
* ours alone to set.
*/
@Test
@SneakyThrows
void testHttpErrorTagsSpan() {
OpenAIClient openAIClient =
OpenAIOkHttpClient.builder()
.baseUrl(testHarness.openAiBaseUrl())
.apiKey(testHarness.openAiApiKey())
.build();

var request =
ChatCompletionCreateParams.builder()
.model("gpt-4o-mini-nonexistent-model")
.addUserMessage("What is the capital of France?")
.build();

assertThrows(Exception.class, () -> openAIClient.chat().completions().create(request));

var spans = testHarness.awaitExportedSpans();
assertEquals(1, spans.size());
var span = spans.get(0);

assertEquals(
StatusCode.ERROR,
span.getStatus().getStatusCode(),
"a non-2xx response must mark the span failed");

var attributes = span.getAttributes();
String requestId = attributes.get(AttributeKey.stringKey("x-request-id"));
assertNotNull(requestId, "x-request-id must still be captured on a failed call");
assertNull(
attributes.get(AttributeKey.stringKey("response_id")),
"an error body has no object id to capture");
}
}
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
Expand Up@@ -24,6 +24,9 @@
import java.io.InputStreamReader;
import java.io.OutputStream;
import java.nio.charset.StandardCharsets;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.atomic.AtomicBoolean;
import java.util.concurrent.atomic.AtomicLong;
Expand DownExpand Up@@ -260,10 +263,25 @@ private void onFirstByte() {

private void onStreamClosed() {
try {
// Scooped first and unconditionally: tagSpanFromBuffer bails on an empty body,
// and a failed request is both the likeliest source of one and the case where
// the vendor's request id is most worth having.
InstrumentationSemConv.tagLLMSpanIdHeaders(span, headersAsMap(delegate.headers()));

byte[] bytes;
synchronized (teeBuffer) {
bytes = teeBuffer.toByteArray();
}

// Recorded before tagging: the anthropic sdk raises above this layer, so the
// error status is ours alone to set, and losing it to a body-parsing problem is
// worse than losing the parsed output.
int statusCode = delegate.statusCode();
if (statusCode >= 400) {
InstrumentationSemConv.tagLLMSpanHttpError(
span, statusCode, new String(bytes, StandardCharsets.UTF_8));
}

// tagLLMSpanResponse also emits child spans for any server-side tool calls (web
// search, etc.) nested under the LLM span while it is still live.
tagSpanFromBuffer(tracer, span, bytes, timeToFirstTokenNanos.get());
Expand DownExpand Up@@ -387,6 +405,29 @@ private static void tagSpanFromBuffer(
}
}

/**
* Adapts the anthropic sdk's {@code Headers} to the vendor-neutral shape {@link
* InstrumentationSemConv} consumes. Returns null on failure so a header-shape change can never
* take down the response tagging that follows it.
*/
@Nullable
private static Map<String, List<String>> headersAsMap(
@Nullable com.anthropic.core.http.Headers headers) {
if (headers == null) {
return null;
}
try {
var map = new HashMap<String, List<String>>();
for (String name : headers.names()) {
map.put(name, headers.values(name));
}
return map;
} catch (Exception e) {
log.debug("could not read response headers", e);
return null;
}
}

private static String firstNonEmptyLine(byte[] bytes) {
int start = 0;
for (int i = 0; i <= bytes.length; i++) {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -562,4 +562,76 @@ void testWrappedClientObjectContract() {
wrapped.toString().contains("ContextCapturingProxy"),
"toString should identify the proxy, got: " + wrapped);
}

/**
* Anthropic returns its correlation ID as {@code request-id} (no {@code x-} prefix, unlike
* OpenAI) and its object ID as {@code msg_*}. Both must land on the span for streaming and
* non-streaming alike — the header comes off the HTTP response, the object ID out of the
* reassembled body, so the two travel independent paths.
*/
@Test
@SneakyThrows
void testCorrelationIdsCaptured() {
AnthropicClient anthropicClient =
AnthropicOkHttpClient.builder()
.baseUrl(testHarness.anthropicBaseUrl())
.apiKey(testHarness.anthropicApiKey())
.build();

var request =
MessageCreateParams.builder()
.model(Model.of(TEST_MODEL))
.system("You are a helpful assistant")
.addUserMessage("What is the capital of France?")
.maxTokens(50)
.temperature(0.0)
.build();

anthropicClient.messages().create(request);
assertAnthropicIdsCaptured(testHarness.awaitExportedSpans().get(0));
}

@Test
@SneakyThrows
void testCorrelationIdsCapturedStreaming() {
AnthropicClient anthropicClient =
AnthropicOkHttpClient.builder()
.baseUrl(testHarness.anthropicBaseUrl())
.apiKey(testHarness.anthropicApiKey())
.build();

var request =
MessageCreateParams.builder()
.model(Model.of(TEST_MODEL))
.system("You are a helpful assistant")
.addUserMessage("What is the capital of France?")
.maxTokens(50)
.temperature(0.0)
.build();

try (var stream = anthropicClient.messages().createStreaming(request)) {
stream.stream().forEach(event -> {});
}
assertAnthropicIdsCaptured(testHarness.awaitExportedSpans().get(0));
}

/**
* Asserts presence only for the header: its value is an opaque vendor string, so pinning its
* shape would encode an assumption the provider never made.
*/
private static void assertAnthropicIdsCaptured(io.opentelemetry.sdk.trace.data.SpanData span) {
var attributes = span.getAttributes();

String requestId = attributes.get(AttributeKey.stringKey("request-id"));
assertNotNull(requestId, "request-id header must be captured");
assertFalse(requestId.isBlank(), "request-id must not be blank");

String responseId = attributes.get(AttributeKey.stringKey("response_id"));
assertNotNull(responseId, "response_id must be captured from the response body");
assertTrue(responseId.startsWith("msg_"), "unexpected response_id: " + responseId);

assertNull(
attributes.get(AttributeKey.stringKey("x-request-id")),
"OpenAI's header name must not appear on an Anthropic span");
}
}
Original file line numberDiff line numberDiff line change
Expand Up@@ -20,6 +20,9 @@
import io.opentelemetry.context.Context;
import java.io.*;
import java.nio.charset.StandardCharsets;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.atomic.AtomicBoolean;
import java.util.concurrent.atomic.AtomicLong;
Expand DownExpand Up@@ -68,7 +71,7 @@ private static ExtractedRequest extractCallerContext(HttpRequest request) {
Context context = contextFromTraceparent(values.get(0));
HttpRequest stripped =
request.toBuilder()
.replaceHeaders(ContextCapturingProxy.CONTEXT_HEADER, java.util.List.of())
.replaceHeaders(ContextCapturingProxy.CONTEXT_HEADER, List.of())
.build();
return new ExtractedRequest(stripped, context);
}
Expand DownExpand Up@@ -259,6 +262,28 @@ private static void tagSpanFromBuffer(
}
}

/**
* Adapts openai-java's {@link Headers} to the vendor-neutral shape {@link
* InstrumentationSemConv} consumes. Returns null on failure so a header-shape change can never
* take down the response tagging that follows it.
*/
@Nullable
private static Map<String, List<String>> headersAsMap(@Nullable Headers headers) {
if (headers == null) {
return null;
}
try {
var map = new HashMap<String, List<String>>();
for (String name : headers.names()) {
map.put(name, headers.values(name));
}
return map;
} catch (Exception e) {
log.debug("could not read response headers", e);
return null;
}
}

private static String firstNonEmptyLine(byte[] bytes) {
int start = 0;
for (int i = 0; i <= bytes.length; i++) {
Expand DownExpand Up@@ -368,12 +393,27 @@ private void onFirstByte() {
/** Called back by {@link TeeInputStream} when the stream is fully drained or closed. */
private void onStreamClosed() {
try {
// Scooped first and unconditionally: tagSpanFromBuffer bails on an empty body,
// and a failed request is both the likeliest source of one and the case where
// the vendor's request id is most worth having.
InstrumentationSemConv.tagLLMSpanIdHeaders(span, headersAsMap(delegate.headers()));

// Synchronize on teeBuffer to ensure any write() that was in-flight on a
// concurrent read thread has fully completed before we snapshot the bytes.
byte[] bytes;
synchronized (teeBuffer) {
bytes = teeBuffer.toByteArray();
}

// Recorded before tagging: openai-java raises above this layer, so the error
// status is ours alone to set, and losing it to a body-parsing problem is worse
// than losing the parsed output.
int statusCode = delegate.statusCode();
if (statusCode >= 400) {
InstrumentationSemConv.tagLLMSpanHttpError(
span, statusCode, new String(bytes, StandardCharsets.UTF_8));
}

// tagLLMSpanResponse also emits child spans for any server-side tool calls (web
// search, etc.) nested under the LLM span while it is still live. No-op for Chat
// Completions responses (no `output` array).
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -24,6 +24,7 @@
import dev.braintrust.TestHarness;
import dev.braintrust.instrumentation.Instrumenter;
import io.opentelemetry.api.common.AttributeKey;
import io.opentelemetry.api.trace.StatusCode;
import io.opentelemetry.sdk.trace.data.SpanData;
import java.util.List;
import java.util.Map;
Expand DownExpand Up@@ -649,5 +650,65 @@ private static void assertValidOpenAISpan(SpanData span, boolean isStreaming) {
assertNotNull(
attributes.get(AttributeKey.stringKey("braintrust.output_json")),
"output must be set");
assertOpenAIIdsCaptured(span);
}

/**
* Both correlation IDs OpenAI hands back. Deliberately asserts only presence and the object-ID
* prefix: {@code x-request-id} is opaque, and OpenAI returns both {@code req_*} and bare UUIDs
* for it, so pinning its shape would be wrong.
*/
private static void assertOpenAIIdsCaptured(SpanData span) {
var attributes = span.getAttributes();

String requestId = attributes.get(AttributeKey.stringKey("x-request-id"));
assertNotNull(requestId, "x-request-id header must be captured");
assertFalse(requestId.isBlank(), "x-request-id must not be blank");

String responseId = attributes.get(AttributeKey.stringKey("response_id"));
assertNotNull(responseId, "response_id must be captured from the response body");
assertTrue(
responseId.startsWith("resp_") || responseId.startsWith("chatcmpl-"),
"unexpected response_id: " + responseId);
}

/**
* A failed call is the case where the vendor's request id matters most, and the only one where
* it is the *sole* ID available: an error body carries no object id of its own. openai-java
* raises its exception above the HTTP layer we instrument, so the error status on the span is
* ours alone to set.
*/
@Test
@SneakyThrows
void testHttpErrorTagsSpan() {
OpenAIClient openAIClient =
OpenAIOkHttpClient.builder()
.baseUrl(testHarness.openAiBaseUrl())
.apiKey(testHarness.openAiApiKey())
.build();

var request =
ChatCompletionCreateParams.builder()
.model("gpt-4o-mini-nonexistent-model")
.addUserMessage("What is the capital of France?")
.build();

assertThrows(Exception.class, () -> openAIClient.chat().completions().create(request));

var spans = testHarness.awaitExportedSpans();
assertEquals(1, spans.size());
var span = spans.get(0);

assertEquals(
StatusCode.ERROR,
span.getStatus().getStatusCode(),
"a non-2xx response must mark the span failed");

var attributes = span.getAttributes();
String requestId = attributes.get(AttributeKey.stringKey("x-request-id"));
assertNotNull(requestId, "x-request-id must still be captured on a failed call");
assertNull(
attributes.get(AttributeKey.stringKey("response_id")),
"an error body has no object id to capture");
}
}
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
Expand Up@@ -24,6 +24,9 @@
import java.io.InputStreamReader;
import java.io.OutputStream;
import java.nio.charset.StandardCharsets;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.atomic.AtomicBoolean;
import java.util.concurrent.atomic.AtomicLong;
Expand DownExpand Up@@ -260,10 +263,25 @@ private void onFirstByte() {

private void onStreamClosed() {
try {
// Scooped first and unconditionally: tagSpanFromBuffer bails on an empty body,
// and a failed request is both the likeliest source of one and the case where
// the vendor's request id is most worth having.
InstrumentationSemConv.tagLLMSpanIdHeaders(span, headersAsMap(delegate.headers()));

byte[] bytes;
synchronized (teeBuffer) {
bytes = teeBuffer.toByteArray();
}

// Recorded before tagging: the anthropic sdk raises above this layer, so the
// error status is ours alone to set, and losing it to a body-parsing problem is
// worse than losing the parsed output.
int statusCode = delegate.statusCode();
if (statusCode >= 400) {
InstrumentationSemConv.tagLLMSpanHttpError(
span, statusCode, new String(bytes, StandardCharsets.UTF_8));
}

// tagLLMSpanResponse also emits child spans for any server-side tool calls (web
// search, etc.) nested under the LLM span while it is still live.
tagSpanFromBuffer(tracer, span, bytes, timeToFirstTokenNanos.get());
Expand DownExpand Up@@ -387,6 +405,29 @@ private static void tagSpanFromBuffer(
}
}

/**
* Adapts the anthropic sdk's {@code Headers} to the vendor-neutral shape {@link
* InstrumentationSemConv} consumes. Returns null on failure so a header-shape change can never
* take down the response tagging that follows it.
*/
@Nullable
private static Map<String, List<String>> headersAsMap(
@Nullable com.anthropic.core.http.Headers headers) {
if (headers == null) {
return null;
}
try {
var map = new HashMap<String, List<String>>();
for (String name : headers.names()) {
map.put(name, headers.values(name));
}
return map;
} catch (Exception e) {
log.debug("could not read response headers", e);
return null;
}
}

private static String firstNonEmptyLine(byte[] bytes) {
int start = 0;
for (int i = 0; i <= bytes.length; i++) {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -562,4 +562,76 @@ void testWrappedClientObjectContract() {
wrapped.toString().contains("ContextCapturingProxy"),
"toString should identify the proxy, got: " + wrapped);
}

/**
* Anthropic returns its correlation ID as {@code request-id} (no {@code x-} prefix, unlike
* OpenAI) and its object ID as {@code msg_*}. Both must land on the span for streaming and
* non-streaming alike — the header comes off the HTTP response, the object ID out of the
* reassembled body, so the two travel independent paths.
*/
@Test
@SneakyThrows
void testCorrelationIdsCaptured() {
AnthropicClient anthropicClient =
AnthropicOkHttpClient.builder()
.baseUrl(testHarness.anthropicBaseUrl())
.apiKey(testHarness.anthropicApiKey())
.build();

var request =
MessageCreateParams.builder()
.model(Model.of(TEST_MODEL))
.system("You are a helpful assistant")
.addUserMessage("What is the capital of France?")
.maxTokens(50)
.temperature(0.0)
.build();

anthropicClient.messages().create(request);
assertAnthropicIdsCaptured(testHarness.awaitExportedSpans().get(0));
}

@Test
@SneakyThrows
void testCorrelationIdsCapturedStreaming() {
AnthropicClient anthropicClient =
AnthropicOkHttpClient.builder()
.baseUrl(testHarness.anthropicBaseUrl())
.apiKey(testHarness.anthropicApiKey())
.build();

var request =
MessageCreateParams.builder()
.model(Model.of(TEST_MODEL))
.system("You are a helpful assistant")
.addUserMessage("What is the capital of France?")
.maxTokens(50)
.temperature(0.0)
.build();

try (var stream = anthropicClient.messages().createStreaming(request)) {
stream.stream().forEach(event -> {});
}
assertAnthropicIdsCaptured(testHarness.awaitExportedSpans().get(0));
}

/**
* Asserts presence only for the header: its value is an opaque vendor string, so pinning its
* shape would encode an assumption the provider never made.
*/
private static void assertAnthropicIdsCaptured(io.opentelemetry.sdk.trace.data.SpanData span) {
var attributes = span.getAttributes();

String requestId = attributes.get(AttributeKey.stringKey("request-id"));
assertNotNull(requestId, "request-id header must be captured");
assertFalse(requestId.isBlank(), "request-id must not be blank");

String responseId = attributes.get(AttributeKey.stringKey("response_id"));
assertNotNull(responseId, "response_id must be captured from the response body");
assertTrue(responseId.startsWith("msg_"), "unexpected response_id: " + responseId);

assertNull(
attributes.get(AttributeKey.stringKey("x-request-id")),
"OpenAI's header name must not appear on an Anthropic span");
}
}
Original file line numberDiff line numberDiff line change
Expand Up@@ -20,6 +20,9 @@
import io.opentelemetry.context.Context;
import java.io.*;
import java.nio.charset.StandardCharsets;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.atomic.AtomicBoolean;
import java.util.concurrent.atomic.AtomicLong;
Expand DownExpand Up@@ -68,7 +71,7 @@ private static ExtractedRequest extractCallerContext(HttpRequest request) {
Context context = contextFromTraceparent(values.get(0));
HttpRequest stripped =
request.toBuilder()
.replaceHeaders(ContextCapturingProxy.CONTEXT_HEADER, java.util.List.of())
.replaceHeaders(ContextCapturingProxy.CONTEXT_HEADER, List.of())
.build();
return new ExtractedRequest(stripped, context);
}
Expand DownExpand Up@@ -259,6 +262,28 @@ private static void tagSpanFromBuffer(
}
}

/**
* Adapts openai-java's {@link Headers} to the vendor-neutral shape {@link
* InstrumentationSemConv} consumes. Returns null on failure so a header-shape change can never
* take down the response tagging that follows it.
*/
@Nullable
private static Map<String, List<String>> headersAsMap(@Nullable Headers headers) {
if (headers == null) {
return null;
}
try {
var map = new HashMap<String, List<String>>();
for (String name : headers.names()) {
map.put(name, headers.values(name));
}
return map;
} catch (Exception e) {
log.debug("could not read response headers", e);
return null;
}
}

private static String firstNonEmptyLine(byte[] bytes) {
int start = 0;
for (int i = 0; i <= bytes.length; i++) {
Expand DownExpand Up@@ -368,12 +393,27 @@ private void onFirstByte() {
/** Called back by {@link TeeInputStream} when the stream is fully drained or closed. */
private void onStreamClosed() {
try {
// Scooped first and unconditionally: tagSpanFromBuffer bails on an empty body,
// and a failed request is both the likeliest source of one and the case where
// the vendor's request id is most worth having.
InstrumentationSemConv.tagLLMSpanIdHeaders(span, headersAsMap(delegate.headers()));

// Synchronize on teeBuffer to ensure any write() that was in-flight on a
// concurrent read thread has fully completed before we snapshot the bytes.
byte[] bytes;
synchronized (teeBuffer) {
bytes = teeBuffer.toByteArray();
}

// Recorded before tagging: openai-java raises above this layer, so the error
// status is ours alone to set, and losing it to a body-parsing problem is worse
// than losing the parsed output.
int statusCode = delegate.statusCode();
if (statusCode >= 400) {
InstrumentationSemConv.tagLLMSpanHttpError(
span, statusCode, new String(bytes, StandardCharsets.UTF_8));
}

// tagLLMSpanResponse also emits child spans for any server-side tool calls (web
// search, etc.) nested under the LLM span while it is still live. No-op for Chat
// Completions responses (no `output` array).
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -24,6 +24,7 @@
import dev.braintrust.TestHarness;
import dev.braintrust.instrumentation.Instrumenter;
import io.opentelemetry.api.common.AttributeKey;
import io.opentelemetry.api.trace.StatusCode;
import io.opentelemetry.sdk.trace.data.SpanData;
import java.util.List;
import java.util.Map;
Expand DownExpand Up@@ -649,5 +650,65 @@ private static void assertValidOpenAISpan(SpanData span, boolean isStreaming) {
assertNotNull(
attributes.get(AttributeKey.stringKey("braintrust.output_json")),
"output must be set");
assertOpenAIIdsCaptured(span);
}

/**
* Both correlation IDs OpenAI hands back. Deliberately asserts only presence and the object-ID
* prefix: {@code x-request-id} is opaque, and OpenAI returns both {@code req_*} and bare UUIDs
* for it, so pinning its shape would be wrong.
*/
private static void assertOpenAIIdsCaptured(SpanData span) {
var attributes = span.getAttributes();

String requestId = attributes.get(AttributeKey.stringKey("x-request-id"));
assertNotNull(requestId, "x-request-id header must be captured");
assertFalse(requestId.isBlank(), "x-request-id must not be blank");

String responseId = attributes.get(AttributeKey.stringKey("response_id"));
assertNotNull(responseId, "response_id must be captured from the response body");
assertTrue(
responseId.startsWith("resp_") || responseId.startsWith("chatcmpl-"),
"unexpected response_id: " + responseId);
}

/**
* A failed call is the case where the vendor's request id matters most, and the only one where
* it is the *sole* ID available: an error body carries no object id of its own. openai-java
* raises its exception above the HTTP layer we instrument, so the error status on the span is
* ours alone to set.
*/
@Test
@SneakyThrows
void testHttpErrorTagsSpan() {
OpenAIClient openAIClient =
OpenAIOkHttpClient.builder()
.baseUrl(testHarness.openAiBaseUrl())
.apiKey(testHarness.openAiApiKey())
.build();

var request =
ChatCompletionCreateParams.builder()
.model("gpt-4o-mini-nonexistent-model")
.addUserMessage("What is the capital of France?")
.build();

assertThrows(Exception.class, () -> openAIClient.chat().completions().create(request));

var spans = testHarness.awaitExportedSpans();
assertEquals(1, spans.size());
var span = spans.get(0);

assertEquals(
StatusCode.ERROR,
span.getStatus().getStatusCode(),
"a non-2xx response must mark the span failed");

var attributes = span.getAttributes();
String requestId = attributes.get(AttributeKey.stringKey("x-request-id"));
assertNotNull(requestId, "x-request-id must still be captured on a failed call");
assertNull(
attributes.get(AttributeKey.stringKey("response_id")),
"an error body has no object id to capture");
}
}
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
Expand Up@@ -24,6 +24,9 @@
import java.io.InputStreamReader;
import java.io.OutputStream;
import java.nio.charset.StandardCharsets;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.atomic.AtomicBoolean;
import java.util.concurrent.atomic.AtomicLong;
Expand DownExpand Up@@ -260,10 +263,25 @@ private void onFirstByte() {

private void onStreamClosed() {
try {
// Scooped first and unconditionally: tagSpanFromBuffer bails on an empty body,
// and a failed request is both the likeliest source of one and the case where
// the vendor's request id is most worth having.
InstrumentationSemConv.tagLLMSpanIdHeaders(span, headersAsMap(delegate.headers()));

byte[] bytes;
synchronized (teeBuffer) {
bytes = teeBuffer.toByteArray();
}

// Recorded before tagging: the anthropic sdk raises above this layer, so the
// error status is ours alone to set, and losing it to a body-parsing problem is
// worse than losing the parsed output.
int statusCode = delegate.statusCode();
if (statusCode >= 400) {
InstrumentationSemConv.tagLLMSpanHttpError(
span, statusCode, new String(bytes, StandardCharsets.UTF_8));
}

// tagLLMSpanResponse also emits child spans for any server-side tool calls (web
// search, etc.) nested under the LLM span while it is still live.
tagSpanFromBuffer(tracer, span, bytes, timeToFirstTokenNanos.get());
Expand DownExpand Up@@ -387,6 +405,29 @@ private static void tagSpanFromBuffer(
}
}

/**
* Adapts the anthropic sdk's {@code Headers} to the vendor-neutral shape {@link
* InstrumentationSemConv} consumes. Returns null on failure so a header-shape change can never
* take down the response tagging that follows it.
*/
@Nullable
private static Map<String, List<String>> headersAsMap(
@Nullable com.anthropic.core.http.Headers headers) {
if (headers == null) {
return null;
}
try {
var map = new HashMap<String, List<String>>();
for (String name : headers.names()) {
map.put(name, headers.values(name));
}
return map;
} catch (Exception e) {
log.debug("could not read response headers", e);
return null;
}
}

private static String firstNonEmptyLine(byte[] bytes) {
int start = 0;
for (int i = 0; i <= bytes.length; i++) {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -562,4 +562,76 @@ void testWrappedClientObjectContract() {
wrapped.toString().contains("ContextCapturingProxy"),
"toString should identify the proxy, got: " + wrapped);
}

/**
* Anthropic returns its correlation ID as {@code request-id} (no {@code x-} prefix, unlike
* OpenAI) and its object ID as {@code msg_*}. Both must land on the span for streaming and
* non-streaming alike — the header comes off the HTTP response, the object ID out of the
* reassembled body, so the two travel independent paths.
*/
@Test
@SneakyThrows
void testCorrelationIdsCaptured() {
AnthropicClient anthropicClient =
AnthropicOkHttpClient.builder()
.baseUrl(testHarness.anthropicBaseUrl())
.apiKey(testHarness.anthropicApiKey())
.build();

var request =
MessageCreateParams.builder()
.model(Model.of(TEST_MODEL))
.system("You are a helpful assistant")
.addUserMessage("What is the capital of France?")
.maxTokens(50)
.temperature(0.0)
.build();

anthropicClient.messages().create(request);
assertAnthropicIdsCaptured(testHarness.awaitExportedSpans().get(0));
}

@Test
@SneakyThrows
void testCorrelationIdsCapturedStreaming() {
AnthropicClient anthropicClient =
AnthropicOkHttpClient.builder()
.baseUrl(testHarness.anthropicBaseUrl())
.apiKey(testHarness.anthropicApiKey())
.build();

var request =
MessageCreateParams.builder()
.model(Model.of(TEST_MODEL))
.system("You are a helpful assistant")
.addUserMessage("What is the capital of France?")
.maxTokens(50)
.temperature(0.0)
.build();

try (var stream = anthropicClient.messages().createStreaming(request)) {
stream.stream().forEach(event -> {});
}
assertAnthropicIdsCaptured(testHarness.awaitExportedSpans().get(0));
}

/**
* Asserts presence only for the header: its value is an opaque vendor string, so pinning its
* shape would encode an assumption the provider never made.
*/
private static void assertAnthropicIdsCaptured(io.opentelemetry.sdk.trace.data.SpanData span) {
var attributes = span.getAttributes();

String requestId = attributes.get(AttributeKey.stringKey("request-id"));
assertNotNull(requestId, "request-id header must be captured");
assertFalse(requestId.isBlank(), "request-id must not be blank");

String responseId = attributes.get(AttributeKey.stringKey("response_id"));
assertNotNull(responseId, "response_id must be captured from the response body");
assertTrue(responseId.startsWith("msg_"), "unexpected response_id: " + responseId);

assertNull(
attributes.get(AttributeKey.stringKey("x-request-id")),
"OpenAI's header name must not appear on an Anthropic span");
}
}
Original file line numberDiff line numberDiff line change
Expand Up@@ -20,6 +20,9 @@
import io.opentelemetry.context.Context;
import java.io.*;
import java.nio.charset.StandardCharsets;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.atomic.AtomicBoolean;
import java.util.concurrent.atomic.AtomicLong;
Expand DownExpand Up@@ -68,7 +71,7 @@ private static ExtractedRequest extractCallerContext(HttpRequest request) {
Context context = contextFromTraceparent(values.get(0));
HttpRequest stripped =
request.toBuilder()
.replaceHeaders(ContextCapturingProxy.CONTEXT_HEADER, java.util.List.of())
.replaceHeaders(ContextCapturingProxy.CONTEXT_HEADER, List.of())
.build();
return new ExtractedRequest(stripped, context);
}
Expand DownExpand Up@@ -259,6 +262,28 @@ private static void tagSpanFromBuffer(
}
}

/**
* Adapts openai-java's {@link Headers} to the vendor-neutral shape {@link
* InstrumentationSemConv} consumes. Returns null on failure so a header-shape change can never
* take down the response tagging that follows it.
*/
@Nullable
private static Map<String, List<String>> headersAsMap(@Nullable Headers headers) {
if (headers == null) {
return null;
}
try {
var map = new HashMap<String, List<String>>();
for (String name : headers.names()) {
map.put(name, headers.values(name));
}
return map;
} catch (Exception e) {
log.debug("could not read response headers", e);
return null;
}
}

private static String firstNonEmptyLine(byte[] bytes) {
int start = 0;
for (int i = 0; i <= bytes.length; i++) {
Expand DownExpand Up@@ -368,12 +393,27 @@ private void onFirstByte() {
/** Called back by {@link TeeInputStream} when the stream is fully drained or closed. */
private void onStreamClosed() {
try {
// Scooped first and unconditionally: tagSpanFromBuffer bails on an empty body,
// and a failed request is both the likeliest source of one and the case where
// the vendor's request id is most worth having.
InstrumentationSemConv.tagLLMSpanIdHeaders(span, headersAsMap(delegate.headers()));

// Synchronize on teeBuffer to ensure any write() that was in-flight on a
// concurrent read thread has fully completed before we snapshot the bytes.
byte[] bytes;
synchronized (teeBuffer) {
bytes = teeBuffer.toByteArray();
}

// Recorded before tagging: openai-java raises above this layer, so the error
// status is ours alone to set, and losing it to a body-parsing problem is worse
// than losing the parsed output.
int statusCode = delegate.statusCode();
if (statusCode >= 400) {
InstrumentationSemConv.tagLLMSpanHttpError(
span, statusCode, new String(bytes, StandardCharsets.UTF_8));
}

// tagLLMSpanResponse also emits child spans for any server-side tool calls (web
// search, etc.) nested under the LLM span while it is still live. No-op for Chat
// Completions responses (no `output` array).
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -24,6 +24,7 @@
import dev.braintrust.TestHarness;
import dev.braintrust.instrumentation.Instrumenter;
import io.opentelemetry.api.common.AttributeKey;
import io.opentelemetry.api.trace.StatusCode;
import io.opentelemetry.sdk.trace.data.SpanData;
import java.util.List;
import java.util.Map;
Expand DownExpand Up@@ -649,5 +650,65 @@ private static void assertValidOpenAISpan(SpanData span, boolean isStreaming) {
assertNotNull(
attributes.get(AttributeKey.stringKey("braintrust.output_json")),
"output must be set");
assertOpenAIIdsCaptured(span);
}

/**
* Both correlation IDs OpenAI hands back. Deliberately asserts only presence and the object-ID
* prefix: {@code x-request-id} is opaque, and OpenAI returns both {@code req_*} and bare UUIDs
* for it, so pinning its shape would be wrong.
*/
private static void assertOpenAIIdsCaptured(SpanData span) {
var attributes = span.getAttributes();

String requestId = attributes.get(AttributeKey.stringKey("x-request-id"));
assertNotNull(requestId, "x-request-id header must be captured");
assertFalse(requestId.isBlank(), "x-request-id must not be blank");

String responseId = attributes.get(AttributeKey.stringKey("response_id"));
assertNotNull(responseId, "response_id must be captured from the response body");
assertTrue(
responseId.startsWith("resp_") || responseId.startsWith("chatcmpl-"),
"unexpected response_id: " + responseId);
}

/**
* A failed call is the case where the vendor's request id matters most, and the only one where
* it is the *sole* ID available: an error body carries no object id of its own. openai-java
* raises its exception above the HTTP layer we instrument, so the error status on the span is
* ours alone to set.
*/
@Test
@SneakyThrows
void testHttpErrorTagsSpan() {
OpenAIClient openAIClient =
OpenAIOkHttpClient.builder()
.baseUrl(testHarness.openAiBaseUrl())
.apiKey(testHarness.openAiApiKey())
.build();

var request =
ChatCompletionCreateParams.builder()
.model("gpt-4o-mini-nonexistent-model")
.addUserMessage("What is the capital of France?")
.build();

assertThrows(Exception.class, () -> openAIClient.chat().completions().create(request));

var spans = testHarness.awaitExportedSpans();
assertEquals(1, spans.size());
var span = spans.get(0);

assertEquals(
StatusCode.ERROR,
span.getStatus().getStatusCode(),
"a non-2xx response must mark the span failed");

var attributes = span.getAttributes();
String requestId = attributes.get(AttributeKey.stringKey("x-request-id"));
assertNotNull(requestId, "x-request-id must still be captured on a failed call");
assertNull(
attributes.get(AttributeKey.stringKey("response_id")),
"an error body has no object id to capture");
}
}
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
Expand Up@@ -24,6 +24,9 @@
import java.io.InputStreamReader;
import java.io.OutputStream;
import java.nio.charset.StandardCharsets;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.atomic.AtomicBoolean;
import java.util.concurrent.atomic.AtomicLong;
Expand DownExpand Up@@ -260,10 +263,25 @@ private void onFirstByte() {

private void onStreamClosed() {
try {
// Scooped first and unconditionally: tagSpanFromBuffer bails on an empty body,
// and a failed request is both the likeliest source of one and the case where
// the vendor's request id is most worth having.
InstrumentationSemConv.tagLLMSpanIdHeaders(span, headersAsMap(delegate.headers()));

byte[] bytes;
synchronized (teeBuffer) {
bytes = teeBuffer.toByteArray();
}

// Recorded before tagging: the anthropic sdk raises above this layer, so the
// error status is ours alone to set, and losing it to a body-parsing problem is
// worse than losing the parsed output.
int statusCode = delegate.statusCode();
if (statusCode >= 400) {
InstrumentationSemConv.tagLLMSpanHttpError(
span, statusCode, new String(bytes, StandardCharsets.UTF_8));
}

// tagLLMSpanResponse also emits child spans for any server-side tool calls (web
// search, etc.) nested under the LLM span while it is still live.
tagSpanFromBuffer(tracer, span, bytes, timeToFirstTokenNanos.get());
Expand DownExpand Up@@ -387,6 +405,29 @@ private static void tagSpanFromBuffer(
}
}

/**
* Adapts the anthropic sdk's {@code Headers} to the vendor-neutral shape {@link
* InstrumentationSemConv} consumes. Returns null on failure so a header-shape change can never
* take down the response tagging that follows it.
*/
@Nullable
private static Map<String, List<String>> headersAsMap(
@Nullable com.anthropic.core.http.Headers headers) {
if (headers == null) {
return null;
}
try {
var map = new HashMap<String, List<String>>();
for (String name : headers.names()) {
map.put(name, headers.values(name));
}
return map;
} catch (Exception e) {
log.debug("could not read response headers", e);
return null;
}
}

private static String firstNonEmptyLine(byte[] bytes) {
int start = 0;
for (int i = 0; i <= bytes.length; i++) {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -562,4 +562,76 @@ void testWrappedClientObjectContract() {
wrapped.toString().contains("ContextCapturingProxy"),
"toString should identify the proxy, got: " + wrapped);
}

/**
* Anthropic returns its correlation ID as {@code request-id} (no {@code x-} prefix, unlike
* OpenAI) and its object ID as {@code msg_*}. Both must land on the span for streaming and
* non-streaming alike — the header comes off the HTTP response, the object ID out of the
* reassembled body, so the two travel independent paths.
*/
@Test
@SneakyThrows
void testCorrelationIdsCaptured() {
AnthropicClient anthropicClient =
AnthropicOkHttpClient.builder()
.baseUrl(testHarness.anthropicBaseUrl())
.apiKey(testHarness.anthropicApiKey())
.build();

var request =
MessageCreateParams.builder()
.model(Model.of(TEST_MODEL))
.system("You are a helpful assistant")
.addUserMessage("What is the capital of France?")
.maxTokens(50)
.temperature(0.0)
.build();

anthropicClient.messages().create(request);
assertAnthropicIdsCaptured(testHarness.awaitExportedSpans().get(0));
}

@Test
@SneakyThrows
void testCorrelationIdsCapturedStreaming() {
AnthropicClient anthropicClient =
AnthropicOkHttpClient.builder()
.baseUrl(testHarness.anthropicBaseUrl())
.apiKey(testHarness.anthropicApiKey())
.build();

var request =
MessageCreateParams.builder()
.model(Model.of(TEST_MODEL))
.system("You are a helpful assistant")
.addUserMessage("What is the capital of France?")
.maxTokens(50)
.temperature(0.0)
.build();

try (var stream = anthropicClient.messages().createStreaming(request)) {
stream.stream().forEach(event -> {});
}
assertAnthropicIdsCaptured(testHarness.awaitExportedSpans().get(0));
}

/**
* Asserts presence only for the header: its value is an opaque vendor string, so pinning its
* shape would encode an assumption the provider never made.
*/
private static void assertAnthropicIdsCaptured(io.opentelemetry.sdk.trace.data.SpanData span) {
var attributes = span.getAttributes();

String requestId = attributes.get(AttributeKey.stringKey("request-id"));
assertNotNull(requestId, "request-id header must be captured");
assertFalse(requestId.isBlank(), "request-id must not be blank");

String responseId = attributes.get(AttributeKey.stringKey("response_id"));
assertNotNull(responseId, "response_id must be captured from the response body");
assertTrue(responseId.startsWith("msg_"), "unexpected response_id: " + responseId);

assertNull(
attributes.get(AttributeKey.stringKey("x-request-id")),
"OpenAI's header name must not appear on an Anthropic span");
}
}
Original file line numberDiff line numberDiff line change
Expand Up@@ -20,6 +20,9 @@
import io.opentelemetry.context.Context;
import java.io.*;
import java.nio.charset.StandardCharsets;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.atomic.AtomicBoolean;
import java.util.concurrent.atomic.AtomicLong;
Expand DownExpand Up@@ -68,7 +71,7 @@ private static ExtractedRequest extractCallerContext(HttpRequest request) {
Context context = contextFromTraceparent(values.get(0));
HttpRequest stripped =
request.toBuilder()
.replaceHeaders(ContextCapturingProxy.CONTEXT_HEADER, java.util.List.of())
.replaceHeaders(ContextCapturingProxy.CONTEXT_HEADER, List.of())
.build();
return new ExtractedRequest(stripped, context);
}
Expand DownExpand Up@@ -259,6 +262,28 @@ private static void tagSpanFromBuffer(
}
}

/**
* Adapts openai-java's {@link Headers} to the vendor-neutral shape {@link
* InstrumentationSemConv} consumes. Returns null on failure so a header-shape change can never
* take down the response tagging that follows it.
*/
@Nullable
private static Map<String, List<String>> headersAsMap(@Nullable Headers headers) {
if (headers == null) {
return null;
}
try {
var map = new HashMap<String, List<String>>();
for (String name : headers.names()) {
map.put(name, headers.values(name));
}
return map;
} catch (Exception e) {
log.debug("could not read response headers", e);
return null;
}
}

private static String firstNonEmptyLine(byte[] bytes) {
int start = 0;
for (int i = 0; i <= bytes.length; i++) {
Expand DownExpand Up@@ -368,12 +393,27 @@ private void onFirstByte() {
/** Called back by {@link TeeInputStream} when the stream is fully drained or closed. */
private void onStreamClosed() {
try {
// Scooped first and unconditionally: tagSpanFromBuffer bails on an empty body,
// and a failed request is both the likeliest source of one and the case where
// the vendor's request id is most worth having.
InstrumentationSemConv.tagLLMSpanIdHeaders(span, headersAsMap(delegate.headers()));

// Synchronize on teeBuffer to ensure any write() that was in-flight on a
// concurrent read thread has fully completed before we snapshot the bytes.
byte[] bytes;
synchronized (teeBuffer) {
bytes = teeBuffer.toByteArray();
}

// Recorded before tagging: openai-java raises above this layer, so the error
// status is ours alone to set, and losing it to a body-parsing problem is worse
// than losing the parsed output.
int statusCode = delegate.statusCode();
if (statusCode >= 400) {
InstrumentationSemConv.tagLLMSpanHttpError(
span, statusCode, new String(bytes, StandardCharsets.UTF_8));
}

// tagLLMSpanResponse also emits child spans for any server-side tool calls (web
// search, etc.) nested under the LLM span while it is still live. No-op for Chat
// Completions responses (no `output` array).
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -24,6 +24,7 @@
import dev.braintrust.TestHarness;
import dev.braintrust.instrumentation.Instrumenter;
import io.opentelemetry.api.common.AttributeKey;
import io.opentelemetry.api.trace.StatusCode;
import io.opentelemetry.sdk.trace.data.SpanData;
import java.util.List;
import java.util.Map;
Expand DownExpand Up@@ -649,5 +650,65 @@ private static void assertValidOpenAISpan(SpanData span, boolean isStreaming) {
assertNotNull(
attributes.get(AttributeKey.stringKey("braintrust.output_json")),
"output must be set");
assertOpenAIIdsCaptured(span);
}

/**
* Both correlation IDs OpenAI hands back. Deliberately asserts only presence and the object-ID
* prefix: {@code x-request-id} is opaque, and OpenAI returns both {@code req_*} and bare UUIDs
* for it, so pinning its shape would be wrong.
*/
private static void assertOpenAIIdsCaptured(SpanData span) {
var attributes = span.getAttributes();

String requestId = attributes.get(AttributeKey.stringKey("x-request-id"));
assertNotNull(requestId, "x-request-id header must be captured");
assertFalse(requestId.isBlank(), "x-request-id must not be blank");

String responseId = attributes.get(AttributeKey.stringKey("response_id"));
assertNotNull(responseId, "response_id must be captured from the response body");
assertTrue(
responseId.startsWith("resp_") || responseId.startsWith("chatcmpl-"),
"unexpected response_id: " + responseId);
}

/**
* A failed call is the case where the vendor's request id matters most, and the only one where
* it is the *sole* ID available: an error body carries no object id of its own. openai-java
* raises its exception above the HTTP layer we instrument, so the error status on the span is
* ours alone to set.
*/
@Test
@SneakyThrows
void testHttpErrorTagsSpan() {
OpenAIClient openAIClient =
OpenAIOkHttpClient.builder()
.baseUrl(testHarness.openAiBaseUrl())
.apiKey(testHarness.openAiApiKey())
.build();

var request =
ChatCompletionCreateParams.builder()
.model("gpt-4o-mini-nonexistent-model")
.addUserMessage("What is the capital of France?")
.build();

assertThrows(Exception.class, () -> openAIClient.chat().completions().create(request));

var spans = testHarness.awaitExportedSpans();
assertEquals(1, spans.size());
var span = spans.get(0);

assertEquals(
StatusCode.ERROR,
span.getStatus().getStatusCode(),
"a non-2xx response must mark the span failed");

var attributes = span.getAttributes();
String requestId = attributes.get(AttributeKey.stringKey("x-request-id"));
assertNotNull(requestId, "x-request-id must still be captured on a failed call");
assertNull(
attributes.get(AttributeKey.stringKey("response_id")),
"an error body has no object id to capture");
}
}
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
Expand Up@@ -24,6 +24,9 @@
import java.io.InputStreamReader;
import java.io.OutputStream;
import java.nio.charset.StandardCharsets;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.atomic.AtomicBoolean;
import java.util.concurrent.atomic.AtomicLong;
Expand DownExpand Up@@ -260,10 +263,25 @@ private void onFirstByte() {

private void onStreamClosed() {
try {
// Scooped first and unconditionally: tagSpanFromBuffer bails on an empty body,
// and a failed request is both the likeliest source of one and the case where
// the vendor's request id is most worth having.
InstrumentationSemConv.tagLLMSpanIdHeaders(span, headersAsMap(delegate.headers()));

byte[] bytes;
synchronized (teeBuffer) {
bytes = teeBuffer.toByteArray();
}

// Recorded before tagging: the anthropic sdk raises above this layer, so the
// error status is ours alone to set, and losing it to a body-parsing problem is
// worse than losing the parsed output.
int statusCode = delegate.statusCode();
if (statusCode >= 400) {
InstrumentationSemConv.tagLLMSpanHttpError(
span, statusCode, new String(bytes, StandardCharsets.UTF_8));
}

// tagLLMSpanResponse also emits child spans for any server-side tool calls (web
// search, etc.) nested under the LLM span while it is still live.
tagSpanFromBuffer(tracer, span, bytes, timeToFirstTokenNanos.get());
Expand DownExpand Up@@ -387,6 +405,29 @@ private static void tagSpanFromBuffer(
}
}

/**
* Adapts the anthropic sdk's {@code Headers} to the vendor-neutral shape {@link
* InstrumentationSemConv} consumes. Returns null on failure so a header-shape change can never
* take down the response tagging that follows it.
*/
@Nullable
private static Map<String, List<String>> headersAsMap(
@Nullable com.anthropic.core.http.Headers headers) {
if (headers == null) {
return null;
}
try {
var map = new HashMap<String, List<String>>();
for (String name : headers.names()) {
map.put(name, headers.values(name));
}
return map;
} catch (Exception e) {
log.debug("could not read response headers", e);
return null;
}
}

private static String firstNonEmptyLine(byte[] bytes) {
int start = 0;
for (int i = 0; i <= bytes.length; i++) {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -562,4 +562,76 @@ void testWrappedClientObjectContract() {
wrapped.toString().contains("ContextCapturingProxy"),
"toString should identify the proxy, got: " + wrapped);
}

/**
* Anthropic returns its correlation ID as {@code request-id} (no {@code x-} prefix, unlike
* OpenAI) and its object ID as {@code msg_*}. Both must land on the span for streaming and
* non-streaming alike — the header comes off the HTTP response, the object ID out of the
* reassembled body, so the two travel independent paths.
*/
@Test
@SneakyThrows
void testCorrelationIdsCaptured() {
AnthropicClient anthropicClient =
AnthropicOkHttpClient.builder()
.baseUrl(testHarness.anthropicBaseUrl())
.apiKey(testHarness.anthropicApiKey())
.build();

var request =
MessageCreateParams.builder()
.model(Model.of(TEST_MODEL))
.system("You are a helpful assistant")
.addUserMessage("What is the capital of France?")
.maxTokens(50)
.temperature(0.0)
.build();

anthropicClient.messages().create(request);
assertAnthropicIdsCaptured(testHarness.awaitExportedSpans().get(0));
}

@Test
@SneakyThrows
void testCorrelationIdsCapturedStreaming() {
AnthropicClient anthropicClient =
AnthropicOkHttpClient.builder()
.baseUrl(testHarness.anthropicBaseUrl())
.apiKey(testHarness.anthropicApiKey())
.build();

var request =
MessageCreateParams.builder()
.model(Model.of(TEST_MODEL))
.system("You are a helpful assistant")
.addUserMessage("What is the capital of France?")
.maxTokens(50)
.temperature(0.0)
.build();

try (var stream = anthropicClient.messages().createStreaming(request)) {
stream.stream().forEach(event -> {});
}
assertAnthropicIdsCaptured(testHarness.awaitExportedSpans().get(0));
}

/**
* Asserts presence only for the header: its value is an opaque vendor string, so pinning its
* shape would encode an assumption the provider never made.
*/
private static void assertAnthropicIdsCaptured(io.opentelemetry.sdk.trace.data.SpanData span) {
var attributes = span.getAttributes();

String requestId = attributes.get(AttributeKey.stringKey("request-id"));
assertNotNull(requestId, "request-id header must be captured");
assertFalse(requestId.isBlank(), "request-id must not be blank");

String responseId = attributes.get(AttributeKey.stringKey("response_id"));
assertNotNull(responseId, "response_id must be captured from the response body");
assertTrue(responseId.startsWith("msg_"), "unexpected response_id: " + responseId);

assertNull(
attributes.get(AttributeKey.stringKey("x-request-id")),
"OpenAI's header name must not appear on an Anthropic span");
}
}
Original file line numberDiff line numberDiff line change
Expand Up@@ -20,6 +20,9 @@
import io.opentelemetry.context.Context;
import java.io.*;
import java.nio.charset.StandardCharsets;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.atomic.AtomicBoolean;
import java.util.concurrent.atomic.AtomicLong;
Expand DownExpand Up@@ -68,7 +71,7 @@ private static ExtractedRequest extractCallerContext(HttpRequest request) {
Context context = contextFromTraceparent(values.get(0));
HttpRequest stripped =
request.toBuilder()
.replaceHeaders(ContextCapturingProxy.CONTEXT_HEADER, java.util.List.of())
.replaceHeaders(ContextCapturingProxy.CONTEXT_HEADER, List.of())
.build();
return new ExtractedRequest(stripped, context);
}
Expand DownExpand Up@@ -259,6 +262,28 @@ private static void tagSpanFromBuffer(
}
}

/**
* Adapts openai-java's {@link Headers} to the vendor-neutral shape {@link
* InstrumentationSemConv} consumes. Returns null on failure so a header-shape change can never
* take down the response tagging that follows it.
*/
@Nullable
private static Map<String, List<String>> headersAsMap(@Nullable Headers headers) {
if (headers == null) {
return null;
}
try {
var map = new HashMap<String, List<String>>();
for (String name : headers.names()) {
map.put(name, headers.values(name));
}
return map;
} catch (Exception e) {
log.debug("could not read response headers", e);
return null;
}
}

private static String firstNonEmptyLine(byte[] bytes) {
int start = 0;
for (int i = 0; i <= bytes.length; i++) {
Expand DownExpand Up@@ -368,12 +393,27 @@ private void onFirstByte() {
/** Called back by {@link TeeInputStream} when the stream is fully drained or closed. */
private void onStreamClosed() {
try {
// Scooped first and unconditionally: tagSpanFromBuffer bails on an empty body,
// and a failed request is both the likeliest source of one and the case where
// the vendor's request id is most worth having.
InstrumentationSemConv.tagLLMSpanIdHeaders(span, headersAsMap(delegate.headers()));

// Synchronize on teeBuffer to ensure any write() that was in-flight on a
// concurrent read thread has fully completed before we snapshot the bytes.
byte[] bytes;
synchronized (teeBuffer) {
bytes = teeBuffer.toByteArray();
}

// Recorded before tagging: openai-java raises above this layer, so the error
// status is ours alone to set, and losing it to a body-parsing problem is worse
// than losing the parsed output.
int statusCode = delegate.statusCode();
if (statusCode >= 400) {
InstrumentationSemConv.tagLLMSpanHttpError(
span, statusCode, new String(bytes, StandardCharsets.UTF_8));
}

// tagLLMSpanResponse also emits child spans for any server-side tool calls (web
// search, etc.) nested under the LLM span while it is still live. No-op for Chat
// Completions responses (no `output` array).
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -24,6 +24,7 @@
import dev.braintrust.TestHarness;
import dev.braintrust.instrumentation.Instrumenter;
import io.opentelemetry.api.common.AttributeKey;
import io.opentelemetry.api.trace.StatusCode;
import io.opentelemetry.sdk.trace.data.SpanData;
import java.util.List;
import java.util.Map;
Expand DownExpand Up@@ -649,5 +650,65 @@ private static void assertValidOpenAISpan(SpanData span, boolean isStreaming) {
assertNotNull(
attributes.get(AttributeKey.stringKey("braintrust.output_json")),
"output must be set");
assertOpenAIIdsCaptured(span);
}

/**
* Both correlation IDs OpenAI hands back. Deliberately asserts only presence and the object-ID
* prefix: {@code x-request-id} is opaque, and OpenAI returns both {@code req_*} and bare UUIDs
* for it, so pinning its shape would be wrong.
*/
private static void assertOpenAIIdsCaptured(SpanData span) {
var attributes = span.getAttributes();

String requestId = attributes.get(AttributeKey.stringKey("x-request-id"));
assertNotNull(requestId, "x-request-id header must be captured");
assertFalse(requestId.isBlank(), "x-request-id must not be blank");

String responseId = attributes.get(AttributeKey.stringKey("response_id"));
assertNotNull(responseId, "response_id must be captured from the response body");
assertTrue(
responseId.startsWith("resp_") || responseId.startsWith("chatcmpl-"),
"unexpected response_id: " + responseId);
}

/**
* A failed call is the case where the vendor's request id matters most, and the only one where
* it is the *sole* ID available: an error body carries no object id of its own. openai-java
* raises its exception above the HTTP layer we instrument, so the error status on the span is
* ours alone to set.
*/
@Test
@SneakyThrows
void testHttpErrorTagsSpan() {
OpenAIClient openAIClient =
OpenAIOkHttpClient.builder()
.baseUrl(testHarness.openAiBaseUrl())
.apiKey(testHarness.openAiApiKey())
.build();

var request =
ChatCompletionCreateParams.builder()
.model("gpt-4o-mini-nonexistent-model")
.addUserMessage("What is the capital of France?")
.build();

assertThrows(Exception.class, () -> openAIClient.chat().completions().create(request));

var spans = testHarness.awaitExportedSpans();
assertEquals(1, spans.size());
var span = spans.get(0);

assertEquals(
StatusCode.ERROR,
span.getStatus().getStatusCode(),
"a non-2xx response must mark the span failed");

var attributes = span.getAttributes();
String requestId = attributes.get(AttributeKey.stringKey("x-request-id"));
assertNotNull(requestId, "x-request-id must still be captured on a failed call");
assertNull(
attributes.get(AttributeKey.stringKey("response_id")),
"an error body has no object id to capture");
}
}
Loading
Loading