feat: Introduce new integrations API and convert anthropic - #118

Merged
Abhijeet Prasad (AbhiPrasad) merged 1 commit into
mainfrom
abhi-new-integrations-api
Mar 23, 2026
Merged

feat: Introduce new integrations API and convert anthropic#118
Abhijeet Prasad (AbhiPrasad) merged 1 commit into
mainfrom
abhi-new-integrations-api

Conversation

@AbhiPrasad

@AbhiPrasadAbhijeet Prasad (AbhiPrasad) commented Mar 23, 2026

Copy link
Copy Markdown
Member

This PR introduces a new integrations API for provider instrumentation (wrappers) and migrates Anthropic to it as the first implementation. The goal is to separate three concerns that were previously mixed together in individual wrappers:

  • integration discovery and version compatibility
  • patch selection and idempotent patch application
  • provider-specific tracing behavior

This PR is inspired by the current Ruby SDK implementation.

AI Summary

A new base integration layer lives under py/src/braintrust/integrations/. BaseIntegration is the orchestration class. It is responsible for:

  • probing whether an integration is installed
  • detecting the installed version
  • checking compatibility bounds
  • exposing the patchers available for that integration
  • resolving enabled_patchers / disabled_patchers
  • applying patchers in a deterministic, idempotent way

Conceptually, BaseIntegration.setup() is now the standard entry point for “instrument this library in the current process”.

BasePatcher is the unit of patch work. It represents one concrete patch strategy and is responsible for:

  • identifying itself with a stable patcher id
  • deciding whether it applies for the current runtime
  • checking whether its target is already patched
  • applying its patch once

This PR also adds FunctionWrapperPatcher, a reusable BasePatcher subclass for the common case where instrumentation is done with wrapt.wrap_function_wrapper against a single target path.

Supporting types added with this work:

  • IntegrationRuntime: normalized runtime facts for one integration (name, module, version)
  • IntegrationPatchConfig: user-facing config object for selecting patchers
  • versioning.py: a small stdlib-only helper for version detection and simple spec matching

Anthropic Migration

AnthropicIntegration defines:

  • name = "anthropic"
  • import_names = ("anthropic",)
  • min_version = "0.48.0"
  • two patchers:
    • anthropic.init.sync
    • anthropic.init.async

Those patchers wrap:

  • anthropic.Anthropic.__init__
  • anthropic.AsyncAnthropic.__init__

The constructor patching model is straightforward: after a client is constructed, Braintrust replaces the instance’s messages and beta.messages surfaces with traced wrappers. Those wrappers preserve Anthropic behavior while adding span creation, metadata capture, token metrics, time-to-first-token, stream aggregation, and error logging for sync, async, and streaming request paths.

This means the old Anthropic tracing logic did not disappear, but it was moved behind a cleaner integration boundary:

  • orchestration and patch selection now live in the integration layer
  • Anthropic-specific tracing remains local to the Anthropic implementation

The old braintrust.wrappers.anthropic module is now a compatibility shim that re-exports the new Anthropic wrapper entry points.

User-Facing Changes

The main user-facing change is that Anthropic instrumentation is now configurable instead of being strictly all-or-nothing.

Existing behavior still works:

importbraintrustbraintrust.auto_instrument()

Users can now also choose which Anthropic patchers to apply:

frombraintrustimportauto_instrumentfrombraintrust.integrationsimportIntegrationPatchConfigauto_instrument(
anthropic=IntegrationPatchConfig(
disabled_patchers={"anthropic.init.async"},
)
)

New public surfaces introduced by this PR:

  • braintrust.integrations.AnthropicIntegration
  • braintrust.integrations.IntegrationPatchConfig
  • braintrust.integrations.anthropic.wrap_anthropic

Existing exports:

  • braintrust.wrappers.anthropic.wrap_anthropic still works for compatibility

In practical terms, this PR is additive for users:

  • no intended breaking change for existing Anthropic wrapper usage
  • new ability to selectively instrument Anthropic sync vs async constructor paths
  • new public integration API that future providers can migrate onto

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we need to migrate all providers, should additional features for providers that haven't been migrated yet be postponed until their migration is done (unless there's an explicit customer request)?


Keep the class focused on orchestration. Provider-specific tracing logic should stay in `tracing.py`.

If the provider already supports direct instance wrapping, expose a `wrap(client)` method on the integration class that returns the traced client wrapper.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which providers do this?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I needed to update the skill - I deleted this .wrap stuff, will fix!

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I don't know if this is a plausible situation)

If some providers share a similar API and we could create some shared functions/classes to reduce LoC and improve code reuse, where should this shared code live?

Or maybe we don't want to have any code shared between providers?

@AbhiPrasad

Copy link
Copy Markdown
MemberAuthor

If some providers share a similar API and we could create some shared functions/classes to reduce LoC and improve code reuse, where should this shared code live?

We can just add a utility folder, or figure that out at this time.

@AbhiPrasad

Copy link
Copy Markdown
MemberAuthor

Since we need to migrate all providers, should additional features for providers that haven't been migrated yet be postponed until their migration is done

no, we can just do this on a case by case basis. Not that much activity on this repo, so we can get away with less merge conflicts.

Comment threadpy/src/braintrust/integrations/anthropic/__init__.py Outdated
Comment threadpy/src/braintrust/integrations/anthropic/patchers.py Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the CI is failing because the old tests are running against the new codebase and it has to be merged for the tests to be updated?

Good to merge

@AbhiPrasad

Copy link
Copy Markdown
MemberAuthor

I assume the CI is failing because the old tests are running against the new codebase and it has to be merged for the tests to be updated?

yeah I gotta fix that. Thanks for the review!

@AbhiPrasad
Abhijeet Prasad (AbhiPrasad) merged commit 363baa0 into mainMar 23, 2026
33 checks passed
@AbhiPrasad
Abhijeet Prasad (AbhiPrasad) deleted the abhi-new-integrations-api branch March 23, 2026 23:12
Abhijeet Prasad (AbhiPrasad) added a commit that referenced this pull request Mar 24, 2026
Convert the Google ADK (Agent Development Kit) instrumentation from the
legacy wrappers pattern to the new integrations API introduced in #118.
- Extract tracing helpers into integrations/adk/tracing.py
- Create ADK patchers (agent, runner, flow, mcp_tool) in patchers.py
- Add AdkIntegration class with proper registration
- Move tests and cassettes from wrappers/adk/ to integrations/adk/
- Move auto_instrument test script to integrations/auto_test_scripts/
- Slim down wrappers/adk/__init__.py to delegate to integrations
- Update noxfile.py with ADK integration test sessions
- Update integrations base and registry for ADK support
Abhijeet Prasad (AbhiPrasad) added a commit that referenced this pull request Mar 24, 2026
Convert the Google ADK (Agent Development Kit) instrumentation from the
legacy wrappers pattern to the new integrations API introduced in #118.
- Extract tracing helpers into integrations/adk/tracing.py
- Create ADK patchers (agent, runner, flow, mcp_tool) in patchers.py
- Add AdkIntegration class with proper registration
- Move tests and cassettes from wrappers/adk/ to integrations/adk/
- Move auto_instrument test script to integrations/auto_test_scripts/
- Slim down wrappers/adk/__init__.py to delegate to integrations
- Update noxfile.py with ADK integration test sessions
- Update integrations base and registry for ADK support
Abhijeet Prasad (AbhiPrasad) added a commit that referenced this pull request Mar 24, 2026
Convert the Google ADK (Agent Development Kit) instrumentation from the
legacy wrappers pattern to the new integrations API introduced in #118.
- Extract tracing helpers into integrations/adk/tracing.py
- Create ADK patchers (agent, runner, flow, mcp_tool) in patchers.py
- Add AdkIntegration class with proper registration
- Move tests and cassettes from wrappers/adk/ to integrations/adk/
- Move auto_instrument test script to integrations/auto_test_scripts/
- Slim down wrappers/adk/__init__.py to delegate to integrations
- Update noxfile.py with ADK integration test sessions
- Update integrations base and registry for ADK support
Abhijeet Prasad (AbhiPrasad) added a commit that referenced this pull request Mar 24, 2026
Convert the Google ADK (Agent Development Kit) instrumentation from the
legacy wrappers pattern to the new integrations API introduced in #118.
- Extract tracing helpers into integrations/adk/tracing.py
- Create ADK patchers (agent, runner, flow, mcp_tool) in patchers.py
- Add AdkIntegration class with proper registration
- Move tests and cassettes from wrappers/adk/ to integrations/adk/
- Move auto_instrument test script to integrations/auto_test_scripts/
- Slim down wrappers/adk/__init__.py to delegate to integrations
- Update noxfile.py with ADK integration test sessions
- Update integrations base and registry for ADK support
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@AbhiPrasad@viadezo1er
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

feat: Introduce new integrations API and convert anthropic - #118

Merged
Abhijeet Prasad (AbhiPrasad) merged 1 commit into
mainfrom
abhi-new-integrations-api
Mar 23, 2026
Merged

feat: Introduce new integrations API and convert anthropic#118
Abhijeet Prasad (AbhiPrasad) merged 1 commit into
mainfrom
abhi-new-integrations-api

Conversation

@AbhiPrasad

@AbhiPrasadAbhijeet Prasad (AbhiPrasad) commented Mar 23, 2026

Copy link
Copy Markdown
Member

This PR introduces a new integrations API for provider instrumentation (wrappers) and migrates Anthropic to it as the first implementation. The goal is to separate three concerns that were previously mixed together in individual wrappers:

  • integration discovery and version compatibility
  • patch selection and idempotent patch application
  • provider-specific tracing behavior

This PR is inspired by the current Ruby SDK implementation.

AI Summary

A new base integration layer lives under py/src/braintrust/integrations/. BaseIntegration is the orchestration class. It is responsible for:

  • probing whether an integration is installed
  • detecting the installed version
  • checking compatibility bounds
  • exposing the patchers available for that integration
  • resolving enabled_patchers / disabled_patchers
  • applying patchers in a deterministic, idempotent way

Conceptually, BaseIntegration.setup() is now the standard entry point for “instrument this library in the current process”.

BasePatcher is the unit of patch work. It represents one concrete patch strategy and is responsible for:

  • identifying itself with a stable patcher id
  • deciding whether it applies for the current runtime
  • checking whether its target is already patched
  • applying its patch once

This PR also adds FunctionWrapperPatcher, a reusable BasePatcher subclass for the common case where instrumentation is done with wrapt.wrap_function_wrapper against a single target path.

Supporting types added with this work:

  • IntegrationRuntime: normalized runtime facts for one integration (name, module, version)
  • IntegrationPatchConfig: user-facing config object for selecting patchers
  • versioning.py: a small stdlib-only helper for version detection and simple spec matching

Anthropic Migration

AnthropicIntegration defines:

  • name = "anthropic"
  • import_names = ("anthropic",)
  • min_version = "0.48.0"
  • two patchers:
    • anthropic.init.sync
    • anthropic.init.async

Those patchers wrap:

  • anthropic.Anthropic.__init__
  • anthropic.AsyncAnthropic.__init__

The constructor patching model is straightforward: after a client is constructed, Braintrust replaces the instance’s messages and beta.messages surfaces with traced wrappers. Those wrappers preserve Anthropic behavior while adding span creation, metadata capture, token metrics, time-to-first-token, stream aggregation, and error logging for sync, async, and streaming request paths.

This means the old Anthropic tracing logic did not disappear, but it was moved behind a cleaner integration boundary:

  • orchestration and patch selection now live in the integration layer
  • Anthropic-specific tracing remains local to the Anthropic implementation

The old braintrust.wrappers.anthropic module is now a compatibility shim that re-exports the new Anthropic wrapper entry points.

User-Facing Changes

The main user-facing change is that Anthropic instrumentation is now configurable instead of being strictly all-or-nothing.

Existing behavior still works:

importbraintrustbraintrust.auto_instrument()

Users can now also choose which Anthropic patchers to apply:

frombraintrustimportauto_instrumentfrombraintrust.integrationsimportIntegrationPatchConfigauto_instrument(
anthropic=IntegrationPatchConfig(
disabled_patchers={"anthropic.init.async"},
)
)

New public surfaces introduced by this PR:

  • braintrust.integrations.AnthropicIntegration
  • braintrust.integrations.IntegrationPatchConfig
  • braintrust.integrations.anthropic.wrap_anthropic

Existing exports:

  • braintrust.wrappers.anthropic.wrap_anthropic still works for compatibility

In practical terms, this PR is additive for users:

  • no intended breaking change for existing Anthropic wrapper usage
  • new ability to selectively instrument Anthropic sync vs async constructor paths
  • new public integration API that future providers can migrate onto

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we need to migrate all providers, should additional features for providers that haven't been migrated yet be postponed until their migration is done (unless there's an explicit customer request)?


Keep the class focused on orchestration. Provider-specific tracing logic should stay in `tracing.py`.

If the provider already supports direct instance wrapping, expose a `wrap(client)` method on the integration class that returns the traced client wrapper.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which providers do this?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I needed to update the skill - I deleted this .wrap stuff, will fix!

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I don't know if this is a plausible situation)

If some providers share a similar API and we could create some shared functions/classes to reduce LoC and improve code reuse, where should this shared code live?

Or maybe we don't want to have any code shared between providers?

@AbhiPrasad

Copy link
Copy Markdown
MemberAuthor

If some providers share a similar API and we could create some shared functions/classes to reduce LoC and improve code reuse, where should this shared code live?

We can just add a utility folder, or figure that out at this time.

@AbhiPrasad

Copy link
Copy Markdown
MemberAuthor

Since we need to migrate all providers, should additional features for providers that haven't been migrated yet be postponed until their migration is done

no, we can just do this on a case by case basis. Not that much activity on this repo, so we can get away with less merge conflicts.

Comment threadpy/src/braintrust/integrations/anthropic/__init__.py Outdated
Comment threadpy/src/braintrust/integrations/anthropic/patchers.py Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the CI is failing because the old tests are running against the new codebase and it has to be merged for the tests to be updated?

Good to merge

@AbhiPrasad

Copy link
Copy Markdown
MemberAuthor

I assume the CI is failing because the old tests are running against the new codebase and it has to be merged for the tests to be updated?

yeah I gotta fix that. Thanks for the review!

@AbhiPrasad
Abhijeet Prasad (AbhiPrasad) merged commit 363baa0 into mainMar 23, 2026
33 checks passed
@AbhiPrasad
Abhijeet Prasad (AbhiPrasad) deleted the abhi-new-integrations-api branch March 23, 2026 23:12
Abhijeet Prasad (AbhiPrasad) added a commit that referenced this pull request Mar 24, 2026
Convert the Google ADK (Agent Development Kit) instrumentation from the
legacy wrappers pattern to the new integrations API introduced in #118.
- Extract tracing helpers into integrations/adk/tracing.py
- Create ADK patchers (agent, runner, flow, mcp_tool) in patchers.py
- Add AdkIntegration class with proper registration
- Move tests and cassettes from wrappers/adk/ to integrations/adk/
- Move auto_instrument test script to integrations/auto_test_scripts/
- Slim down wrappers/adk/__init__.py to delegate to integrations
- Update noxfile.py with ADK integration test sessions
- Update integrations base and registry for ADK support
Abhijeet Prasad (AbhiPrasad) added a commit that referenced this pull request Mar 24, 2026
Convert the Google ADK (Agent Development Kit) instrumentation from the
legacy wrappers pattern to the new integrations API introduced in #118.
- Extract tracing helpers into integrations/adk/tracing.py
- Create ADK patchers (agent, runner, flow, mcp_tool) in patchers.py
- Add AdkIntegration class with proper registration
- Move tests and cassettes from wrappers/adk/ to integrations/adk/
- Move auto_instrument test script to integrations/auto_test_scripts/
- Slim down wrappers/adk/__init__.py to delegate to integrations
- Update noxfile.py with ADK integration test sessions
- Update integrations base and registry for ADK support
Abhijeet Prasad (AbhiPrasad) added a commit that referenced this pull request Mar 24, 2026
Convert the Google ADK (Agent Development Kit) instrumentation from the
legacy wrappers pattern to the new integrations API introduced in #118.
- Extract tracing helpers into integrations/adk/tracing.py
- Create ADK patchers (agent, runner, flow, mcp_tool) in patchers.py
- Add AdkIntegration class with proper registration
- Move tests and cassettes from wrappers/adk/ to integrations/adk/
- Move auto_instrument test script to integrations/auto_test_scripts/
- Slim down wrappers/adk/__init__.py to delegate to integrations
- Update noxfile.py with ADK integration test sessions
- Update integrations base and registry for ADK support
Abhijeet Prasad (AbhiPrasad) added a commit that referenced this pull request Mar 24, 2026
Convert the Google ADK (Agent Development Kit) instrumentation from the
legacy wrappers pattern to the new integrations API introduced in #118.
- Extract tracing helpers into integrations/adk/tracing.py
- Create ADK patchers (agent, runner, flow, mcp_tool) in patchers.py
- Add AdkIntegration class with proper registration
- Move tests and cassettes from wrappers/adk/ to integrations/adk/
- Move auto_instrument test script to integrations/auto_test_scripts/
- Slim down wrappers/adk/__init__.py to delegate to integrations
- Update noxfile.py with ADK integration test sessions
- Update integrations base and registry for ADK support
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@AbhiPrasad@viadezo1er
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat: Introduce new integrations API and convert anthropic - #118

Merged
Abhijeet Prasad (AbhiPrasad) merged 1 commit into
mainfrom
abhi-new-integrations-api
Mar 23, 2026
Merged

feat: Introduce new integrations API and convert anthropic#118
Abhijeet Prasad (AbhiPrasad) merged 1 commit into
mainfrom
abhi-new-integrations-api

Conversation

@AbhiPrasad

@AbhiPrasadAbhijeet Prasad (AbhiPrasad) commented Mar 23, 2026

Copy link
Copy Markdown
Member

This PR introduces a new integrations API for provider instrumentation (wrappers) and migrates Anthropic to it as the first implementation. The goal is to separate three concerns that were previously mixed together in individual wrappers:

  • integration discovery and version compatibility
  • patch selection and idempotent patch application
  • provider-specific tracing behavior

This PR is inspired by the current Ruby SDK implementation.

AI Summary

A new base integration layer lives under py/src/braintrust/integrations/. BaseIntegration is the orchestration class. It is responsible for:

  • probing whether an integration is installed
  • detecting the installed version
  • checking compatibility bounds
  • exposing the patchers available for that integration
  • resolving enabled_patchers / disabled_patchers
  • applying patchers in a deterministic, idempotent way

Conceptually, BaseIntegration.setup() is now the standard entry point for “instrument this library in the current process”.

BasePatcher is the unit of patch work. It represents one concrete patch strategy and is responsible for:

  • identifying itself with a stable patcher id
  • deciding whether it applies for the current runtime
  • checking whether its target is already patched
  • applying its patch once

This PR also adds FunctionWrapperPatcher, a reusable BasePatcher subclass for the common case where instrumentation is done with wrapt.wrap_function_wrapper against a single target path.

Supporting types added with this work:

  • IntegrationRuntime: normalized runtime facts for one integration (name, module, version)
  • IntegrationPatchConfig: user-facing config object for selecting patchers
  • versioning.py: a small stdlib-only helper for version detection and simple spec matching

Anthropic Migration

AnthropicIntegration defines:

  • name = "anthropic"
  • import_names = ("anthropic",)
  • min_version = "0.48.0"
  • two patchers:
    • anthropic.init.sync
    • anthropic.init.async

Those patchers wrap:

  • anthropic.Anthropic.__init__
  • anthropic.AsyncAnthropic.__init__

The constructor patching model is straightforward: after a client is constructed, Braintrust replaces the instance’s messages and beta.messages surfaces with traced wrappers. Those wrappers preserve Anthropic behavior while adding span creation, metadata capture, token metrics, time-to-first-token, stream aggregation, and error logging for sync, async, and streaming request paths.

This means the old Anthropic tracing logic did not disappear, but it was moved behind a cleaner integration boundary:

  • orchestration and patch selection now live in the integration layer
  • Anthropic-specific tracing remains local to the Anthropic implementation

The old braintrust.wrappers.anthropic module is now a compatibility shim that re-exports the new Anthropic wrapper entry points.

User-Facing Changes

The main user-facing change is that Anthropic instrumentation is now configurable instead of being strictly all-or-nothing.

Existing behavior still works:

importbraintrustbraintrust.auto_instrument()

Users can now also choose which Anthropic patchers to apply:

frombraintrustimportauto_instrumentfrombraintrust.integrationsimportIntegrationPatchConfigauto_instrument(
anthropic=IntegrationPatchConfig(
disabled_patchers={"anthropic.init.async"},
)
)

New public surfaces introduced by this PR:

  • braintrust.integrations.AnthropicIntegration
  • braintrust.integrations.IntegrationPatchConfig
  • braintrust.integrations.anthropic.wrap_anthropic

Existing exports:

  • braintrust.wrappers.anthropic.wrap_anthropic still works for compatibility

In practical terms, this PR is additive for users:

  • no intended breaking change for existing Anthropic wrapper usage
  • new ability to selectively instrument Anthropic sync vs async constructor paths
  • new public integration API that future providers can migrate onto

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we need to migrate all providers, should additional features for providers that haven't been migrated yet be postponed until their migration is done (unless there's an explicit customer request)?


Keep the class focused on orchestration. Provider-specific tracing logic should stay in `tracing.py`.

If the provider already supports direct instance wrapping, expose a `wrap(client)` method on the integration class that returns the traced client wrapper.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which providers do this?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I needed to update the skill - I deleted this .wrap stuff, will fix!

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I don't know if this is a plausible situation)

If some providers share a similar API and we could create some shared functions/classes to reduce LoC and improve code reuse, where should this shared code live?

Or maybe we don't want to have any code shared between providers?

@AbhiPrasad

Copy link
Copy Markdown
MemberAuthor

If some providers share a similar API and we could create some shared functions/classes to reduce LoC and improve code reuse, where should this shared code live?

We can just add a utility folder, or figure that out at this time.

@AbhiPrasad

Copy link
Copy Markdown
MemberAuthor

Since we need to migrate all providers, should additional features for providers that haven't been migrated yet be postponed until their migration is done

no, we can just do this on a case by case basis. Not that much activity on this repo, so we can get away with less merge conflicts.

Comment threadpy/src/braintrust/integrations/anthropic/__init__.py Outdated
Comment threadpy/src/braintrust/integrations/anthropic/patchers.py Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the CI is failing because the old tests are running against the new codebase and it has to be merged for the tests to be updated?

Good to merge

@AbhiPrasad

Copy link
Copy Markdown
MemberAuthor

I assume the CI is failing because the old tests are running against the new codebase and it has to be merged for the tests to be updated?

yeah I gotta fix that. Thanks for the review!

@AbhiPrasad
Abhijeet Prasad (AbhiPrasad) merged commit 363baa0 into mainMar 23, 2026
33 checks passed
@AbhiPrasad
Abhijeet Prasad (AbhiPrasad) deleted the abhi-new-integrations-api branch March 23, 2026 23:12
Abhijeet Prasad (AbhiPrasad) added a commit that referenced this pull request Mar 24, 2026
Convert the Google ADK (Agent Development Kit) instrumentation from the
legacy wrappers pattern to the new integrations API introduced in #118.
- Extract tracing helpers into integrations/adk/tracing.py
- Create ADK patchers (agent, runner, flow, mcp_tool) in patchers.py
- Add AdkIntegration class with proper registration
- Move tests and cassettes from wrappers/adk/ to integrations/adk/
- Move auto_instrument test script to integrations/auto_test_scripts/
- Slim down wrappers/adk/__init__.py to delegate to integrations
- Update noxfile.py with ADK integration test sessions
- Update integrations base and registry for ADK support
Abhijeet Prasad (AbhiPrasad) added a commit that referenced this pull request Mar 24, 2026
Convert the Google ADK (Agent Development Kit) instrumentation from the
legacy wrappers pattern to the new integrations API introduced in #118.
- Extract tracing helpers into integrations/adk/tracing.py
- Create ADK patchers (agent, runner, flow, mcp_tool) in patchers.py
- Add AdkIntegration class with proper registration
- Move tests and cassettes from wrappers/adk/ to integrations/adk/
- Move auto_instrument test script to integrations/auto_test_scripts/
- Slim down wrappers/adk/__init__.py to delegate to integrations
- Update noxfile.py with ADK integration test sessions
- Update integrations base and registry for ADK support
Abhijeet Prasad (AbhiPrasad) added a commit that referenced this pull request Mar 24, 2026
Convert the Google ADK (Agent Development Kit) instrumentation from the
legacy wrappers pattern to the new integrations API introduced in #118.
- Extract tracing helpers into integrations/adk/tracing.py
- Create ADK patchers (agent, runner, flow, mcp_tool) in patchers.py
- Add AdkIntegration class with proper registration
- Move tests and cassettes from wrappers/adk/ to integrations/adk/
- Move auto_instrument test script to integrations/auto_test_scripts/
- Slim down wrappers/adk/__init__.py to delegate to integrations
- Update noxfile.py with ADK integration test sessions
- Update integrations base and registry for ADK support
Abhijeet Prasad (AbhiPrasad) added a commit that referenced this pull request Mar 24, 2026
Convert the Google ADK (Agent Development Kit) instrumentation from the
legacy wrappers pattern to the new integrations API introduced in #118.
- Extract tracing helpers into integrations/adk/tracing.py
- Create ADK patchers (agent, runner, flow, mcp_tool) in patchers.py
- Add AdkIntegration class with proper registration
- Move tests and cassettes from wrappers/adk/ to integrations/adk/
- Move auto_instrument test script to integrations/auto_test_scripts/
- Slim down wrappers/adk/__init__.py to delegate to integrations
- Update noxfile.py with ADK integration test sessions
- Update integrations base and registry for ADK support
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@AbhiPrasad@viadezo1er
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat: Introduce new integrations API and convert anthropic - #118

Merged
Abhijeet Prasad (AbhiPrasad) merged 1 commit into
mainfrom
abhi-new-integrations-api
Mar 23, 2026
Merged

feat: Introduce new integrations API and convert anthropic#118
Abhijeet Prasad (AbhiPrasad) merged 1 commit into
mainfrom
abhi-new-integrations-api

Conversation

@AbhiPrasad

@AbhiPrasadAbhijeet Prasad (AbhiPrasad) commented Mar 23, 2026

Copy link
Copy Markdown
Member

This PR introduces a new integrations API for provider instrumentation (wrappers) and migrates Anthropic to it as the first implementation. The goal is to separate three concerns that were previously mixed together in individual wrappers:

  • integration discovery and version compatibility
  • patch selection and idempotent patch application
  • provider-specific tracing behavior

This PR is inspired by the current Ruby SDK implementation.

AI Summary

A new base integration layer lives under py/src/braintrust/integrations/. BaseIntegration is the orchestration class. It is responsible for:

  • probing whether an integration is installed
  • detecting the installed version
  • checking compatibility bounds
  • exposing the patchers available for that integration
  • resolving enabled_patchers / disabled_patchers
  • applying patchers in a deterministic, idempotent way

Conceptually, BaseIntegration.setup() is now the standard entry point for “instrument this library in the current process”.

BasePatcher is the unit of patch work. It represents one concrete patch strategy and is responsible for:

  • identifying itself with a stable patcher id
  • deciding whether it applies for the current runtime
  • checking whether its target is already patched
  • applying its patch once

This PR also adds FunctionWrapperPatcher, a reusable BasePatcher subclass for the common case where instrumentation is done with wrapt.wrap_function_wrapper against a single target path.

Supporting types added with this work:

  • IntegrationRuntime: normalized runtime facts for one integration (name, module, version)
  • IntegrationPatchConfig: user-facing config object for selecting patchers
  • versioning.py: a small stdlib-only helper for version detection and simple spec matching

Anthropic Migration

AnthropicIntegration defines:

  • name = "anthropic"
  • import_names = ("anthropic",)
  • min_version = "0.48.0"
  • two patchers:
    • anthropic.init.sync
    • anthropic.init.async

Those patchers wrap:

  • anthropic.Anthropic.__init__
  • anthropic.AsyncAnthropic.__init__

The constructor patching model is straightforward: after a client is constructed, Braintrust replaces the instance’s messages and beta.messages surfaces with traced wrappers. Those wrappers preserve Anthropic behavior while adding span creation, metadata capture, token metrics, time-to-first-token, stream aggregation, and error logging for sync, async, and streaming request paths.

This means the old Anthropic tracing logic did not disappear, but it was moved behind a cleaner integration boundary:

  • orchestration and patch selection now live in the integration layer
  • Anthropic-specific tracing remains local to the Anthropic implementation

The old braintrust.wrappers.anthropic module is now a compatibility shim that re-exports the new Anthropic wrapper entry points.

User-Facing Changes

The main user-facing change is that Anthropic instrumentation is now configurable instead of being strictly all-or-nothing.

Existing behavior still works:

importbraintrustbraintrust.auto_instrument()

Users can now also choose which Anthropic patchers to apply:

frombraintrustimportauto_instrumentfrombraintrust.integrationsimportIntegrationPatchConfigauto_instrument(
anthropic=IntegrationPatchConfig(
disabled_patchers={"anthropic.init.async"},
)
)

New public surfaces introduced by this PR:

  • braintrust.integrations.AnthropicIntegration
  • braintrust.integrations.IntegrationPatchConfig
  • braintrust.integrations.anthropic.wrap_anthropic

Existing exports:

  • braintrust.wrappers.anthropic.wrap_anthropic still works for compatibility

In practical terms, this PR is additive for users:

  • no intended breaking change for existing Anthropic wrapper usage
  • new ability to selectively instrument Anthropic sync vs async constructor paths
  • new public integration API that future providers can migrate onto

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we need to migrate all providers, should additional features for providers that haven't been migrated yet be postponed until their migration is done (unless there's an explicit customer request)?


Keep the class focused on orchestration. Provider-specific tracing logic should stay in `tracing.py`.

If the provider already supports direct instance wrapping, expose a `wrap(client)` method on the integration class that returns the traced client wrapper.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which providers do this?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I needed to update the skill - I deleted this .wrap stuff, will fix!

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I don't know if this is a plausible situation)

If some providers share a similar API and we could create some shared functions/classes to reduce LoC and improve code reuse, where should this shared code live?

Or maybe we don't want to have any code shared between providers?

@AbhiPrasad

Copy link
Copy Markdown
MemberAuthor

If some providers share a similar API and we could create some shared functions/classes to reduce LoC and improve code reuse, where should this shared code live?

We can just add a utility folder, or figure that out at this time.

@AbhiPrasad

Copy link
Copy Markdown
MemberAuthor

Since we need to migrate all providers, should additional features for providers that haven't been migrated yet be postponed until their migration is done

no, we can just do this on a case by case basis. Not that much activity on this repo, so we can get away with less merge conflicts.

Comment threadpy/src/braintrust/integrations/anthropic/__init__.py Outdated
Comment threadpy/src/braintrust/integrations/anthropic/patchers.py Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the CI is failing because the old tests are running against the new codebase and it has to be merged for the tests to be updated?

Good to merge

@AbhiPrasad

Copy link
Copy Markdown
MemberAuthor

I assume the CI is failing because the old tests are running against the new codebase and it has to be merged for the tests to be updated?

yeah I gotta fix that. Thanks for the review!

@AbhiPrasad
Abhijeet Prasad (AbhiPrasad) merged commit 363baa0 into mainMar 23, 2026
33 checks passed
@AbhiPrasad
Abhijeet Prasad (AbhiPrasad) deleted the abhi-new-integrations-api branch March 23, 2026 23:12
Abhijeet Prasad (AbhiPrasad) added a commit that referenced this pull request Mar 24, 2026
Convert the Google ADK (Agent Development Kit) instrumentation from the
legacy wrappers pattern to the new integrations API introduced in #118.
- Extract tracing helpers into integrations/adk/tracing.py
- Create ADK patchers (agent, runner, flow, mcp_tool) in patchers.py
- Add AdkIntegration class with proper registration
- Move tests and cassettes from wrappers/adk/ to integrations/adk/
- Move auto_instrument test script to integrations/auto_test_scripts/
- Slim down wrappers/adk/__init__.py to delegate to integrations
- Update noxfile.py with ADK integration test sessions
- Update integrations base and registry for ADK support
Abhijeet Prasad (AbhiPrasad) added a commit that referenced this pull request Mar 24, 2026
Convert the Google ADK (Agent Development Kit) instrumentation from the
legacy wrappers pattern to the new integrations API introduced in #118.
- Extract tracing helpers into integrations/adk/tracing.py
- Create ADK patchers (agent, runner, flow, mcp_tool) in patchers.py
- Add AdkIntegration class with proper registration
- Move tests and cassettes from wrappers/adk/ to integrations/adk/
- Move auto_instrument test script to integrations/auto_test_scripts/
- Slim down wrappers/adk/__init__.py to delegate to integrations
- Update noxfile.py with ADK integration test sessions
- Update integrations base and registry for ADK support
Abhijeet Prasad (AbhiPrasad) added a commit that referenced this pull request Mar 24, 2026
Convert the Google ADK (Agent Development Kit) instrumentation from the
legacy wrappers pattern to the new integrations API introduced in #118.
- Extract tracing helpers into integrations/adk/tracing.py
- Create ADK patchers (agent, runner, flow, mcp_tool) in patchers.py
- Add AdkIntegration class with proper registration
- Move tests and cassettes from wrappers/adk/ to integrations/adk/
- Move auto_instrument test script to integrations/auto_test_scripts/
- Slim down wrappers/adk/__init__.py to delegate to integrations
- Update noxfile.py with ADK integration test sessions
- Update integrations base and registry for ADK support
Abhijeet Prasad (AbhiPrasad) added a commit that referenced this pull request Mar 24, 2026
Convert the Google ADK (Agent Development Kit) instrumentation from the
legacy wrappers pattern to the new integrations API introduced in #118.
- Extract tracing helpers into integrations/adk/tracing.py
- Create ADK patchers (agent, runner, flow, mcp_tool) in patchers.py
- Add AdkIntegration class with proper registration
- Move tests and cassettes from wrappers/adk/ to integrations/adk/
- Move auto_instrument test script to integrations/auto_test_scripts/
- Slim down wrappers/adk/__init__.py to delegate to integrations
- Update noxfile.py with ADK integration test sessions
- Update integrations base and registry for ADK support
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@AbhiPrasad@viadezo1er
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

feat: Introduce new integrations API and convert anthropic - #118

Merged
Abhijeet Prasad (AbhiPrasad) merged 1 commit into
mainfrom
abhi-new-integrations-api
Mar 23, 2026
Merged

feat: Introduce new integrations API and convert anthropic#118
Abhijeet Prasad (AbhiPrasad) merged 1 commit into
mainfrom
abhi-new-integrations-api

Conversation

@AbhiPrasad

@AbhiPrasadAbhijeet Prasad (AbhiPrasad) commented Mar 23, 2026

Copy link
Copy Markdown
Member

This PR introduces a new integrations API for provider instrumentation (wrappers) and migrates Anthropic to it as the first implementation. The goal is to separate three concerns that were previously mixed together in individual wrappers:

  • integration discovery and version compatibility
  • patch selection and idempotent patch application
  • provider-specific tracing behavior

This PR is inspired by the current Ruby SDK implementation.

AI Summary

A new base integration layer lives under py/src/braintrust/integrations/. BaseIntegration is the orchestration class. It is responsible for:

  • probing whether an integration is installed
  • detecting the installed version
  • checking compatibility bounds
  • exposing the patchers available for that integration
  • resolving enabled_patchers / disabled_patchers
  • applying patchers in a deterministic, idempotent way

Conceptually, BaseIntegration.setup() is now the standard entry point for “instrument this library in the current process”.

BasePatcher is the unit of patch work. It represents one concrete patch strategy and is responsible for:

  • identifying itself with a stable patcher id
  • deciding whether it applies for the current runtime
  • checking whether its target is already patched
  • applying its patch once

This PR also adds FunctionWrapperPatcher, a reusable BasePatcher subclass for the common case where instrumentation is done with wrapt.wrap_function_wrapper against a single target path.

Supporting types added with this work:

  • IntegrationRuntime: normalized runtime facts for one integration (name, module, version)
  • IntegrationPatchConfig: user-facing config object for selecting patchers
  • versioning.py: a small stdlib-only helper for version detection and simple spec matching

Anthropic Migration

AnthropicIntegration defines:

  • name = "anthropic"
  • import_names = ("anthropic",)
  • min_version = "0.48.0"
  • two patchers:
    • anthropic.init.sync
    • anthropic.init.async

Those patchers wrap:

  • anthropic.Anthropic.__init__
  • anthropic.AsyncAnthropic.__init__

The constructor patching model is straightforward: after a client is constructed, Braintrust replaces the instance’s messages and beta.messages surfaces with traced wrappers. Those wrappers preserve Anthropic behavior while adding span creation, metadata capture, token metrics, time-to-first-token, stream aggregation, and error logging for sync, async, and streaming request paths.

This means the old Anthropic tracing logic did not disappear, but it was moved behind a cleaner integration boundary:

  • orchestration and patch selection now live in the integration layer
  • Anthropic-specific tracing remains local to the Anthropic implementation

The old braintrust.wrappers.anthropic module is now a compatibility shim that re-exports the new Anthropic wrapper entry points.

User-Facing Changes

The main user-facing change is that Anthropic instrumentation is now configurable instead of being strictly all-or-nothing.

Existing behavior still works:

importbraintrustbraintrust.auto_instrument()

Users can now also choose which Anthropic patchers to apply:

frombraintrustimportauto_instrumentfrombraintrust.integrationsimportIntegrationPatchConfigauto_instrument(
anthropic=IntegrationPatchConfig(
disabled_patchers={"anthropic.init.async"},
)
)

New public surfaces introduced by this PR:

  • braintrust.integrations.AnthropicIntegration
  • braintrust.integrations.IntegrationPatchConfig
  • braintrust.integrations.anthropic.wrap_anthropic

Existing exports:

  • braintrust.wrappers.anthropic.wrap_anthropic still works for compatibility

In practical terms, this PR is additive for users:

  • no intended breaking change for existing Anthropic wrapper usage
  • new ability to selectively instrument Anthropic sync vs async constructor paths
  • new public integration API that future providers can migrate onto

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we need to migrate all providers, should additional features for providers that haven't been migrated yet be postponed until their migration is done (unless there's an explicit customer request)?


Keep the class focused on orchestration. Provider-specific tracing logic should stay in `tracing.py`.

If the provider already supports direct instance wrapping, expose a `wrap(client)` method on the integration class that returns the traced client wrapper.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which providers do this?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I needed to update the skill - I deleted this .wrap stuff, will fix!

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I don't know if this is a plausible situation)

If some providers share a similar API and we could create some shared functions/classes to reduce LoC and improve code reuse, where should this shared code live?

Or maybe we don't want to have any code shared between providers?

@AbhiPrasad

Copy link
Copy Markdown
MemberAuthor

If some providers share a similar API and we could create some shared functions/classes to reduce LoC and improve code reuse, where should this shared code live?

We can just add a utility folder, or figure that out at this time.

@AbhiPrasad

Copy link
Copy Markdown
MemberAuthor

Since we need to migrate all providers, should additional features for providers that haven't been migrated yet be postponed until their migration is done

no, we can just do this on a case by case basis. Not that much activity on this repo, so we can get away with less merge conflicts.

Comment threadpy/src/braintrust/integrations/anthropic/__init__.py Outdated
Comment threadpy/src/braintrust/integrations/anthropic/patchers.py Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the CI is failing because the old tests are running against the new codebase and it has to be merged for the tests to be updated?

Good to merge

@AbhiPrasad

Copy link
Copy Markdown
MemberAuthor

I assume the CI is failing because the old tests are running against the new codebase and it has to be merged for the tests to be updated?

yeah I gotta fix that. Thanks for the review!

@AbhiPrasad
Abhijeet Prasad (AbhiPrasad) merged commit 363baa0 into mainMar 23, 2026
33 checks passed
@AbhiPrasad
Abhijeet Prasad (AbhiPrasad) deleted the abhi-new-integrations-api branch March 23, 2026 23:12
Abhijeet Prasad (AbhiPrasad) added a commit that referenced this pull request Mar 24, 2026
Convert the Google ADK (Agent Development Kit) instrumentation from the
legacy wrappers pattern to the new integrations API introduced in #118.
- Extract tracing helpers into integrations/adk/tracing.py
- Create ADK patchers (agent, runner, flow, mcp_tool) in patchers.py
- Add AdkIntegration class with proper registration
- Move tests and cassettes from wrappers/adk/ to integrations/adk/
- Move auto_instrument test script to integrations/auto_test_scripts/
- Slim down wrappers/adk/__init__.py to delegate to integrations
- Update noxfile.py with ADK integration test sessions
- Update integrations base and registry for ADK support
Abhijeet Prasad (AbhiPrasad) added a commit that referenced this pull request Mar 24, 2026
Convert the Google ADK (Agent Development Kit) instrumentation from the
legacy wrappers pattern to the new integrations API introduced in #118.
- Extract tracing helpers into integrations/adk/tracing.py
- Create ADK patchers (agent, runner, flow, mcp_tool) in patchers.py
- Add AdkIntegration class with proper registration
- Move tests and cassettes from wrappers/adk/ to integrations/adk/
- Move auto_instrument test script to integrations/auto_test_scripts/
- Slim down wrappers/adk/__init__.py to delegate to integrations
- Update noxfile.py with ADK integration test sessions
- Update integrations base and registry for ADK support
Abhijeet Prasad (AbhiPrasad) added a commit that referenced this pull request Mar 24, 2026
Convert the Google ADK (Agent Development Kit) instrumentation from the
legacy wrappers pattern to the new integrations API introduced in #118.
- Extract tracing helpers into integrations/adk/tracing.py
- Create ADK patchers (agent, runner, flow, mcp_tool) in patchers.py
- Add AdkIntegration class with proper registration
- Move tests and cassettes from wrappers/adk/ to integrations/adk/
- Move auto_instrument test script to integrations/auto_test_scripts/
- Slim down wrappers/adk/__init__.py to delegate to integrations
- Update noxfile.py with ADK integration test sessions
- Update integrations base and registry for ADK support
Abhijeet Prasad (AbhiPrasad) added a commit that referenced this pull request Mar 24, 2026
Convert the Google ADK (Agent Development Kit) instrumentation from the
legacy wrappers pattern to the new integrations API introduced in #118.
- Extract tracing helpers into integrations/adk/tracing.py
- Create ADK patchers (agent, runner, flow, mcp_tool) in patchers.py
- Add AdkIntegration class with proper registration
- Move tests and cassettes from wrappers/adk/ to integrations/adk/
- Move auto_instrument test script to integrations/auto_test_scripts/
- Slim down wrappers/adk/__init__.py to delegate to integrations
- Update noxfile.py with ADK integration test sessions
- Update integrations base and registry for ADK support
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@AbhiPrasad@viadezo1er
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat: Introduce new integrations API and convert anthropic - #118

Merged
Abhijeet Prasad (AbhiPrasad) merged 1 commit into
mainfrom
abhi-new-integrations-api
Mar 23, 2026
Merged

feat: Introduce new integrations API and convert anthropic#118
Abhijeet Prasad (AbhiPrasad) merged 1 commit into
mainfrom
abhi-new-integrations-api

Conversation

@AbhiPrasad

@AbhiPrasadAbhijeet Prasad (AbhiPrasad) commented Mar 23, 2026

Copy link
Copy Markdown
Member

This PR introduces a new integrations API for provider instrumentation (wrappers) and migrates Anthropic to it as the first implementation. The goal is to separate three concerns that were previously mixed together in individual wrappers:

  • integration discovery and version compatibility
  • patch selection and idempotent patch application
  • provider-specific tracing behavior

This PR is inspired by the current Ruby SDK implementation.

AI Summary

A new base integration layer lives under py/src/braintrust/integrations/. BaseIntegration is the orchestration class. It is responsible for:

  • probing whether an integration is installed
  • detecting the installed version
  • checking compatibility bounds
  • exposing the patchers available for that integration
  • resolving enabled_patchers / disabled_patchers
  • applying patchers in a deterministic, idempotent way

Conceptually, BaseIntegration.setup() is now the standard entry point for “instrument this library in the current process”.

BasePatcher is the unit of patch work. It represents one concrete patch strategy and is responsible for:

  • identifying itself with a stable patcher id
  • deciding whether it applies for the current runtime
  • checking whether its target is already patched
  • applying its patch once

This PR also adds FunctionWrapperPatcher, a reusable BasePatcher subclass for the common case where instrumentation is done with wrapt.wrap_function_wrapper against a single target path.

Supporting types added with this work:

  • IntegrationRuntime: normalized runtime facts for one integration (name, module, version)
  • IntegrationPatchConfig: user-facing config object for selecting patchers
  • versioning.py: a small stdlib-only helper for version detection and simple spec matching

Anthropic Migration

AnthropicIntegration defines:

  • name = "anthropic"
  • import_names = ("anthropic",)
  • min_version = "0.48.0"
  • two patchers:
    • anthropic.init.sync
    • anthropic.init.async

Those patchers wrap:

  • anthropic.Anthropic.__init__
  • anthropic.AsyncAnthropic.__init__

The constructor patching model is straightforward: after a client is constructed, Braintrust replaces the instance’s messages and beta.messages surfaces with traced wrappers. Those wrappers preserve Anthropic behavior while adding span creation, metadata capture, token metrics, time-to-first-token, stream aggregation, and error logging for sync, async, and streaming request paths.

This means the old Anthropic tracing logic did not disappear, but it was moved behind a cleaner integration boundary:

  • orchestration and patch selection now live in the integration layer
  • Anthropic-specific tracing remains local to the Anthropic implementation

The old braintrust.wrappers.anthropic module is now a compatibility shim that re-exports the new Anthropic wrapper entry points.

User-Facing Changes

The main user-facing change is that Anthropic instrumentation is now configurable instead of being strictly all-or-nothing.

Existing behavior still works:

importbraintrustbraintrust.auto_instrument()

Users can now also choose which Anthropic patchers to apply:

frombraintrustimportauto_instrumentfrombraintrust.integrationsimportIntegrationPatchConfigauto_instrument(
anthropic=IntegrationPatchConfig(
disabled_patchers={"anthropic.init.async"},
)
)

New public surfaces introduced by this PR:

  • braintrust.integrations.AnthropicIntegration
  • braintrust.integrations.IntegrationPatchConfig
  • braintrust.integrations.anthropic.wrap_anthropic

Existing exports:

  • braintrust.wrappers.anthropic.wrap_anthropic still works for compatibility

In practical terms, this PR is additive for users:

  • no intended breaking change for existing Anthropic wrapper usage
  • new ability to selectively instrument Anthropic sync vs async constructor paths
  • new public integration API that future providers can migrate onto

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we need to migrate all providers, should additional features for providers that haven't been migrated yet be postponed until their migration is done (unless there's an explicit customer request)?


Keep the class focused on orchestration. Provider-specific tracing logic should stay in `tracing.py`.

If the provider already supports direct instance wrapping, expose a `wrap(client)` method on the integration class that returns the traced client wrapper.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which providers do this?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I needed to update the skill - I deleted this .wrap stuff, will fix!

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I don't know if this is a plausible situation)

If some providers share a similar API and we could create some shared functions/classes to reduce LoC and improve code reuse, where should this shared code live?

Or maybe we don't want to have any code shared between providers?

@AbhiPrasad

Copy link
Copy Markdown
MemberAuthor

If some providers share a similar API and we could create some shared functions/classes to reduce LoC and improve code reuse, where should this shared code live?

We can just add a utility folder, or figure that out at this time.

@AbhiPrasad

Copy link
Copy Markdown
MemberAuthor

Since we need to migrate all providers, should additional features for providers that haven't been migrated yet be postponed until their migration is done

no, we can just do this on a case by case basis. Not that much activity on this repo, so we can get away with less merge conflicts.

Comment threadpy/src/braintrust/integrations/anthropic/__init__.py Outdated
Comment threadpy/src/braintrust/integrations/anthropic/patchers.py Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the CI is failing because the old tests are running against the new codebase and it has to be merged for the tests to be updated?

Good to merge

@AbhiPrasad

Copy link
Copy Markdown
MemberAuthor

I assume the CI is failing because the old tests are running against the new codebase and it has to be merged for the tests to be updated?

yeah I gotta fix that. Thanks for the review!

@AbhiPrasad
Abhijeet Prasad (AbhiPrasad) merged commit 363baa0 into mainMar 23, 2026
33 checks passed
@AbhiPrasad
Abhijeet Prasad (AbhiPrasad) deleted the abhi-new-integrations-api branch March 23, 2026 23:12
Abhijeet Prasad (AbhiPrasad) added a commit that referenced this pull request Mar 24, 2026
Convert the Google ADK (Agent Development Kit) instrumentation from the
legacy wrappers pattern to the new integrations API introduced in #118.
- Extract tracing helpers into integrations/adk/tracing.py
- Create ADK patchers (agent, runner, flow, mcp_tool) in patchers.py
- Add AdkIntegration class with proper registration
- Move tests and cassettes from wrappers/adk/ to integrations/adk/
- Move auto_instrument test script to integrations/auto_test_scripts/
- Slim down wrappers/adk/__init__.py to delegate to integrations
- Update noxfile.py with ADK integration test sessions
- Update integrations base and registry for ADK support
Abhijeet Prasad (AbhiPrasad) added a commit that referenced this pull request Mar 24, 2026
Convert the Google ADK (Agent Development Kit) instrumentation from the
legacy wrappers pattern to the new integrations API introduced in #118.
- Extract tracing helpers into integrations/adk/tracing.py
- Create ADK patchers (agent, runner, flow, mcp_tool) in patchers.py
- Add AdkIntegration class with proper registration
- Move tests and cassettes from wrappers/adk/ to integrations/adk/
- Move auto_instrument test script to integrations/auto_test_scripts/
- Slim down wrappers/adk/__init__.py to delegate to integrations
- Update noxfile.py with ADK integration test sessions
- Update integrations base and registry for ADK support
Abhijeet Prasad (AbhiPrasad) added a commit that referenced this pull request Mar 24, 2026
Convert the Google ADK (Agent Development Kit) instrumentation from the
legacy wrappers pattern to the new integrations API introduced in #118.
- Extract tracing helpers into integrations/adk/tracing.py
- Create ADK patchers (agent, runner, flow, mcp_tool) in patchers.py
- Add AdkIntegration class with proper registration
- Move tests and cassettes from wrappers/adk/ to integrations/adk/
- Move auto_instrument test script to integrations/auto_test_scripts/
- Slim down wrappers/adk/__init__.py to delegate to integrations
- Update noxfile.py with ADK integration test sessions
- Update integrations base and registry for ADK support
Abhijeet Prasad (AbhiPrasad) added a commit that referenced this pull request Mar 24, 2026
Convert the Google ADK (Agent Development Kit) instrumentation from the
legacy wrappers pattern to the new integrations API introduced in #118.
- Extract tracing helpers into integrations/adk/tracing.py
- Create ADK patchers (agent, runner, flow, mcp_tool) in patchers.py
- Add AdkIntegration class with proper registration
- Move tests and cassettes from wrappers/adk/ to integrations/adk/
- Move auto_instrument test script to integrations/auto_test_scripts/
- Slim down wrappers/adk/__init__.py to delegate to integrations
- Update noxfile.py with ADK integration test sessions
- Update integrations base and registry for ADK support
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@AbhiPrasad@viadezo1er
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat: Introduce new integrations API and convert anthropic - #118

Merged
Abhijeet Prasad (AbhiPrasad) merged 1 commit into
mainfrom
abhi-new-integrations-api
Mar 23, 2026
Merged

feat: Introduce new integrations API and convert anthropic#118
Abhijeet Prasad (AbhiPrasad) merged 1 commit into
mainfrom
abhi-new-integrations-api

Conversation

@AbhiPrasad

@AbhiPrasadAbhijeet Prasad (AbhiPrasad) commented Mar 23, 2026

Copy link
Copy Markdown
Member

This PR introduces a new integrations API for provider instrumentation (wrappers) and migrates Anthropic to it as the first implementation. The goal is to separate three concerns that were previously mixed together in individual wrappers:

  • integration discovery and version compatibility
  • patch selection and idempotent patch application
  • provider-specific tracing behavior

This PR is inspired by the current Ruby SDK implementation.

AI Summary

A new base integration layer lives under py/src/braintrust/integrations/. BaseIntegration is the orchestration class. It is responsible for:

  • probing whether an integration is installed
  • detecting the installed version
  • checking compatibility bounds
  • exposing the patchers available for that integration
  • resolving enabled_patchers / disabled_patchers
  • applying patchers in a deterministic, idempotent way

Conceptually, BaseIntegration.setup() is now the standard entry point for “instrument this library in the current process”.

BasePatcher is the unit of patch work. It represents one concrete patch strategy and is responsible for:

  • identifying itself with a stable patcher id
  • deciding whether it applies for the current runtime
  • checking whether its target is already patched
  • applying its patch once

This PR also adds FunctionWrapperPatcher, a reusable BasePatcher subclass for the common case where instrumentation is done with wrapt.wrap_function_wrapper against a single target path.

Supporting types added with this work:

  • IntegrationRuntime: normalized runtime facts for one integration (name, module, version)
  • IntegrationPatchConfig: user-facing config object for selecting patchers
  • versioning.py: a small stdlib-only helper for version detection and simple spec matching

Anthropic Migration

AnthropicIntegration defines:

  • name = "anthropic"
  • import_names = ("anthropic",)
  • min_version = "0.48.0"
  • two patchers:
    • anthropic.init.sync
    • anthropic.init.async

Those patchers wrap:

  • anthropic.Anthropic.__init__
  • anthropic.AsyncAnthropic.__init__

The constructor patching model is straightforward: after a client is constructed, Braintrust replaces the instance’s messages and beta.messages surfaces with traced wrappers. Those wrappers preserve Anthropic behavior while adding span creation, metadata capture, token metrics, time-to-first-token, stream aggregation, and error logging for sync, async, and streaming request paths.

This means the old Anthropic tracing logic did not disappear, but it was moved behind a cleaner integration boundary:

  • orchestration and patch selection now live in the integration layer
  • Anthropic-specific tracing remains local to the Anthropic implementation

The old braintrust.wrappers.anthropic module is now a compatibility shim that re-exports the new Anthropic wrapper entry points.

User-Facing Changes

The main user-facing change is that Anthropic instrumentation is now configurable instead of being strictly all-or-nothing.

Existing behavior still works:

importbraintrustbraintrust.auto_instrument()

Users can now also choose which Anthropic patchers to apply:

frombraintrustimportauto_instrumentfrombraintrust.integrationsimportIntegrationPatchConfigauto_instrument(
anthropic=IntegrationPatchConfig(
disabled_patchers={"anthropic.init.async"},
)
)

New public surfaces introduced by this PR:

  • braintrust.integrations.AnthropicIntegration
  • braintrust.integrations.IntegrationPatchConfig
  • braintrust.integrations.anthropic.wrap_anthropic

Existing exports:

  • braintrust.wrappers.anthropic.wrap_anthropic still works for compatibility

In practical terms, this PR is additive for users:

  • no intended breaking change for existing Anthropic wrapper usage
  • new ability to selectively instrument Anthropic sync vs async constructor paths
  • new public integration API that future providers can migrate onto

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we need to migrate all providers, should additional features for providers that haven't been migrated yet be postponed until their migration is done (unless there's an explicit customer request)?


Keep the class focused on orchestration. Provider-specific tracing logic should stay in `tracing.py`.

If the provider already supports direct instance wrapping, expose a `wrap(client)` method on the integration class that returns the traced client wrapper.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which providers do this?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I needed to update the skill - I deleted this .wrap stuff, will fix!

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I don't know if this is a plausible situation)

If some providers share a similar API and we could create some shared functions/classes to reduce LoC and improve code reuse, where should this shared code live?

Or maybe we don't want to have any code shared between providers?

@AbhiPrasad

Copy link
Copy Markdown
MemberAuthor

If some providers share a similar API and we could create some shared functions/classes to reduce LoC and improve code reuse, where should this shared code live?

We can just add a utility folder, or figure that out at this time.

@AbhiPrasad

Copy link
Copy Markdown
MemberAuthor

Since we need to migrate all providers, should additional features for providers that haven't been migrated yet be postponed until their migration is done

no, we can just do this on a case by case basis. Not that much activity on this repo, so we can get away with less merge conflicts.

Comment threadpy/src/braintrust/integrations/anthropic/__init__.py Outdated
Comment threadpy/src/braintrust/integrations/anthropic/patchers.py Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the CI is failing because the old tests are running against the new codebase and it has to be merged for the tests to be updated?

Good to merge

@AbhiPrasad

Copy link
Copy Markdown
MemberAuthor

I assume the CI is failing because the old tests are running against the new codebase and it has to be merged for the tests to be updated?

yeah I gotta fix that. Thanks for the review!

@AbhiPrasad
Abhijeet Prasad (AbhiPrasad) merged commit 363baa0 into mainMar 23, 2026
33 checks passed
@AbhiPrasad
Abhijeet Prasad (AbhiPrasad) deleted the abhi-new-integrations-api branch March 23, 2026 23:12
Abhijeet Prasad (AbhiPrasad) added a commit that referenced this pull request Mar 24, 2026
Convert the Google ADK (Agent Development Kit) instrumentation from the
legacy wrappers pattern to the new integrations API introduced in #118.
- Extract tracing helpers into integrations/adk/tracing.py
- Create ADK patchers (agent, runner, flow, mcp_tool) in patchers.py
- Add AdkIntegration class with proper registration
- Move tests and cassettes from wrappers/adk/ to integrations/adk/
- Move auto_instrument test script to integrations/auto_test_scripts/
- Slim down wrappers/adk/__init__.py to delegate to integrations
- Update noxfile.py with ADK integration test sessions
- Update integrations base and registry for ADK support
Abhijeet Prasad (AbhiPrasad) added a commit that referenced this pull request Mar 24, 2026
Convert the Google ADK (Agent Development Kit) instrumentation from the
legacy wrappers pattern to the new integrations API introduced in #118.
- Extract tracing helpers into integrations/adk/tracing.py
- Create ADK patchers (agent, runner, flow, mcp_tool) in patchers.py
- Add AdkIntegration class with proper registration
- Move tests and cassettes from wrappers/adk/ to integrations/adk/
- Move auto_instrument test script to integrations/auto_test_scripts/
- Slim down wrappers/adk/__init__.py to delegate to integrations
- Update noxfile.py with ADK integration test sessions
- Update integrations base and registry for ADK support
Abhijeet Prasad (AbhiPrasad) added a commit that referenced this pull request Mar 24, 2026
Convert the Google ADK (Agent Development Kit) instrumentation from the
legacy wrappers pattern to the new integrations API introduced in #118.
- Extract tracing helpers into integrations/adk/tracing.py
- Create ADK patchers (agent, runner, flow, mcp_tool) in patchers.py
- Add AdkIntegration class with proper registration
- Move tests and cassettes from wrappers/adk/ to integrations/adk/
- Move auto_instrument test script to integrations/auto_test_scripts/
- Slim down wrappers/adk/__init__.py to delegate to integrations
- Update noxfile.py with ADK integration test sessions
- Update integrations base and registry for ADK support
Abhijeet Prasad (AbhiPrasad) added a commit that referenced this pull request Mar 24, 2026
Convert the Google ADK (Agent Development Kit) instrumentation from the
legacy wrappers pattern to the new integrations API introduced in #118.
- Extract tracing helpers into integrations/adk/tracing.py
- Create ADK patchers (agent, runner, flow, mcp_tool) in patchers.py
- Add AdkIntegration class with proper registration
- Move tests and cassettes from wrappers/adk/ to integrations/adk/
- Move auto_instrument test script to integrations/auto_test_scripts/
- Slim down wrappers/adk/__init__.py to delegate to integrations
- Update noxfile.py with ADK integration test sessions
- Update integrations base and registry for ADK support
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@AbhiPrasad@viadezo1er
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

feat: Introduce new integrations API and convert anthropic - #118

Merged
Abhijeet Prasad (AbhiPrasad) merged 1 commit into
mainfrom
abhi-new-integrations-api
Mar 23, 2026
Merged

feat: Introduce new integrations API and convert anthropic#118
Abhijeet Prasad (AbhiPrasad) merged 1 commit into
mainfrom
abhi-new-integrations-api

Conversation

@AbhiPrasad

@AbhiPrasadAbhijeet Prasad (AbhiPrasad) commented Mar 23, 2026

Copy link
Copy Markdown
Member

This PR introduces a new integrations API for provider instrumentation (wrappers) and migrates Anthropic to it as the first implementation. The goal is to separate three concerns that were previously mixed together in individual wrappers:

  • integration discovery and version compatibility
  • patch selection and idempotent patch application
  • provider-specific tracing behavior

This PR is inspired by the current Ruby SDK implementation.

AI Summary

A new base integration layer lives under py/src/braintrust/integrations/. BaseIntegration is the orchestration class. It is responsible for:

  • probing whether an integration is installed
  • detecting the installed version
  • checking compatibility bounds
  • exposing the patchers available for that integration
  • resolving enabled_patchers / disabled_patchers
  • applying patchers in a deterministic, idempotent way

Conceptually, BaseIntegration.setup() is now the standard entry point for “instrument this library in the current process”.

BasePatcher is the unit of patch work. It represents one concrete patch strategy and is responsible for:

  • identifying itself with a stable patcher id
  • deciding whether it applies for the current runtime
  • checking whether its target is already patched
  • applying its patch once

This PR also adds FunctionWrapperPatcher, a reusable BasePatcher subclass for the common case where instrumentation is done with wrapt.wrap_function_wrapper against a single target path.

Supporting types added with this work:

  • IntegrationRuntime: normalized runtime facts for one integration (name, module, version)
  • IntegrationPatchConfig: user-facing config object for selecting patchers
  • versioning.py: a small stdlib-only helper for version detection and simple spec matching

Anthropic Migration

AnthropicIntegration defines:

  • name = "anthropic"
  • import_names = ("anthropic",)
  • min_version = "0.48.0"
  • two patchers:
    • anthropic.init.sync
    • anthropic.init.async

Those patchers wrap:

  • anthropic.Anthropic.__init__
  • anthropic.AsyncAnthropic.__init__

The constructor patching model is straightforward: after a client is constructed, Braintrust replaces the instance’s messages and beta.messages surfaces with traced wrappers. Those wrappers preserve Anthropic behavior while adding span creation, metadata capture, token metrics, time-to-first-token, stream aggregation, and error logging for sync, async, and streaming request paths.

This means the old Anthropic tracing logic did not disappear, but it was moved behind a cleaner integration boundary:

  • orchestration and patch selection now live in the integration layer
  • Anthropic-specific tracing remains local to the Anthropic implementation

The old braintrust.wrappers.anthropic module is now a compatibility shim that re-exports the new Anthropic wrapper entry points.

User-Facing Changes

The main user-facing change is that Anthropic instrumentation is now configurable instead of being strictly all-or-nothing.

Existing behavior still works:

importbraintrustbraintrust.auto_instrument()

Users can now also choose which Anthropic patchers to apply:

frombraintrustimportauto_instrumentfrombraintrust.integrationsimportIntegrationPatchConfigauto_instrument(
anthropic=IntegrationPatchConfig(
disabled_patchers={"anthropic.init.async"},
)
)

New public surfaces introduced by this PR:

  • braintrust.integrations.AnthropicIntegration
  • braintrust.integrations.IntegrationPatchConfig
  • braintrust.integrations.anthropic.wrap_anthropic

Existing exports:

  • braintrust.wrappers.anthropic.wrap_anthropic still works for compatibility

In practical terms, this PR is additive for users:

  • no intended breaking change for existing Anthropic wrapper usage
  • new ability to selectively instrument Anthropic sync vs async constructor paths
  • new public integration API that future providers can migrate onto

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we need to migrate all providers, should additional features for providers that haven't been migrated yet be postponed until their migration is done (unless there's an explicit customer request)?


Keep the class focused on orchestration. Provider-specific tracing logic should stay in `tracing.py`.

If the provider already supports direct instance wrapping, expose a `wrap(client)` method on the integration class that returns the traced client wrapper.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which providers do this?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I needed to update the skill - I deleted this .wrap stuff, will fix!

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I don't know if this is a plausible situation)

If some providers share a similar API and we could create some shared functions/classes to reduce LoC and improve code reuse, where should this shared code live?

Or maybe we don't want to have any code shared between providers?

@AbhiPrasad

Copy link
Copy Markdown
MemberAuthor

If some providers share a similar API and we could create some shared functions/classes to reduce LoC and improve code reuse, where should this shared code live?

We can just add a utility folder, or figure that out at this time.

@AbhiPrasad

Copy link
Copy Markdown
MemberAuthor

Since we need to migrate all providers, should additional features for providers that haven't been migrated yet be postponed until their migration is done

no, we can just do this on a case by case basis. Not that much activity on this repo, so we can get away with less merge conflicts.

Comment threadpy/src/braintrust/integrations/anthropic/__init__.py Outdated
Comment threadpy/src/braintrust/integrations/anthropic/patchers.py Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the CI is failing because the old tests are running against the new codebase and it has to be merged for the tests to be updated?

Good to merge

@AbhiPrasad

Copy link
Copy Markdown
MemberAuthor

I assume the CI is failing because the old tests are running against the new codebase and it has to be merged for the tests to be updated?

yeah I gotta fix that. Thanks for the review!

@AbhiPrasad
Abhijeet Prasad (AbhiPrasad) merged commit 363baa0 into mainMar 23, 2026
33 checks passed
@AbhiPrasad
Abhijeet Prasad (AbhiPrasad) deleted the abhi-new-integrations-api branch March 23, 2026 23:12
Abhijeet Prasad (AbhiPrasad) added a commit that referenced this pull request Mar 24, 2026
Convert the Google ADK (Agent Development Kit) instrumentation from the
legacy wrappers pattern to the new integrations API introduced in #118.
- Extract tracing helpers into integrations/adk/tracing.py
- Create ADK patchers (agent, runner, flow, mcp_tool) in patchers.py
- Add AdkIntegration class with proper registration
- Move tests and cassettes from wrappers/adk/ to integrations/adk/
- Move auto_instrument test script to integrations/auto_test_scripts/
- Slim down wrappers/adk/__init__.py to delegate to integrations
- Update noxfile.py with ADK integration test sessions
- Update integrations base and registry for ADK support
Abhijeet Prasad (AbhiPrasad) added a commit that referenced this pull request Mar 24, 2026
Convert the Google ADK (Agent Development Kit) instrumentation from the
legacy wrappers pattern to the new integrations API introduced in #118.
- Extract tracing helpers into integrations/adk/tracing.py
- Create ADK patchers (agent, runner, flow, mcp_tool) in patchers.py
- Add AdkIntegration class with proper registration
- Move tests and cassettes from wrappers/adk/ to integrations/adk/
- Move auto_instrument test script to integrations/auto_test_scripts/
- Slim down wrappers/adk/__init__.py to delegate to integrations
- Update noxfile.py with ADK integration test sessions
- Update integrations base and registry for ADK support
Abhijeet Prasad (AbhiPrasad) added a commit that referenced this pull request Mar 24, 2026
Convert the Google ADK (Agent Development Kit) instrumentation from the
legacy wrappers pattern to the new integrations API introduced in #118.
- Extract tracing helpers into integrations/adk/tracing.py
- Create ADK patchers (agent, runner, flow, mcp_tool) in patchers.py
- Add AdkIntegration class with proper registration
- Move tests and cassettes from wrappers/adk/ to integrations/adk/
- Move auto_instrument test script to integrations/auto_test_scripts/
- Slim down wrappers/adk/__init__.py to delegate to integrations
- Update noxfile.py with ADK integration test sessions
- Update integrations base and registry for ADK support
Abhijeet Prasad (AbhiPrasad) added a commit that referenced this pull request Mar 24, 2026
Convert the Google ADK (Agent Development Kit) instrumentation from the
legacy wrappers pattern to the new integrations API introduced in #118.
- Extract tracing helpers into integrations/adk/tracing.py
- Create ADK patchers (agent, runner, flow, mcp_tool) in patchers.py
- Add AdkIntegration class with proper registration
- Move tests and cassettes from wrappers/adk/ to integrations/adk/
- Move auto_instrument test script to integrations/auto_test_scripts/
- Slim down wrappers/adk/__init__.py to delegate to integrations
- Update noxfile.py with ADK integration test sessions
- Update integrations base and registry for ADK support
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@AbhiPrasad@viadezo1er