perf(bt_json): optimize _to_bt_safe and bt_safe_deep_copy hot paths#139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Abhijeet Prasad (AbhiPrasad) merged 1 commit into from
Mar 25, 2026
Merged

perf(bt_json): optimize _to_bt_safe and bt_safe_deep_copy hot paths #139

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
143 changes: 97 additions & 46 deletions py/src/braintrust/bt_json.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,6 +19,23 @@ def _to_bt_safe(v: Any) -> Any:
"""
Converts the object to a Braintrust-safe representation (i.e. Attachment objects are safe (specially handled by background logger)).
"""
# Fast path: check primitives via type identity before hitting
# isinstance checks against abstract classes or Pydantic model_dump.
if v is None or v is True or v is False:
return v
tv = type(v)
if tv is int or tv is str:
return v
if tv is float or isinstance(v, float):
if math.isnan(v):
return "NaN"
if math.isinf(v):
return "Infinity" if v > 0 else "-Infinity"
return v
# Catch str/int subclasses (e.g. str-enums like SpanTypeAttribute)
if isinstance(v, (int, str)):
return v

# avoid circular imports
from braintrust.logger import BaseAttachment, Dataset, Experiment, Logger, ReadonlyAttachment, Span

Expand DownExpand Up@@ -57,32 +74,20 @@ def _to_bt_safe(v: Any) -> Any:
# Suppress Pydantic serializer warnings that arise from generic/discriminated-union
# models (e.g. OpenAI's ParsedResponse[T]). See
# https://github.com/braintrustdata/braintrust-sdk-python/issues/60
try:
with warnings.catch_warnings():
warnings.filterwarnings("ignore", message="Pydantic serializer warnings", category=UserWarning)
return cast(Any, v).model_dump(exclude_none=True)
except (AttributeError, TypeError):
pass
if hasattr(v, "model_dump"):
try:
with warnings.catch_warnings():
warnings.filterwarnings("ignore", message="Pydantic serializer warnings", category=UserWarning)
return cast(Any, v).model_dump(exclude_none=True)
except (AttributeError, TypeError):
pass

# Attempt to dump a Pydantic v1 `BaseModel`.
try:
return cast(Any, v).dict(exclude_none=True)
except (AttributeError, TypeError):
pass

if isinstance(v, float):
# Handle NaN and Infinity for JSON compatibility
if math.isnan(v):
return "NaN"

if math.isinf(v):
return "Infinity" if v > 0 else "-Infinity"

return v

if isinstance(v, (int, str, bool)) or v is None:
# Skip roundtrip for primitive types.
return v
if hasattr(v, "dict") and not isinstance(v, type):
try:
return cast(Any, v).dict(exclude_none=True)
except (AttributeError, TypeError):
pass

# Note: we avoid using copy.deepcopy, because it's difficult to
# guarantee the independence of such copied types from their origin.
Expand DownExpand Up@@ -119,49 +124,95 @@ def bt_safe_deep_copy(obj: Any, max_depth: int = 200):

Args:
obj: Object to deep copy and sanitize.
to_json_safe: Function to ensure the object is json safe.
max_depth: Maximum depth to copy.

Returns:
Deep copy of the object.
"""
# Track visited objects to detect circular references
visited: set[int] = set()
visited_add = visited.add
visited_discard = visited.discard

def _deep_copy_object(v: Any, depth: int = 0) -> Any:
# Check depth limit - use >= to stop before exceeding
# Fast path: primitives don't need deep copy or circular ref tracking.
if v is None or v is True or v is False:
return v
tv = type(v)
if tv is int or tv is str:
return v
if tv is float or isinstance(v, float):
if math.isnan(v):
return "NaN"
if math.isinf(v):
return "Infinity" if v > 0 else "-Infinity"
return v
# Catch str/int subclasses (e.g. str-enums)
if isinstance(v, (int, str)):
return v

if depth >= max_depth:
return "<max depth exceeded>"

# Check for circular references in mutable containers
# Use id() to track object identity
if isinstance(v, (Mapping, list, tuple, set)):
# Fast path for dict (the most common container in log data).
# Uses type identity instead of isinstance(v, Mapping) which is slow.
if tv is dict:
obj_id = id(v)
if obj_id in visited:
return "<circular reference>"
visited.add(obj_id)
visited_add(obj_id)
try:
if isinstance(v, Mapping):
# Prevent dict keys from holding references to user data. Note that
# `bt_json` already coerces keys to string, a behavior that comes from
# `json.dumps`. However, that runs at log upload time, while we want to
# cut out all the references to user objects synchronously in this
# function.
result = {}
for k in v:
result = {}
for k in v:
if type(k) is str:
key_str = k
else:
try:
key_str = str(k)
except Exception:
# If str() fails on the key, use a fallback representation
key_str = f"<non-stringifiable-key: {type(k).__name__}>"
result[key_str] = _deep_copy_object(v[k], depth + 1)
return result
elif isinstance(v, (list, tuple, set)):
return [_deep_copy_object(x, depth + 1) for x in v]
result[key_str] = _deep_copy_object(v[k], depth + 1)
return result
finally:
visited_discard(obj_id)
elif tv is list or tv is tuple:
obj_id = id(v)
if obj_id in visited:
return "<circular reference>"
visited_add(obj_id)
try:
return [_deep_copy_object(x, depth + 1) for x in v]
finally:
visited_discard(obj_id)
# Slow path for non-builtin Mapping/set types.
elif isinstance(v, Mapping):
obj_id = id(v)
if obj_id in visited:
return "<circular reference>"
visited_add(obj_id)
try:
result = {}
for k in v:
if type(k) is str:
key_str = k
else:
try:
key_str = str(k)
except Exception:
key_str = f"<non-stringifiable-key: {type(k).__name__}>"
result[key_str] = _deep_copy_object(v[k], depth + 1)
return result
finally:
visited_discard(obj_id)
elif isinstance(v, set):
obj_id = id(v)
if obj_id in visited:
return "<circular reference>"
visited_add(obj_id)
try:
return [_deep_copy_object(x, depth + 1) for x in v]
finally:
# Remove from visited set after processing to allow the same object
# to appear in different branches of the tree
visited.discard(obj_id)
visited_discard(obj_id)

try:
return _to_bt_safe(v)
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
perf(bt_json): optimize _to_bt_safe and bt_safe_deep_copy hot paths#139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Abhijeet Prasad (AbhiPrasad)
merged 1 commit into

from

Mar 25, 2026
 Merged


perf(bt_json): optimize _to_bt_safe and bt_safe_deep_copy hot paths
#139
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


143 changes: 97 additions & 46 deletions
py/src/braintrust/bt_json.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -19,6 +19,23 @@ def _to_bt_safe(v: Any) -> Any:
 """
 Converts the object to a Braintrust-safe representation (i.e. Attachment objects are safe (specially handled by background logger)).
 """
 # Fast path: check primitives via type identity before hitting
 # isinstance checks against abstract classes or Pydantic model_dump.
 if v is None or v is True or v is False:
 return v
 tv = type(v)
 if tv is int or tv is str:
 return v
 if tv is float or isinstance(v, float):
 if math.isnan(v):
 return "NaN"
 if math.isinf(v):
 return "Infinity" if v > 0 else "-Infinity"
 return v
 # Catch str/int subclasses (e.g. str-enums like SpanTypeAttribute)
 if isinstance(v, (int, str)):
 return v

 # avoid circular imports
 from braintrust.logger import BaseAttachment, Dataset, Experiment, Logger, ReadonlyAttachment, Span

Expand DownExpand Up@@ -57,32 +74,20 @@ def _to_bt_safe(v: Any) -> Any:
 # Suppress Pydantic serializer warnings that arise from generic/discriminated-union
 # models (e.g. OpenAI's ParsedResponse[T]). See
 # https://github.com/braintrustdata/braintrust-sdk-python/issues/60
 try:
 with warnings.catch_warnings():
 warnings.filterwarnings("ignore", message="Pydantic serializer warnings", category=UserWarning)
 return cast(Any, v).model_dump(exclude_none=True)
 except (AttributeError, TypeError):
 pass
 if hasattr(v, "model_dump"):
 try:
 with warnings.catch_warnings():
 warnings.filterwarnings("ignore", message="Pydantic serializer warnings", category=UserWarning)
 return cast(Any, v).model_dump(exclude_none=True)
 except (AttributeError, TypeError):
 pass

 # Attempt to dump a Pydantic v1 `BaseModel`.
 try:
 return cast(Any, v).dict(exclude_none=True)
 except (AttributeError, TypeError):
 pass

 if isinstance(v, float):
 # Handle NaN and Infinity for JSON compatibility
 if math.isnan(v):
 return "NaN"

 if math.isinf(v):
 return "Infinity" if v > 0 else "-Infinity"

 return v

 if isinstance(v, (int, str, bool)) or v is None:
 # Skip roundtrip for primitive types.
 return v
 if hasattr(v, "dict") and not isinstance(v, type):
 try:
 return cast(Any, v).dict(exclude_none=True)
 except (AttributeError, TypeError):
 pass

 # Note: we avoid using copy.deepcopy, because it's difficult to
 # guarantee the independence of such copied types from their origin.
Expand DownExpand Up@@ -119,49 +124,95 @@ def bt_safe_deep_copy(obj: Any, max_depth: int = 200):

 Args:
 obj: Object to deep copy and sanitize.
 to_json_safe: Function to ensure the object is json safe.
 max_depth: Maximum depth to copy.

 Returns:
 Deep copy of the object.
 """
 # Track visited objects to detect circular references
 visited: set[int] = set()
 visited_add = visited.add
 visited_discard = visited.discard

 def _deep_copy_object(v: Any, depth: int = 0) -> Any:
 # Check depth limit - use >= to stop before exceeding
 # Fast path: primitives don't need deep copy or circular ref tracking.
 if v is None or v is True or v is False:
 return v
 tv = type(v)
 if tv is int or tv is str:
 return v
 if tv is float or isinstance(v, float):
 if math.isnan(v):
 return "NaN"
 if math.isinf(v):
 return "Infinity" if v > 0 else "-Infinity"
 return v
 # Catch str/int subclasses (e.g. str-enums)
 if isinstance(v, (int, str)):
 return v

 if depth >= max_depth:
 return "<max depth exceeded>"

 # Check for circular references in mutable containers
 # Use id() to track object identity
 if isinstance(v, (Mapping, list, tuple, set)):
 # Fast path for dict (the most common container in log data).
 # Uses type identity instead of isinstance(v, Mapping) which is slow.
 if tv is dict:
 obj_id = id(v)
 if obj_id in visited:
 return "<circular reference>"
visited.add(obj_id)
visited_add(obj_id)
 try:
 if isinstance(v, Mapping):
 # Prevent dict keys from holding references to user data. Note that
 # `bt_json` already coerces keys to string, a behavior that comes from
 # `json.dumps`. However, that runs at log upload time, while we want to
 # cut out all the references to user objects synchronously in this
 # function.
 result = {}
 for k in v:
 result = {}
 for k in v:
 if type(k) is str:
 key_str = k
 else:
 try:
 key_str = str(k)
 except Exception:
 # If str() fails on the key, use a fallback representation
 key_str = f"<non-stringifiable-key: {type(k).__name__}>"
 result[key_str] = _deep_copy_object(v[k], depth + 1)
 return result
 elif isinstance(v, (list, tuple, set)):
 return [_deep_copy_object(x, depth + 1) for x in v]
 result[key_str] = _deep_copy_object(v[k], depth + 1)
 return result
 finally:
 visited_discard(obj_id)
 elif tv is list or tv is tuple:
 obj_id = id(v)
 if obj_id in visited:
 return "<circular reference>"
 visited_add(obj_id)
 try:
 return [_deep_copy_object(x, depth + 1) for x in v]
 finally:
 visited_discard(obj_id)
 # Slow path for non-builtin Mapping/set types.
 elif isinstance(v, Mapping):
 obj_id = id(v)
 if obj_id in visited:
 return "<circular reference>"
 visited_add(obj_id)
 try:
 result = {}
 for k in v:
 if type(k) is str:
 key_str = k
 else:
 try:
 key_str = str(k)
 except Exception:
 key_str = f"<non-stringifiable-key: {type(k).__name__}>"
 result[key_str] = _deep_copy_object(v[k], depth + 1)
 return result
 finally:
 visited_discard(obj_id)
 elif isinstance(v, set):
 obj_id = id(v)
 if obj_id in visited:
 return "<circular reference>"
 visited_add(obj_id)
 try:
 return [_deep_copy_object(x, depth + 1) for x in v]
 finally:
 # Remove from visited set after processing to allow the same object
 # to appear in different branches of the tree
 visited.discard(obj_id)
 visited_discard(obj_id)

 try:
 return _to_bt_safe(v)
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
perf(bt_json): optimize _to_bt_safe and bt_safe_deep_copy hot paths#139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Abhijeet Prasad (AbhiPrasad)
merged 1 commit into

from

Mar 25, 2026
 Merged


perf(bt_json): optimize _to_bt_safe and bt_safe_deep_copy hot paths
#139
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


143 changes: 97 additions & 46 deletions
py/src/braintrust/bt_json.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -19,6 +19,23 @@ def _to_bt_safe(v: Any) -> Any:
 """
 Converts the object to a Braintrust-safe representation (i.e. Attachment objects are safe (specially handled by background logger)).
 """
 # Fast path: check primitives via type identity before hitting
 # isinstance checks against abstract classes or Pydantic model_dump.
 if v is None or v is True or v is False:
 return v
 tv = type(v)
 if tv is int or tv is str:
 return v
 if tv is float or isinstance(v, float):
 if math.isnan(v):
 return "NaN"
 if math.isinf(v):
 return "Infinity" if v > 0 else "-Infinity"
 return v
 # Catch str/int subclasses (e.g. str-enums like SpanTypeAttribute)
 if isinstance(v, (int, str)):
 return v

 # avoid circular imports
 from braintrust.logger import BaseAttachment, Dataset, Experiment, Logger, ReadonlyAttachment, Span

Expand DownExpand Up@@ -57,32 +74,20 @@ def _to_bt_safe(v: Any) -> Any:
 # Suppress Pydantic serializer warnings that arise from generic/discriminated-union
 # models (e.g. OpenAI's ParsedResponse[T]). See
 # https://github.com/braintrustdata/braintrust-sdk-python/issues/60
 try:
 with warnings.catch_warnings():
 warnings.filterwarnings("ignore", message="Pydantic serializer warnings", category=UserWarning)
 return cast(Any, v).model_dump(exclude_none=True)
 except (AttributeError, TypeError):
 pass
 if hasattr(v, "model_dump"):
 try:
 with warnings.catch_warnings():
 warnings.filterwarnings("ignore", message="Pydantic serializer warnings", category=UserWarning)
 return cast(Any, v).model_dump(exclude_none=True)
 except (AttributeError, TypeError):
 pass

 # Attempt to dump a Pydantic v1 `BaseModel`.
 try:
 return cast(Any, v).dict(exclude_none=True)
 except (AttributeError, TypeError):
 pass

 if isinstance(v, float):
 # Handle NaN and Infinity for JSON compatibility
 if math.isnan(v):
 return "NaN"

 if math.isinf(v):
 return "Infinity" if v > 0 else "-Infinity"

 return v

 if isinstance(v, (int, str, bool)) or v is None:
 # Skip roundtrip for primitive types.
 return v
 if hasattr(v, "dict") and not isinstance(v, type):
 try:
 return cast(Any, v).dict(exclude_none=True)
 except (AttributeError, TypeError):
 pass

 # Note: we avoid using copy.deepcopy, because it's difficult to
 # guarantee the independence of such copied types from their origin.
Expand DownExpand Up@@ -119,49 +124,95 @@ def bt_safe_deep_copy(obj: Any, max_depth: int = 200):

 Args:
 obj: Object to deep copy and sanitize.
 to_json_safe: Function to ensure the object is json safe.
 max_depth: Maximum depth to copy.

 Returns:
 Deep copy of the object.
 """
 # Track visited objects to detect circular references
 visited: set[int] = set()
 visited_add = visited.add
 visited_discard = visited.discard

 def _deep_copy_object(v: Any, depth: int = 0) -> Any:
 # Check depth limit - use >= to stop before exceeding
 # Fast path: primitives don't need deep copy or circular ref tracking.
 if v is None or v is True or v is False:
 return v
 tv = type(v)
 if tv is int or tv is str:
 return v
 if tv is float or isinstance(v, float):
 if math.isnan(v):
 return "NaN"
 if math.isinf(v):
 return "Infinity" if v > 0 else "-Infinity"
 return v
 # Catch str/int subclasses (e.g. str-enums)
 if isinstance(v, (int, str)):
 return v

 if depth >= max_depth:
 return "<max depth exceeded>"

 # Check for circular references in mutable containers
 # Use id() to track object identity
 if isinstance(v, (Mapping, list, tuple, set)):
 # Fast path for dict (the most common container in log data).
 # Uses type identity instead of isinstance(v, Mapping) which is slow.
 if tv is dict:
 obj_id = id(v)
 if obj_id in visited:
 return "<circular reference>"
visited.add(obj_id)
visited_add(obj_id)
 try:
 if isinstance(v, Mapping):
 # Prevent dict keys from holding references to user data. Note that
 # `bt_json` already coerces keys to string, a behavior that comes from
 # `json.dumps`. However, that runs at log upload time, while we want to
 # cut out all the references to user objects synchronously in this
 # function.
 result = {}
 for k in v:
 result = {}
 for k in v:
 if type(k) is str:
 key_str = k
 else:
 try:
 key_str = str(k)
 except Exception:
 # If str() fails on the key, use a fallback representation
 key_str = f"<non-stringifiable-key: {type(k).__name__}>"
 result[key_str] = _deep_copy_object(v[k], depth + 1)
 return result
 elif isinstance(v, (list, tuple, set)):
 return [_deep_copy_object(x, depth + 1) for x in v]
 result[key_str] = _deep_copy_object(v[k], depth + 1)
 return result
 finally:
 visited_discard(obj_id)
 elif tv is list or tv is tuple:
 obj_id = id(v)
 if obj_id in visited:
 return "<circular reference>"
 visited_add(obj_id)
 try:
 return [_deep_copy_object(x, depth + 1) for x in v]
 finally:
 visited_discard(obj_id)
 # Slow path for non-builtin Mapping/set types.
 elif isinstance(v, Mapping):
 obj_id = id(v)
 if obj_id in visited:
 return "<circular reference>"
 visited_add(obj_id)
 try:
 result = {}
 for k in v:
 if type(k) is str:
 key_str = k
 else:
 try:
 key_str = str(k)
 except Exception:
 key_str = f"<non-stringifiable-key: {type(k).__name__}>"
 result[key_str] = _deep_copy_object(v[k], depth + 1)
 return result
 finally:
 visited_discard(obj_id)
 elif isinstance(v, set):
 obj_id = id(v)
 if obj_id in visited:
 return "<circular reference>"
 visited_add(obj_id)
 try:
 return [_deep_copy_object(x, depth + 1) for x in v]
 finally:
 # Remove from visited set after processing to allow the same object
 # to appear in different branches of the tree
 visited.discard(obj_id)
 visited_discard(obj_id)

 try:
 return _to_bt_safe(v)
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
perf(bt_json): optimize _to_bt_safe and bt_safe_deep_copy hot paths#139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Abhijeet Prasad (AbhiPrasad)
merged 1 commit into

from

Mar 25, 2026
 Merged


perf(bt_json): optimize _to_bt_safe and bt_safe_deep_copy hot paths
#139
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


143 changes: 97 additions & 46 deletions
py/src/braintrust/bt_json.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -19,6 +19,23 @@ def _to_bt_safe(v: Any) -> Any:
 """
 Converts the object to a Braintrust-safe representation (i.e. Attachment objects are safe (specially handled by background logger)).
 """
 # Fast path: check primitives via type identity before hitting
 # isinstance checks against abstract classes or Pydantic model_dump.
 if v is None or v is True or v is False:
 return v
 tv = type(v)
 if tv is int or tv is str:
 return v
 if tv is float or isinstance(v, float):
 if math.isnan(v):
 return "NaN"
 if math.isinf(v):
 return "Infinity" if v > 0 else "-Infinity"
 return v
 # Catch str/int subclasses (e.g. str-enums like SpanTypeAttribute)
 if isinstance(v, (int, str)):
 return v

 # avoid circular imports
 from braintrust.logger import BaseAttachment, Dataset, Experiment, Logger, ReadonlyAttachment, Span

Expand DownExpand Up@@ -57,32 +74,20 @@ def _to_bt_safe(v: Any) -> Any:
 # Suppress Pydantic serializer warnings that arise from generic/discriminated-union
 # models (e.g. OpenAI's ParsedResponse[T]). See
 # https://github.com/braintrustdata/braintrust-sdk-python/issues/60
 try:
 with warnings.catch_warnings():
 warnings.filterwarnings("ignore", message="Pydantic serializer warnings", category=UserWarning)
 return cast(Any, v).model_dump(exclude_none=True)
 except (AttributeError, TypeError):
 pass
 if hasattr(v, "model_dump"):
 try:
 with warnings.catch_warnings():
 warnings.filterwarnings("ignore", message="Pydantic serializer warnings", category=UserWarning)
 return cast(Any, v).model_dump(exclude_none=True)
 except (AttributeError, TypeError):
 pass

 # Attempt to dump a Pydantic v1 `BaseModel`.
 try:
 return cast(Any, v).dict(exclude_none=True)
 except (AttributeError, TypeError):
 pass

 if isinstance(v, float):
 # Handle NaN and Infinity for JSON compatibility
 if math.isnan(v):
 return "NaN"

 if math.isinf(v):
 return "Infinity" if v > 0 else "-Infinity"

 return v

 if isinstance(v, (int, str, bool)) or v is None:
 # Skip roundtrip for primitive types.
 return v
 if hasattr(v, "dict") and not isinstance(v, type):
 try:
 return cast(Any, v).dict(exclude_none=True)
 except (AttributeError, TypeError):
 pass

 # Note: we avoid using copy.deepcopy, because it's difficult to
 # guarantee the independence of such copied types from their origin.
Expand DownExpand Up@@ -119,49 +124,95 @@ def bt_safe_deep_copy(obj: Any, max_depth: int = 200):

 Args:
 obj: Object to deep copy and sanitize.
 to_json_safe: Function to ensure the object is json safe.
 max_depth: Maximum depth to copy.

 Returns:
 Deep copy of the object.
 """
 # Track visited objects to detect circular references
 visited: set[int] = set()
 visited_add = visited.add
 visited_discard = visited.discard

 def _deep_copy_object(v: Any, depth: int = 0) -> Any:
 # Check depth limit - use >= to stop before exceeding
 # Fast path: primitives don't need deep copy or circular ref tracking.
 if v is None or v is True or v is False:
 return v
 tv = type(v)
 if tv is int or tv is str:
 return v
 if tv is float or isinstance(v, float):
 if math.isnan(v):
 return "NaN"
 if math.isinf(v):
 return "Infinity" if v > 0 else "-Infinity"
 return v
 # Catch str/int subclasses (e.g. str-enums)
 if isinstance(v, (int, str)):
 return v

 if depth >= max_depth:
 return "<max depth exceeded>"

 # Check for circular references in mutable containers
 # Use id() to track object identity
 if isinstance(v, (Mapping, list, tuple, set)):
 # Fast path for dict (the most common container in log data).
 # Uses type identity instead of isinstance(v, Mapping) which is slow.
 if tv is dict:
 obj_id = id(v)
 if obj_id in visited:
 return "<circular reference>"
visited.add(obj_id)
visited_add(obj_id)
 try:
 if isinstance(v, Mapping):
 # Prevent dict keys from holding references to user data. Note that
 # `bt_json` already coerces keys to string, a behavior that comes from
 # `json.dumps`. However, that runs at log upload time, while we want to
 # cut out all the references to user objects synchronously in this
 # function.
 result = {}
 for k in v:
 result = {}
 for k in v:
 if type(k) is str:
 key_str = k
 else:
 try:
 key_str = str(k)
 except Exception:
 # If str() fails on the key, use a fallback representation
 key_str = f"<non-stringifiable-key: {type(k).__name__}>"
 result[key_str] = _deep_copy_object(v[k], depth + 1)
 return result
 elif isinstance(v, (list, tuple, set)):
 return [_deep_copy_object(x, depth + 1) for x in v]
 result[key_str] = _deep_copy_object(v[k], depth + 1)
 return result
 finally:
 visited_discard(obj_id)
 elif tv is list or tv is tuple:
 obj_id = id(v)
 if obj_id in visited:
 return "<circular reference>"
 visited_add(obj_id)
 try:
 return [_deep_copy_object(x, depth + 1) for x in v]
 finally:
 visited_discard(obj_id)
 # Slow path for non-builtin Mapping/set types.
 elif isinstance(v, Mapping):
 obj_id = id(v)
 if obj_id in visited:
 return "<circular reference>"
 visited_add(obj_id)
 try:
 result = {}
 for k in v:
 if type(k) is str:
 key_str = k
 else:
 try:
 key_str = str(k)
 except Exception:
 key_str = f"<non-stringifiable-key: {type(k).__name__}>"
 result[key_str] = _deep_copy_object(v[k], depth + 1)
 return result
 finally:
 visited_discard(obj_id)
 elif isinstance(v, set):
 obj_id = id(v)
 if obj_id in visited:
 return "<circular reference>"
 visited_add(obj_id)
 try:
 return [_deep_copy_object(x, depth + 1) for x in v]
 finally:
 # Remove from visited set after processing to allow the same object
 # to appear in different branches of the tree
 visited.discard(obj_id)
 visited_discard(obj_id)

 try:
 return _to_bt_safe(v)
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
perf(bt_json): optimize _to_bt_safe and bt_safe_deep_copy hot paths#139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Abhijeet Prasad (AbhiPrasad)
merged 1 commit into

from

Mar 25, 2026
 Merged


perf(bt_json): optimize _to_bt_safe and bt_safe_deep_copy hot paths
#139
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


143 changes: 97 additions & 46 deletions
py/src/braintrust/bt_json.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -19,6 +19,23 @@ def _to_bt_safe(v: Any) -> Any:
 """
 Converts the object to a Braintrust-safe representation (i.e. Attachment objects are safe (specially handled by background logger)).
 """
 # Fast path: check primitives via type identity before hitting
 # isinstance checks against abstract classes or Pydantic model_dump.
 if v is None or v is True or v is False:
 return v
 tv = type(v)
 if tv is int or tv is str:
 return v
 if tv is float or isinstance(v, float):
 if math.isnan(v):
 return "NaN"
 if math.isinf(v):
 return "Infinity" if v > 0 else "-Infinity"
 return v
 # Catch str/int subclasses (e.g. str-enums like SpanTypeAttribute)
 if isinstance(v, (int, str)):
 return v

 # avoid circular imports
 from braintrust.logger import BaseAttachment, Dataset, Experiment, Logger, ReadonlyAttachment, Span

Expand DownExpand Up@@ -57,32 +74,20 @@ def _to_bt_safe(v: Any) -> Any:
 # Suppress Pydantic serializer warnings that arise from generic/discriminated-union
 # models (e.g. OpenAI's ParsedResponse[T]). See
 # https://github.com/braintrustdata/braintrust-sdk-python/issues/60
 try:
 with warnings.catch_warnings():
 warnings.filterwarnings("ignore", message="Pydantic serializer warnings", category=UserWarning)
 return cast(Any, v).model_dump(exclude_none=True)
 except (AttributeError, TypeError):
 pass
 if hasattr(v, "model_dump"):
 try:
 with warnings.catch_warnings():
 warnings.filterwarnings("ignore", message="Pydantic serializer warnings", category=UserWarning)
 return cast(Any, v).model_dump(exclude_none=True)
 except (AttributeError, TypeError):
 pass

 # Attempt to dump a Pydantic v1 `BaseModel`.
 try:
 return cast(Any, v).dict(exclude_none=True)
 except (AttributeError, TypeError):
 pass

 if isinstance(v, float):
 # Handle NaN and Infinity for JSON compatibility
 if math.isnan(v):
 return "NaN"

 if math.isinf(v):
 return "Infinity" if v > 0 else "-Infinity"

 return v

 if isinstance(v, (int, str, bool)) or v is None:
 # Skip roundtrip for primitive types.
 return v
 if hasattr(v, "dict") and not isinstance(v, type):
 try:
 return cast(Any, v).dict(exclude_none=True)
 except (AttributeError, TypeError):
 pass

 # Note: we avoid using copy.deepcopy, because it's difficult to
 # guarantee the independence of such copied types from their origin.
Expand DownExpand Up@@ -119,49 +124,95 @@ def bt_safe_deep_copy(obj: Any, max_depth: int = 200):

 Args:
 obj: Object to deep copy and sanitize.
 to_json_safe: Function to ensure the object is json safe.
 max_depth: Maximum depth to copy.

 Returns:
 Deep copy of the object.
 """
 # Track visited objects to detect circular references
 visited: set[int] = set()
 visited_add = visited.add
 visited_discard = visited.discard

 def _deep_copy_object(v: Any, depth: int = 0) -> Any:
 # Check depth limit - use >= to stop before exceeding
 # Fast path: primitives don't need deep copy or circular ref tracking.
 if v is None or v is True or v is False:
 return v
 tv = type(v)
 if tv is int or tv is str:
 return v
 if tv is float or isinstance(v, float):
 if math.isnan(v):
 return "NaN"
 if math.isinf(v):
 return "Infinity" if v > 0 else "-Infinity"
 return v
 # Catch str/int subclasses (e.g. str-enums)
 if isinstance(v, (int, str)):
 return v

 if depth >= max_depth:
 return "<max depth exceeded>"

 # Check for circular references in mutable containers
 # Use id() to track object identity
 if isinstance(v, (Mapping, list, tuple, set)):
 # Fast path for dict (the most common container in log data).
 # Uses type identity instead of isinstance(v, Mapping) which is slow.
 if tv is dict:
 obj_id = id(v)
 if obj_id in visited:
 return "<circular reference>"
visited.add(obj_id)
visited_add(obj_id)
 try:
 if isinstance(v, Mapping):
 # Prevent dict keys from holding references to user data. Note that
 # `bt_json` already coerces keys to string, a behavior that comes from
 # `json.dumps`. However, that runs at log upload time, while we want to
 # cut out all the references to user objects synchronously in this
 # function.
 result = {}
 for k in v:
 result = {}
 for k in v:
 if type(k) is str:
 key_str = k
 else:
 try:
 key_str = str(k)
 except Exception:
 # If str() fails on the key, use a fallback representation
 key_str = f"<non-stringifiable-key: {type(k).__name__}>"
 result[key_str] = _deep_copy_object(v[k], depth + 1)
 return result
 elif isinstance(v, (list, tuple, set)):
 return [_deep_copy_object(x, depth + 1) for x in v]
 result[key_str] = _deep_copy_object(v[k], depth + 1)
 return result
 finally:
 visited_discard(obj_id)
 elif tv is list or tv is tuple:
 obj_id = id(v)
 if obj_id in visited:
 return "<circular reference>"
 visited_add(obj_id)
 try:
 return [_deep_copy_object(x, depth + 1) for x in v]
 finally:
 visited_discard(obj_id)
 # Slow path for non-builtin Mapping/set types.
 elif isinstance(v, Mapping):
 obj_id = id(v)
 if obj_id in visited:
 return "<circular reference>"
 visited_add(obj_id)
 try:
 result = {}
 for k in v:
 if type(k) is str:
 key_str = k
 else:
 try:
 key_str = str(k)
 except Exception:
 key_str = f"<non-stringifiable-key: {type(k).__name__}>"
 result[key_str] = _deep_copy_object(v[k], depth + 1)
 return result
 finally:
 visited_discard(obj_id)
 elif isinstance(v, set):
 obj_id = id(v)
 if obj_id in visited:
 return "<circular reference>"
 visited_add(obj_id)
 try:
 return [_deep_copy_object(x, depth + 1) for x in v]
 finally:
 # Remove from visited set after processing to allow the same object
 # to appear in different branches of the tree
 visited.discard(obj_id)
 visited_discard(obj_id)

 try:
 return _to_bt_safe(v)
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
perf(bt_json): optimize _to_bt_safe and bt_safe_deep_copy hot paths#139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Abhijeet Prasad (AbhiPrasad)
merged 1 commit into

from

Mar 25, 2026
 Merged


perf(bt_json): optimize _to_bt_safe and bt_safe_deep_copy hot paths
#139
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


143 changes: 97 additions & 46 deletions
py/src/braintrust/bt_json.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -19,6 +19,23 @@ def _to_bt_safe(v: Any) -> Any:
 """
 Converts the object to a Braintrust-safe representation (i.e. Attachment objects are safe (specially handled by background logger)).
 """
 # Fast path: check primitives via type identity before hitting
 # isinstance checks against abstract classes or Pydantic model_dump.
 if v is None or v is True or v is False:
 return v
 tv = type(v)
 if tv is int or tv is str:
 return v
 if tv is float or isinstance(v, float):
 if math.isnan(v):
 return "NaN"
 if math.isinf(v):
 return "Infinity" if v > 0 else "-Infinity"
 return v
 # Catch str/int subclasses (e.g. str-enums like SpanTypeAttribute)
 if isinstance(v, (int, str)):
 return v

 # avoid circular imports
 from braintrust.logger import BaseAttachment, Dataset, Experiment, Logger, ReadonlyAttachment, Span

Expand DownExpand Up@@ -57,32 +74,20 @@ def _to_bt_safe(v: Any) -> Any:
 # Suppress Pydantic serializer warnings that arise from generic/discriminated-union
 # models (e.g. OpenAI's ParsedResponse[T]). See
 # https://github.com/braintrustdata/braintrust-sdk-python/issues/60
 try:
 with warnings.catch_warnings():
 warnings.filterwarnings("ignore", message="Pydantic serializer warnings", category=UserWarning)
 return cast(Any, v).model_dump(exclude_none=True)
 except (AttributeError, TypeError):
 pass
 if hasattr(v, "model_dump"):
 try:
 with warnings.catch_warnings():
 warnings.filterwarnings("ignore", message="Pydantic serializer warnings", category=UserWarning)
 return cast(Any, v).model_dump(exclude_none=True)
 except (AttributeError, TypeError):
 pass

 # Attempt to dump a Pydantic v1 `BaseModel`.
 try:
 return cast(Any, v).dict(exclude_none=True)
 except (AttributeError, TypeError):
 pass

 if isinstance(v, float):
 # Handle NaN and Infinity for JSON compatibility
 if math.isnan(v):
 return "NaN"

 if math.isinf(v):
 return "Infinity" if v > 0 else "-Infinity"

 return v

 if isinstance(v, (int, str, bool)) or v is None:
 # Skip roundtrip for primitive types.
 return v
 if hasattr(v, "dict") and not isinstance(v, type):
 try:
 return cast(Any, v).dict(exclude_none=True)
 except (AttributeError, TypeError):
 pass

 # Note: we avoid using copy.deepcopy, because it's difficult to
 # guarantee the independence of such copied types from their origin.
Expand DownExpand Up@@ -119,49 +124,95 @@ def bt_safe_deep_copy(obj: Any, max_depth: int = 200):

 Args:
 obj: Object to deep copy and sanitize.
 to_json_safe: Function to ensure the object is json safe.
 max_depth: Maximum depth to copy.

 Returns:
 Deep copy of the object.
 """
 # Track visited objects to detect circular references
 visited: set[int] = set()
 visited_add = visited.add
 visited_discard = visited.discard

 def _deep_copy_object(v: Any, depth: int = 0) -> Any:
 # Check depth limit - use >= to stop before exceeding
 # Fast path: primitives don't need deep copy or circular ref tracking.
 if v is None or v is True or v is False:
 return v
 tv = type(v)
 if tv is int or tv is str:
 return v
 if tv is float or isinstance(v, float):
 if math.isnan(v):
 return "NaN"
 if math.isinf(v):
 return "Infinity" if v > 0 else "-Infinity"
 return v
 # Catch str/int subclasses (e.g. str-enums)
 if isinstance(v, (int, str)):
 return v

 if depth >= max_depth:
 return "<max depth exceeded>"

 # Check for circular references in mutable containers
 # Use id() to track object identity
 if isinstance(v, (Mapping, list, tuple, set)):
 # Fast path for dict (the most common container in log data).
 # Uses type identity instead of isinstance(v, Mapping) which is slow.
 if tv is dict:
 obj_id = id(v)
 if obj_id in visited:
 return "<circular reference>"
visited.add(obj_id)
visited_add(obj_id)
 try:
 if isinstance(v, Mapping):
 # Prevent dict keys from holding references to user data. Note that
 # `bt_json` already coerces keys to string, a behavior that comes from
 # `json.dumps`. However, that runs at log upload time, while we want to
 # cut out all the references to user objects synchronously in this
 # function.
 result = {}
 for k in v:
 result = {}
 for k in v:
 if type(k) is str:
 key_str = k
 else:
 try:
 key_str = str(k)
 except Exception:
 # If str() fails on the key, use a fallback representation
 key_str = f"<non-stringifiable-key: {type(k).__name__}>"
 result[key_str] = _deep_copy_object(v[k], depth + 1)
 return result
 elif isinstance(v, (list, tuple, set)):
 return [_deep_copy_object(x, depth + 1) for x in v]
 result[key_str] = _deep_copy_object(v[k], depth + 1)
 return result
 finally:
 visited_discard(obj_id)
 elif tv is list or tv is tuple:
 obj_id = id(v)
 if obj_id in visited:
 return "<circular reference>"
 visited_add(obj_id)
 try:
 return [_deep_copy_object(x, depth + 1) for x in v]
 finally:
 visited_discard(obj_id)
 # Slow path for non-builtin Mapping/set types.
 elif isinstance(v, Mapping):
 obj_id = id(v)
 if obj_id in visited:
 return "<circular reference>"
 visited_add(obj_id)
 try:
 result = {}
 for k in v:
 if type(k) is str:
 key_str = k
 else:
 try:
 key_str = str(k)
 except Exception:
 key_str = f"<non-stringifiable-key: {type(k).__name__}>"
 result[key_str] = _deep_copy_object(v[k], depth + 1)
 return result
 finally:
 visited_discard(obj_id)
 elif isinstance(v, set):
 obj_id = id(v)
 if obj_id in visited:
 return "<circular reference>"
 visited_add(obj_id)
 try:
 return [_deep_copy_object(x, depth + 1) for x in v]
 finally:
 # Remove from visited set after processing to allow the same object
 # to appear in different branches of the tree
 visited.discard(obj_id)
 visited_discard(obj_id)

 try:
 return _to_bt_safe(v)
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
perf(bt_json): optimize _to_bt_safe and bt_safe_deep_copy hot paths#139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Abhijeet Prasad (AbhiPrasad)
merged 1 commit into

from

Mar 25, 2026
 Merged


perf(bt_json): optimize _to_bt_safe and bt_safe_deep_copy hot paths
#139
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


143 changes: 97 additions & 46 deletions
py/src/braintrust/bt_json.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -19,6 +19,23 @@ def _to_bt_safe(v: Any) -> Any:
 """
 Converts the object to a Braintrust-safe representation (i.e. Attachment objects are safe (specially handled by background logger)).
 """
 # Fast path: check primitives via type identity before hitting
 # isinstance checks against abstract classes or Pydantic model_dump.
 if v is None or v is True or v is False:
 return v
 tv = type(v)
 if tv is int or tv is str:
 return v
 if tv is float or isinstance(v, float):
 if math.isnan(v):
 return "NaN"
 if math.isinf(v):
 return "Infinity" if v > 0 else "-Infinity"
 return v
 # Catch str/int subclasses (e.g. str-enums like SpanTypeAttribute)
 if isinstance(v, (int, str)):
 return v

 # avoid circular imports
 from braintrust.logger import BaseAttachment, Dataset, Experiment, Logger, ReadonlyAttachment, Span

Expand DownExpand Up@@ -57,32 +74,20 @@ def _to_bt_safe(v: Any) -> Any:
 # Suppress Pydantic serializer warnings that arise from generic/discriminated-union
 # models (e.g. OpenAI's ParsedResponse[T]). See
 # https://github.com/braintrustdata/braintrust-sdk-python/issues/60
 try:
 with warnings.catch_warnings():
 warnings.filterwarnings("ignore", message="Pydantic serializer warnings", category=UserWarning)
 return cast(Any, v).model_dump(exclude_none=True)
 except (AttributeError, TypeError):
 pass
 if hasattr(v, "model_dump"):
 try:
 with warnings.catch_warnings():
 warnings.filterwarnings("ignore", message="Pydantic serializer warnings", category=UserWarning)
 return cast(Any, v).model_dump(exclude_none=True)
 except (AttributeError, TypeError):
 pass

 # Attempt to dump a Pydantic v1 `BaseModel`.
 try:
 return cast(Any, v).dict(exclude_none=True)
 except (AttributeError, TypeError):
 pass

 if isinstance(v, float):
 # Handle NaN and Infinity for JSON compatibility
 if math.isnan(v):
 return "NaN"

 if math.isinf(v):
 return "Infinity" if v > 0 else "-Infinity"

 return v

 if isinstance(v, (int, str, bool)) or v is None:
 # Skip roundtrip for primitive types.
 return v
 if hasattr(v, "dict") and not isinstance(v, type):
 try:
 return cast(Any, v).dict(exclude_none=True)
 except (AttributeError, TypeError):
 pass

 # Note: we avoid using copy.deepcopy, because it's difficult to
 # guarantee the independence of such copied types from their origin.
Expand DownExpand Up@@ -119,49 +124,95 @@ def bt_safe_deep_copy(obj: Any, max_depth: int = 200):

 Args:
 obj: Object to deep copy and sanitize.
 to_json_safe: Function to ensure the object is json safe.
 max_depth: Maximum depth to copy.

 Returns:
 Deep copy of the object.
 """
 # Track visited objects to detect circular references
 visited: set[int] = set()
 visited_add = visited.add
 visited_discard = visited.discard

 def _deep_copy_object(v: Any, depth: int = 0) -> Any:
 # Check depth limit - use >= to stop before exceeding
 # Fast path: primitives don't need deep copy or circular ref tracking.
 if v is None or v is True or v is False:
 return v
 tv = type(v)
 if tv is int or tv is str:
 return v
 if tv is float or isinstance(v, float):
 if math.isnan(v):
 return "NaN"
 if math.isinf(v):
 return "Infinity" if v > 0 else "-Infinity"
 return v
 # Catch str/int subclasses (e.g. str-enums)
 if isinstance(v, (int, str)):
 return v

 if depth >= max_depth:
 return "<max depth exceeded>"

 # Check for circular references in mutable containers
 # Use id() to track object identity
 if isinstance(v, (Mapping, list, tuple, set)):
 # Fast path for dict (the most common container in log data).
 # Uses type identity instead of isinstance(v, Mapping) which is slow.
 if tv is dict:
 obj_id = id(v)
 if obj_id in visited:
 return "<circular reference>"
visited.add(obj_id)
visited_add(obj_id)
 try:
 if isinstance(v, Mapping):
 # Prevent dict keys from holding references to user data. Note that
 # `bt_json` already coerces keys to string, a behavior that comes from
 # `json.dumps`. However, that runs at log upload time, while we want to
 # cut out all the references to user objects synchronously in this
 # function.
 result = {}
 for k in v:
 result = {}
 for k in v:
 if type(k) is str:
 key_str = k
 else:
 try:
 key_str = str(k)
 except Exception:
 # If str() fails on the key, use a fallback representation
 key_str = f"<non-stringifiable-key: {type(k).__name__}>"
 result[key_str] = _deep_copy_object(v[k], depth + 1)
 return result
 elif isinstance(v, (list, tuple, set)):
 return [_deep_copy_object(x, depth + 1) for x in v]
 result[key_str] = _deep_copy_object(v[k], depth + 1)
 return result
 finally:
 visited_discard(obj_id)
 elif tv is list or tv is tuple:
 obj_id = id(v)
 if obj_id in visited:
 return "<circular reference>"
 visited_add(obj_id)
 try:
 return [_deep_copy_object(x, depth + 1) for x in v]
 finally:
 visited_discard(obj_id)
 # Slow path for non-builtin Mapping/set types.
 elif isinstance(v, Mapping):
 obj_id = id(v)
 if obj_id in visited:
 return "<circular reference>"
 visited_add(obj_id)
 try:
 result = {}
 for k in v:
 if type(k) is str:
 key_str = k
 else:
 try:
 key_str = str(k)
 except Exception:
 key_str = f"<non-stringifiable-key: {type(k).__name__}>"
 result[key_str] = _deep_copy_object(v[k], depth + 1)
 return result
 finally:
 visited_discard(obj_id)
 elif isinstance(v, set):
 obj_id = id(v)
 if obj_id in visited:
 return "<circular reference>"
 visited_add(obj_id)
 try:
 return [_deep_copy_object(x, depth + 1) for x in v]
 finally:
 # Remove from visited set after processing to allow the same object
 # to appear in different branches of the tree
 visited.discard(obj_id)
 visited_discard(obj_id)

 try:
 return _to_bt_safe(v)
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
perf(bt_json): optimize _to_bt_safe and bt_safe_deep_copy hot paths#139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Abhijeet Prasad (AbhiPrasad)
merged 1 commit into

from

Mar 25, 2026
 Merged


perf(bt_json): optimize _to_bt_safe and bt_safe_deep_copy hot paths
#139
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


143 changes: 97 additions & 46 deletions
py/src/braintrust/bt_json.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -19,6 +19,23 @@ def _to_bt_safe(v: Any) -> Any:
 """
 Converts the object to a Braintrust-safe representation (i.e. Attachment objects are safe (specially handled by background logger)).
 """
 # Fast path: check primitives via type identity before hitting
 # isinstance checks against abstract classes or Pydantic model_dump.
 if v is None or v is True or v is False:
 return v
 tv = type(v)
 if tv is int or tv is str:
 return v
 if tv is float or isinstance(v, float):
 if math.isnan(v):
 return "NaN"
 if math.isinf(v):
 return "Infinity" if v > 0 else "-Infinity"
 return v
 # Catch str/int subclasses (e.g. str-enums like SpanTypeAttribute)
 if isinstance(v, (int, str)):
 return v

 # avoid circular imports
 from braintrust.logger import BaseAttachment, Dataset, Experiment, Logger, ReadonlyAttachment, Span

Expand DownExpand Up@@ -57,32 +74,20 @@ def _to_bt_safe(v: Any) -> Any:
 # Suppress Pydantic serializer warnings that arise from generic/discriminated-union
 # models (e.g. OpenAI's ParsedResponse[T]). See
 # https://github.com/braintrustdata/braintrust-sdk-python/issues/60
 try:
 with warnings.catch_warnings():
 warnings.filterwarnings("ignore", message="Pydantic serializer warnings", category=UserWarning)
 return cast(Any, v).model_dump(exclude_none=True)
 except (AttributeError, TypeError):
 pass
 if hasattr(v, "model_dump"):
 try:
 with warnings.catch_warnings():
 warnings.filterwarnings("ignore", message="Pydantic serializer warnings", category=UserWarning)
 return cast(Any, v).model_dump(exclude_none=True)
 except (AttributeError, TypeError):
 pass

 # Attempt to dump a Pydantic v1 `BaseModel`.
 try:
 return cast(Any, v).dict(exclude_none=True)
 except (AttributeError, TypeError):
 pass

 if isinstance(v, float):
 # Handle NaN and Infinity for JSON compatibility
 if math.isnan(v):
 return "NaN"

 if math.isinf(v):
 return "Infinity" if v > 0 else "-Infinity"

 return v

 if isinstance(v, (int, str, bool)) or v is None:
 # Skip roundtrip for primitive types.
 return v
 if hasattr(v, "dict") and not isinstance(v, type):
 try:
 return cast(Any, v).dict(exclude_none=True)
 except (AttributeError, TypeError):
 pass

 # Note: we avoid using copy.deepcopy, because it's difficult to
 # guarantee the independence of such copied types from their origin.
Expand DownExpand Up@@ -119,49 +124,95 @@ def bt_safe_deep_copy(obj: Any, max_depth: int = 200):

 Args:
 obj: Object to deep copy and sanitize.
 to_json_safe: Function to ensure the object is json safe.
 max_depth: Maximum depth to copy.

 Returns:
 Deep copy of the object.
 """
 # Track visited objects to detect circular references
 visited: set[int] = set()
 visited_add = visited.add
 visited_discard = visited.discard

 def _deep_copy_object(v: Any, depth: int = 0) -> Any:
 # Check depth limit - use >= to stop before exceeding
 # Fast path: primitives don't need deep copy or circular ref tracking.
 if v is None or v is True or v is False:
 return v
 tv = type(v)
 if tv is int or tv is str:
 return v
 if tv is float or isinstance(v, float):
 if math.isnan(v):
 return "NaN"
 if math.isinf(v):
 return "Infinity" if v > 0 else "-Infinity"
 return v
 # Catch str/int subclasses (e.g. str-enums)
 if isinstance(v, (int, str)):
 return v

 if depth >= max_depth:
 return "<max depth exceeded>"

 # Check for circular references in mutable containers
 # Use id() to track object identity
 if isinstance(v, (Mapping, list, tuple, set)):
 # Fast path for dict (the most common container in log data).
 # Uses type identity instead of isinstance(v, Mapping) which is slow.
 if tv is dict:
 obj_id = id(v)
 if obj_id in visited:
 return "<circular reference>"
visited.add(obj_id)
visited_add(obj_id)
 try:
 if isinstance(v, Mapping):
 # Prevent dict keys from holding references to user data. Note that
 # `bt_json` already coerces keys to string, a behavior that comes from
 # `json.dumps`. However, that runs at log upload time, while we want to
 # cut out all the references to user objects synchronously in this
 # function.
 result = {}
 for k in v:
 result = {}
 for k in v:
 if type(k) is str:
 key_str = k
 else:
 try:
 key_str = str(k)
 except Exception:
 # If str() fails on the key, use a fallback representation
 key_str = f"<non-stringifiable-key: {type(k).__name__}>"
 result[key_str] = _deep_copy_object(v[k], depth + 1)
 return result
 elif isinstance(v, (list, tuple, set)):
 return [_deep_copy_object(x, depth + 1) for x in v]
 result[key_str] = _deep_copy_object(v[k], depth + 1)
 return result
 finally:
 visited_discard(obj_id)
 elif tv is list or tv is tuple:
 obj_id = id(v)
 if obj_id in visited:
 return "<circular reference>"
 visited_add(obj_id)
 try:
 return [_deep_copy_object(x, depth + 1) for x in v]
 finally:
 visited_discard(obj_id)
 # Slow path for non-builtin Mapping/set types.
 elif isinstance(v, Mapping):
 obj_id = id(v)
 if obj_id in visited:
 return "<circular reference>"
 visited_add(obj_id)
 try:
 result = {}
 for k in v:
 if type(k) is str:
 key_str = k
 else:
 try:
 key_str = str(k)
 except Exception:
 key_str = f"<non-stringifiable-key: {type(k).__name__}>"
 result[key_str] = _deep_copy_object(v[k], depth + 1)
 return result
 finally:
 visited_discard(obj_id)
 elif isinstance(v, set):
 obj_id = id(v)
 if obj_id in visited:
 return "<circular reference>"
 visited_add(obj_id)
 try:
 return [_deep_copy_object(x, depth + 1) for x in v]
 finally:
 # Remove from visited set after processing to allow the same object
 # to appear in different branches of the tree
 visited.discard(obj_id)
 visited_discard(obj_id)

 try:
 return _to_bt_safe(v)
Expand Down
Loading