Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions py/src/braintrust/cli/push.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -140,6 +140,23 @@ def _run_install(install_args: list[str], packages_dir: str):
)


def _validate_python_archive_path(archive_path: str) -> None:
for component in archive_path.split(os.sep):
if any(ch.isspace() for ch in component):
raise ValueError(
"python bundle source path "
f"'{archive_path}' contains whitespace in path component '{component}'; "
"rename the file or directory before running `braintrust push`"
)


def _validate_python_bundle_source_paths(sources: list[str], archive_root: str | None = None) -> None:
abs_root = os.path.abspath(archive_root or os.getcwd())
for source in sources:
archive_path = os.path.normpath(os.path.relpath(os.path.abspath(source), abs_root))
_validate_python_archive_path(archive_path)


def _upload_bundle(entry_module_name: str, sources: list[str], requirements: str | None) -> str:
_check_uv()

Expand DownExpand Up@@ -369,6 +386,7 @@ def run(args):
needs_bundle = len(global_.functions) > 0 or len(evaluators) > 0
bundle_id = None
if needs_bundle:
_validate_python_bundle_source_paths(sources)
bundle_id = _upload_bundle(module_name, sources, args.requirements)

if len(global_.functions) > 0:
Expand Down
38 changes: 37 additions & 1 deletion py/src/braintrust/cli/test_push.py
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
"""Tests for push command serialization."""

import sys

import pytest


Expand All@@ -9,7 +11,7 @@
global_,
projects,
)
from .push import _collect_function_function_defs
from .push import _collect_function_function_defs, _validate_python_bundle_source_paths


class ToolInput(pydantic.BaseModel):
Expand DownExpand Up@@ -100,3 +102,37 @@ def test_collect_function_function_defs_excludes_tags_when_none(self, mock_proje

assert len(functions) == 1
assert "tags" not in functions[0]


class TestValidatePythonBundleSourcePaths:
def _assert_whitespace_in_filename_rejected(self, tmp_path, filename: str):
source = tmp_path / filename
source.write_text("VALUE = 1\n")

with pytest.raises(ValueError, match="contains whitespace in path component"):
_validate_python_bundle_source_paths([str(source)], str(tmp_path))

def test_rejects_whitespace_in_filename(self, tmp_path):
self._assert_whitespace_in_filename_rejected(tmp_path, "my tool.py")

@pytest.mark.skipif(sys.platform == "win32", reason="leading-space filenames are not portable on Windows")
def test_rejects_leading_whitespace_in_filename(self, tmp_path):
self._assert_whitespace_in_filename_rejected(tmp_path, " tool.py")

def test_rejects_whitespace_in_directory_name(self, tmp_path):
subdir = tmp_path / "my tools"
subdir.mkdir()
source = subdir / "tool.py"
source.write_text("VALUE = 1\n")

with pytest.raises(ValueError, match="contains whitespace in path component"):
_validate_python_bundle_source_paths([str(source)], str(tmp_path))

@pytest.mark.skipif(sys.platform == "win32", reason="tab characters in filenames are not allowed on Windows")
def test_rejects_tab_in_filename(self, tmp_path):
self._assert_whitespace_in_filename_rejected(tmp_path, "my\ttool.py")

def test_accepts_valid_path(self, tmp_path):
source = tmp_path / "my_tool.py"
source.write_text("VALUE = 1\n")
_validate_python_bundle_source_paths([str(source)], str(tmp_path))
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
fix(cli): reject whitespace in python bundle filenames by AbhiPrasad · Pull Request #237 · braintrustdata/braintrust-sdk-python · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions py/src/braintrust/cli/push.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -140,6 +140,23 @@ def _run_install(install_args: list[str], packages_dir: str):
)


def _validate_python_archive_path(archive_path: str) -> None:
for component in archive_path.split(os.sep):
if any(ch.isspace() for ch in component):
raise ValueError(
"python bundle source path "
f"'{archive_path}' contains whitespace in path component '{component}'; "
"rename the file or directory before running `braintrust push`"
)


def _validate_python_bundle_source_paths(sources: list[str], archive_root: str | None = None) -> None:
abs_root = os.path.abspath(archive_root or os.getcwd())
for source in sources:
archive_path = os.path.normpath(os.path.relpath(os.path.abspath(source), abs_root))
_validate_python_archive_path(archive_path)


def _upload_bundle(entry_module_name: str, sources: list[str], requirements: str | None) -> str:
_check_uv()

Expand DownExpand Up@@ -369,6 +386,7 @@ def run(args):
needs_bundle = len(global_.functions) > 0 or len(evaluators) > 0
bundle_id = None
if needs_bundle:
_validate_python_bundle_source_paths(sources)
bundle_id = _upload_bundle(module_name, sources, args.requirements)

if len(global_.functions) > 0:
Expand Down
38 changes: 37 additions & 1 deletion py/src/braintrust/cli/test_push.py
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
"""Tests for push command serialization."""

import sys

import pytest


Expand All@@ -9,7 +11,7 @@
global_,
projects,
)
from .push import _collect_function_function_defs
from .push import _collect_function_function_defs, _validate_python_bundle_source_paths


class ToolInput(pydantic.BaseModel):
Expand DownExpand Up@@ -100,3 +102,37 @@ def test_collect_function_function_defs_excludes_tags_when_none(self, mock_proje

assert len(functions) == 1
assert "tags" not in functions[0]


class TestValidatePythonBundleSourcePaths:
def _assert_whitespace_in_filename_rejected(self, tmp_path, filename: str):
source = tmp_path / filename
source.write_text("VALUE = 1\n")

with pytest.raises(ValueError, match="contains whitespace in path component"):
_validate_python_bundle_source_paths([str(source)], str(tmp_path))

def test_rejects_whitespace_in_filename(self, tmp_path):
self._assert_whitespace_in_filename_rejected(tmp_path, "my tool.py")

@pytest.mark.skipif(sys.platform == "win32", reason="leading-space filenames are not portable on Windows")
def test_rejects_leading_whitespace_in_filename(self, tmp_path):
self._assert_whitespace_in_filename_rejected(tmp_path, " tool.py")

def test_rejects_whitespace_in_directory_name(self, tmp_path):
subdir = tmp_path / "my tools"
subdir.mkdir()
source = subdir / "tool.py"
source.write_text("VALUE = 1\n")

with pytest.raises(ValueError, match="contains whitespace in path component"):
_validate_python_bundle_source_paths([str(source)], str(tmp_path))

@pytest.mark.skipif(sys.platform == "win32", reason="tab characters in filenames are not allowed on Windows")
def test_rejects_tab_in_filename(self, tmp_path):
self._assert_whitespace_in_filename_rejected(tmp_path, "my\ttool.py")

def test_accepts_valid_path(self, tmp_path):
source = tmp_path / "my_tool.py"
source.write_text("VALUE = 1\n")
_validate_python_bundle_source_paths([str(source)], str(tmp_path))
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(cli): reject whitespace in python bundle filenames by AbhiPrasad · Pull Request #237 · braintrustdata/braintrust-sdk-python · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions py/src/braintrust/cli/push.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -140,6 +140,23 @@ def _run_install(install_args: list[str], packages_dir: str):
)


def _validate_python_archive_path(archive_path: str) -> None:
for component in archive_path.split(os.sep):
if any(ch.isspace() for ch in component):
raise ValueError(
"python bundle source path "
f"'{archive_path}' contains whitespace in path component '{component}'; "
"rename the file or directory before running `braintrust push`"
)


def _validate_python_bundle_source_paths(sources: list[str], archive_root: str | None = None) -> None:
abs_root = os.path.abspath(archive_root or os.getcwd())
for source in sources:
archive_path = os.path.normpath(os.path.relpath(os.path.abspath(source), abs_root))
_validate_python_archive_path(archive_path)


def _upload_bundle(entry_module_name: str, sources: list[str], requirements: str | None) -> str:
_check_uv()

Expand DownExpand Up@@ -369,6 +386,7 @@ def run(args):
needs_bundle = len(global_.functions) > 0 or len(evaluators) > 0
bundle_id = None
if needs_bundle:
_validate_python_bundle_source_paths(sources)
bundle_id = _upload_bundle(module_name, sources, args.requirements)

if len(global_.functions) > 0:
Expand Down
38 changes: 37 additions & 1 deletion py/src/braintrust/cli/test_push.py
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
"""Tests for push command serialization."""

import sys

import pytest


Expand All@@ -9,7 +11,7 @@
global_,
projects,
)
from .push import _collect_function_function_defs
from .push import _collect_function_function_defs, _validate_python_bundle_source_paths


class ToolInput(pydantic.BaseModel):
Expand DownExpand Up@@ -100,3 +102,37 @@ def test_collect_function_function_defs_excludes_tags_when_none(self, mock_proje

assert len(functions) == 1
assert "tags" not in functions[0]


class TestValidatePythonBundleSourcePaths:
def _assert_whitespace_in_filename_rejected(self, tmp_path, filename: str):
source = tmp_path / filename
source.write_text("VALUE = 1\n")

with pytest.raises(ValueError, match="contains whitespace in path component"):
_validate_python_bundle_source_paths([str(source)], str(tmp_path))

def test_rejects_whitespace_in_filename(self, tmp_path):
self._assert_whitespace_in_filename_rejected(tmp_path, "my tool.py")

@pytest.mark.skipif(sys.platform == "win32", reason="leading-space filenames are not portable on Windows")
def test_rejects_leading_whitespace_in_filename(self, tmp_path):
self._assert_whitespace_in_filename_rejected(tmp_path, " tool.py")

def test_rejects_whitespace_in_directory_name(self, tmp_path):
subdir = tmp_path / "my tools"
subdir.mkdir()
source = subdir / "tool.py"
source.write_text("VALUE = 1\n")

with pytest.raises(ValueError, match="contains whitespace in path component"):
_validate_python_bundle_source_paths([str(source)], str(tmp_path))

@pytest.mark.skipif(sys.platform == "win32", reason="tab characters in filenames are not allowed on Windows")
def test_rejects_tab_in_filename(self, tmp_path):
self._assert_whitespace_in_filename_rejected(tmp_path, "my\ttool.py")

def test_accepts_valid_path(self, tmp_path):
source = tmp_path / "my_tool.py"
source.write_text("VALUE = 1\n")
_validate_python_bundle_source_paths([str(source)], str(tmp_path))
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(cli): reject whitespace in python bundle filenames by AbhiPrasad · Pull Request #237 · braintrustdata/braintrust-sdk-python · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions py/src/braintrust/cli/push.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -140,6 +140,23 @@ def _run_install(install_args: list[str], packages_dir: str):
)


def _validate_python_archive_path(archive_path: str) -> None:
for component in archive_path.split(os.sep):
if any(ch.isspace() for ch in component):
raise ValueError(
"python bundle source path "
f"'{archive_path}' contains whitespace in path component '{component}'; "
"rename the file or directory before running `braintrust push`"
)


def _validate_python_bundle_source_paths(sources: list[str], archive_root: str | None = None) -> None:
abs_root = os.path.abspath(archive_root or os.getcwd())
for source in sources:
archive_path = os.path.normpath(os.path.relpath(os.path.abspath(source), abs_root))
_validate_python_archive_path(archive_path)


def _upload_bundle(entry_module_name: str, sources: list[str], requirements: str | None) -> str:
_check_uv()

Expand DownExpand Up@@ -369,6 +386,7 @@ def run(args):
needs_bundle = len(global_.functions) > 0 or len(evaluators) > 0
bundle_id = None
if needs_bundle:
_validate_python_bundle_source_paths(sources)
bundle_id = _upload_bundle(module_name, sources, args.requirements)

if len(global_.functions) > 0:
Expand Down
38 changes: 37 additions & 1 deletion py/src/braintrust/cli/test_push.py
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
"""Tests for push command serialization."""

import sys

import pytest


Expand All@@ -9,7 +11,7 @@
global_,
projects,
)
from .push import _collect_function_function_defs
from .push import _collect_function_function_defs, _validate_python_bundle_source_paths


class ToolInput(pydantic.BaseModel):
Expand DownExpand Up@@ -100,3 +102,37 @@ def test_collect_function_function_defs_excludes_tags_when_none(self, mock_proje

assert len(functions) == 1
assert "tags" not in functions[0]


class TestValidatePythonBundleSourcePaths:
def _assert_whitespace_in_filename_rejected(self, tmp_path, filename: str):
source = tmp_path / filename
source.write_text("VALUE = 1\n")

with pytest.raises(ValueError, match="contains whitespace in path component"):
_validate_python_bundle_source_paths([str(source)], str(tmp_path))

def test_rejects_whitespace_in_filename(self, tmp_path):
self._assert_whitespace_in_filename_rejected(tmp_path, "my tool.py")

@pytest.mark.skipif(sys.platform == "win32", reason="leading-space filenames are not portable on Windows")
def test_rejects_leading_whitespace_in_filename(self, tmp_path):
self._assert_whitespace_in_filename_rejected(tmp_path, " tool.py")

def test_rejects_whitespace_in_directory_name(self, tmp_path):
subdir = tmp_path / "my tools"
subdir.mkdir()
source = subdir / "tool.py"
source.write_text("VALUE = 1\n")

with pytest.raises(ValueError, match="contains whitespace in path component"):
_validate_python_bundle_source_paths([str(source)], str(tmp_path))

@pytest.mark.skipif(sys.platform == "win32", reason="tab characters in filenames are not allowed on Windows")
def test_rejects_tab_in_filename(self, tmp_path):
self._assert_whitespace_in_filename_rejected(tmp_path, "my\ttool.py")

def test_accepts_valid_path(self, tmp_path):
source = tmp_path / "my_tool.py"
source.write_text("VALUE = 1\n")
_validate_python_bundle_source_paths([str(source)], str(tmp_path))
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' fix(cli): reject whitespace in python bundle filenames by AbhiPrasad · Pull Request #237 · braintrustdata/braintrust-sdk-python · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions py/src/braintrust/cli/push.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -140,6 +140,23 @@ def _run_install(install_args: list[str], packages_dir: str):
)


def _validate_python_archive_path(archive_path: str) -> None:
for component in archive_path.split(os.sep):
if any(ch.isspace() for ch in component):
raise ValueError(
"python bundle source path "
f"'{archive_path}' contains whitespace in path component '{component}'; "
"rename the file or directory before running `braintrust push`"
)


def _validate_python_bundle_source_paths(sources: list[str], archive_root: str | None = None) -> None:
abs_root = os.path.abspath(archive_root or os.getcwd())
for source in sources:
archive_path = os.path.normpath(os.path.relpath(os.path.abspath(source), abs_root))
_validate_python_archive_path(archive_path)


def _upload_bundle(entry_module_name: str, sources: list[str], requirements: str | None) -> str:
_check_uv()

Expand DownExpand Up@@ -369,6 +386,7 @@ def run(args):
needs_bundle = len(global_.functions) > 0 or len(evaluators) > 0
bundle_id = None
if needs_bundle:
_validate_python_bundle_source_paths(sources)
bundle_id = _upload_bundle(module_name, sources, args.requirements)

if len(global_.functions) > 0:
Expand Down
38 changes: 37 additions & 1 deletion py/src/braintrust/cli/test_push.py
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
"""Tests for push command serialization."""

import sys

import pytest


Expand All@@ -9,7 +11,7 @@
global_,
projects,
)
from .push import _collect_function_function_defs
from .push import _collect_function_function_defs, _validate_python_bundle_source_paths


class ToolInput(pydantic.BaseModel):
Expand DownExpand Up@@ -100,3 +102,37 @@ def test_collect_function_function_defs_excludes_tags_when_none(self, mock_proje

assert len(functions) == 1
assert "tags" not in functions[0]


class TestValidatePythonBundleSourcePaths:
def _assert_whitespace_in_filename_rejected(self, tmp_path, filename: str):
source = tmp_path / filename
source.write_text("VALUE = 1\n")

with pytest.raises(ValueError, match="contains whitespace in path component"):
_validate_python_bundle_source_paths([str(source)], str(tmp_path))

def test_rejects_whitespace_in_filename(self, tmp_path):
self._assert_whitespace_in_filename_rejected(tmp_path, "my tool.py")

@pytest.mark.skipif(sys.platform == "win32", reason="leading-space filenames are not portable on Windows")
def test_rejects_leading_whitespace_in_filename(self, tmp_path):
self._assert_whitespace_in_filename_rejected(tmp_path, " tool.py")

def test_rejects_whitespace_in_directory_name(self, tmp_path):
subdir = tmp_path / "my tools"
subdir.mkdir()
source = subdir / "tool.py"
source.write_text("VALUE = 1\n")

with pytest.raises(ValueError, match="contains whitespace in path component"):
_validate_python_bundle_source_paths([str(source)], str(tmp_path))

@pytest.mark.skipif(sys.platform == "win32", reason="tab characters in filenames are not allowed on Windows")
def test_rejects_tab_in_filename(self, tmp_path):
self._assert_whitespace_in_filename_rejected(tmp_path, "my\ttool.py")

def test_accepts_valid_path(self, tmp_path):
source = tmp_path / "my_tool.py"
source.write_text("VALUE = 1\n")
_validate_python_bundle_source_paths([str(source)], str(tmp_path))
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(cli): reject whitespace in python bundle filenames by AbhiPrasad · Pull Request #237 · braintrustdata/braintrust-sdk-python · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions py/src/braintrust/cli/push.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -140,6 +140,23 @@ def _run_install(install_args: list[str], packages_dir: str):
)


def _validate_python_archive_path(archive_path: str) -> None:
for component in archive_path.split(os.sep):
if any(ch.isspace() for ch in component):
raise ValueError(
"python bundle source path "
f"'{archive_path}' contains whitespace in path component '{component}'; "
"rename the file or directory before running `braintrust push`"
)


def _validate_python_bundle_source_paths(sources: list[str], archive_root: str | None = None) -> None:
abs_root = os.path.abspath(archive_root or os.getcwd())
for source in sources:
archive_path = os.path.normpath(os.path.relpath(os.path.abspath(source), abs_root))
_validate_python_archive_path(archive_path)


def _upload_bundle(entry_module_name: str, sources: list[str], requirements: str | None) -> str:
_check_uv()

Expand DownExpand Up@@ -369,6 +386,7 @@ def run(args):
needs_bundle = len(global_.functions) > 0 or len(evaluators) > 0
bundle_id = None
if needs_bundle:
_validate_python_bundle_source_paths(sources)
bundle_id = _upload_bundle(module_name, sources, args.requirements)

if len(global_.functions) > 0:
Expand Down
38 changes: 37 additions & 1 deletion py/src/braintrust/cli/test_push.py
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
"""Tests for push command serialization."""

import sys

import pytest


Expand All@@ -9,7 +11,7 @@
global_,
projects,
)
from .push import _collect_function_function_defs
from .push import _collect_function_function_defs, _validate_python_bundle_source_paths


class ToolInput(pydantic.BaseModel):
Expand DownExpand Up@@ -100,3 +102,37 @@ def test_collect_function_function_defs_excludes_tags_when_none(self, mock_proje

assert len(functions) == 1
assert "tags" not in functions[0]


class TestValidatePythonBundleSourcePaths:
def _assert_whitespace_in_filename_rejected(self, tmp_path, filename: str):
source = tmp_path / filename
source.write_text("VALUE = 1\n")

with pytest.raises(ValueError, match="contains whitespace in path component"):
_validate_python_bundle_source_paths([str(source)], str(tmp_path))

def test_rejects_whitespace_in_filename(self, tmp_path):
self._assert_whitespace_in_filename_rejected(tmp_path, "my tool.py")

@pytest.mark.skipif(sys.platform == "win32", reason="leading-space filenames are not portable on Windows")
def test_rejects_leading_whitespace_in_filename(self, tmp_path):
self._assert_whitespace_in_filename_rejected(tmp_path, " tool.py")

def test_rejects_whitespace_in_directory_name(self, tmp_path):
subdir = tmp_path / "my tools"
subdir.mkdir()
source = subdir / "tool.py"
source.write_text("VALUE = 1\n")

with pytest.raises(ValueError, match="contains whitespace in path component"):
_validate_python_bundle_source_paths([str(source)], str(tmp_path))

@pytest.mark.skipif(sys.platform == "win32", reason="tab characters in filenames are not allowed on Windows")
def test_rejects_tab_in_filename(self, tmp_path):
self._assert_whitespace_in_filename_rejected(tmp_path, "my\ttool.py")

def test_accepts_valid_path(self, tmp_path):
source = tmp_path / "my_tool.py"
source.write_text("VALUE = 1\n")
_validate_python_bundle_source_paths([str(source)], str(tmp_path))
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(cli): reject whitespace in python bundle filenames by AbhiPrasad · Pull Request #237 · braintrustdata/braintrust-sdk-python · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions py/src/braintrust/cli/push.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -140,6 +140,23 @@ def _run_install(install_args: list[str], packages_dir: str):
)


def _validate_python_archive_path(archive_path: str) -> None:
for component in archive_path.split(os.sep):
if any(ch.isspace() for ch in component):
raise ValueError(
"python bundle source path "
f"'{archive_path}' contains whitespace in path component '{component}'; "
"rename the file or directory before running `braintrust push`"
)


def _validate_python_bundle_source_paths(sources: list[str], archive_root: str | None = None) -> None:
abs_root = os.path.abspath(archive_root or os.getcwd())
for source in sources:
archive_path = os.path.normpath(os.path.relpath(os.path.abspath(source), abs_root))
_validate_python_archive_path(archive_path)


def _upload_bundle(entry_module_name: str, sources: list[str], requirements: str | None) -> str:
_check_uv()

Expand DownExpand Up@@ -369,6 +386,7 @@ def run(args):
needs_bundle = len(global_.functions) > 0 or len(evaluators) > 0
bundle_id = None
if needs_bundle:
_validate_python_bundle_source_paths(sources)
bundle_id = _upload_bundle(module_name, sources, args.requirements)

if len(global_.functions) > 0:
Expand Down
38 changes: 37 additions & 1 deletion py/src/braintrust/cli/test_push.py
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
"""Tests for push command serialization."""

import sys

import pytest


Expand All@@ -9,7 +11,7 @@
global_,
projects,
)
from .push import _collect_function_function_defs
from .push import _collect_function_function_defs, _validate_python_bundle_source_paths


class ToolInput(pydantic.BaseModel):
Expand DownExpand Up@@ -100,3 +102,37 @@ def test_collect_function_function_defs_excludes_tags_when_none(self, mock_proje

assert len(functions) == 1
assert "tags" not in functions[0]


class TestValidatePythonBundleSourcePaths:
def _assert_whitespace_in_filename_rejected(self, tmp_path, filename: str):
source = tmp_path / filename
source.write_text("VALUE = 1\n")

with pytest.raises(ValueError, match="contains whitespace in path component"):
_validate_python_bundle_source_paths([str(source)], str(tmp_path))

def test_rejects_whitespace_in_filename(self, tmp_path):
self._assert_whitespace_in_filename_rejected(tmp_path, "my tool.py")

@pytest.mark.skipif(sys.platform == "win32", reason="leading-space filenames are not portable on Windows")
def test_rejects_leading_whitespace_in_filename(self, tmp_path):
self._assert_whitespace_in_filename_rejected(tmp_path, " tool.py")

def test_rejects_whitespace_in_directory_name(self, tmp_path):
subdir = tmp_path / "my tools"
subdir.mkdir()
source = subdir / "tool.py"
source.write_text("VALUE = 1\n")

with pytest.raises(ValueError, match="contains whitespace in path component"):
_validate_python_bundle_source_paths([str(source)], str(tmp_path))

@pytest.mark.skipif(sys.platform == "win32", reason="tab characters in filenames are not allowed on Windows")
def test_rejects_tab_in_filename(self, tmp_path):
self._assert_whitespace_in_filename_rejected(tmp_path, "my\ttool.py")

def test_accepts_valid_path(self, tmp_path):
source = tmp_path / "my_tool.py"
source.write_text("VALUE = 1\n")
_validate_python_bundle_source_paths([str(source)], str(tmp_path))
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); fix(cli): reject whitespace in python bundle filenames by AbhiPrasad · Pull Request #237 · braintrustdata/braintrust-sdk-python · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions py/src/braintrust/cli/push.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -140,6 +140,23 @@ def _run_install(install_args: list[str], packages_dir: str):
)


def _validate_python_archive_path(archive_path: str) -> None:
for component in archive_path.split(os.sep):
if any(ch.isspace() for ch in component):
raise ValueError(
"python bundle source path "
f"'{archive_path}' contains whitespace in path component '{component}'; "
"rename the file or directory before running `braintrust push`"
)


def _validate_python_bundle_source_paths(sources: list[str], archive_root: str | None = None) -> None:
abs_root = os.path.abspath(archive_root or os.getcwd())
for source in sources:
archive_path = os.path.normpath(os.path.relpath(os.path.abspath(source), abs_root))
_validate_python_archive_path(archive_path)


def _upload_bundle(entry_module_name: str, sources: list[str], requirements: str | None) -> str:
_check_uv()

Expand DownExpand Up@@ -369,6 +386,7 @@ def run(args):
needs_bundle = len(global_.functions) > 0 or len(evaluators) > 0
bundle_id = None
if needs_bundle:
_validate_python_bundle_source_paths(sources)
bundle_id = _upload_bundle(module_name, sources, args.requirements)

if len(global_.functions) > 0:
Expand Down
38 changes: 37 additions & 1 deletion py/src/braintrust/cli/test_push.py
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
"""Tests for push command serialization."""

import sys

import pytest


Expand All@@ -9,7 +11,7 @@
global_,
projects,
)
from .push import _collect_function_function_defs
from .push import _collect_function_function_defs, _validate_python_bundle_source_paths


class ToolInput(pydantic.BaseModel):
Expand DownExpand Up@@ -100,3 +102,37 @@ def test_collect_function_function_defs_excludes_tags_when_none(self, mock_proje

assert len(functions) == 1
assert "tags" not in functions[0]


class TestValidatePythonBundleSourcePaths:
def _assert_whitespace_in_filename_rejected(self, tmp_path, filename: str):
source = tmp_path / filename
source.write_text("VALUE = 1\n")

with pytest.raises(ValueError, match="contains whitespace in path component"):
_validate_python_bundle_source_paths([str(source)], str(tmp_path))

def test_rejects_whitespace_in_filename(self, tmp_path):
self._assert_whitespace_in_filename_rejected(tmp_path, "my tool.py")

@pytest.mark.skipif(sys.platform == "win32", reason="leading-space filenames are not portable on Windows")
def test_rejects_leading_whitespace_in_filename(self, tmp_path):
self._assert_whitespace_in_filename_rejected(tmp_path, " tool.py")

def test_rejects_whitespace_in_directory_name(self, tmp_path):
subdir = tmp_path / "my tools"
subdir.mkdir()
source = subdir / "tool.py"
source.write_text("VALUE = 1\n")

with pytest.raises(ValueError, match="contains whitespace in path component"):
_validate_python_bundle_source_paths([str(source)], str(tmp_path))

@pytest.mark.skipif(sys.platform == "win32", reason="tab characters in filenames are not allowed on Windows")
def test_rejects_tab_in_filename(self, tmp_path):
self._assert_whitespace_in_filename_rejected(tmp_path, "my\ttool.py")

def test_accepts_valid_path(self, tmp_path):
source = tmp_path / "my_tool.py"
source.write_text("VALUE = 1\n")
_validate_python_bundle_source_paths([str(source)], str(tmp_path))
Loading