fix(framework): split Output TypeVar into Output and Expected#243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Abhijeet Prasad (AbhiPrasad) merged 3 commits into from
Apr 10, 2026
Merged

fix(framework): split Output TypeVar into Output and Expected#243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e5c4c43
fix(framework): split `Output` TypeVar into `Output` and `Expected` (…
Apr 9, 2026
dbe6a10
fix(noxfile): pin pyright and mypy versions in test_types session
AbhiPrasad Apr 9, 2026
e619a9f
fix(devserver): update Evaluator generic params to include Expected
AbhiPrasad Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions AGENTS.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,7 @@ Important code areas in `py/src/braintrust/`:
- temporal: `contrib/temporal/`
- CLI/devserver: `cli/`, `devserver/`
- tests: colocated `test_*.py`
- type tests: `type_tests/`

## Setup

Expand DownExpand Up@@ -83,13 +84,27 @@ Testing preferences:
Key facts:

- `test_core` runs without optional vendor packages.
- `test_types` runs pyright, mypy, and pytest on `py/src/braintrust/type_tests/`. Use this session when changing generic type signatures in the framework.
- wrapper coverage is split across dedicated nox sessions by provider/version.
- `pylint` installs the broad dependency surface before checking files.
- `cd py && make pylint` runs only `pylint`; `cd py && make lint` runs pre-commit hooks first and then `pylint`.
- `test-wheel` is a wheel sanity check and requires a built wheel first.

When changing behavior, run the narrowest affected session first, then expand only if needed.

## Type Tests

`py/src/braintrust/type_tests/` contains tests that are validated by both static type checkers (pyright, mypy) and pytest at runtime. The `test_types` nox session runs all three checks and is auto-discovered by CI.

When changing generic type signatures (e.g., `Eval`, `EvalCase`, `EvalScorer`, `EvalHooks`), add or update a test in `type_tests/` to verify the type checker accepts the intended usage patterns.

New test files should be named `test_*.py` and use absolute imports (`from braintrust.framework import ...`). They are regular pytest files that also happen to be valid pyright/mypy targets.

```bash
cd py
nox -s test_types
```

## VCR

VCR/cassette coverage is the default and preferred testing strategy for provider and integration behavior in this repo. Reach for cassette-backed tests before introducing mocks or fakes, and keep new coverage aligned with the existing VCR patterns unless there is a strong reason not to.
Expand Down
11 changes: 11 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -134,6 +134,17 @@ BRAINTRUST_CLAUDE_AGENT_SDK_RECORD_MODE=all \
nox -s "test_claude_agent_sdk(latest)" -- -k "test_calculator_with_multiple_operations"
```

### Type Tests

`py/src/braintrust/type_tests/` contains tests that are checked by pyright, mypy, and pytest. The `test_types` nox session runs all three and is included in CI automatically.

When changing generic type signatures (e.g., `Eval`, `EvalCase`, `EvalScorer`, `EvalHooks`), add or update a test file in `type_tests/` to verify the type checker accepts the intended usage patterns. Test files are named `test_*.py`, use absolute imports (`from braintrust.framework import ...`), and double as regular pytest files.

```bash
cd py
nox -s test_types
```

### Fixtures

Shared test fixtures live in `py/src/braintrust/conftest.py`.
Expand Down
23 changes: 23 additions & 0 deletions py/noxfile.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -44,6 +44,7 @@ def _pinned_python_version():
INTEGRATION_DIR = "braintrust/integrations"
CONTRIB_DIR = "braintrust/contrib"
DEVSERVER_DIR = "braintrust/devserver"
TYPE_TESTS_DIR = "braintrust/type_tests"


SILENT_INSTALLS = True
Expand DownExpand Up@@ -390,6 +391,27 @@ def test_otel_not_installed(session):
_run_tests(session, "braintrust/test_otel.py")


@nox.session()
def test_types(session):
"""Run type-check tests with pyright, mypy, and pytest."""
_install_test_deps(session)
session.install("pyright==1.1.408", "mypy==1.20.0")

type_tests_dir = f"src/{TYPE_TESTS_DIR}"
test_files = glob.glob(os.path.join(type_tests_dir, "test_*.py"))
if not test_files:
session.skip("No type test files found")

# Run pyright on each file
session.run("pyright", *test_files)

# Run mypy on each file (only check the test files themselves, not transitive deps)
session.run("mypy", "--follow-imports=silent", *test_files)

# Run pytest for the runtime assertions
_run_tests(session, TYPE_TESTS_DIR)


@nox.session()
def pylint(session):
# pylint needs everything so we don't trigger missing import errors
Expand DownExpand Up@@ -502,6 +524,7 @@ def _run_core_tests(session):
*_integration_subdirs_to_ignore(),
CONTRIB_DIR,
DEVSERVER_DIR,
TYPE_TESTS_DIR,
],
)

Expand Down
8 changes: 4 additions & 4 deletions py/src/braintrust/devserver/server.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -50,7 +50,7 @@
from .schemas import ValidationError, parse_eval_body


_all_evaluators: dict[str, Evaluator[Any, Any]] = {}
_all_evaluators: dict[str, Evaluator[Any, Any, Any]] = {}


class _ParameterOverrideHooks:
Expand DownExpand Up@@ -289,7 +289,7 @@ async def run_and_complete():
return JSONResponse({"error": f"Failed to run evaluation: {str(e)}"}, status_code=500)


def create_app(evaluators: list[Evaluator[Any, Any]], org_name: str | None = None):
def create_app(evaluators: list[Evaluator[Any, Any, Any]], org_name: str | None = None):
"""Create and configure the Starlette app for the dev server.

Args:
Expand DownExpand Up@@ -318,7 +318,7 @@ def create_app(evaluators: list[Evaluator[Any, Any]], org_name: str | None = Non


def run_dev_server(
evaluators: list[Evaluator[Any, Any]],
evaluators: list[Evaluator[Any, Any, Any]],
host: str = "localhost",
port: int = 8300,
org_name: str | None = None,
Expand DownExpand Up@@ -346,7 +346,7 @@ def snake_to_camel(snake_str: str) -> str:

def make_scorer(
state: BraintrustState, name: str, score: FunctionId, project_id: str | None = None
) -> EvalScorer[Any, Any]:
) -> EvalScorer[Any, Any, Any]:
def scorer_fn(input, output, expected, metadata):
request = {
**score,
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
fix(framework): split Output TypeVar into Output and Expected#243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Abhijeet Prasad (AbhiPrasad)
merged 3 commits into

from

Apr 10, 2026
 Merged


fix(framework): split Output TypeVar into Output and Expected#243
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
e5c4c43

fix(framework): split `Output` TypeVar into `Output` and `Expected` (…

Apr 9, 2026
dbe6a10

fix(noxfile): pin pyright and mypy versions in test_types session


AbhiPrasad Apr 9, 2026
e619a9f

fix(devserver): update Evaluator generic params to include Expected


AbhiPrasad Apr 9, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


15 changes: 15 additions & 0 deletions
AGENTS.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,7 @@ Important code areas in `py/src/braintrust/`:
- temporal: `contrib/temporal/`
- CLI/devserver: `cli/`, `devserver/`
- tests: colocated `test_*.py`
- type tests: `type_tests/`

## Setup

Expand DownExpand Up@@ -83,13 +84,27 @@ Testing preferences:
Key facts:

- `test_core` runs without optional vendor packages.
- `test_types` runs pyright, mypy, and pytest on `py/src/braintrust/type_tests/`. Use this session when changing generic type signatures in the framework.
- wrapper coverage is split across dedicated nox sessions by provider/version.
- `pylint` installs the broad dependency surface before checking files.
- `cd py && make pylint` runs only `pylint`; `cd py && make lint` runs pre-commit hooks first and then `pylint`.
- `test-wheel` is a wheel sanity check and requires a built wheel first.

When changing behavior, run the narrowest affected session first, then expand only if needed.

## Type Tests

`py/src/braintrust/type_tests/` contains tests that are validated by both static type checkers (pyright, mypy) and pytest at runtime. The `test_types` nox session runs all three checks and is auto-discovered by CI.

When changing generic type signatures (e.g., `Eval`, `EvalCase`, `EvalScorer`, `EvalHooks`), add or update a test in `type_tests/` to verify the type checker accepts the intended usage patterns.

New test files should be named `test_*.py` and use absolute imports (`from braintrust.framework import ...`). They are regular pytest files that also happen to be valid pyright/mypy targets.

```bash
cd py
nox -s test_types
```

## VCR

VCR/cassette coverage is the default and preferred testing strategy for provider and integration behavior in this repo. Reach for cassette-backed tests before introducing mocks or fakes, and keep new coverage aligned with the existing VCR patterns unless there is a strong reason not to.
Expand Down

11 changes: 11 additions & 0 deletions
CONTRIBUTING.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -134,6 +134,17 @@ BRAINTRUST_CLAUDE_AGENT_SDK_RECORD_MODE=all \
 nox -s "test_claude_agent_sdk(latest)" -- -k "test_calculator_with_multiple_operations"
```

### Type Tests

`py/src/braintrust/type_tests/` contains tests that are checked by pyright, mypy, and pytest. The `test_types` nox session runs all three and is included in CI automatically.

When changing generic type signatures (e.g., `Eval`, `EvalCase`, `EvalScorer`, `EvalHooks`), add or update a test file in `type_tests/` to verify the type checker accepts the intended usage patterns. Test files are named `test_*.py`, use absolute imports (`from braintrust.framework import ...`), and double as regular pytest files.

```bash
cd py
nox -s test_types
```

### Fixtures

Shared test fixtures live in `py/src/braintrust/conftest.py`.
Expand Down

23 changes: 23 additions & 0 deletions
py/noxfile.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -44,6 +44,7 @@ def _pinned_python_version():
INTEGRATION_DIR = "braintrust/integrations"
CONTRIB_DIR = "braintrust/contrib"
DEVSERVER_DIR = "braintrust/devserver"
TYPE_TESTS_DIR = "braintrust/type_tests"


SILENT_INSTALLS = True
Expand DownExpand Up@@ -390,6 +391,27 @@ def test_otel_not_installed(session):
 _run_tests(session, "braintrust/test_otel.py")


@nox.session()
def test_types(session):
 """Run type-check tests with pyright, mypy, and pytest."""
 _install_test_deps(session)
 session.install("pyright==1.1.408", "mypy==1.20.0")

 type_tests_dir = f"src/{TYPE_TESTS_DIR}"
 test_files = glob.glob(os.path.join(type_tests_dir, "test_*.py"))
 if not test_files:
 session.skip("No type test files found")

 # Run pyright on each file
 session.run("pyright", *test_files)

 # Run mypy on each file (only check the test files themselves, not transitive deps)
 session.run("mypy", "--follow-imports=silent", *test_files)

 # Run pytest for the runtime assertions
 _run_tests(session, TYPE_TESTS_DIR)


@nox.session()
def pylint(session):
 # pylint needs everything so we don't trigger missing import errors
Expand DownExpand Up@@ -502,6 +524,7 @@ def _run_core_tests(session):
 *_integration_subdirs_to_ignore(),
 CONTRIB_DIR,
 DEVSERVER_DIR,
 TYPE_TESTS_DIR,
 ],
 )

Expand Down

8 changes: 4 additions & 4 deletions
py/src/braintrust/devserver/server.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -50,7 +50,7 @@
from .schemas import ValidationError, parse_eval_body


_all_evaluators: dict[str, Evaluator[Any, Any]] = {}
_all_evaluators: dict[str, Evaluator[Any, Any, Any]] = {}


class _ParameterOverrideHooks:
Expand DownExpand Up@@ -289,7 +289,7 @@ async def run_and_complete():
 return JSONResponse({"error": f"Failed to run evaluation: {str(e)}"}, status_code=500)


def create_app(evaluators: list[Evaluator[Any, Any]], org_name: str | None = None):
def create_app(evaluators: list[Evaluator[Any, Any, Any]], org_name: str | None = None):
 """Create and configure the Starlette app for the dev server.

 Args:
Expand DownExpand Up@@ -318,7 +318,7 @@ def create_app(evaluators: list[Evaluator[Any, Any]], org_name: str | None = Non


def run_dev_server(
 evaluators: list[Evaluator[Any, Any]],
 evaluators: list[Evaluator[Any, Any, Any]],
 host: str = "localhost",
 port: int = 8300,
 org_name: str | None = None,
Expand DownExpand Up@@ -346,7 +346,7 @@ def snake_to_camel(snake_str: str) -> str:

def make_scorer(
 state: BraintrustState, name: str, score: FunctionId, project_id: str | None = None
) -> EvalScorer[Any, Any]:
) -> EvalScorer[Any, Any, Any]:
 def scorer_fn(input, output, expected, metadata):
 request = {
 **score,
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(framework): split Output TypeVar into Output and Expected#243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Abhijeet Prasad (AbhiPrasad)
merged 3 commits into

from

Apr 10, 2026
 Merged


fix(framework): split Output TypeVar into Output and Expected#243
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
e5c4c43

fix(framework): split `Output` TypeVar into `Output` and `Expected` (…

Apr 9, 2026
dbe6a10

fix(noxfile): pin pyright and mypy versions in test_types session


AbhiPrasad Apr 9, 2026
e619a9f

fix(devserver): update Evaluator generic params to include Expected


AbhiPrasad Apr 9, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


15 changes: 15 additions & 0 deletions
AGENTS.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,7 @@ Important code areas in `py/src/braintrust/`:
- temporal: `contrib/temporal/`
- CLI/devserver: `cli/`, `devserver/`
- tests: colocated `test_*.py`
- type tests: `type_tests/`

## Setup

Expand DownExpand Up@@ -83,13 +84,27 @@ Testing preferences:
Key facts:

- `test_core` runs without optional vendor packages.
- `test_types` runs pyright, mypy, and pytest on `py/src/braintrust/type_tests/`. Use this session when changing generic type signatures in the framework.
- wrapper coverage is split across dedicated nox sessions by provider/version.
- `pylint` installs the broad dependency surface before checking files.
- `cd py && make pylint` runs only `pylint`; `cd py && make lint` runs pre-commit hooks first and then `pylint`.
- `test-wheel` is a wheel sanity check and requires a built wheel first.

When changing behavior, run the narrowest affected session first, then expand only if needed.

## Type Tests

`py/src/braintrust/type_tests/` contains tests that are validated by both static type checkers (pyright, mypy) and pytest at runtime. The `test_types` nox session runs all three checks and is auto-discovered by CI.

When changing generic type signatures (e.g., `Eval`, `EvalCase`, `EvalScorer`, `EvalHooks`), add or update a test in `type_tests/` to verify the type checker accepts the intended usage patterns.

New test files should be named `test_*.py` and use absolute imports (`from braintrust.framework import ...`). They are regular pytest files that also happen to be valid pyright/mypy targets.

```bash
cd py
nox -s test_types
```

## VCR

VCR/cassette coverage is the default and preferred testing strategy for provider and integration behavior in this repo. Reach for cassette-backed tests before introducing mocks or fakes, and keep new coverage aligned with the existing VCR patterns unless there is a strong reason not to.
Expand Down

11 changes: 11 additions & 0 deletions
CONTRIBUTING.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -134,6 +134,17 @@ BRAINTRUST_CLAUDE_AGENT_SDK_RECORD_MODE=all \
 nox -s "test_claude_agent_sdk(latest)" -- -k "test_calculator_with_multiple_operations"
```

### Type Tests

`py/src/braintrust/type_tests/` contains tests that are checked by pyright, mypy, and pytest. The `test_types` nox session runs all three and is included in CI automatically.

When changing generic type signatures (e.g., `Eval`, `EvalCase`, `EvalScorer`, `EvalHooks`), add or update a test file in `type_tests/` to verify the type checker accepts the intended usage patterns. Test files are named `test_*.py`, use absolute imports (`from braintrust.framework import ...`), and double as regular pytest files.

```bash
cd py
nox -s test_types
```

### Fixtures

Shared test fixtures live in `py/src/braintrust/conftest.py`.
Expand Down

23 changes: 23 additions & 0 deletions
py/noxfile.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -44,6 +44,7 @@ def _pinned_python_version():
INTEGRATION_DIR = "braintrust/integrations"
CONTRIB_DIR = "braintrust/contrib"
DEVSERVER_DIR = "braintrust/devserver"
TYPE_TESTS_DIR = "braintrust/type_tests"


SILENT_INSTALLS = True
Expand DownExpand Up@@ -390,6 +391,27 @@ def test_otel_not_installed(session):
 _run_tests(session, "braintrust/test_otel.py")


@nox.session()
def test_types(session):
 """Run type-check tests with pyright, mypy, and pytest."""
 _install_test_deps(session)
 session.install("pyright==1.1.408", "mypy==1.20.0")

 type_tests_dir = f"src/{TYPE_TESTS_DIR}"
 test_files = glob.glob(os.path.join(type_tests_dir, "test_*.py"))
 if not test_files:
 session.skip("No type test files found")

 # Run pyright on each file
 session.run("pyright", *test_files)

 # Run mypy on each file (only check the test files themselves, not transitive deps)
 session.run("mypy", "--follow-imports=silent", *test_files)

 # Run pytest for the runtime assertions
 _run_tests(session, TYPE_TESTS_DIR)


@nox.session()
def pylint(session):
 # pylint needs everything so we don't trigger missing import errors
Expand DownExpand Up@@ -502,6 +524,7 @@ def _run_core_tests(session):
 *_integration_subdirs_to_ignore(),
 CONTRIB_DIR,
 DEVSERVER_DIR,
 TYPE_TESTS_DIR,
 ],
 )

Expand Down

8 changes: 4 additions & 4 deletions
py/src/braintrust/devserver/server.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -50,7 +50,7 @@
from .schemas import ValidationError, parse_eval_body


_all_evaluators: dict[str, Evaluator[Any, Any]] = {}
_all_evaluators: dict[str, Evaluator[Any, Any, Any]] = {}


class _ParameterOverrideHooks:
Expand DownExpand Up@@ -289,7 +289,7 @@ async def run_and_complete():
 return JSONResponse({"error": f"Failed to run evaluation: {str(e)}"}, status_code=500)


def create_app(evaluators: list[Evaluator[Any, Any]], org_name: str | None = None):
def create_app(evaluators: list[Evaluator[Any, Any, Any]], org_name: str | None = None):
 """Create and configure the Starlette app for the dev server.

 Args:
Expand DownExpand Up@@ -318,7 +318,7 @@ def create_app(evaluators: list[Evaluator[Any, Any]], org_name: str | None = Non


def run_dev_server(
 evaluators: list[Evaluator[Any, Any]],
 evaluators: list[Evaluator[Any, Any, Any]],
 host: str = "localhost",
 port: int = 8300,
 org_name: str | None = None,
Expand DownExpand Up@@ -346,7 +346,7 @@ def snake_to_camel(snake_str: str) -> str:

def make_scorer(
 state: BraintrustState, name: str, score: FunctionId, project_id: str | None = None
) -> EvalScorer[Any, Any]:
) -> EvalScorer[Any, Any, Any]:
 def scorer_fn(input, output, expected, metadata):
 request = {
 **score,
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(framework): split Output TypeVar into Output and Expected#243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Abhijeet Prasad (AbhiPrasad)
merged 3 commits into

from

Apr 10, 2026
 Merged


fix(framework): split Output TypeVar into Output and Expected#243
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
e5c4c43

fix(framework): split `Output` TypeVar into `Output` and `Expected` (…

Apr 9, 2026
dbe6a10

fix(noxfile): pin pyright and mypy versions in test_types session


AbhiPrasad Apr 9, 2026
e619a9f

fix(devserver): update Evaluator generic params to include Expected


AbhiPrasad Apr 9, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


15 changes: 15 additions & 0 deletions
AGENTS.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,7 @@ Important code areas in `py/src/braintrust/`:
- temporal: `contrib/temporal/`
- CLI/devserver: `cli/`, `devserver/`
- tests: colocated `test_*.py`
- type tests: `type_tests/`

## Setup

Expand DownExpand Up@@ -83,13 +84,27 @@ Testing preferences:
Key facts:

- `test_core` runs without optional vendor packages.
- `test_types` runs pyright, mypy, and pytest on `py/src/braintrust/type_tests/`. Use this session when changing generic type signatures in the framework.
- wrapper coverage is split across dedicated nox sessions by provider/version.
- `pylint` installs the broad dependency surface before checking files.
- `cd py && make pylint` runs only `pylint`; `cd py && make lint` runs pre-commit hooks first and then `pylint`.
- `test-wheel` is a wheel sanity check and requires a built wheel first.

When changing behavior, run the narrowest affected session first, then expand only if needed.

## Type Tests

`py/src/braintrust/type_tests/` contains tests that are validated by both static type checkers (pyright, mypy) and pytest at runtime. The `test_types` nox session runs all three checks and is auto-discovered by CI.

When changing generic type signatures (e.g., `Eval`, `EvalCase`, `EvalScorer`, `EvalHooks`), add or update a test in `type_tests/` to verify the type checker accepts the intended usage patterns.

New test files should be named `test_*.py` and use absolute imports (`from braintrust.framework import ...`). They are regular pytest files that also happen to be valid pyright/mypy targets.

```bash
cd py
nox -s test_types
```

## VCR

VCR/cassette coverage is the default and preferred testing strategy for provider and integration behavior in this repo. Reach for cassette-backed tests before introducing mocks or fakes, and keep new coverage aligned with the existing VCR patterns unless there is a strong reason not to.
Expand Down

11 changes: 11 additions & 0 deletions
CONTRIBUTING.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -134,6 +134,17 @@ BRAINTRUST_CLAUDE_AGENT_SDK_RECORD_MODE=all \
 nox -s "test_claude_agent_sdk(latest)" -- -k "test_calculator_with_multiple_operations"
```

### Type Tests

`py/src/braintrust/type_tests/` contains tests that are checked by pyright, mypy, and pytest. The `test_types` nox session runs all three and is included in CI automatically.

When changing generic type signatures (e.g., `Eval`, `EvalCase`, `EvalScorer`, `EvalHooks`), add or update a test file in `type_tests/` to verify the type checker accepts the intended usage patterns. Test files are named `test_*.py`, use absolute imports (`from braintrust.framework import ...`), and double as regular pytest files.

```bash
cd py
nox -s test_types
```

### Fixtures

Shared test fixtures live in `py/src/braintrust/conftest.py`.
Expand Down

23 changes: 23 additions & 0 deletions
py/noxfile.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -44,6 +44,7 @@ def _pinned_python_version():
INTEGRATION_DIR = "braintrust/integrations"
CONTRIB_DIR = "braintrust/contrib"
DEVSERVER_DIR = "braintrust/devserver"
TYPE_TESTS_DIR = "braintrust/type_tests"


SILENT_INSTALLS = True
Expand DownExpand Up@@ -390,6 +391,27 @@ def test_otel_not_installed(session):
 _run_tests(session, "braintrust/test_otel.py")


@nox.session()
def test_types(session):
 """Run type-check tests with pyright, mypy, and pytest."""
 _install_test_deps(session)
 session.install("pyright==1.1.408", "mypy==1.20.0")

 type_tests_dir = f"src/{TYPE_TESTS_DIR}"
 test_files = glob.glob(os.path.join(type_tests_dir, "test_*.py"))
 if not test_files:
 session.skip("No type test files found")

 # Run pyright on each file
 session.run("pyright", *test_files)

 # Run mypy on each file (only check the test files themselves, not transitive deps)
 session.run("mypy", "--follow-imports=silent", *test_files)

 # Run pytest for the runtime assertions
 _run_tests(session, TYPE_TESTS_DIR)


@nox.session()
def pylint(session):
 # pylint needs everything so we don't trigger missing import errors
Expand DownExpand Up@@ -502,6 +524,7 @@ def _run_core_tests(session):
 *_integration_subdirs_to_ignore(),
 CONTRIB_DIR,
 DEVSERVER_DIR,
 TYPE_TESTS_DIR,
 ],
 )

Expand Down

8 changes: 4 additions & 4 deletions
py/src/braintrust/devserver/server.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -50,7 +50,7 @@
from .schemas import ValidationError, parse_eval_body


_all_evaluators: dict[str, Evaluator[Any, Any]] = {}
_all_evaluators: dict[str, Evaluator[Any, Any, Any]] = {}


class _ParameterOverrideHooks:
Expand DownExpand Up@@ -289,7 +289,7 @@ async def run_and_complete():
 return JSONResponse({"error": f"Failed to run evaluation: {str(e)}"}, status_code=500)


def create_app(evaluators: list[Evaluator[Any, Any]], org_name: str | None = None):
def create_app(evaluators: list[Evaluator[Any, Any, Any]], org_name: str | None = None):
 """Create and configure the Starlette app for the dev server.

 Args:
Expand DownExpand Up@@ -318,7 +318,7 @@ def create_app(evaluators: list[Evaluator[Any, Any]], org_name: str | None = Non


def run_dev_server(
 evaluators: list[Evaluator[Any, Any]],
 evaluators: list[Evaluator[Any, Any, Any]],
 host: str = "localhost",
 port: int = 8300,
 org_name: str | None = None,
Expand DownExpand Up@@ -346,7 +346,7 @@ def snake_to_camel(snake_str: str) -> str:

def make_scorer(
 state: BraintrustState, name: str, score: FunctionId, project_id: str | None = None
) -> EvalScorer[Any, Any]:
) -> EvalScorer[Any, Any, Any]:
 def scorer_fn(input, output, expected, metadata):
 request = {
 **score,
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
fix(framework): split Output TypeVar into Output and Expected#243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Abhijeet Prasad (AbhiPrasad)
merged 3 commits into

from

Apr 10, 2026
 Merged


fix(framework): split Output TypeVar into Output and Expected#243
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
e5c4c43

fix(framework): split `Output` TypeVar into `Output` and `Expected` (…

Apr 9, 2026
dbe6a10

fix(noxfile): pin pyright and mypy versions in test_types session


AbhiPrasad Apr 9, 2026
e619a9f

fix(devserver): update Evaluator generic params to include Expected


AbhiPrasad Apr 9, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


15 changes: 15 additions & 0 deletions
AGENTS.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,7 @@ Important code areas in `py/src/braintrust/`:
- temporal: `contrib/temporal/`
- CLI/devserver: `cli/`, `devserver/`
- tests: colocated `test_*.py`
- type tests: `type_tests/`

## Setup

Expand DownExpand Up@@ -83,13 +84,27 @@ Testing preferences:
Key facts:

- `test_core` runs without optional vendor packages.
- `test_types` runs pyright, mypy, and pytest on `py/src/braintrust/type_tests/`. Use this session when changing generic type signatures in the framework.
- wrapper coverage is split across dedicated nox sessions by provider/version.
- `pylint` installs the broad dependency surface before checking files.
- `cd py && make pylint` runs only `pylint`; `cd py && make lint` runs pre-commit hooks first and then `pylint`.
- `test-wheel` is a wheel sanity check and requires a built wheel first.

When changing behavior, run the narrowest affected session first, then expand only if needed.

## Type Tests

`py/src/braintrust/type_tests/` contains tests that are validated by both static type checkers (pyright, mypy) and pytest at runtime. The `test_types` nox session runs all three checks and is auto-discovered by CI.

When changing generic type signatures (e.g., `Eval`, `EvalCase`, `EvalScorer`, `EvalHooks`), add or update a test in `type_tests/` to verify the type checker accepts the intended usage patterns.

New test files should be named `test_*.py` and use absolute imports (`from braintrust.framework import ...`). They are regular pytest files that also happen to be valid pyright/mypy targets.

```bash
cd py
nox -s test_types
```

## VCR

VCR/cassette coverage is the default and preferred testing strategy for provider and integration behavior in this repo. Reach for cassette-backed tests before introducing mocks or fakes, and keep new coverage aligned with the existing VCR patterns unless there is a strong reason not to.
Expand Down

11 changes: 11 additions & 0 deletions
CONTRIBUTING.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -134,6 +134,17 @@ BRAINTRUST_CLAUDE_AGENT_SDK_RECORD_MODE=all \
 nox -s "test_claude_agent_sdk(latest)" -- -k "test_calculator_with_multiple_operations"
```

### Type Tests

`py/src/braintrust/type_tests/` contains tests that are checked by pyright, mypy, and pytest. The `test_types` nox session runs all three and is included in CI automatically.

When changing generic type signatures (e.g., `Eval`, `EvalCase`, `EvalScorer`, `EvalHooks`), add or update a test file in `type_tests/` to verify the type checker accepts the intended usage patterns. Test files are named `test_*.py`, use absolute imports (`from braintrust.framework import ...`), and double as regular pytest files.

```bash
cd py
nox -s test_types
```

### Fixtures

Shared test fixtures live in `py/src/braintrust/conftest.py`.
Expand Down

23 changes: 23 additions & 0 deletions
py/noxfile.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -44,6 +44,7 @@ def _pinned_python_version():
INTEGRATION_DIR = "braintrust/integrations"
CONTRIB_DIR = "braintrust/contrib"
DEVSERVER_DIR = "braintrust/devserver"
TYPE_TESTS_DIR = "braintrust/type_tests"


SILENT_INSTALLS = True
Expand DownExpand Up@@ -390,6 +391,27 @@ def test_otel_not_installed(session):
 _run_tests(session, "braintrust/test_otel.py")


@nox.session()
def test_types(session):
 """Run type-check tests with pyright, mypy, and pytest."""
 _install_test_deps(session)
 session.install("pyright==1.1.408", "mypy==1.20.0")

 type_tests_dir = f"src/{TYPE_TESTS_DIR}"
 test_files = glob.glob(os.path.join(type_tests_dir, "test_*.py"))
 if not test_files:
 session.skip("No type test files found")

 # Run pyright on each file
 session.run("pyright", *test_files)

 # Run mypy on each file (only check the test files themselves, not transitive deps)
 session.run("mypy", "--follow-imports=silent", *test_files)

 # Run pytest for the runtime assertions
 _run_tests(session, TYPE_TESTS_DIR)


@nox.session()
def pylint(session):
 # pylint needs everything so we don't trigger missing import errors
Expand DownExpand Up@@ -502,6 +524,7 @@ def _run_core_tests(session):
 *_integration_subdirs_to_ignore(),
 CONTRIB_DIR,
 DEVSERVER_DIR,
 TYPE_TESTS_DIR,
 ],
 )

Expand Down

8 changes: 4 additions & 4 deletions
py/src/braintrust/devserver/server.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -50,7 +50,7 @@
from .schemas import ValidationError, parse_eval_body


_all_evaluators: dict[str, Evaluator[Any, Any]] = {}
_all_evaluators: dict[str, Evaluator[Any, Any, Any]] = {}


class _ParameterOverrideHooks:
Expand DownExpand Up@@ -289,7 +289,7 @@ async def run_and_complete():
 return JSONResponse({"error": f"Failed to run evaluation: {str(e)}"}, status_code=500)


def create_app(evaluators: list[Evaluator[Any, Any]], org_name: str | None = None):
def create_app(evaluators: list[Evaluator[Any, Any, Any]], org_name: str | None = None):
 """Create and configure the Starlette app for the dev server.

 Args:
Expand DownExpand Up@@ -318,7 +318,7 @@ def create_app(evaluators: list[Evaluator[Any, Any]], org_name: str | None = Non


def run_dev_server(
 evaluators: list[Evaluator[Any, Any]],
 evaluators: list[Evaluator[Any, Any, Any]],
 host: str = "localhost",
 port: int = 8300,
 org_name: str | None = None,
Expand DownExpand Up@@ -346,7 +346,7 @@ def snake_to_camel(snake_str: str) -> str:

def make_scorer(
 state: BraintrustState, name: str, score: FunctionId, project_id: str | None = None
) -> EvalScorer[Any, Any]:
) -> EvalScorer[Any, Any, Any]:
 def scorer_fn(input, output, expected, metadata):
 request = {
 **score,
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(framework): split Output TypeVar into Output and Expected#243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Abhijeet Prasad (AbhiPrasad)
merged 3 commits into

from

Apr 10, 2026
 Merged


fix(framework): split Output TypeVar into Output and Expected#243
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
e5c4c43

fix(framework): split `Output` TypeVar into `Output` and `Expected` (…

Apr 9, 2026
dbe6a10

fix(noxfile): pin pyright and mypy versions in test_types session


AbhiPrasad Apr 9, 2026
e619a9f

fix(devserver): update Evaluator generic params to include Expected


AbhiPrasad Apr 9, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


15 changes: 15 additions & 0 deletions
AGENTS.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,7 @@ Important code areas in `py/src/braintrust/`:
- temporal: `contrib/temporal/`
- CLI/devserver: `cli/`, `devserver/`
- tests: colocated `test_*.py`
- type tests: `type_tests/`

## Setup

Expand DownExpand Up@@ -83,13 +84,27 @@ Testing preferences:
Key facts:

- `test_core` runs without optional vendor packages.
- `test_types` runs pyright, mypy, and pytest on `py/src/braintrust/type_tests/`. Use this session when changing generic type signatures in the framework.
- wrapper coverage is split across dedicated nox sessions by provider/version.
- `pylint` installs the broad dependency surface before checking files.
- `cd py && make pylint` runs only `pylint`; `cd py && make lint` runs pre-commit hooks first and then `pylint`.
- `test-wheel` is a wheel sanity check and requires a built wheel first.

When changing behavior, run the narrowest affected session first, then expand only if needed.

## Type Tests

`py/src/braintrust/type_tests/` contains tests that are validated by both static type checkers (pyright, mypy) and pytest at runtime. The `test_types` nox session runs all three checks and is auto-discovered by CI.

When changing generic type signatures (e.g., `Eval`, `EvalCase`, `EvalScorer`, `EvalHooks`), add or update a test in `type_tests/` to verify the type checker accepts the intended usage patterns.

New test files should be named `test_*.py` and use absolute imports (`from braintrust.framework import ...`). They are regular pytest files that also happen to be valid pyright/mypy targets.

```bash
cd py
nox -s test_types
```

## VCR

VCR/cassette coverage is the default and preferred testing strategy for provider and integration behavior in this repo. Reach for cassette-backed tests before introducing mocks or fakes, and keep new coverage aligned with the existing VCR patterns unless there is a strong reason not to.
Expand Down

11 changes: 11 additions & 0 deletions
CONTRIBUTING.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -134,6 +134,17 @@ BRAINTRUST_CLAUDE_AGENT_SDK_RECORD_MODE=all \
 nox -s "test_claude_agent_sdk(latest)" -- -k "test_calculator_with_multiple_operations"
```

### Type Tests

`py/src/braintrust/type_tests/` contains tests that are checked by pyright, mypy, and pytest. The `test_types` nox session runs all three and is included in CI automatically.

When changing generic type signatures (e.g., `Eval`, `EvalCase`, `EvalScorer`, `EvalHooks`), add or update a test file in `type_tests/` to verify the type checker accepts the intended usage patterns. Test files are named `test_*.py`, use absolute imports (`from braintrust.framework import ...`), and double as regular pytest files.

```bash
cd py
nox -s test_types
```

### Fixtures

Shared test fixtures live in `py/src/braintrust/conftest.py`.
Expand Down

23 changes: 23 additions & 0 deletions
py/noxfile.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -44,6 +44,7 @@ def _pinned_python_version():
INTEGRATION_DIR = "braintrust/integrations"
CONTRIB_DIR = "braintrust/contrib"
DEVSERVER_DIR = "braintrust/devserver"
TYPE_TESTS_DIR = "braintrust/type_tests"


SILENT_INSTALLS = True
Expand DownExpand Up@@ -390,6 +391,27 @@ def test_otel_not_installed(session):
 _run_tests(session, "braintrust/test_otel.py")


@nox.session()
def test_types(session):
 """Run type-check tests with pyright, mypy, and pytest."""
 _install_test_deps(session)
 session.install("pyright==1.1.408", "mypy==1.20.0")

 type_tests_dir = f"src/{TYPE_TESTS_DIR}"
 test_files = glob.glob(os.path.join(type_tests_dir, "test_*.py"))
 if not test_files:
 session.skip("No type test files found")

 # Run pyright on each file
 session.run("pyright", *test_files)

 # Run mypy on each file (only check the test files themselves, not transitive deps)
 session.run("mypy", "--follow-imports=silent", *test_files)

 # Run pytest for the runtime assertions
 _run_tests(session, TYPE_TESTS_DIR)


@nox.session()
def pylint(session):
 # pylint needs everything so we don't trigger missing import errors
Expand DownExpand Up@@ -502,6 +524,7 @@ def _run_core_tests(session):
 *_integration_subdirs_to_ignore(),
 CONTRIB_DIR,
 DEVSERVER_DIR,
 TYPE_TESTS_DIR,
 ],
 )

Expand Down

8 changes: 4 additions & 4 deletions
py/src/braintrust/devserver/server.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -50,7 +50,7 @@
from .schemas import ValidationError, parse_eval_body


_all_evaluators: dict[str, Evaluator[Any, Any]] = {}
_all_evaluators: dict[str, Evaluator[Any, Any, Any]] = {}


class _ParameterOverrideHooks:
Expand DownExpand Up@@ -289,7 +289,7 @@ async def run_and_complete():
 return JSONResponse({"error": f"Failed to run evaluation: {str(e)}"}, status_code=500)


def create_app(evaluators: list[Evaluator[Any, Any]], org_name: str | None = None):
def create_app(evaluators: list[Evaluator[Any, Any, Any]], org_name: str | None = None):
 """Create and configure the Starlette app for the dev server.

 Args:
Expand DownExpand Up@@ -318,7 +318,7 @@ def create_app(evaluators: list[Evaluator[Any, Any]], org_name: str | None = Non


def run_dev_server(
 evaluators: list[Evaluator[Any, Any]],
 evaluators: list[Evaluator[Any, Any, Any]],
 host: str = "localhost",
 port: int = 8300,
 org_name: str | None = None,
Expand DownExpand Up@@ -346,7 +346,7 @@ def snake_to_camel(snake_str: str) -> str:

def make_scorer(
 state: BraintrustState, name: str, score: FunctionId, project_id: str | None = None
) -> EvalScorer[Any, Any]:
) -> EvalScorer[Any, Any, Any]:
 def scorer_fn(input, output, expected, metadata):
 request = {
 **score,
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(framework): split Output TypeVar into Output and Expected#243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Abhijeet Prasad (AbhiPrasad)
merged 3 commits into

from

Apr 10, 2026
 Merged


fix(framework): split Output TypeVar into Output and Expected#243
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
e5c4c43

fix(framework): split `Output` TypeVar into `Output` and `Expected` (…

Apr 9, 2026
dbe6a10

fix(noxfile): pin pyright and mypy versions in test_types session


AbhiPrasad Apr 9, 2026
e619a9f

fix(devserver): update Evaluator generic params to include Expected


AbhiPrasad Apr 9, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


15 changes: 15 additions & 0 deletions
AGENTS.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,7 @@ Important code areas in `py/src/braintrust/`:
- temporal: `contrib/temporal/`
- CLI/devserver: `cli/`, `devserver/`
- tests: colocated `test_*.py`
- type tests: `type_tests/`

## Setup

Expand DownExpand Up@@ -83,13 +84,27 @@ Testing preferences:
Key facts:

- `test_core` runs without optional vendor packages.
- `test_types` runs pyright, mypy, and pytest on `py/src/braintrust/type_tests/`. Use this session when changing generic type signatures in the framework.
- wrapper coverage is split across dedicated nox sessions by provider/version.
- `pylint` installs the broad dependency surface before checking files.
- `cd py && make pylint` runs only `pylint`; `cd py && make lint` runs pre-commit hooks first and then `pylint`.
- `test-wheel` is a wheel sanity check and requires a built wheel first.

When changing behavior, run the narrowest affected session first, then expand only if needed.

## Type Tests

`py/src/braintrust/type_tests/` contains tests that are validated by both static type checkers (pyright, mypy) and pytest at runtime. The `test_types` nox session runs all three checks and is auto-discovered by CI.

When changing generic type signatures (e.g., `Eval`, `EvalCase`, `EvalScorer`, `EvalHooks`), add or update a test in `type_tests/` to verify the type checker accepts the intended usage patterns.

New test files should be named `test_*.py` and use absolute imports (`from braintrust.framework import ...`). They are regular pytest files that also happen to be valid pyright/mypy targets.

```bash
cd py
nox -s test_types
```

## VCR

VCR/cassette coverage is the default and preferred testing strategy for provider and integration behavior in this repo. Reach for cassette-backed tests before introducing mocks or fakes, and keep new coverage aligned with the existing VCR patterns unless there is a strong reason not to.
Expand Down

11 changes: 11 additions & 0 deletions
CONTRIBUTING.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -134,6 +134,17 @@ BRAINTRUST_CLAUDE_AGENT_SDK_RECORD_MODE=all \
 nox -s "test_claude_agent_sdk(latest)" -- -k "test_calculator_with_multiple_operations"
```

### Type Tests

`py/src/braintrust/type_tests/` contains tests that are checked by pyright, mypy, and pytest. The `test_types` nox session runs all three and is included in CI automatically.

When changing generic type signatures (e.g., `Eval`, `EvalCase`, `EvalScorer`, `EvalHooks`), add or update a test file in `type_tests/` to verify the type checker accepts the intended usage patterns. Test files are named `test_*.py`, use absolute imports (`from braintrust.framework import ...`), and double as regular pytest files.

```bash
cd py
nox -s test_types
```

### Fixtures

Shared test fixtures live in `py/src/braintrust/conftest.py`.
Expand Down

23 changes: 23 additions & 0 deletions
py/noxfile.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -44,6 +44,7 @@ def _pinned_python_version():
INTEGRATION_DIR = "braintrust/integrations"
CONTRIB_DIR = "braintrust/contrib"
DEVSERVER_DIR = "braintrust/devserver"
TYPE_TESTS_DIR = "braintrust/type_tests"


SILENT_INSTALLS = True
Expand DownExpand Up@@ -390,6 +391,27 @@ def test_otel_not_installed(session):
 _run_tests(session, "braintrust/test_otel.py")


@nox.session()
def test_types(session):
 """Run type-check tests with pyright, mypy, and pytest."""
 _install_test_deps(session)
 session.install("pyright==1.1.408", "mypy==1.20.0")

 type_tests_dir = f"src/{TYPE_TESTS_DIR}"
 test_files = glob.glob(os.path.join(type_tests_dir, "test_*.py"))
 if not test_files:
 session.skip("No type test files found")

 # Run pyright on each file
 session.run("pyright", *test_files)

 # Run mypy on each file (only check the test files themselves, not transitive deps)
 session.run("mypy", "--follow-imports=silent", *test_files)

 # Run pytest for the runtime assertions
 _run_tests(session, TYPE_TESTS_DIR)


@nox.session()
def pylint(session):
 # pylint needs everything so we don't trigger missing import errors
Expand DownExpand Up@@ -502,6 +524,7 @@ def _run_core_tests(session):
 *_integration_subdirs_to_ignore(),
 CONTRIB_DIR,
 DEVSERVER_DIR,
 TYPE_TESTS_DIR,
 ],
 )

Expand Down

8 changes: 4 additions & 4 deletions
py/src/braintrust/devserver/server.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -50,7 +50,7 @@
from .schemas import ValidationError, parse_eval_body


_all_evaluators: dict[str, Evaluator[Any, Any]] = {}
_all_evaluators: dict[str, Evaluator[Any, Any, Any]] = {}


class _ParameterOverrideHooks:
Expand DownExpand Up@@ -289,7 +289,7 @@ async def run_and_complete():
 return JSONResponse({"error": f"Failed to run evaluation: {str(e)}"}, status_code=500)


def create_app(evaluators: list[Evaluator[Any, Any]], org_name: str | None = None):
def create_app(evaluators: list[Evaluator[Any, Any, Any]], org_name: str | None = None):
 """Create and configure the Starlette app for the dev server.

 Args:
Expand DownExpand Up@@ -318,7 +318,7 @@ def create_app(evaluators: list[Evaluator[Any, Any]], org_name: str | None = Non


def run_dev_server(
 evaluators: list[Evaluator[Any, Any]],
 evaluators: list[Evaluator[Any, Any, Any]],
 host: str = "localhost",
 port: int = 8300,
 org_name: str | None = None,
Expand DownExpand Up@@ -346,7 +346,7 @@ def snake_to_camel(snake_str: str) -> str:

def make_scorer(
 state: BraintrustState, name: str, score: FunctionId, project_id: str | None = None
) -> EvalScorer[Any, Any]:
) -> EvalScorer[Any, Any, Any]:
 def scorer_fn(input, output, expected, metadata):
 request = {
 **score,
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
fix(framework): split Output TypeVar into Output and Expected#243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Abhijeet Prasad (AbhiPrasad)
merged 3 commits into

from

Apr 10, 2026
 Merged


fix(framework): split Output TypeVar into Output and Expected#243
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
e5c4c43

fix(framework): split `Output` TypeVar into `Output` and `Expected` (…

Apr 9, 2026
dbe6a10

fix(noxfile): pin pyright and mypy versions in test_types session


AbhiPrasad Apr 9, 2026
e619a9f

fix(devserver): update Evaluator generic params to include Expected


AbhiPrasad Apr 9, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


15 changes: 15 additions & 0 deletions
AGENTS.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,7 @@ Important code areas in `py/src/braintrust/`:
- temporal: `contrib/temporal/`
- CLI/devserver: `cli/`, `devserver/`
- tests: colocated `test_*.py`
- type tests: `type_tests/`

## Setup

Expand DownExpand Up@@ -83,13 +84,27 @@ Testing preferences:
Key facts:

- `test_core` runs without optional vendor packages.
- `test_types` runs pyright, mypy, and pytest on `py/src/braintrust/type_tests/`. Use this session when changing generic type signatures in the framework.
- wrapper coverage is split across dedicated nox sessions by provider/version.
- `pylint` installs the broad dependency surface before checking files.
- `cd py && make pylint` runs only `pylint`; `cd py && make lint` runs pre-commit hooks first and then `pylint`.
- `test-wheel` is a wheel sanity check and requires a built wheel first.

When changing behavior, run the narrowest affected session first, then expand only if needed.

## Type Tests

`py/src/braintrust/type_tests/` contains tests that are validated by both static type checkers (pyright, mypy) and pytest at runtime. The `test_types` nox session runs all three checks and is auto-discovered by CI.

When changing generic type signatures (e.g., `Eval`, `EvalCase`, `EvalScorer`, `EvalHooks`), add or update a test in `type_tests/` to verify the type checker accepts the intended usage patterns.

New test files should be named `test_*.py` and use absolute imports (`from braintrust.framework import ...`). They are regular pytest files that also happen to be valid pyright/mypy targets.

```bash
cd py
nox -s test_types
```

## VCR

VCR/cassette coverage is the default and preferred testing strategy for provider and integration behavior in this repo. Reach for cassette-backed tests before introducing mocks or fakes, and keep new coverage aligned with the existing VCR patterns unless there is a strong reason not to.
Expand Down

11 changes: 11 additions & 0 deletions
CONTRIBUTING.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -134,6 +134,17 @@ BRAINTRUST_CLAUDE_AGENT_SDK_RECORD_MODE=all \
 nox -s "test_claude_agent_sdk(latest)" -- -k "test_calculator_with_multiple_operations"
```

### Type Tests

`py/src/braintrust/type_tests/` contains tests that are checked by pyright, mypy, and pytest. The `test_types` nox session runs all three and is included in CI automatically.

When changing generic type signatures (e.g., `Eval`, `EvalCase`, `EvalScorer`, `EvalHooks`), add or update a test file in `type_tests/` to verify the type checker accepts the intended usage patterns. Test files are named `test_*.py`, use absolute imports (`from braintrust.framework import ...`), and double as regular pytest files.

```bash
cd py
nox -s test_types
```

### Fixtures

Shared test fixtures live in `py/src/braintrust/conftest.py`.
Expand Down

23 changes: 23 additions & 0 deletions
py/noxfile.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -44,6 +44,7 @@ def _pinned_python_version():
INTEGRATION_DIR = "braintrust/integrations"
CONTRIB_DIR = "braintrust/contrib"
DEVSERVER_DIR = "braintrust/devserver"
TYPE_TESTS_DIR = "braintrust/type_tests"


SILENT_INSTALLS = True
Expand DownExpand Up@@ -390,6 +391,27 @@ def test_otel_not_installed(session):
 _run_tests(session, "braintrust/test_otel.py")


@nox.session()
def test_types(session):
 """Run type-check tests with pyright, mypy, and pytest."""
 _install_test_deps(session)
 session.install("pyright==1.1.408", "mypy==1.20.0")

 type_tests_dir = f"src/{TYPE_TESTS_DIR}"
 test_files = glob.glob(os.path.join(type_tests_dir, "test_*.py"))
 if not test_files:
 session.skip("No type test files found")

 # Run pyright on each file
 session.run("pyright", *test_files)

 # Run mypy on each file (only check the test files themselves, not transitive deps)
 session.run("mypy", "--follow-imports=silent", *test_files)

 # Run pytest for the runtime assertions
 _run_tests(session, TYPE_TESTS_DIR)


@nox.session()
def pylint(session):
 # pylint needs everything so we don't trigger missing import errors
Expand DownExpand Up@@ -502,6 +524,7 @@ def _run_core_tests(session):
 *_integration_subdirs_to_ignore(),
 CONTRIB_DIR,
 DEVSERVER_DIR,
 TYPE_TESTS_DIR,
 ],
 )

Expand Down

8 changes: 4 additions & 4 deletions
py/src/braintrust/devserver/server.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -50,7 +50,7 @@
from .schemas import ValidationError, parse_eval_body


_all_evaluators: dict[str, Evaluator[Any, Any]] = {}
_all_evaluators: dict[str, Evaluator[Any, Any, Any]] = {}


class _ParameterOverrideHooks:
Expand DownExpand Up@@ -289,7 +289,7 @@ async def run_and_complete():
 return JSONResponse({"error": f"Failed to run evaluation: {str(e)}"}, status_code=500)


def create_app(evaluators: list[Evaluator[Any, Any]], org_name: str | None = None):
def create_app(evaluators: list[Evaluator[Any, Any, Any]], org_name: str | None = None):
 """Create and configure the Starlette app for the dev server.

 Args:
Expand DownExpand Up@@ -318,7 +318,7 @@ def create_app(evaluators: list[Evaluator[Any, Any]], org_name: str | None = Non


def run_dev_server(
 evaluators: list[Evaluator[Any, Any]],
 evaluators: list[Evaluator[Any, Any, Any]],
 host: str = "localhost",
 port: int = 8300,
 org_name: str | None = None,
Expand DownExpand Up@@ -346,7 +346,7 @@ def snake_to_camel(snake_str: str) -> str:

def make_scorer(
 state: BraintrustState, name: str, score: FunctionId, project_id: str | None = None
) -> EvalScorer[Any, Any]:
) -> EvalScorer[Any, Any, Any]:
 def scorer_fn(input, output, expected, metadata):
 request = {
 **score,
Expand Down
Loading
Loading