You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The reason will be displayed to describe this comment to others. Learn more.
Can we reuse the existing evaluator-parameter serialization flow from eval-runner.ts here, instead of the direct toJsonValue(rawParams) path? I think using the shared serializer covers some cases with Zod->JSON Schema conversion that help avoid malformed evaluator_definition.parameters for parameterized evals.
The reason will be displayed to describe this comment to others. Learn more.
I tried extracting this into a new file, but the eval-runner doesn't play nice with local exports since it needs to run with multiple runner types in a way the functions-runner doesn't. I'm going to just copy the logic over from eval-runner. I'm a bit hesitant to move to a complex local file structure for these runners since they need to work in so many situations, but let me know if you think that's the wrong approach
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit hesitant to move to a complex local file structure for these runners since they need to work in so many situations, but let me know if you think that's the wrong approach
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the ability to push sandboxes using the
bt function pushcommand. pushes lambda sandboxes for each language.