Make external calibration a release gate - #50
Merged
Merged
Conversation
tools/calibration/run.sh packs the tree and runs it against real consumers pinned in tools/calibration/consumers.json: `kernel` mode redirects their RulesKernel pins and requires build and tests to pass; `analyzer` mode attaches the packed analyzer from outside, counts findings per rule, and places a control draw beside every project so zero findings proves the analyzer ran. tools/release-checks.py gains calibration-recorded: a release changing src/RulesKernel/ needs docs/calibration/<version>.md naming at least two passing kernel consumers, and one changing src/RulesKernel.Analyzers/ at least one analyzer consumer, calibrated at a commit in the tag's history with no calibrated path changed since. publish.yml fetches full history and reruns the kernel calibration at the tag. ADR 0021; CLAUDE.md release step. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Kernel mode: faa-part-107, hoyle-backgammon, srd-52-combat all pass (958 tests). Analyzer mode: the three factory engines have no findings with controls seen in every project; SRD_Combat reproduces the recorded 17 findings. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Item 7 of the 0.4.0 plan. The PyYAML pin landed in #40.
Tool:
tools/calibration/run.sh kernel|analyzer [checkout...]. With no arguments, it fetches the consumers intools/calibration/consumers.jsonat their pinned commits.kernel: packs the tree under a non-shadowing version, redirects each consumer's RulesKernel pins (and counts them), then restores, builds with-warnaserrorand tests. Result is pass or fail.analyzer: attaches the packed analyzer from outside, keeps RK warnings from stopping the build, and counts unique findings per rule. It puts a control draw beside every project and fails if any control goes unreported, so "0 findings" is a result and not a missing analyzer.Gate:
tools/release-checks.pyaddscalibration-recorded, which applies whensrc/RulesKernel/orsrc/RulesKernel.Analyzers/changed since the previous release tag:docs/calibration/<version>.mdmust exist.It has 14 new tests against git fixtures, including an earlier-tree calibration, the wrong consumer commit, a failing row, a wrong mode, and a missing previous tag.
publish.ymlfetches full history and reruns the kernel calibration at the tag. The validate timeout goes from 15 to 45 minutes.Record:
docs/calibration/0.4.0.md(at 793252e):release-checks.pywith the suffix cleared passes.ADR 0021 records the decision.
CLAUDE.md's release cycle gains the calibration step. The gate does not run per PR (network, minutes). A PR that changes a kernel type calibrates and says so in its description, as #47 did.🤖 Generated with Claude Code