Make ArchitectureTests read the resolved dependency graph - #71
Merged
Merged
Conversation
They called GetReferencedAssemblies(), which omits references the code never uses, so they passed vacuously (#54). They now read the test run's .deps.json, which records every project's declared dependencies. Verified by injecting a ProjectReference from RulesKernel to RulesKernel.Analyzers and one from RegulatoryProbe to RulesKernel.Randomness: all three affected tests fail. Closes #54 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #54.
ArchitectureTestsinRulesKernel.TestsandRulesKernel.Randomness.Tests, and the no-randomness assertion inRegulatoryProbe.Tests, usedAssembly.GetReferencedAssemblies(). The compiler omits references the code never uses, so while no kernel assembly calls another, those tests passed whatever the project graph said.They now read the
.deps.jsonthe SDK writes beside each test assembly. It lists every project in the resolved graph with its declared dependencies, used or not.RulesKerneldepends on noRulesKernel*project.RulesKernel.Randomnessdepends only onRulesKernel, andRulesKernel.Testingonly onRulesKernel.Randomness.RegulatoryProbe.TestshasRulesKernelin its graph and neverRulesKernel.Randomness.Verified they bite: with a
ProjectReferencefromRulesKerneltoRulesKernel.Analyzers, and another from the probe toRulesKernel.Randomness, all three fail. Nothing calls across either reference. Thelayeringtext check also flagged the injection, so the two nets agree.docs/architecture.mdand therepo-checksdocstring no longer call these tests vacuous.🤖 Generated with Claude Code