') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Removing Scheme from Workflow by leogdion · Pull Request #404 · brightdigit/MistKit · GitHub
Skip to content

Removing Scheme from Workflow - #404

Merged
leogdion merged 1 commit into
v1.0.0-beta.3from
403-remove-scheme-from-workflows
Jun 2, 2026
Merged

Removing Scheme from Workflow#404
leogdion merged 1 commit into
v1.0.0-beta.3from
403-remove-scheme-from-workflows

Conversation

@leogdion

@leogdionleogdion commented Jun 2, 2026

Copy link
Copy Markdown
Member

No description provided.

@coderabbitai

coderabbitaiBot commented Jun 2, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5593c2dc-a9b3-4070-bfe4-043a24b610b2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 403-remove-scheme-from-workflows

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@claude

claudeBot commented Jun 2, 2026

Copy link
Copy Markdown

Code Review

Overview

This PR removes explicit scheme parameters from five brightdigit/swift-build@v1 action invocations across two workflow files, addressing issue #403. The intent is to let the action use its own default scheme detection rather than an explicitly specified scheme.

What's Good

  • Correct direction for consistency: Before this PR, several swift-build invocations (WASI, Windows, Android in MistKit.yml) already omitted scheme. After this PR, all invocations are uniform — no scheme passed anywhere.
  • Minimal, surgical diff: 5 line deletions, no additions — low risk of unintended side-effects.

Issues / Suggestions

1. Missing PR description
The PR body is empty. Even a one-liner like "The brightdigit/swift-build@v1 action now auto-detects the scheme; passing it explicitly causes X" would make the intent clear to reviewers and future git blame readers. Consider filling in the body.

2. Inconsistency being silently fixed
Before this PR, MistDemo.yml passes two different scheme values:

  • Android step: scheme: ${{ env.PACKAGE_NAME }} → MistDemo
  • macOS steps: scheme: ${{ env.PACKAGE_NAME }}-Package → MistDemo-Package

That's an existing bug being cleaned up here, but it isn't called out. It would be worth noting in the PR description that the Android build was using a potentially wrong scheme name.

3. No test/validation evidence
Since this changes CI configuration, it would be reassuring to see a note (or link to a successful run) confirming the workflows still pass without the scheme input. If the action silently ignores unknown or missing inputs, a green run after this change is the only proof the removal is safe.

4. Branch target
This is targeting v1.0.0-beta.3 rather than main. If the same scheme parameters exist on main, a follow-up PR will be needed there — worth tracking.

Summary

The change itself is correct and low-risk. Main asks before merging:

  1. Add a brief PR description explaining why scheme is being removed (action change? was it causing failures?).
  2. Link or paste a successful CI run demonstrating the workflows pass without scheme.
  3. Confirm whether a matching change to main is needed.

@codecov

codecovBot commented Jun 2, 2026•
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (v1.0.0-beta.3@6d23e40). Learn more about missing BASE report.

Additional details and impacted files
@@ Coverage Diff @@## v1.0.0-beta.3 #404 +/- ##
================================================
Coverage ? 71.69% ================================================
Files ? 168 Lines ? 3844 Branches ? 0 ================================================
Hits ? 2756 Misses ? 1088 Partials ? 0
FlagCoverage Δ
mistdemo-spm-macos11.42% <ø> (?)
mistdemo-swift-6.2-jammy11.42% <ø> (?)
mistdemo-swift-6.2-noble11.55% <ø> (?)
mistdemo-swift-6.3-jammy11.42% <ø> (?)
mistdemo-swift-6.3-noble11.42% <ø> (?)
spm71.55% <ø> (?)
swift-6.1-jammy71.67% <ø> (?)
swift-6.1-noble71.57% <ø> (?)
swift-6.2-jammy71.59% <ø> (?)
swift-6.2-noble71.57% <ø> (?)
swift-6.3-jammy71.73% <ø> (?)
swift-6.3-noble71.65% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@leogdion
leogdion merged commit 7f29e08 into v1.0.0-beta.3Jun 2, 2026
71 of 72 checks passed
@leogdion
leogdion deleted the 403-remove-scheme-from-workflows branch June 2, 2026 13:17
@claudeclaudeBot mentioned this pull request Aug 20, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@leogdion