Skip to content

Drop obsolete scheme input from example workflows (#403) - #413

Merged
leogdion merged 1 commit into
v1.0.0-beta.3from
chore/remove-scheme-workflows
Jun 30, 2026
Merged

Drop obsolete scheme input from example workflows (#403)#413
leogdion merged 1 commit into
v1.0.0-beta.3from
chore/remove-scheme-workflows

Conversation

@leogdion

@leogdionleogdion commented Jun 30, 2026

Copy link
Copy Markdown
Member

brightdigit/swift-build@v1 no longer needs an explicit scheme — the MistKit and MistDemo workflows already omit it. Removes the now-obsolete scheme: input from the BushelCloud and CelestraCloud workflows to match.

These are subrepo workflows; changes will be propagated upstream via git subrepo push after approval.

ConfigKeyKit excluded: that subrepo is being removed entirely in #417, so its workflow is not modified here.

⚠️ The issue body was empty — please confirm this is the intended target set.

Closes#403.

@coderabbitai

coderabbitaiBot commented Jun 30, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 33bfcb76-f598-401b-8097-6d7fdd00ed23

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/remove-scheme-workflows

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

brightdigit/swift-build@v1 no longer needs an explicit scheme — the
MistKit and MistDemo workflows already omit it. Remove the now-obsolete
`scheme:` input from the BushelCloud and CelestraCloud workflows to match.
These are subrepo workflows; propagate upstream via `git subrepo push`
after review. (ConfigKeyKit is excluded — that subrepo is being removed
entirely in a separate PR.)
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@leogdion
leogdionforce-pushed the chore/remove-scheme-workflows branch from 1e6aa8f to cd460d6CompareJune 30, 2026 16:24
@leogdionleogdion changed the title Drop obsolete scheme input from example/package workflows (#403)Drop obsolete scheme input from example workflows (#403)Jun 30, 2026
@codecov

codecovBot commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.90%. Comparing base (9894d48) to head (cd460d6).
⚠️ Report is 2 commits behind head on v1.0.0-beta.3.

Additional details and impacted files
@@ Coverage Diff @@## v1.0.0-beta.3 #413 +/- ##
=================================================
+ Coverage 71.82% 71.90% +0.07% 
=================================================
Files 168 156 -12 Lines 3844 3698 -146 =================================================
- Hits 2761 2659 -102 + Misses 1083 1039 -44 
FlagCoverage Δ
mistdemo-spm-macos?
mistdemo-swift-6.2-jammy?
mistdemo-swift-6.2-noble?
mistdemo-swift-6.3-jammy?
mistdemo-swift-6.3-noble?
spm71.87% <ø> (+0.35%)⬆️
swift-6.1-jammy71.59% <ø> (-0.14%)⬇️
swift-6.1-noble71.59% <ø> (-0.28%)⬇️
swift-6.2-jammy71.57% <ø> (-0.09%)⬇️
swift-6.2-noble71.76% <ø> (+0.16%)⬆️
swift-6.3-jammy71.57% <ø> (+0.02%)⬆️
swift-6.3-noble71.62% <ø> (+0.02%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@leogdion
leogdion marked this pull request as ready for review June 30, 2026 23:49
@leogdion
leogdion merged commit 4395549 into v1.0.0-beta.3Jun 30, 2026
45 of 47 checks passed
@claude

claudeBot commented Jun 30, 2026

Copy link
Copy Markdown

Review

Reviewed the diff (Examples/BushelCloud/.github/workflows/BushelCloud.yml, Examples/CelestraCloud/.github/workflows/CelestraCloud.yml).

Summary: Minimal, mechanical change — removes the now-unnecessary scheme: ${{ env.PACKAGE_NAME }}-Package input from 4 brightdigit/swift-build@v1 steps (2 per file). Confirmed no scheme: input remains anywhere in the repo's workflows (including MistKit's and MistDemo's, which the PR description says already omit it), so this brings BushelCloud/CelestraCloud in line with the rest of the fleet.

Code quality / correctness: No issues. The diff only removes a line in each of the 4 steps; surrounding with: blocks are untouched and still well-formed YAML.

Minor nit (non-blocking): In both files, PACKAGE_NAME (declared in the top-level env: block, e.g. BushelCloud.yml:23) was only ever referenced by the now-removed scheme: lines. After this change it's an unused env var in both workflows. Worth a quick follow-up to drop it (or fold into #417's ConfigKeyKit cleanup) so it doesn't linger as dead config — not worth blocking this PR on.

Performance / security: N/A — CI-config-only change, no runtime code, secrets, or permissions touched.

Test coverage: N/A (workflow YAML). The PR description already notes the 7 edited files parse and the mistdemo build succeeds; since these are git-subrepo mirrors (BushelCloud/CelestraCloud.gitrepo files confirm method = merge), the real validation will be the next CI run after git subrepo push, as the PR body already flags.

Overall: safe, well-scoped cleanup. ✅

@leogdion
leogdion deleted the chore/remove-scheme-workflows branch July 1, 2026 00:29
@claudeclaudeBot mentioned this pull request Aug 20, 2026
@leogdionleogdion mentioned this pull request Aug 20, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@leogdion
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Drop obsolete scheme input from example workflows (#403) by leogdion · Pull Request #413 · brightdigit/MistKit · GitHub
Skip to content

Drop obsolete scheme input from example workflows (#403) - #413

Merged
leogdion merged 1 commit into
v1.0.0-beta.3from
chore/remove-scheme-workflows
Jun 30, 2026
Merged

Drop obsolete scheme input from example workflows (#403)#413
leogdion merged 1 commit into
v1.0.0-beta.3from
chore/remove-scheme-workflows

Conversation

@leogdion

@leogdionleogdion commented Jun 30, 2026

Copy link
Copy Markdown
Member

brightdigit/swift-build@v1 no longer needs an explicit scheme — the MistKit and MistDemo workflows already omit it. Removes the now-obsolete scheme: input from the BushelCloud and CelestraCloud workflows to match.

These are subrepo workflows; changes will be propagated upstream via git subrepo push after approval.

ConfigKeyKit excluded: that subrepo is being removed entirely in #417, so its workflow is not modified here.

⚠️ The issue body was empty — please confirm this is the intended target set.

Closes#403.

@coderabbitai

coderabbitaiBot commented Jun 30, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 33bfcb76-f598-401b-8097-6d7fdd00ed23

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/remove-scheme-workflows

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

brightdigit/swift-build@v1 no longer needs an explicit scheme — the
MistKit and MistDemo workflows already omit it. Remove the now-obsolete
`scheme:` input from the BushelCloud and CelestraCloud workflows to match.
These are subrepo workflows; propagate upstream via `git subrepo push`
after review. (ConfigKeyKit is excluded — that subrepo is being removed
entirely in a separate PR.)
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@leogdion
leogdionforce-pushed the chore/remove-scheme-workflows branch from 1e6aa8f to cd460d6CompareJune 30, 2026 16:24
@leogdionleogdion changed the title Drop obsolete scheme input from example/package workflows (#403)Drop obsolete scheme input from example workflows (#403)Jun 30, 2026
@codecov

codecovBot commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.90%. Comparing base (9894d48) to head (cd460d6).
⚠️ Report is 2 commits behind head on v1.0.0-beta.3.

Additional details and impacted files
@@ Coverage Diff @@## v1.0.0-beta.3 #413 +/- ##
=================================================
+ Coverage 71.82% 71.90% +0.07% 
=================================================
Files 168 156 -12 Lines 3844 3698 -146 =================================================
- Hits 2761 2659 -102 + Misses 1083 1039 -44 
FlagCoverage Δ
mistdemo-spm-macos?
mistdemo-swift-6.2-jammy?
mistdemo-swift-6.2-noble?
mistdemo-swift-6.3-jammy?
mistdemo-swift-6.3-noble?
spm71.87% <ø> (+0.35%)⬆️
swift-6.1-jammy71.59% <ø> (-0.14%)⬇️
swift-6.1-noble71.59% <ø> (-0.28%)⬇️
swift-6.2-jammy71.57% <ø> (-0.09%)⬇️
swift-6.2-noble71.76% <ø> (+0.16%)⬆️
swift-6.3-jammy71.57% <ø> (+0.02%)⬆️
swift-6.3-noble71.62% <ø> (+0.02%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@leogdion
leogdion marked this pull request as ready for review June 30, 2026 23:49
@leogdion
leogdion merged commit 4395549 into v1.0.0-beta.3Jun 30, 2026
45 of 47 checks passed
@claude

claudeBot commented Jun 30, 2026

Copy link
Copy Markdown

Review

Reviewed the diff (Examples/BushelCloud/.github/workflows/BushelCloud.yml, Examples/CelestraCloud/.github/workflows/CelestraCloud.yml).

Summary: Minimal, mechanical change — removes the now-unnecessary scheme: ${{ env.PACKAGE_NAME }}-Package input from 4 brightdigit/swift-build@v1 steps (2 per file). Confirmed no scheme: input remains anywhere in the repo's workflows (including MistKit's and MistDemo's, which the PR description says already omit it), so this brings BushelCloud/CelestraCloud in line with the rest of the fleet.

Code quality / correctness: No issues. The diff only removes a line in each of the 4 steps; surrounding with: blocks are untouched and still well-formed YAML.

Minor nit (non-blocking): In both files, PACKAGE_NAME (declared in the top-level env: block, e.g. BushelCloud.yml:23) was only ever referenced by the now-removed scheme: lines. After this change it's an unused env var in both workflows. Worth a quick follow-up to drop it (or fold into #417's ConfigKeyKit cleanup) so it doesn't linger as dead config — not worth blocking this PR on.

Performance / security: N/A — CI-config-only change, no runtime code, secrets, or permissions touched.

Test coverage: N/A (workflow YAML). The PR description already notes the 7 edited files parse and the mistdemo build succeeds; since these are git-subrepo mirrors (BushelCloud/CelestraCloud.gitrepo files confirm method = merge), the real validation will be the next CI run after git subrepo push, as the PR body already flags.

Overall: safe, well-scoped cleanup. ✅

@leogdion
leogdion deleted the chore/remove-scheme-workflows branch July 1, 2026 00:29
@claudeclaudeBot mentioned this pull request Aug 20, 2026
@leogdionleogdion mentioned this pull request Aug 20, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@leogdion
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Drop obsolete scheme input from example workflows (#403) by leogdion · Pull Request #413 · brightdigit/MistKit · GitHub
Skip to content

Drop obsolete scheme input from example workflows (#403) - #413

Merged
leogdion merged 1 commit into
v1.0.0-beta.3from
chore/remove-scheme-workflows
Jun 30, 2026
Merged

Drop obsolete scheme input from example workflows (#403)#413
leogdion merged 1 commit into
v1.0.0-beta.3from
chore/remove-scheme-workflows

Conversation

@leogdion

@leogdionleogdion commented Jun 30, 2026

Copy link
Copy Markdown
Member

brightdigit/swift-build@v1 no longer needs an explicit scheme — the MistKit and MistDemo workflows already omit it. Removes the now-obsolete scheme: input from the BushelCloud and CelestraCloud workflows to match.

These are subrepo workflows; changes will be propagated upstream via git subrepo push after approval.

ConfigKeyKit excluded: that subrepo is being removed entirely in #417, so its workflow is not modified here.

⚠️ The issue body was empty — please confirm this is the intended target set.

Closes#403.

@coderabbitai

coderabbitaiBot commented Jun 30, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 33bfcb76-f598-401b-8097-6d7fdd00ed23

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/remove-scheme-workflows

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

brightdigit/swift-build@v1 no longer needs an explicit scheme — the
MistKit and MistDemo workflows already omit it. Remove the now-obsolete
`scheme:` input from the BushelCloud and CelestraCloud workflows to match.
These are subrepo workflows; propagate upstream via `git subrepo push`
after review. (ConfigKeyKit is excluded — that subrepo is being removed
entirely in a separate PR.)
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@leogdion
leogdionforce-pushed the chore/remove-scheme-workflows branch from 1e6aa8f to cd460d6CompareJune 30, 2026 16:24
@leogdionleogdion changed the title Drop obsolete scheme input from example/package workflows (#403)Drop obsolete scheme input from example workflows (#403)Jun 30, 2026
@codecov

codecovBot commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.90%. Comparing base (9894d48) to head (cd460d6).
⚠️ Report is 2 commits behind head on v1.0.0-beta.3.

Additional details and impacted files
@@ Coverage Diff @@## v1.0.0-beta.3 #413 +/- ##
=================================================
+ Coverage 71.82% 71.90% +0.07% 
=================================================
Files 168 156 -12 Lines 3844 3698 -146 =================================================
- Hits 2761 2659 -102 + Misses 1083 1039 -44 
FlagCoverage Δ
mistdemo-spm-macos?
mistdemo-swift-6.2-jammy?
mistdemo-swift-6.2-noble?
mistdemo-swift-6.3-jammy?
mistdemo-swift-6.3-noble?
spm71.87% <ø> (+0.35%)⬆️
swift-6.1-jammy71.59% <ø> (-0.14%)⬇️
swift-6.1-noble71.59% <ø> (-0.28%)⬇️
swift-6.2-jammy71.57% <ø> (-0.09%)⬇️
swift-6.2-noble71.76% <ø> (+0.16%)⬆️
swift-6.3-jammy71.57% <ø> (+0.02%)⬆️
swift-6.3-noble71.62% <ø> (+0.02%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@leogdion
leogdion marked this pull request as ready for review June 30, 2026 23:49
@leogdion
leogdion merged commit 4395549 into v1.0.0-beta.3Jun 30, 2026
45 of 47 checks passed
@claude

claudeBot commented Jun 30, 2026

Copy link
Copy Markdown

Review

Reviewed the diff (Examples/BushelCloud/.github/workflows/BushelCloud.yml, Examples/CelestraCloud/.github/workflows/CelestraCloud.yml).

Summary: Minimal, mechanical change — removes the now-unnecessary scheme: ${{ env.PACKAGE_NAME }}-Package input from 4 brightdigit/swift-build@v1 steps (2 per file). Confirmed no scheme: input remains anywhere in the repo's workflows (including MistKit's and MistDemo's, which the PR description says already omit it), so this brings BushelCloud/CelestraCloud in line with the rest of the fleet.

Code quality / correctness: No issues. The diff only removes a line in each of the 4 steps; surrounding with: blocks are untouched and still well-formed YAML.

Minor nit (non-blocking): In both files, PACKAGE_NAME (declared in the top-level env: block, e.g. BushelCloud.yml:23) was only ever referenced by the now-removed scheme: lines. After this change it's an unused env var in both workflows. Worth a quick follow-up to drop it (or fold into #417's ConfigKeyKit cleanup) so it doesn't linger as dead config — not worth blocking this PR on.

Performance / security: N/A — CI-config-only change, no runtime code, secrets, or permissions touched.

Test coverage: N/A (workflow YAML). The PR description already notes the 7 edited files parse and the mistdemo build succeeds; since these are git-subrepo mirrors (BushelCloud/CelestraCloud.gitrepo files confirm method = merge), the real validation will be the next CI run after git subrepo push, as the PR body already flags.

Overall: safe, well-scoped cleanup. ✅

@leogdion
leogdion deleted the chore/remove-scheme-workflows branch July 1, 2026 00:29
@claudeclaudeBot mentioned this pull request Aug 20, 2026
@leogdionleogdion mentioned this pull request Aug 20, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@leogdion
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Drop obsolete scheme input from example workflows (#403) by leogdion · Pull Request #413 · brightdigit/MistKit · GitHub
Skip to content

Drop obsolete scheme input from example workflows (#403) - #413

Merged
leogdion merged 1 commit into
v1.0.0-beta.3from
chore/remove-scheme-workflows
Jun 30, 2026
Merged

Drop obsolete scheme input from example workflows (#403)#413
leogdion merged 1 commit into
v1.0.0-beta.3from
chore/remove-scheme-workflows

Conversation

@leogdion

@leogdionleogdion commented Jun 30, 2026

Copy link
Copy Markdown
Member

brightdigit/swift-build@v1 no longer needs an explicit scheme — the MistKit and MistDemo workflows already omit it. Removes the now-obsolete scheme: input from the BushelCloud and CelestraCloud workflows to match.

These are subrepo workflows; changes will be propagated upstream via git subrepo push after approval.

ConfigKeyKit excluded: that subrepo is being removed entirely in #417, so its workflow is not modified here.

⚠️ The issue body was empty — please confirm this is the intended target set.

Closes#403.

@coderabbitai

coderabbitaiBot commented Jun 30, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 33bfcb76-f598-401b-8097-6d7fdd00ed23

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/remove-scheme-workflows

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

brightdigit/swift-build@v1 no longer needs an explicit scheme — the
MistKit and MistDemo workflows already omit it. Remove the now-obsolete
`scheme:` input from the BushelCloud and CelestraCloud workflows to match.
These are subrepo workflows; propagate upstream via `git subrepo push`
after review. (ConfigKeyKit is excluded — that subrepo is being removed
entirely in a separate PR.)
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@leogdion
leogdionforce-pushed the chore/remove-scheme-workflows branch from 1e6aa8f to cd460d6CompareJune 30, 2026 16:24
@leogdionleogdion changed the title Drop obsolete scheme input from example/package workflows (#403)Drop obsolete scheme input from example workflows (#403)Jun 30, 2026
@codecov

codecovBot commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.90%. Comparing base (9894d48) to head (cd460d6).
⚠️ Report is 2 commits behind head on v1.0.0-beta.3.

Additional details and impacted files
@@ Coverage Diff @@## v1.0.0-beta.3 #413 +/- ##
=================================================
+ Coverage 71.82% 71.90% +0.07% 
=================================================
Files 168 156 -12 Lines 3844 3698 -146 =================================================
- Hits 2761 2659 -102 + Misses 1083 1039 -44 
FlagCoverage Δ
mistdemo-spm-macos?
mistdemo-swift-6.2-jammy?
mistdemo-swift-6.2-noble?
mistdemo-swift-6.3-jammy?
mistdemo-swift-6.3-noble?
spm71.87% <ø> (+0.35%)⬆️
swift-6.1-jammy71.59% <ø> (-0.14%)⬇️
swift-6.1-noble71.59% <ø> (-0.28%)⬇️
swift-6.2-jammy71.57% <ø> (-0.09%)⬇️
swift-6.2-noble71.76% <ø> (+0.16%)⬆️
swift-6.3-jammy71.57% <ø> (+0.02%)⬆️
swift-6.3-noble71.62% <ø> (+0.02%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@leogdion
leogdion marked this pull request as ready for review June 30, 2026 23:49
@leogdion
leogdion merged commit 4395549 into v1.0.0-beta.3Jun 30, 2026
45 of 47 checks passed
@claude

claudeBot commented Jun 30, 2026

Copy link
Copy Markdown

Review

Reviewed the diff (Examples/BushelCloud/.github/workflows/BushelCloud.yml, Examples/CelestraCloud/.github/workflows/CelestraCloud.yml).

Summary: Minimal, mechanical change — removes the now-unnecessary scheme: ${{ env.PACKAGE_NAME }}-Package input from 4 brightdigit/swift-build@v1 steps (2 per file). Confirmed no scheme: input remains anywhere in the repo's workflows (including MistKit's and MistDemo's, which the PR description says already omit it), so this brings BushelCloud/CelestraCloud in line with the rest of the fleet.

Code quality / correctness: No issues. The diff only removes a line in each of the 4 steps; surrounding with: blocks are untouched and still well-formed YAML.

Minor nit (non-blocking): In both files, PACKAGE_NAME (declared in the top-level env: block, e.g. BushelCloud.yml:23) was only ever referenced by the now-removed scheme: lines. After this change it's an unused env var in both workflows. Worth a quick follow-up to drop it (or fold into #417's ConfigKeyKit cleanup) so it doesn't linger as dead config — not worth blocking this PR on.

Performance / security: N/A — CI-config-only change, no runtime code, secrets, or permissions touched.

Test coverage: N/A (workflow YAML). The PR description already notes the 7 edited files parse and the mistdemo build succeeds; since these are git-subrepo mirrors (BushelCloud/CelestraCloud.gitrepo files confirm method = merge), the real validation will be the next CI run after git subrepo push, as the PR body already flags.

Overall: safe, well-scoped cleanup. ✅

@leogdion
leogdion deleted the chore/remove-scheme-workflows branch July 1, 2026 00:29
@claudeclaudeBot mentioned this pull request Aug 20, 2026
@leogdionleogdion mentioned this pull request Aug 20, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@leogdion
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' Drop obsolete scheme input from example workflows (#403) by leogdion · Pull Request #413 · brightdigit/MistKit · GitHub
Skip to content

Drop obsolete scheme input from example workflows (#403) - #413

Merged
leogdion merged 1 commit into
v1.0.0-beta.3from
chore/remove-scheme-workflows
Jun 30, 2026
Merged

Drop obsolete scheme input from example workflows (#403)#413
leogdion merged 1 commit into
v1.0.0-beta.3from
chore/remove-scheme-workflows

Conversation

@leogdion

@leogdionleogdion commented Jun 30, 2026

Copy link
Copy Markdown
Member

brightdigit/swift-build@v1 no longer needs an explicit scheme — the MistKit and MistDemo workflows already omit it. Removes the now-obsolete scheme: input from the BushelCloud and CelestraCloud workflows to match.

These are subrepo workflows; changes will be propagated upstream via git subrepo push after approval.

ConfigKeyKit excluded: that subrepo is being removed entirely in #417, so its workflow is not modified here.

⚠️ The issue body was empty — please confirm this is the intended target set.

Closes#403.

@coderabbitai

coderabbitaiBot commented Jun 30, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 33bfcb76-f598-401b-8097-6d7fdd00ed23

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/remove-scheme-workflows

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

brightdigit/swift-build@v1 no longer needs an explicit scheme — the
MistKit and MistDemo workflows already omit it. Remove the now-obsolete
`scheme:` input from the BushelCloud and CelestraCloud workflows to match.
These are subrepo workflows; propagate upstream via `git subrepo push`
after review. (ConfigKeyKit is excluded — that subrepo is being removed
entirely in a separate PR.)
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@leogdion
leogdionforce-pushed the chore/remove-scheme-workflows branch from 1e6aa8f to cd460d6CompareJune 30, 2026 16:24
@leogdionleogdion changed the title Drop obsolete scheme input from example/package workflows (#403)Drop obsolete scheme input from example workflows (#403)Jun 30, 2026
@codecov

codecovBot commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.90%. Comparing base (9894d48) to head (cd460d6).
⚠️ Report is 2 commits behind head on v1.0.0-beta.3.

Additional details and impacted files
@@ Coverage Diff @@## v1.0.0-beta.3 #413 +/- ##
=================================================
+ Coverage 71.82% 71.90% +0.07% 
=================================================
Files 168 156 -12 Lines 3844 3698 -146 =================================================
- Hits 2761 2659 -102 + Misses 1083 1039 -44 
FlagCoverage Δ
mistdemo-spm-macos?
mistdemo-swift-6.2-jammy?
mistdemo-swift-6.2-noble?
mistdemo-swift-6.3-jammy?
mistdemo-swift-6.3-noble?
spm71.87% <ø> (+0.35%)⬆️
swift-6.1-jammy71.59% <ø> (-0.14%)⬇️
swift-6.1-noble71.59% <ø> (-0.28%)⬇️
swift-6.2-jammy71.57% <ø> (-0.09%)⬇️
swift-6.2-noble71.76% <ø> (+0.16%)⬆️
swift-6.3-jammy71.57% <ø> (+0.02%)⬆️
swift-6.3-noble71.62% <ø> (+0.02%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@leogdion
leogdion marked this pull request as ready for review June 30, 2026 23:49
@leogdion
leogdion merged commit 4395549 into v1.0.0-beta.3Jun 30, 2026
45 of 47 checks passed
@claude

claudeBot commented Jun 30, 2026

Copy link
Copy Markdown

Review

Reviewed the diff (Examples/BushelCloud/.github/workflows/BushelCloud.yml, Examples/CelestraCloud/.github/workflows/CelestraCloud.yml).

Summary: Minimal, mechanical change — removes the now-unnecessary scheme: ${{ env.PACKAGE_NAME }}-Package input from 4 brightdigit/swift-build@v1 steps (2 per file). Confirmed no scheme: input remains anywhere in the repo's workflows (including MistKit's and MistDemo's, which the PR description says already omit it), so this brings BushelCloud/CelestraCloud in line with the rest of the fleet.

Code quality / correctness: No issues. The diff only removes a line in each of the 4 steps; surrounding with: blocks are untouched and still well-formed YAML.

Minor nit (non-blocking): In both files, PACKAGE_NAME (declared in the top-level env: block, e.g. BushelCloud.yml:23) was only ever referenced by the now-removed scheme: lines. After this change it's an unused env var in both workflows. Worth a quick follow-up to drop it (or fold into #417's ConfigKeyKit cleanup) so it doesn't linger as dead config — not worth blocking this PR on.

Performance / security: N/A — CI-config-only change, no runtime code, secrets, or permissions touched.

Test coverage: N/A (workflow YAML). The PR description already notes the 7 edited files parse and the mistdemo build succeeds; since these are git-subrepo mirrors (BushelCloud/CelestraCloud.gitrepo files confirm method = merge), the real validation will be the next CI run after git subrepo push, as the PR body already flags.

Overall: safe, well-scoped cleanup. ✅

@leogdion
leogdion deleted the chore/remove-scheme-workflows branch July 1, 2026 00:29
@claudeclaudeBot mentioned this pull request Aug 20, 2026
@leogdionleogdion mentioned this pull request Aug 20, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@leogdion
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Drop obsolete scheme input from example workflows (#403) by leogdion · Pull Request #413 · brightdigit/MistKit · GitHub
Skip to content

Drop obsolete scheme input from example workflows (#403) - #413

Merged
leogdion merged 1 commit into
v1.0.0-beta.3from
chore/remove-scheme-workflows
Jun 30, 2026
Merged

Drop obsolete scheme input from example workflows (#403)#413
leogdion merged 1 commit into
v1.0.0-beta.3from
chore/remove-scheme-workflows

Conversation

@leogdion

@leogdionleogdion commented Jun 30, 2026

Copy link
Copy Markdown
Member

brightdigit/swift-build@v1 no longer needs an explicit scheme — the MistKit and MistDemo workflows already omit it. Removes the now-obsolete scheme: input from the BushelCloud and CelestraCloud workflows to match.

These are subrepo workflows; changes will be propagated upstream via git subrepo push after approval.

ConfigKeyKit excluded: that subrepo is being removed entirely in #417, so its workflow is not modified here.

⚠️ The issue body was empty — please confirm this is the intended target set.

Closes#403.

@coderabbitai

coderabbitaiBot commented Jun 30, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 33bfcb76-f598-401b-8097-6d7fdd00ed23

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/remove-scheme-workflows

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

brightdigit/swift-build@v1 no longer needs an explicit scheme — the
MistKit and MistDemo workflows already omit it. Remove the now-obsolete
`scheme:` input from the BushelCloud and CelestraCloud workflows to match.
These are subrepo workflows; propagate upstream via `git subrepo push`
after review. (ConfigKeyKit is excluded — that subrepo is being removed
entirely in a separate PR.)
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@leogdion
leogdionforce-pushed the chore/remove-scheme-workflows branch from 1e6aa8f to cd460d6CompareJune 30, 2026 16:24
@leogdionleogdion changed the title Drop obsolete scheme input from example/package workflows (#403)Drop obsolete scheme input from example workflows (#403)Jun 30, 2026
@codecov

codecovBot commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.90%. Comparing base (9894d48) to head (cd460d6).
⚠️ Report is 2 commits behind head on v1.0.0-beta.3.

Additional details and impacted files
@@ Coverage Diff @@## v1.0.0-beta.3 #413 +/- ##
=================================================
+ Coverage 71.82% 71.90% +0.07% 
=================================================
Files 168 156 -12 Lines 3844 3698 -146 =================================================
- Hits 2761 2659 -102 + Misses 1083 1039 -44 
FlagCoverage Δ
mistdemo-spm-macos?
mistdemo-swift-6.2-jammy?
mistdemo-swift-6.2-noble?
mistdemo-swift-6.3-jammy?
mistdemo-swift-6.3-noble?
spm71.87% <ø> (+0.35%)⬆️
swift-6.1-jammy71.59% <ø> (-0.14%)⬇️
swift-6.1-noble71.59% <ø> (-0.28%)⬇️
swift-6.2-jammy71.57% <ø> (-0.09%)⬇️
swift-6.2-noble71.76% <ø> (+0.16%)⬆️
swift-6.3-jammy71.57% <ø> (+0.02%)⬆️
swift-6.3-noble71.62% <ø> (+0.02%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@leogdion
leogdion marked this pull request as ready for review June 30, 2026 23:49
@leogdion
leogdion merged commit 4395549 into v1.0.0-beta.3Jun 30, 2026
45 of 47 checks passed
@claude

claudeBot commented Jun 30, 2026

Copy link
Copy Markdown

Review

Reviewed the diff (Examples/BushelCloud/.github/workflows/BushelCloud.yml, Examples/CelestraCloud/.github/workflows/CelestraCloud.yml).

Summary: Minimal, mechanical change — removes the now-unnecessary scheme: ${{ env.PACKAGE_NAME }}-Package input from 4 brightdigit/swift-build@v1 steps (2 per file). Confirmed no scheme: input remains anywhere in the repo's workflows (including MistKit's and MistDemo's, which the PR description says already omit it), so this brings BushelCloud/CelestraCloud in line with the rest of the fleet.

Code quality / correctness: No issues. The diff only removes a line in each of the 4 steps; surrounding with: blocks are untouched and still well-formed YAML.

Minor nit (non-blocking): In both files, PACKAGE_NAME (declared in the top-level env: block, e.g. BushelCloud.yml:23) was only ever referenced by the now-removed scheme: lines. After this change it's an unused env var in both workflows. Worth a quick follow-up to drop it (or fold into #417's ConfigKeyKit cleanup) so it doesn't linger as dead config — not worth blocking this PR on.

Performance / security: N/A — CI-config-only change, no runtime code, secrets, or permissions touched.

Test coverage: N/A (workflow YAML). The PR description already notes the 7 edited files parse and the mistdemo build succeeds; since these are git-subrepo mirrors (BushelCloud/CelestraCloud.gitrepo files confirm method = merge), the real validation will be the next CI run after git subrepo push, as the PR body already flags.

Overall: safe, well-scoped cleanup. ✅

@leogdion
leogdion deleted the chore/remove-scheme-workflows branch July 1, 2026 00:29
@claudeclaudeBot mentioned this pull request Aug 20, 2026
@leogdionleogdion mentioned this pull request Aug 20, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@leogdion
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Drop obsolete scheme input from example workflows (#403) by leogdion · Pull Request #413 · brightdigit/MistKit · GitHub
Skip to content

Drop obsolete scheme input from example workflows (#403) - #413

Merged
leogdion merged 1 commit into
v1.0.0-beta.3from
chore/remove-scheme-workflows
Jun 30, 2026
Merged

Drop obsolete scheme input from example workflows (#403)#413
leogdion merged 1 commit into
v1.0.0-beta.3from
chore/remove-scheme-workflows

Conversation

@leogdion

@leogdionleogdion commented Jun 30, 2026

Copy link
Copy Markdown
Member

brightdigit/swift-build@v1 no longer needs an explicit scheme — the MistKit and MistDemo workflows already omit it. Removes the now-obsolete scheme: input from the BushelCloud and CelestraCloud workflows to match.

These are subrepo workflows; changes will be propagated upstream via git subrepo push after approval.

ConfigKeyKit excluded: that subrepo is being removed entirely in #417, so its workflow is not modified here.

⚠️ The issue body was empty — please confirm this is the intended target set.

Closes#403.

@coderabbitai

coderabbitaiBot commented Jun 30, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 33bfcb76-f598-401b-8097-6d7fdd00ed23

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/remove-scheme-workflows

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

brightdigit/swift-build@v1 no longer needs an explicit scheme — the
MistKit and MistDemo workflows already omit it. Remove the now-obsolete
`scheme:` input from the BushelCloud and CelestraCloud workflows to match.
These are subrepo workflows; propagate upstream via `git subrepo push`
after review. (ConfigKeyKit is excluded — that subrepo is being removed
entirely in a separate PR.)
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@leogdion
leogdionforce-pushed the chore/remove-scheme-workflows branch from 1e6aa8f to cd460d6CompareJune 30, 2026 16:24
@leogdionleogdion changed the title Drop obsolete scheme input from example/package workflows (#403)Drop obsolete scheme input from example workflows (#403)Jun 30, 2026
@codecov

codecovBot commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.90%. Comparing base (9894d48) to head (cd460d6).
⚠️ Report is 2 commits behind head on v1.0.0-beta.3.

Additional details and impacted files
@@ Coverage Diff @@## v1.0.0-beta.3 #413 +/- ##
=================================================
+ Coverage 71.82% 71.90% +0.07% 
=================================================
Files 168 156 -12 Lines 3844 3698 -146 =================================================
- Hits 2761 2659 -102 + Misses 1083 1039 -44 
FlagCoverage Δ
mistdemo-spm-macos?
mistdemo-swift-6.2-jammy?
mistdemo-swift-6.2-noble?
mistdemo-swift-6.3-jammy?
mistdemo-swift-6.3-noble?
spm71.87% <ø> (+0.35%)⬆️
swift-6.1-jammy71.59% <ø> (-0.14%)⬇️
swift-6.1-noble71.59% <ø> (-0.28%)⬇️
swift-6.2-jammy71.57% <ø> (-0.09%)⬇️
swift-6.2-noble71.76% <ø> (+0.16%)⬆️
swift-6.3-jammy71.57% <ø> (+0.02%)⬆️
swift-6.3-noble71.62% <ø> (+0.02%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@leogdion
leogdion marked this pull request as ready for review June 30, 2026 23:49
@leogdion
leogdion merged commit 4395549 into v1.0.0-beta.3Jun 30, 2026
45 of 47 checks passed
@claude

claudeBot commented Jun 30, 2026

Copy link
Copy Markdown

Review

Reviewed the diff (Examples/BushelCloud/.github/workflows/BushelCloud.yml, Examples/CelestraCloud/.github/workflows/CelestraCloud.yml).

Summary: Minimal, mechanical change — removes the now-unnecessary scheme: ${{ env.PACKAGE_NAME }}-Package input from 4 brightdigit/swift-build@v1 steps (2 per file). Confirmed no scheme: input remains anywhere in the repo's workflows (including MistKit's and MistDemo's, which the PR description says already omit it), so this brings BushelCloud/CelestraCloud in line with the rest of the fleet.

Code quality / correctness: No issues. The diff only removes a line in each of the 4 steps; surrounding with: blocks are untouched and still well-formed YAML.

Minor nit (non-blocking): In both files, PACKAGE_NAME (declared in the top-level env: block, e.g. BushelCloud.yml:23) was only ever referenced by the now-removed scheme: lines. After this change it's an unused env var in both workflows. Worth a quick follow-up to drop it (or fold into #417's ConfigKeyKit cleanup) so it doesn't linger as dead config — not worth blocking this PR on.

Performance / security: N/A — CI-config-only change, no runtime code, secrets, or permissions touched.

Test coverage: N/A (workflow YAML). The PR description already notes the 7 edited files parse and the mistdemo build succeeds; since these are git-subrepo mirrors (BushelCloud/CelestraCloud.gitrepo files confirm method = merge), the real validation will be the next CI run after git subrepo push, as the PR body already flags.

Overall: safe, well-scoped cleanup. ✅

@leogdion
leogdion deleted the chore/remove-scheme-workflows branch July 1, 2026 00:29
@claudeclaudeBot mentioned this pull request Aug 20, 2026
@leogdionleogdion mentioned this pull request Aug 20, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@leogdion
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); Drop obsolete scheme input from example workflows (#403) by leogdion · Pull Request #413 · brightdigit/MistKit · GitHub
Skip to content

Drop obsolete scheme input from example workflows (#403) - #413

Merged
leogdion merged 1 commit into
v1.0.0-beta.3from
chore/remove-scheme-workflows
Jun 30, 2026
Merged

Drop obsolete scheme input from example workflows (#403)#413
leogdion merged 1 commit into
v1.0.0-beta.3from
chore/remove-scheme-workflows

Conversation

@leogdion

@leogdionleogdion commented Jun 30, 2026

Copy link
Copy Markdown
Member

brightdigit/swift-build@v1 no longer needs an explicit scheme — the MistKit and MistDemo workflows already omit it. Removes the now-obsolete scheme: input from the BushelCloud and CelestraCloud workflows to match.

These are subrepo workflows; changes will be propagated upstream via git subrepo push after approval.

ConfigKeyKit excluded: that subrepo is being removed entirely in #417, so its workflow is not modified here.

⚠️ The issue body was empty — please confirm this is the intended target set.

Closes#403.

@coderabbitai

coderabbitaiBot commented Jun 30, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 33bfcb76-f598-401b-8097-6d7fdd00ed23

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/remove-scheme-workflows

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

brightdigit/swift-build@v1 no longer needs an explicit scheme — the
MistKit and MistDemo workflows already omit it. Remove the now-obsolete
`scheme:` input from the BushelCloud and CelestraCloud workflows to match.
These are subrepo workflows; propagate upstream via `git subrepo push`
after review. (ConfigKeyKit is excluded — that subrepo is being removed
entirely in a separate PR.)
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@leogdion
leogdionforce-pushed the chore/remove-scheme-workflows branch from 1e6aa8f to cd460d6CompareJune 30, 2026 16:24
@leogdionleogdion changed the title Drop obsolete scheme input from example/package workflows (#403)Drop obsolete scheme input from example workflows (#403)Jun 30, 2026
@codecov

codecovBot commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.90%. Comparing base (9894d48) to head (cd460d6).
⚠️ Report is 2 commits behind head on v1.0.0-beta.3.

Additional details and impacted files
@@ Coverage Diff @@## v1.0.0-beta.3 #413 +/- ##
=================================================
+ Coverage 71.82% 71.90% +0.07% 
=================================================
Files 168 156 -12 Lines 3844 3698 -146 =================================================
- Hits 2761 2659 -102 + Misses 1083 1039 -44 
FlagCoverage Δ
mistdemo-spm-macos?
mistdemo-swift-6.2-jammy?
mistdemo-swift-6.2-noble?
mistdemo-swift-6.3-jammy?
mistdemo-swift-6.3-noble?
spm71.87% <ø> (+0.35%)⬆️
swift-6.1-jammy71.59% <ø> (-0.14%)⬇️
swift-6.1-noble71.59% <ø> (-0.28%)⬇️
swift-6.2-jammy71.57% <ø> (-0.09%)⬇️
swift-6.2-noble71.76% <ø> (+0.16%)⬆️
swift-6.3-jammy71.57% <ø> (+0.02%)⬆️
swift-6.3-noble71.62% <ø> (+0.02%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@leogdion
leogdion marked this pull request as ready for review June 30, 2026 23:49
@leogdion
leogdion merged commit 4395549 into v1.0.0-beta.3Jun 30, 2026
45 of 47 checks passed
@claude

claudeBot commented Jun 30, 2026

Copy link
Copy Markdown

Review

Reviewed the diff (Examples/BushelCloud/.github/workflows/BushelCloud.yml, Examples/CelestraCloud/.github/workflows/CelestraCloud.yml).

Summary: Minimal, mechanical change — removes the now-unnecessary scheme: ${{ env.PACKAGE_NAME }}-Package input from 4 brightdigit/swift-build@v1 steps (2 per file). Confirmed no scheme: input remains anywhere in the repo's workflows (including MistKit's and MistDemo's, which the PR description says already omit it), so this brings BushelCloud/CelestraCloud in line with the rest of the fleet.

Code quality / correctness: No issues. The diff only removes a line in each of the 4 steps; surrounding with: blocks are untouched and still well-formed YAML.

Minor nit (non-blocking): In both files, PACKAGE_NAME (declared in the top-level env: block, e.g. BushelCloud.yml:23) was only ever referenced by the now-removed scheme: lines. After this change it's an unused env var in both workflows. Worth a quick follow-up to drop it (or fold into #417's ConfigKeyKit cleanup) so it doesn't linger as dead config — not worth blocking this PR on.

Performance / security: N/A — CI-config-only change, no runtime code, secrets, or permissions touched.

Test coverage: N/A (workflow YAML). The PR description already notes the 7 edited files parse and the mistdemo build succeeds; since these are git-subrepo mirrors (BushelCloud/CelestraCloud.gitrepo files confirm method = merge), the real validation will be the next CI run after git subrepo push, as the PR body already flags.

Overall: safe, well-scoped cleanup. ✅

@leogdion
leogdion deleted the chore/remove-scheme-workflows branch July 1, 2026 00:29
@claudeclaudeBot mentioned this pull request Aug 20, 2026
@leogdionleogdion mentioned this pull request Aug 20, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@leogdion