Uh oh!
There was an error while loading. Please reload this page.
Merge prep: drop 1.28 MB of stale docs, re-enable periphery - #440
Merged
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## v1.0.0-beta.4 #440 +/- ##
=================================================
- Coverage 81.64% 81.45% -0.20%
=================================================
Files 191 191 Lines 4719 4719 =================================================
- Hits 3853 3844 -9 - Misses 866 875 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Deletes the five conference-talk transcription exports (paragraphs.json, timestamps.json, transcript.srt/.txt/.vtt, 1,272,627 bytes total). They are build-irrelevant artifacts of the 2026-05 "CloudKit as Your Backend" dry run and are not referenced by docs/README.md. All five blobs are preserved on the pushed annotated tag archive/talk-prep-2026-05-17, so they remain recoverable even though main is squash-merged. docs/talk-feedback.md still cites the raw transcript in its cleanup and brand/spelling sections, so the reference is kept and repointed at the archive tag on GitHub rather than dropped. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xs1c8vvxjCxqZiStcmuPS2
Time-boxed WIP handoff (7,606 B) from the Claude Code web session behind PR #424: it points at branch `claude/parallel-agents-work-trees-pbumvn` and head `fb84e52`, both long superseded. `git grep MILESTONE-19` finds no reference to it anywhere outside the file itself, and it is the only file in .claude/docs/ that is a session snapshot rather than reference material. Still recoverable from PR #424's own commits on GitHub (added by 1411227; blob a75fbcd). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xs1c8vvxjCxqZiStcmuPS2
PR #429 gated periphery behind an opt-in RUN_PERIPHERY=1 because periphery could no longer find SwiftPM's index store. Fix the cause instead of skipping the check. The store's location depends on the build system: swiftbuild (the SwiftPM default since Swift 6.2) writes `.build/out`, the native build system writes `.build/<triple>/debug/index/store`, and older toolchains wrote `.build/debug/index/store`. lint.sh now probes those three candidates for a `v5/units` directory and passes the winner to periphery's `--index-store-path` (3.7.4, pinned in mise.toml), with `--skip-build` stated explicitly to silence periphery's implied-flag warning. The build step above already produced the store, so skipping periphery's own build is both correct and faster. The RUN_PERIPHERY opt-in and the stale explanatory comment are gone; periphery runs by default in local runs again. The $CI and CLAUDE_CODE_REMOTE exclusions are unchanged, so CI behavior is identical. Examples/MistDemo/Scripts/lint.sh gets the same resolution; it is an in-repo package, not a subrepo. Its BushelCloud and CelestraCloud siblings are git subrepos and are left alone. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xs1c8vvxjCxqZiStcmuPS2
leogdionforce-pushed
the
beta4-merge-prep
branch
from
August 28, 2026 20:15
8ef0d4f to
8215febCompareUh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three independent housekeeping changes to prepare
v1.0.0-beta.4for merge. No production source is touched.1. Remove
docs/transcriptions/— 1,272,627 bytesparagraphs.jsontimestamps.jsontranscript.srttranscript.vtttranscript.txtRaw exports from the 2026-05 "CloudKit as Your Backend" dry run. Nothing builds from them and
docs/README.mdnever linked them.Recoverability proof.
mainis squash-merged, so branch history is not a preservation mechanism (see.claude/memory/feedback_check_merge_strategy_before_release_deletions.md). All five blobs were verified present on the annotated tagarchive/talk-prep-2026-05-17, which is pushed toorigin(6bc67f7, peeledde82483):Dangling link.
docs/talk-feedback.md:8was the only live reference. That file stays (it is already onmain), and the reference is repointed at the archive tag rather than dropped — the doc still cites the transcript substantively in its "Audio / Delivery Cleanup" and "Brand / Spelling" sections (it even quotes a line number), so a reader who follows those sections needs a way to reach the source.git grep -n 'transcriptions/'now returns only that one resolvable GitHub URL plus the memory memo's prose mention.2. Delete
.claude/docs/MILESTONE-19-HANDOFF.md— 7,606 bytesA session snapshot, not reference material: it points at branch
claude/parallel-agents-work-trees-pbumvnand headfb84e52, both long superseded. Verified unreferenced —git grep MILESTONE-19finds nothing outside the file, and a case-insensitivemilestone.19sweep only matches the file's own body. It is the only time-boxed file in.claude/docs/; everything else under.claude/,.agents/, and.cursor/is untouched. Still recoverable from PR #424's commits on GitHub (added by1411227, bloba75fbcd).3. Re-enable periphery in
Scripts/lint.shPR #429 gated periphery behind
RUN_PERIPHERY=1because it could no longer find SwiftPM's index store. The gate is removed and the root cause fixed.The store's location depends on the build system, and the old comment described only one of three layouts:
.build/out.build/<triple>/debug/index/store.build/debug/index/storelint.shnow probes those three candidates for av5/unitsdirectory and hands the winner to periphery 3.7.4's--index-store-path(the version pinned inmise.toml).--skip-buildis passed explicitly —--index-store-pathimplies it, and stating it silences periphery's warning. Skipping periphery's own build is correct here becauseswift build --build-testsalready ran earlier in the script. If no store is found the scan is skipped with an actionable message instead of failing.The
$CIandCLAUDE_CODE_REMOTEexclusions are unchanged — periphery has never run in CI on either branch and this PR does not alter that.git grep RUN_PERIPHERYis now clean.Periphery's actual output
Plain
./Scripts/lint.sh(no env vars) now runs the scan and reports one finding:Per instruction this was not deleted. For triage: it is
internal init(from schema: Components.Schemas.ShareTargetReference), soretain_public: truedoes not shield it — this looks like genuine dead code. The opposite direction,Components.Schemas.ShareTargetReference.init(from: ShareTargetReference)in the same file, is used (Sources/MistKit/OpenAPI/Components/Components.Schemas.RecordOperation.swift:70); only the OpenAPI-schema-to-model converter appears to have been written without a caller. Leo's call.Periphery exits 0 on findings (no
--strict), so this does not fail the lint gate — behavior matches the previously recorded clean run.Examples/*/Scripts/lint.shinconsistencyThe three example copies still carried the old unconditional
periphery scan $PERIPHERY_OPTIONSshape, which is broken under the current toolchain for the same index-store reason.Examples/MistDemo/Scripts/lint.sh:66— fixed here. MistDemo has no.gitrepo; it is an in-repo package, so the fix belongs in this PR. Not executed, since another lane is concurrently changingExamples/MistDemo/Sources/.Examples/BushelCloud/Scripts/lint.sh:65andExamples/CelestraCloud/Scripts/lint.sh:67— deliberately left alone. Both are git subrepos with their own CI and PR flow; per.claude/memory/feedback_subrepo_fixes_belong_in_subrepo.mdthe same fix should be made in their own repositories and pulled back in viagit subrepo. Flagging rather than fixing.Verification
swift build --build-tests— clean, exit 0swift test— 618 tests in 195 suites passed, 2.1 s./Scripts/lint.sh—Linting completed successfully, with periphery actually running (swift-format clean; SwiftLint 28 violations / 0 serious, pre-existing and non-fatal in non-strict mode)git grep -n 'transcriptions/'— no dangling linksgit grep -n 'MILESTONE-19'— no hitsgit grep -n 'RUN_PERIPHERY'— no hitsswift-format --in-placeleft the tree unchangedBase is
v1.0.0-beta.4, notmain.🤖 Generated with Claude Code