Skip to content

[wip] improve lua performance - #2

Closed
bomgar wants to merge 1 commit into
masterfrom
lua-performance
Closed

[wip] improve lua performance#2
bomgar wants to merge 1 commit into
masterfrom
lua-performance

Conversation

@bomgar

@bomgarbomgar commented Jul 8, 2017•
edited
Loading

Copy link
Copy Markdown
Member
  1. I don't like, that lua is allocated although it is not needed if no filter is specifier
  2. I don't like that other variables survive the log entry.

@bomgar

bomgar commented Jul 8, 2017

Copy link
Copy Markdown
MemberAuthor

@mriehl maybe you have a better solution

@bomgar
bomgar requested a review from mriehlJuly 8, 2017 14:51
@bomgar

bomgar commented Jul 9, 2017

Copy link
Copy Markdown
MemberAuthor

i don't like that the state needs to be cleaned instead of being recreated. I will leave this as it is.

tomaka/hlua#147 this should at least help with the performance.

@bomgarbomgar closed this Jul 9, 2017
@bomgar
bomgar deleted the lua-performance branch September 13, 2019 10:57
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mriehlmriehlAwaiting requested review from mriehl

Assignees

@mriehlmriehl

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bomgar@mriehl