fix(netlify-deploy): expose the build env vars to Next.js sites - #88
Merged
Merged
Conversation
Next.js only inlines variables prefixed with NEXT_PUBLIC_, so sites migrated from Gatsby were silently getting undefined. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The workflow passes
PRODUCTION_DEPLOYandREVIEW_IDto the build script.Those names date back to Gatsby, which reads plain environment variables at build
time. Next.js only inlines variables prefixed with
NEXT_PUBLIC_, so a sitemigrated from Gatsby to Next.js reads
undefinedand silently falls back.That is the case on lescapsules-web,
where
lib/metadata.tsreadsNEXT_PUBLIC_REVIEW_IDandNEXT_PUBLIC_PRODUCTION_DEPLOY: deploy previews advertisehttps://www.lescapsules.comas theirsiteUrl, which then feedsmetadataBase,the sitemap and the manifest, so a preview points search engines and social cards
at production.
What
Passes both variables under their prefixed name as well, and documents the ones
the build script gets. Plain names are kept so that Gatsby sites using the
workflow are unaffected.
Consumers pick the fix up when their pinned ref moves to the next release.
🤖 Generated with Claude Code