Configure services

[bubacoder]

Summary by CodeRabbit

• Configuration

  • Updated Docker environment IP configuration and added documentation comments.
  • Enhanced health check mechanism for containerized services with improved detection and startup delays.
  • Added network connectivity for Docker services.

• Build & Setup

  • Extended project template to include additional VS Code configuration files.
  • Updated ignore rules for logs and Docker localhost paths.

• Code Quality

  • Adjusted code formatting configuration.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

Configuration and tooling updates across infrastructure files: Ansible inventory documentation, Docker environment IP address change, Docker health check enhancement, external Docker network attachment, ruff formatting rule removal, and VS Code configuration file extension in copy script.

Changes

Cohort / File(s)	Summary
Inventory & Configuration Documentation ansible/inventory/inventory.yaml, config-example/docker/.env	Added cross-reference comment in Ansible inventory pointing to Docker env file. Updated Docker env with corresponding header comment and changed SECOND_NODE_IP from 192.168.1.243 to 192.168.1.40.
Git Ignore Rules config-example/.gitignore	Added two new ignore patterns: log/ for project root logs and docker/localhost for local Docker paths.
Docker Service Configuration docker/ai/litellm.yaml, docker/security/endlessh.yaml	Updated litellm health check from wget-based test to Python HTTP request with 40s start_period delay. Added proxy external network configuration and network attachment to endlessh service.
Tooling Configuration ruff.toml	Removed skip-magic-trailing-comma = true from [format] section.
Script Updates scripts/copy-repo-template.sh	Extended VS Code file copy list to include .vscode/settings.json and .vscode/mcp.json alongside existing .vscode/extensions.json.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• Setup a new host, extend setup documentation #89 — Modifies ansible/inventory/inventory.yaml and updates SECOND_NODE_IP value for the same hive/second-node host referenced in this PR.
• Isolate networks of sensitive services #196 — Directly related through opposite changes to docker/security/endlessh.yaml network configuration (removes vs. adds proxy network attachment).
• Add git repo template script #216 — Modifies the same scripts/copy-repo-template.sh file to alter the VS Code configuration files being copied.

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title 'Configure services' is vague and generic. The PR modifies 6 different files with varied changes including health checks, network configurations, IP updates, and VS Code settings, but the title does not reflect any of these specific changes.	Use a more specific title that reflects the primary change, such as 'Update service configurations and health checks' or 'Add service network configurations and update deployment settings'.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch feature/configure-services

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1d23a5c and 8d40e2d.

📒 Files selected for processing (7)

• ansible/inventory/inventory.yaml
• config-example/.gitignore
• config-example/docker/.env
• docker/ai/litellm.yaml
• docker/security/endlessh.yaml
• ruff.toml
• scripts/copy-repo-template.sh

💤 Files with no reviewable changes (1)

• ruff.toml

🧰 Additional context used

📓 Path-based instructions (3)

**/*.sh

📄 CodeRabbit inference engine (AGENTS.md)

Shell scripts must pass ShellCheck validation

Files:

• scripts/copy-repo-template.sh

**/*.{yaml,yml}

📄 CodeRabbit inference engine (AGENTS.md)

YAML files must pass YAML linting and validation

Files:

• ansible/inventory/inventory.yaml
• docker/ai/litellm.yaml
• docker/security/endlessh.yaml

ansible/**/*.{yaml,yml}

📄 CodeRabbit inference engine (AGENTS.md)

Ansible playbooks and roles must pass Ansible linting

Files:

• ansible/inventory/inventory.yaml

🧠 Learnings (2)

📓 Common learnings

Learnt from: CR
Repo: bubacoder/infra PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-26T20:10:59.672Z
Learning: Use Ansible for infrastructure configuration management

📚 Learning: 2025-11-26T20:10:59.672Z

Learnt from: CR
Repo: bubacoder/infra PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-26T20:10:59.672Z
Learning: Use Ansible for infrastructure configuration management

Applied to files:

• ansible/inventory/inventory.yaml

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: check
• GitHub Check: build-test-push (ubuntu, ubuntu:24.04)
• GitHub Check: build-test-push (debian, debian:trixie-slim)

🔇 Additional comments (8)

config-example/.gitignore (1)

1-2: LGTM! Appropriate ignore patterns.

The ignore patterns correctly exclude generated logs and localhost-specific Docker configurations from version control.

ansible/inventory/inventory.yaml (1)

8-8: Good practice for cross-file consistency.

The cross-reference comment helps maintain consistency between the Ansible inventory and Docker environment configuration, reducing the risk of configuration drift.

docker/ai/litellm.yaml (2)

36-36: Good addition of start_period.

Adding start_period: 40s allows the container to fully initialize before health checks begin, preventing false negatives during startup.

---

30-32: Code is correct — no changes needed.

The health endpoint /health/liveliness matches LiteLLM's official proxy documentation, and Python 3.11.8 is available in the specified image. YAML syntax is valid.

config-example/docker/.env (2)

13-14: Good cross-reference documentation.

The header comment creates a bidirectional reference with the Ansible inventory, helping maintain consistency between infrastructure configuration files.

---

19-19: IP change is consistent with Ansible inventory.

The SECOND_NODE_IP update to 192.168.1.40 correctly matches the hive node's ansible_host value in ansible/inventory/inventory.yaml (line 19).

scripts/copy-repo-template.sh (1)

24-25: Source files verified to exist.

Both .vscode/settings.json and .vscode/mcp.json are present in the repository. The shell script passes ShellCheck validation without errors.

docker/security/endlessh.yaml (1)

36-47: Confirm if port 2112 is actually exposed by endlessh and how Prometheus scrapes it.

The comment references "Prometheus metrics scraping (port 2112)", but this port is not in the exposed ports section. Verify: (1) does endlessh expose port 2112 internally, (2) is Prometheus configured to scrape metrics through the proxy network, or (3) should port 2112 be explicitly exposed in the ports section?

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}