Configure Frigate, Traefik, backup, agent guidelines - #265
Conversation
WalkthroughAdds a Git guideline to AGENTS.md, updates backup Taskfile to exclude Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
docker/security/traefik/dynamic/external-services.yml (1)
19-23: Resolve qbittorrent middleware inconsistency: two conflicting configurations.Qbittorrent is configured with different middlewares in two places:
docker/fileshare/qbittorrent.yaml(line 38):localaccess-sso@file(IP allowlist + Authelia SSO)docker/security/traefik/dynamic/external-services.yml(line 23):localaccess@file(IP allowlist only)The dynamic config route uses
localaccess@filewhich removes SSO authentication, creating a security regression. Choose one authoritative configuration:
- If SSO should remain enforced: remove qbittorrent from external-services.yml
- If IP-only access is intentional: update qbittorrent.yaml to match
🔒 Suggested fix to restore SSO protection
- - localaccess@file + - localaccess-sso@file
🤖 Fix all issues with AI agents
In `@docker/security/frigate/config.yml`:
- Around line 21-42: The config uses an unsupported stream role "rtmp" on the
camera stream entry; remove the "rtmp" role from the roles list (leave only
detect/record/audio as appropriate) and, if you need live/restreaming, wire the
source into go2rtc and map it via cameras.<name>.live.streams instead of adding
rtmp here; also verify that the substream name h264Preview_01_sub actually
outputs 960x540 (or adjust detect.width/detect.height to match the substream) so
Frigate's detect settings aren't causing scaling or ignored frames.
b99491a to
4015266
Compare
Summary by CodeRabbit
Documentation
Configuration
✏️ Tip: You can customize this high-level summary in your review settings.