Update pre-commit hooks, add actionlint - #306
Conversation
WalkthroughThis PR adjusts shell quoting in GitHub workflow files to ensure proper argument parsing, updates pre-commit hook versions (gitleaks, shellcheck-py, renovate-config-validator), adds actionlint hook, and renames a task in Taskfile.yaml. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
Taskfile.yaml (1)
71-74: Consider keeping a compatibility alias for the old task name.If any local scripts/docs still call the previous task, this rename can cause avoidable breakage.
Proposed backward-compatible update
update-pre-commit: + aliases: [pre-commit-update] desc: Update pre-commit repositories cmds: - pre-commit autoupdate🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@Taskfile.yaml` around lines 71 - 74, You renamed the Taskfile task to "update-pre-commit" which can break callers; add a backward-compatible alias task using the previous task name (replace OLD_TASK_NAME with whatever the repo previously used) that either duplicates the same cmds (["pre-commit autoupdate"]) or depends on "update-pre-commit" so old scripts/docs keep working while the new "update-pre-commit" task remains the canonical one.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@Taskfile.yaml`:
- Around line 71-74: You renamed the Taskfile task to "update-pre-commit" which
can break callers; add a backward-compatible alias task using the previous task
name (replace OLD_TASK_NAME with whatever the repo previously used) that either
duplicates the same cmds (["pre-commit autoupdate"]) or depends on
"update-pre-commit" so old scripts/docs keep working while the new
"update-pre-commit" task remains the canonical one.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: d649ba9a-1254-4309-80ac-7cefabd3c45e
📒 Files selected for processing (4)
.github/workflows/docs-web.yml.github/workflows/pre-commit.yml.pre-commit-config.yamlTaskfile.yaml
Summary by CodeRabbit