Skip to content

Update pre-commit hooks, add actionlint - #306

Merged
bubacoder merged 1 commit into
mainfrom
feature/pre-commit
Apr 9, 2026
Merged

Update pre-commit hooks, add actionlint#306
bubacoder merged 1 commit into
mainfrom
feature/pre-commit

Conversation

@bubacoder

@bubacoder bubacoder commented Apr 9, 2026

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • Chores
    • Updated pre-commit hook versions and added actionlint configuration
    • Fixed shell command quoting in CI workflows
    • Renamed task identifier in task configuration

@coderabbitai

coderabbitai Bot commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

This PR adjusts shell quoting in GitHub workflow files to ensure proper argument parsing, updates pre-commit hook versions (gitleaks, shellcheck-py, renovate-config-validator), adds actionlint hook, and renames a task in Taskfile.yaml.

Changes

Cohort / File(s) Summary
Workflow Shell Quoting
.github/workflows/docs-web.yml, .github/workflows/pre-commit.yml
Added quotes around shell-expanded arguments in docker run and curl commands to ensure proper parsing of command substitutions as single arguments.
Pre-commit Hook Configuration
.pre-commit-config.yaml
Updated hook versions (gitleaks downgraded to v8.30.0, shellcheck-py upgraded to v0.11.0.1, renovate-config-validator upgraded to 43.110.8), added new actionlint hook v1.7.6 for GitHub Workflows validation with TODO comment update.
Task Definition Rename
Taskfile.yaml
Renamed pre-commit update task identifier from pre-commit-update to update-pre-commit while keeping command and description unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main changes: updating pre-commit hooks (gitleaks, shellcheck-py, renovate-config-validator) and adding the actionlint hook.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/pre-commit

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
Taskfile.yaml (1)

71-74: Consider keeping a compatibility alias for the old task name.

If any local scripts/docs still call the previous task, this rename can cause avoidable breakage.

Proposed backward-compatible update
   update-pre-commit:
+    aliases: [pre-commit-update]
     desc: Update pre-commit repositories
     cmds:
       - pre-commit autoupdate
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@Taskfile.yaml` around lines 71 - 74, You renamed the Taskfile task to
"update-pre-commit" which can break callers; add a backward-compatible alias
task using the previous task name (replace OLD_TASK_NAME with whatever the repo
previously used) that either duplicates the same cmds (["pre-commit
autoupdate"]) or depends on "update-pre-commit" so old scripts/docs keep working
while the new "update-pre-commit" task remains the canonical one.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@Taskfile.yaml`:
- Around line 71-74: You renamed the Taskfile task to "update-pre-commit" which
can break callers; add a backward-compatible alias task using the previous task
name (replace OLD_TASK_NAME with whatever the repo previously used) that either
duplicates the same cmds (["pre-commit autoupdate"]) or depends on
"update-pre-commit" so old scripts/docs keep working while the new
"update-pre-commit" task remains the canonical one.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d649ba9a-1254-4309-80ac-7cefabd3c45e

📥 Commits

Reviewing files that changed from the base of the PR and between 153af82 and 9317fcd.

📒 Files selected for processing (4)
  • .github/workflows/docs-web.yml
  • .github/workflows/pre-commit.yml
  • .pre-commit-config.yaml
  • Taskfile.yaml

@bubacoder
bubacoder merged commit 825cd54 into main Apr 9, 2026
4 checks passed
@bubacoder
bubacoder deleted the feature/pre-commit branch April 9, 2026 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant