Skip to content

Cover Renovate's blind spots - #316

Merged
bubacoder merged 1 commit into
mainfrom
feature/renovate-config
Apr 26, 2026
Merged

Cover Renovate's blind spots#316
bubacoder merged 1 commit into
mainfrom
feature/renovate-config

Conversation

@bubacoder

@bubacoder bubacoder commented Apr 26, 2026

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • Chores
    • Enabled automated dependency version tracking across workflows and infrastructure scripts
    • Added support for pinned versions via environment variables
    • Extended automation configuration for seamless GitHub releases integration

@coderabbitai

coderabbitai Bot commented Apr 26, 2026

Copy link
Copy Markdown
Contributor

Warning

Rate limit exceeded

@bubacoder has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 8 minutes and 6 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 8 minutes and 6 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: afa084df-90f4-4c65-bc44-e3cb9ac4d230

📥 Commits

Reviewing files that changed from the base of the PR and between 02c8749 and f06c201.

📒 Files selected for processing (7)
  • .github/workflows/pre-commit.yml
  • ansible/inventory/group_vars/debian/vars.yaml
  • ansible/roles/debian_tools/tasks/20-homebrew.yaml
  • proxmox/create-openwrt-vm.sh
  • proxmox/create-ubuntu-cloud-vm.sh
  • proxmox/create-ubuntu-server-vm.sh
  • renovate.json

Walkthrough

This pull request configures automated version tracking across infrastructure and workflow files by adding Renovate dependency management comments, updating tool installation commands to support environment variable-based version pinning, and extending the Renovate configuration to detect Python versions in workflow files.

Changes

Cohort / File(s) Summary
Workflow Configuration
.github/workflows/pre-commit.yml, renovate.json
Updates tflint installation to use TFLINT_VERSION environment variable, adds Renovate comments for tflint and terraform-docs tracking, and introduces a new customManagers regex rule to detect and manage Python versions from workflow files.
Version Tracking Metadata
ansible/inventory/group_vars/debian/vars.yaml, proxmox/create-openwrt-vm.sh, proxmox/create-ubuntu-cloud-vm.sh, proxmox/create-ubuntu-server-vm.sh
Adds Renovate configuration comments alongside version constants to enable automated dependency updates for go-task, OpenWRT, and Ubuntu versions without changing runtime logic.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Cover Renovate's blind spots' accurately describes the core objective: extending Renovate configuration to handle version management in files and patterns it previously couldn't detect automatically.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/renovate-config

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
renovate.json (1)

22-31: Consider adding versioningTemplate: "python".

The official Renovate docs example for the python-version datasource includes "versioningTemplate": "python". Without it, Renovate may not properly handle Python's PEP 440 versioning semantics, potentially causing issues with pre-releases and version constraints.

♻️ Proposed refactor
       "managerFilePatterns": ["/^\\.github/workflows/.+\\.ya?ml$/"],
       "matchStrings": ["python-version:\\s*['\"](?<currentValue>[\\d.]+)['\"]"],
       "datasourceTemplate": "python-version",
+      "versioningTemplate": "python",
       "depNameTemplate": "python"
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@renovate.json` around lines 22 - 31, The custom manager entry in the
"customManagers" array lacks a versioningTemplate and should include
versioningTemplate: "python" so Renovate interprets PEP 440 semantics; update
the object containing "description", "customType", "managerFilePatterns",
"matchStrings", "datasourceTemplate": "python-version", and "depNameTemplate":
"python" to also include "versioningTemplate": "python".
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@proxmox/create-ubuntu-server-vm.sh`:
- Around line 8-10: The Renovate directive using the endoflife datasource is
incorrect for point releases; update the header comment and UBUNTU_VERSION
handling so Renovate tracks the LTS cycle only: remove or replace the `#
renovate: datasource=endoflife depName=ubuntu` line, and set `UBUNTU_VERSION` to
the cycle form (e.g., "24.04") or add a Renovate regex that strips point
releases (so `readonly UBUNTU_VERSION="24.04.3"` becomes a cycle-only value) —
change references to the symbol UBUNTU_VERSION and the existing Renovate comment
accordingly.

---

Nitpick comments:
In `@renovate.json`:
- Around line 22-31: The custom manager entry in the "customManagers" array
lacks a versioningTemplate and should include versioningTemplate: "python" so
Renovate interprets PEP 440 semantics; update the object containing
"description", "customType", "managerFilePatterns", "matchStrings",
"datasourceTemplate": "python-version", and "depNameTemplate": "python" to also
include "versioningTemplate": "python".
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 95ffdf15-927f-42fe-bbfd-65ecc18cc4c7

📥 Commits

Reviewing files that changed from the base of the PR and between d0038b3 and 02c8749.

📒 Files selected for processing (6)
  • .github/workflows/pre-commit.yml
  • ansible/inventory/group_vars/debian/vars.yaml
  • proxmox/create-openwrt-vm.sh
  • proxmox/create-ubuntu-cloud-vm.sh
  • proxmox/create-ubuntu-server-vm.sh
  • renovate.json

Comment thread proxmox/create-ubuntu-server-vm.sh Outdated
@bubacoder
bubacoder force-pushed the feature/renovate-config branch 2 times, most recently from c07dee7 to 46711dd Compare April 26, 2026 09:59
@bubacoder
bubacoder force-pushed the feature/renovate-config branch from 46711dd to f06c201 Compare April 26, 2026 10:15
@bubacoder
bubacoder merged commit fd66ea6 into main Apr 26, 2026
6 checks passed
@bubacoder
bubacoder deleted the feature/renovate-config branch April 26, 2026 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant