Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (16)
✅ Files skipped from review due to trivial changes (4)
🚧 Files skipped from review as they are similar to previous changes (6)
WalkthroughExtracts shared Bash helpers into a new ChangesVM Scripts Reorganization and Shared Library
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (1)
vm/proxmox/create-openwrt-vm.sh (1)
69-70: ⚡ Quick winUse
VM_STORAGEconsistently instead of hardcodinglocal-lvm.Line 69 bypasses the shared storage config from
lib-common.sh, which can drift from the rest of the scripts. Use${VM_STORAGE}here as well.Proposed fix
- qm set "${VMID}" --scsi0 local-lvm:0,import-from="$(realpath "./${VM_IMG}")",ssd=1 + qm set "${VMID}" --scsi0 "${VM_STORAGE}:0,import-from=$(realpath "./${VM_IMG}"),ssd=1"🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@vm/proxmox/create-openwrt-vm.sh` around lines 69 - 70, Replace the hardcoded storage name local-lvm with the ${VM_STORAGE} variable in the qm set command on line 69 that configures the SCSI device. Change local-lvm:0 to ${VM_STORAGE}:0 to ensure the storage configuration is consistent with the shared config from lib-common.sh and avoid configuration drift across scripts.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/setup.md`:
- Line 32: The line containing "See [Proxmox VE]" in the setup.md file is
missing the proper Markdown blockquote prefix. The `-->` text will render as
plain text instead of creating the intended callout styling. Restore the line by
replacing the `-->` prefix with the correct Markdown blockquote prefix `>` to
enable proper formatting and visual styling for this note.
In `@vm/lib-common.sh`:
- Around line 34-41: Replace the hardcoded fixed path `/tmp/SHA256SUMS` with a
secure temporary file created using `mktemp` to prevent symlink-clobber attacks
on multi-user systems. Update the wget command that downloads to
`/tmp/SHA256SUMS` and the subsequent sha256sum verification check to use the new
temporary file path instead. Additionally, add a cleanup trap to ensure the
temporary file is removed when the script exits, even in error cases.
In `@vm/proxmox/create-ubuntu-server-vm.sh`:
- Around line 20-23: Remove the hardcoded PASSWORD_HASH variable and the comment
that documents the plaintext password creation method, as these create
predictable bootstrap credentials across all VMs. In the autoinstall
configuration section (outside the current diff range), disable password
authentication by setting allow-pw: false in the SSH configuration to prevent
password-based login. This addresses the root cause of using static credentials
while also ensuring consistency across other affected VM creation scripts that
reuse the same hash.
---
Nitpick comments:
In `@vm/proxmox/create-openwrt-vm.sh`:
- Around line 69-70: Replace the hardcoded storage name local-lvm with the
${VM_STORAGE} variable in the qm set command on line 69 that configures the SCSI
device. Change local-lvm:0 to ${VM_STORAGE}:0 to ensure the storage
configuration is consistent with the shared config from lib-common.sh and avoid
configuration drift across scripts.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 0186f058-dadb-4edf-a0fa-84215217e224
📒 Files selected for processing (16)
AGENTS.mdTaskfile.yamldocs/runbooks.mddocs/setup.mddocs/web/update-docs-config.yamlvm/lib-common.shvm/libvirt/create-ubuntu-cloud-vm.shvm/proxmox/README.mdvm/proxmox/create-openwrt-vm.shvm/proxmox/create-ubuntu-cloud-vm.shvm/proxmox/create-ubuntu-server-vm.shvm/proxmox/haiku-os.mdvm/proxmox/macos.mdvm/proxmox/openwrt.mdvm/proxmox/ubuntu.mdvm/proxmox/windows.md
bubacoder
force-pushed
the
local-vm
branch
2 times, most recently
from
June 21, 2026 08:07
8707870 to
82b2c35
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
rsyncand running them from a temporary location (including the cloud VM workflow).