Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gradle/libs.versions.toml
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
[versions]
assertj = "3.27.7"
buf = "1.70.0"
cel = "0.13.0"
cel = "0.13.1"
error-prone = "2.49.0"
junit = "5.14.4"
maven-publish = "0.36.0"
Expand Down
5 changes: 2 additions & 3 deletions src/main/java/build/buf/protovalidate/AnyEvaluator.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,7 +19,6 @@
import build.buf.validate.FieldPath;
import build.buf.validate.FieldRules;
import com.google.protobuf.Descriptors;
import com.google.protobuf.Message;
import java.util.ArrayList;
import java.util.Collections;
import java.util.HashSet;
Expand DownExpand Up@@ -78,12 +77,12 @@ final class AnyEvaluator implements Evaluator {
@Override
public List<RuleViolation.Builder> evaluate(Value val, boolean failFast)
throws ExecutionException {
Message anyValue = val.messageValue();
MessageReflector anyValue = val.messageValue();
if (anyValue == null) {
return RuleViolation.NO_VIOLATIONS;
}
List<RuleViolation.Builder> violationList = new ArrayList<>();
String typeURL = (String) anyValue.getField(typeURLDescriptor);
String typeURL = anyValue.getField(typeURLDescriptor).jvmValue(String.class);
if (!in.isEmpty() && !in.contains(typeURL)) {
RuleViolation.Builder violation =
RuleViolation.newBuilder()
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/build/buf/protovalidate/CelPrograms.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,7 +45,7 @@ public boolean tautology() {
@Override
public List<RuleViolation.Builder> evaluate(Value val, boolean failFast)
throws ExecutionException {
CelVariableResolver bindings = Variable.newThisVariable(val.value(Object.class));
CelVariableResolver bindings = Variable.newThisVariable(val.celValue());
List<RuleViolation.Builder> violations = new ArrayList<>();
for (CompiledProgram program : programs) {
RuleViolation.Builder violation = program.eval(val, bindings);
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/build/buf/protovalidate/EnumEvaluator.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -77,7 +77,7 @@ public boolean tautology() {
@Override
public List<RuleViolation.Builder> evaluate(Value val, boolean failFast)
throws ExecutionException {
Object enumValue = val.value(Object.class);
Long enumValue = val.jvmValue(Long.class);
if (enumValue == null) {
return RuleViolation.NO_VIOLATIONS;
}
Expand Down
15 changes: 8 additions & 7 deletions src/main/java/build/buf/protovalidate/FieldEvaluator.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,7 +19,6 @@
import build.buf.validate.FieldRules;
import build.buf.validate.Ignore;
import com.google.protobuf.Descriptors.FieldDescriptor;
import com.google.protobuf.Message;
import java.util.Collections;
import java.util.List;

Expand DownExpand Up@@ -95,7 +94,7 @@ public List<RuleViolation.Builder> evaluate(Value val, boolean failFast)
if (this.shouldIgnoreAlways()) {
return RuleViolation.NO_VIOLATIONS;
}
Message message = val.messageValue();
MessageReflector message = val.messageValue();
if (message == null) {
return RuleViolation.NO_VIOLATIONS;
}
Expand All@@ -113,17 +112,19 @@ public List<RuleViolation.Builder> evaluate(Value val, boolean failFast)
if (this.shouldIgnoreEmpty() && !hasField) {
return RuleViolation.NO_VIOLATIONS;
}
return valueEvaluator.evaluate(
new ObjectValue(descriptor, message.getField(descriptor)), failFast);
return valueEvaluator.evaluate(message.getField(descriptor), failFast);
}

/**
* Returns whether the given field is set on the message. Handles repeated and map fields, which
* are not supported by {@link Message#hasField}.
* require inspecting the list/map contents rather than a presence bit.
*/
static boolean isFieldSet(Message message, FieldDescriptor field) {
static boolean isFieldSet(MessageReflector message, FieldDescriptor field) {
if (field.isRepeated()) {
return message.getRepeatedFieldCount(field) != 0;
if (field.isMapField()) {
return !message.getField(field).mapValue().isEmpty();
}
return !message.getField(field).repeatedValue().isEmpty();
}
return message.hasField(field);
}
Expand Down
11 changes: 8 additions & 3 deletions src/main/java/build/buf/protovalidate/ListElementValue.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,15 +45,20 @@ final class ListElementValue implements Value {
}

@Override
public @Nullable Message messageValue() {
public @Nullable MessageReflector messageValue() {
if (fieldDescriptor.getJavaType() == Descriptors.FieldDescriptor.JavaType.MESSAGE) {
return (Message) value;
return new ProtobufMessageReflector((Message) value);
}
return null;
}

@Override
public <T> T value(Class<T> clazz) {
public Object celValue() {
return ProtoAdapter.scalarToCel(fieldDescriptor.getType(), value);
}

@Override
public <T> T jvmValue(Class<T> clazz) {
Descriptors.FieldDescriptor.Type type = fieldDescriptor.getType();
if (type == Descriptors.FieldDescriptor.Type.MESSAGE) {
return clazz.cast(value);
Expand Down
8 changes: 4 additions & 4 deletions src/main/java/build/buf/protovalidate/MapEvaluator.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -155,19 +155,19 @@ private List<RuleViolation.Builder> evalPairs(Value key, Value value, boolean fa
case TYPE_SINT64:
case TYPE_SFIXED32:
case TYPE_SFIXED64:
fieldPathElementBuilder.setIntKey(key.value(Number.class).longValue());
fieldPathElementBuilder.setIntKey(key.jvmValue(Number.class).longValue());
break;
case TYPE_UINT32:
case TYPE_UINT64:
case TYPE_FIXED32:
case TYPE_FIXED64:
fieldPathElementBuilder.setUintKey(key.value(Number.class).longValue());
fieldPathElementBuilder.setUintKey(key.jvmValue(Number.class).longValue());
break;
case TYPE_BOOL:
fieldPathElementBuilder.setBoolKey(key.value(Boolean.class));
fieldPathElementBuilder.setBoolKey(key.jvmValue(Boolean.class));
break;
case TYPE_STRING:
fieldPathElementBuilder.setStringKey(key.value(String.class));
fieldPathElementBuilder.setStringKey(key.jvmValue(String.class));
break;
default:
throw new ExecutionException("Unexpected map key type");
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,7 +45,7 @@ public boolean tautology() {
@Override
public List<RuleViolation.Builder> evaluate(Value val, boolean failFast)
throws ExecutionException {
Message msg = val.messageValue();
MessageReflector msg = val.messageValue();
if (msg == null) {
return RuleViolation.NO_VIOLATIONS;
}
Expand Down
59 changes: 59 additions & 0 deletions src/main/java/build/buf/protovalidate/MessageReflector.java
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,59 @@
// Copyright 2023-2026 Buf Technologies, Inc.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

package build.buf.protovalidate;

import com.google.protobuf.Descriptors.Descriptor;
import com.google.protobuf.Descriptors.FieldDescriptor;

/**
* {@link MessageReflector} is a wrapper around a protobuf message that provides reflective access
* to the underlying message.
*
* <p>{@link MessageReflector} is a runtime-independent interface. Any protobuf runtime that
* implements this interface can wrap its messages so that protovalidate-java can validate them.
*/
public interface MessageReflector {
/**
* The {@link Descriptor} of the wrapped message's type.
*
* @return The descriptor.
*/
Descriptor getDescriptorForType();

/**
* Whether the wrapped message has the field described by the provided field descriptor.
*
* @param field The field descriptor to check for.
* @return Whether the field is present.
*/
boolean hasField(FieldDescriptor field);

/**
* Get the value described by the provided field descriptor.
*
* @param field The field descriptor for which to retrieve a value.
* @return The value corresponding to the field descriptor.
*/
Value getField(FieldDescriptor field);

/**
* Returns the representation of this message to hand to CEL for {@code this}-variable rule
* evaluation. Implementations return whichever form CEL can navigate for their runtime, such as
* a {@link com.google.protobuf.Message} or a {@code dev.cel.common.values.CelValue}.
*
* @return The CEL-navigable representation of this message.
*/
Object celValue();
}
66 changes: 66 additions & 0 deletions src/main/java/build/buf/protovalidate/MessageReflectorValue.java
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,66 @@
// Copyright 2023-2026 Buf Technologies, Inc.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

package build.buf.protovalidate;

import com.google.protobuf.Descriptors;
import java.util.Collections;
import java.util.List;
import java.util.Map;
import org.jspecify.annotations.Nullable;

/** Top-level {@link Value} backed by a user-supplied {@link MessageReflector}. */
final class MessageReflectorValue implements Value {

private final MessageReflector reflector;

MessageReflectorValue(MessageReflector reflector) {
this.reflector = reflector;
}

@Override
public Descriptors.@Nullable FieldDescriptor fieldDescriptor() {
return null;
}

@Override
public MessageReflector messageValue() {
return reflector;
}

@Override
public Object rawValue() {
return reflector;
}

@Override
public Object celValue() {
return reflector.celValue();
}

@Override
public <T> T jvmValue(Class<T> clazz) {
throw new UnsupportedOperationException();
}

@Override
public List<Value> repeatedValue() {
return Collections.emptyList();
}

@Override
public Map<Value, Value> mapValue() {
return Collections.emptyMap();
}
}
18 changes: 11 additions & 7 deletions src/main/java/build/buf/protovalidate/MessageValue.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -24,16 +24,15 @@
/** The {@link Value} type that contains a {@link com.google.protobuf.Message}. */
final class MessageValue implements Value {

/** Object type since the object type is inferred from the field descriptor. */
private final Object value;
private final ProtobufMessageReflector value;

/**
* Constructs a {@link MessageValue} with the provided message value.
*
* @param value The message value.
*/
MessageValue(Message value) {
this.value = value;
this.value = new ProtobufMessageReflector(value);
}

@Override
Expand All@@ -42,13 +41,18 @@ final class MessageValue implements Value {
}

@Override
public Message messageValue() {
return (Message) value;
public MessageReflector messageValue() {
return value;
}

@Override
public Object celValue() {
return value.getMessage();
}
Comment thread
andrewparmet marked this conversation as resolved.

@Override
public <T> T value(Class<T> clazz) {
return clazz.cast(value);
public <T> T jvmValue(Class<T> clazz) {
throw new UnsupportedOperationException();
}

@Override
Expand Down
14 changes: 11 additions & 3 deletions src/main/java/build/buf/protovalidate/ObjectValue.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -53,15 +53,23 @@ public Descriptors.FieldDescriptor fieldDescriptor() {

@Nullable
@Override
public Message messageValue() {
public MessageReflector messageValue() {
if (fieldDescriptor.getJavaType() == Descriptors.FieldDescriptor.JavaType.MESSAGE) {
return (Message) value;
return new ProtobufMessageReflector((Message) value);
}
return null;
}

@Override
public <T> T value(Class<T> clazz) {
public Object celValue() {
return ProtoAdapter.toCel(fieldDescriptor, value);
}

@Override
public <T> T jvmValue(Class<T> clazz) {
if (value instanceof Descriptors.EnumValueDescriptor) {
return clazz.cast((long) ((Descriptors.EnumValueDescriptor) value).getNumber());
}
return clazz.cast(ProtoAdapter.toCel(fieldDescriptor, value));
}

Expand Down
9 changes: 6 additions & 3 deletions src/main/java/build/buf/protovalidate/OneofEvaluator.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,7 +17,6 @@
import build.buf.protovalidate.exceptions.ExecutionException;
import build.buf.validate.FieldPathElement;
import com.google.protobuf.Descriptors.OneofDescriptor;
import com.google.protobuf.Message;
import java.util.Collections;
import java.util.List;

Expand DownExpand Up@@ -48,8 +47,12 @@ public boolean tautology() {
@Override
public List<RuleViolation.Builder> evaluate(Value val, boolean failFast)
throws ExecutionException {
Message message = val.messageValue();
if (message == null || !required || (message.getOneofFieldDescriptor(descriptor) != null)) {
MessageReflector message = val.messageValue();
if (message == null) {
return RuleViolation.NO_VIOLATIONS;
}
boolean hasField = descriptor.getFields().stream().anyMatch(message::hasField);
if (!required || hasField) {
return RuleViolation.NO_VIOLATIONS;
}
return Collections.singletonList(
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gradle/libs.versions.toml
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
[versions]
assertj = "3.27.7"
buf = "1.70.0"
cel = "0.13.0"
cel = "0.13.1"
error-prone = "2.49.0"
junit = "5.14.4"
maven-publish = "0.36.0"
Expand Down
5 changes: 2 additions & 3 deletions src/main/java/build/buf/protovalidate/AnyEvaluator.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,7 +19,6 @@
import build.buf.validate.FieldPath;
import build.buf.validate.FieldRules;
import com.google.protobuf.Descriptors;
import com.google.protobuf.Message;
import java.util.ArrayList;
import java.util.Collections;
import java.util.HashSet;
Expand DownExpand Up@@ -78,12 +77,12 @@ final class AnyEvaluator implements Evaluator {
@Override
public List<RuleViolation.Builder> evaluate(Value val, boolean failFast)
throws ExecutionException {
Message anyValue = val.messageValue();
MessageReflector anyValue = val.messageValue();
if (anyValue == null) {
return RuleViolation.NO_VIOLATIONS;
}
List<RuleViolation.Builder> violationList = new ArrayList<>();
String typeURL = (String) anyValue.getField(typeURLDescriptor);
String typeURL = anyValue.getField(typeURLDescriptor).jvmValue(String.class);
if (!in.isEmpty() && !in.contains(typeURL)) {
RuleViolation.Builder violation =
RuleViolation.newBuilder()
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/build/buf/protovalidate/CelPrograms.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,7 +45,7 @@ public boolean tautology() {
@Override
public List<RuleViolation.Builder> evaluate(Value val, boolean failFast)
throws ExecutionException {
CelVariableResolver bindings = Variable.newThisVariable(val.value(Object.class));
CelVariableResolver bindings = Variable.newThisVariable(val.celValue());
List<RuleViolation.Builder> violations = new ArrayList<>();
for (CompiledProgram program : programs) {
RuleViolation.Builder violation = program.eval(val, bindings);
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/build/buf/protovalidate/EnumEvaluator.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -77,7 +77,7 @@ public boolean tautology() {
@Override
public List<RuleViolation.Builder> evaluate(Value val, boolean failFast)
throws ExecutionException {
Object enumValue = val.value(Object.class);
Long enumValue = val.jvmValue(Long.class);
if (enumValue == null) {
return RuleViolation.NO_VIOLATIONS;
}
Expand Down
15 changes: 8 additions & 7 deletions src/main/java/build/buf/protovalidate/FieldEvaluator.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,7 +19,6 @@
import build.buf.validate.FieldRules;
import build.buf.validate.Ignore;
import com.google.protobuf.Descriptors.FieldDescriptor;
import com.google.protobuf.Message;
import java.util.Collections;
import java.util.List;

Expand DownExpand Up@@ -95,7 +94,7 @@ public List<RuleViolation.Builder> evaluate(Value val, boolean failFast)
if (this.shouldIgnoreAlways()) {
return RuleViolation.NO_VIOLATIONS;
}
Message message = val.messageValue();
MessageReflector message = val.messageValue();
if (message == null) {
return RuleViolation.NO_VIOLATIONS;
}
Expand All@@ -113,17 +112,19 @@ public List<RuleViolation.Builder> evaluate(Value val, boolean failFast)
if (this.shouldIgnoreEmpty() && !hasField) {
return RuleViolation.NO_VIOLATIONS;
}
return valueEvaluator.evaluate(
new ObjectValue(descriptor, message.getField(descriptor)), failFast);
return valueEvaluator.evaluate(message.getField(descriptor), failFast);
}

/**
* Returns whether the given field is set on the message. Handles repeated and map fields, which
* are not supported by {@link Message#hasField}.
* require inspecting the list/map contents rather than a presence bit.
*/
static boolean isFieldSet(Message message, FieldDescriptor field) {
static boolean isFieldSet(MessageReflector message, FieldDescriptor field) {
if (field.isRepeated()) {
return message.getRepeatedFieldCount(field) != 0;
if (field.isMapField()) {
return !message.getField(field).mapValue().isEmpty();
}
return !message.getField(field).repeatedValue().isEmpty();
}
return message.hasField(field);
}
Expand Down
11 changes: 8 additions & 3 deletions src/main/java/build/buf/protovalidate/ListElementValue.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,15 +45,20 @@ final class ListElementValue implements Value {
}

@Override
public @Nullable Message messageValue() {
public @Nullable MessageReflector messageValue() {
if (fieldDescriptor.getJavaType() == Descriptors.FieldDescriptor.JavaType.MESSAGE) {
return (Message) value;
return new ProtobufMessageReflector((Message) value);
}
return null;
}

@Override
public <T> T value(Class<T> clazz) {
public Object celValue() {
return ProtoAdapter.scalarToCel(fieldDescriptor.getType(), value);
}

@Override
public <T> T jvmValue(Class<T> clazz) {
Descriptors.FieldDescriptor.Type type = fieldDescriptor.getType();
if (type == Descriptors.FieldDescriptor.Type.MESSAGE) {
return clazz.cast(value);
Expand Down
8 changes: 4 additions & 4 deletions src/main/java/build/buf/protovalidate/MapEvaluator.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -155,19 +155,19 @@ private List<RuleViolation.Builder> evalPairs(Value key, Value value, boolean fa
case TYPE_SINT64:
case TYPE_SFIXED32:
case TYPE_SFIXED64:
fieldPathElementBuilder.setIntKey(key.value(Number.class).longValue());
fieldPathElementBuilder.setIntKey(key.jvmValue(Number.class).longValue());
break;
case TYPE_UINT32:
case TYPE_UINT64:
case TYPE_FIXED32:
case TYPE_FIXED64:
fieldPathElementBuilder.setUintKey(key.value(Number.class).longValue());
fieldPathElementBuilder.setUintKey(key.jvmValue(Number.class).longValue());
break;
case TYPE_BOOL:
fieldPathElementBuilder.setBoolKey(key.value(Boolean.class));
fieldPathElementBuilder.setBoolKey(key.jvmValue(Boolean.class));
break;
case TYPE_STRING:
fieldPathElementBuilder.setStringKey(key.value(String.class));
fieldPathElementBuilder.setStringKey(key.jvmValue(String.class));
break;
default:
throw new ExecutionException("Unexpected map key type");
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,7 +45,7 @@ public boolean tautology() {
@Override
public List<RuleViolation.Builder> evaluate(Value val, boolean failFast)
throws ExecutionException {
Message msg = val.messageValue();
MessageReflector msg = val.messageValue();
if (msg == null) {
return RuleViolation.NO_VIOLATIONS;
}
Expand Down
59 changes: 59 additions & 0 deletions src/main/java/build/buf/protovalidate/MessageReflector.java
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,59 @@
// Copyright 2023-2026 Buf Technologies, Inc.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

package build.buf.protovalidate;

import com.google.protobuf.Descriptors.Descriptor;
import com.google.protobuf.Descriptors.FieldDescriptor;

/**
* {@link MessageReflector} is a wrapper around a protobuf message that provides reflective access
* to the underlying message.
*
* <p>{@link MessageReflector} is a runtime-independent interface. Any protobuf runtime that
* implements this interface can wrap its messages so that protovalidate-java can validate them.
*/
public interface MessageReflector {
/**
* The {@link Descriptor} of the wrapped message's type.
*
* @return The descriptor.
*/
Descriptor getDescriptorForType();

/**
* Whether the wrapped message has the field described by the provided field descriptor.
*
* @param field The field descriptor to check for.
* @return Whether the field is present.
*/
boolean hasField(FieldDescriptor field);

/**
* Get the value described by the provided field descriptor.
*
* @param field The field descriptor for which to retrieve a value.
* @return The value corresponding to the field descriptor.
*/
Value getField(FieldDescriptor field);

/**
* Returns the representation of this message to hand to CEL for {@code this}-variable rule
* evaluation. Implementations return whichever form CEL can navigate for their runtime, such as
* a {@link com.google.protobuf.Message} or a {@code dev.cel.common.values.CelValue}.
*
* @return The CEL-navigable representation of this message.
*/
Object celValue();
}
66 changes: 66 additions & 0 deletions src/main/java/build/buf/protovalidate/MessageReflectorValue.java
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,66 @@
// Copyright 2023-2026 Buf Technologies, Inc.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

package build.buf.protovalidate;

import com.google.protobuf.Descriptors;
import java.util.Collections;
import java.util.List;
import java.util.Map;
import org.jspecify.annotations.Nullable;

/** Top-level {@link Value} backed by a user-supplied {@link MessageReflector}. */
final class MessageReflectorValue implements Value {

private final MessageReflector reflector;

MessageReflectorValue(MessageReflector reflector) {
this.reflector = reflector;
}

@Override
public Descriptors.@Nullable FieldDescriptor fieldDescriptor() {
return null;
}

@Override
public MessageReflector messageValue() {
return reflector;
}

@Override
public Object rawValue() {
return reflector;
}

@Override
public Object celValue() {
return reflector.celValue();
}

@Override
public <T> T jvmValue(Class<T> clazz) {
throw new UnsupportedOperationException();
}

@Override
public List<Value> repeatedValue() {
return Collections.emptyList();
}

@Override
public Map<Value, Value> mapValue() {
return Collections.emptyMap();
}
}
18 changes: 11 additions & 7 deletions src/main/java/build/buf/protovalidate/MessageValue.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -24,16 +24,15 @@
/** The {@link Value} type that contains a {@link com.google.protobuf.Message}. */
final class MessageValue implements Value {

/** Object type since the object type is inferred from the field descriptor. */
private final Object value;
private final ProtobufMessageReflector value;

/**
* Constructs a {@link MessageValue} with the provided message value.
*
* @param value The message value.
*/
MessageValue(Message value) {
this.value = value;
this.value = new ProtobufMessageReflector(value);
}

@Override
Expand All@@ -42,13 +41,18 @@ final class MessageValue implements Value {
}

@Override
public Message messageValue() {
return (Message) value;
public MessageReflector messageValue() {
return value;
}

@Override
public Object celValue() {
return value.getMessage();
}
Comment thread
andrewparmet marked this conversation as resolved.

@Override
public <T> T value(Class<T> clazz) {
return clazz.cast(value);
public <T> T jvmValue(Class<T> clazz) {
throw new UnsupportedOperationException();
}

@Override
Expand Down
14 changes: 11 additions & 3 deletions src/main/java/build/buf/protovalidate/ObjectValue.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -53,15 +53,23 @@ public Descriptors.FieldDescriptor fieldDescriptor() {

@Nullable
@Override
public Message messageValue() {
public MessageReflector messageValue() {
if (fieldDescriptor.getJavaType() == Descriptors.FieldDescriptor.JavaType.MESSAGE) {
return (Message) value;
return new ProtobufMessageReflector((Message) value);
}
return null;
}

@Override
public <T> T value(Class<T> clazz) {
public Object celValue() {
return ProtoAdapter.toCel(fieldDescriptor, value);
}

@Override
public <T> T jvmValue(Class<T> clazz) {
if (value instanceof Descriptors.EnumValueDescriptor) {
return clazz.cast((long) ((Descriptors.EnumValueDescriptor) value).getNumber());
}
return clazz.cast(ProtoAdapter.toCel(fieldDescriptor, value));
}

Expand Down
9 changes: 6 additions & 3 deletions src/main/java/build/buf/protovalidate/OneofEvaluator.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,7 +17,6 @@
import build.buf.protovalidate.exceptions.ExecutionException;
import build.buf.validate.FieldPathElement;
import com.google.protobuf.Descriptors.OneofDescriptor;
import com.google.protobuf.Message;
import java.util.Collections;
import java.util.List;

Expand DownExpand Up@@ -48,8 +47,12 @@ public boolean tautology() {
@Override
public List<RuleViolation.Builder> evaluate(Value val, boolean failFast)
throws ExecutionException {
Message message = val.messageValue();
if (message == null || !required || (message.getOneofFieldDescriptor(descriptor) != null)) {
MessageReflector message = val.messageValue();
if (message == null) {
return RuleViolation.NO_VIOLATIONS;
}
boolean hasField = descriptor.getFields().stream().anyMatch(message::hasField);
if (!required || hasField) {
return RuleViolation.NO_VIOLATIONS;
}
return Collections.singletonList(
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gradle/libs.versions.toml
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
[versions]
assertj = "3.27.7"
buf = "1.70.0"
cel = "0.13.0"
cel = "0.13.1"
error-prone = "2.49.0"
junit = "5.14.4"
maven-publish = "0.36.0"
Expand Down
5 changes: 2 additions & 3 deletions src/main/java/build/buf/protovalidate/AnyEvaluator.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,7 +19,6 @@
import build.buf.validate.FieldPath;
import build.buf.validate.FieldRules;
import com.google.protobuf.Descriptors;
import com.google.protobuf.Message;
import java.util.ArrayList;
import java.util.Collections;
import java.util.HashSet;
Expand DownExpand Up@@ -78,12 +77,12 @@ final class AnyEvaluator implements Evaluator {
@Override
public List<RuleViolation.Builder> evaluate(Value val, boolean failFast)
throws ExecutionException {
Message anyValue = val.messageValue();
MessageReflector anyValue = val.messageValue();
if (anyValue == null) {
return RuleViolation.NO_VIOLATIONS;
}
List<RuleViolation.Builder> violationList = new ArrayList<>();
String typeURL = (String) anyValue.getField(typeURLDescriptor);
String typeURL = anyValue.getField(typeURLDescriptor).jvmValue(String.class);
if (!in.isEmpty() && !in.contains(typeURL)) {
RuleViolation.Builder violation =
RuleViolation.newBuilder()
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/build/buf/protovalidate/CelPrograms.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,7 +45,7 @@ public boolean tautology() {
@Override
public List<RuleViolation.Builder> evaluate(Value val, boolean failFast)
throws ExecutionException {
CelVariableResolver bindings = Variable.newThisVariable(val.value(Object.class));
CelVariableResolver bindings = Variable.newThisVariable(val.celValue());
List<RuleViolation.Builder> violations = new ArrayList<>();
for (CompiledProgram program : programs) {
RuleViolation.Builder violation = program.eval(val, bindings);
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/build/buf/protovalidate/EnumEvaluator.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -77,7 +77,7 @@ public boolean tautology() {
@Override
public List<RuleViolation.Builder> evaluate(Value val, boolean failFast)
throws ExecutionException {
Object enumValue = val.value(Object.class);
Long enumValue = val.jvmValue(Long.class);
if (enumValue == null) {
return RuleViolation.NO_VIOLATIONS;
}
Expand Down
15 changes: 8 additions & 7 deletions src/main/java/build/buf/protovalidate/FieldEvaluator.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,7 +19,6 @@
import build.buf.validate.FieldRules;
import build.buf.validate.Ignore;
import com.google.protobuf.Descriptors.FieldDescriptor;
import com.google.protobuf.Message;
import java.util.Collections;
import java.util.List;

Expand DownExpand Up@@ -95,7 +94,7 @@ public List<RuleViolation.Builder> evaluate(Value val, boolean failFast)
if (this.shouldIgnoreAlways()) {
return RuleViolation.NO_VIOLATIONS;
}
Message message = val.messageValue();
MessageReflector message = val.messageValue();
if (message == null) {
return RuleViolation.NO_VIOLATIONS;
}
Expand All@@ -113,17 +112,19 @@ public List<RuleViolation.Builder> evaluate(Value val, boolean failFast)
if (this.shouldIgnoreEmpty() && !hasField) {
return RuleViolation.NO_VIOLATIONS;
}
return valueEvaluator.evaluate(
new ObjectValue(descriptor, message.getField(descriptor)), failFast);
return valueEvaluator.evaluate(message.getField(descriptor), failFast);
}

/**
* Returns whether the given field is set on the message. Handles repeated and map fields, which
* are not supported by {@link Message#hasField}.
* require inspecting the list/map contents rather than a presence bit.
*/
static boolean isFieldSet(Message message, FieldDescriptor field) {
static boolean isFieldSet(MessageReflector message, FieldDescriptor field) {
if (field.isRepeated()) {
return message.getRepeatedFieldCount(field) != 0;
if (field.isMapField()) {
return !message.getField(field).mapValue().isEmpty();
}
return !message.getField(field).repeatedValue().isEmpty();
}
return message.hasField(field);
}
Expand Down
11 changes: 8 additions & 3 deletions src/main/java/build/buf/protovalidate/ListElementValue.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,15 +45,20 @@ final class ListElementValue implements Value {
}

@Override
public @Nullable Message messageValue() {
public @Nullable MessageReflector messageValue() {
if (fieldDescriptor.getJavaType() == Descriptors.FieldDescriptor.JavaType.MESSAGE) {
return (Message) value;
return new ProtobufMessageReflector((Message) value);
}
return null;
}

@Override
public <T> T value(Class<T> clazz) {
public Object celValue() {
return ProtoAdapter.scalarToCel(fieldDescriptor.getType(), value);
}

@Override
public <T> T jvmValue(Class<T> clazz) {
Descriptors.FieldDescriptor.Type type = fieldDescriptor.getType();
if (type == Descriptors.FieldDescriptor.Type.MESSAGE) {
return clazz.cast(value);
Expand Down
8 changes: 4 additions & 4 deletions src/main/java/build/buf/protovalidate/MapEvaluator.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -155,19 +155,19 @@ private List<RuleViolation.Builder> evalPairs(Value key, Value value, boolean fa
case TYPE_SINT64:
case TYPE_SFIXED32:
case TYPE_SFIXED64:
fieldPathElementBuilder.setIntKey(key.value(Number.class).longValue());
fieldPathElementBuilder.setIntKey(key.jvmValue(Number.class).longValue());
break;
case TYPE_UINT32:
case TYPE_UINT64:
case TYPE_FIXED32:
case TYPE_FIXED64:
fieldPathElementBuilder.setUintKey(key.value(Number.class).longValue());
fieldPathElementBuilder.setUintKey(key.jvmValue(Number.class).longValue());
break;
case TYPE_BOOL:
fieldPathElementBuilder.setBoolKey(key.value(Boolean.class));
fieldPathElementBuilder.setBoolKey(key.jvmValue(Boolean.class));
break;
case TYPE_STRING:
fieldPathElementBuilder.setStringKey(key.value(String.class));
fieldPathElementBuilder.setStringKey(key.jvmValue(String.class));
break;
default:
throw new ExecutionException("Unexpected map key type");
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,7 +45,7 @@ public boolean tautology() {
@Override
public List<RuleViolation.Builder> evaluate(Value val, boolean failFast)
throws ExecutionException {
Message msg = val.messageValue();
MessageReflector msg = val.messageValue();
if (msg == null) {
return RuleViolation.NO_VIOLATIONS;
}
Expand Down
59 changes: 59 additions & 0 deletions src/main/java/build/buf/protovalidate/MessageReflector.java
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,59 @@
// Copyright 2023-2026 Buf Technologies, Inc.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

package build.buf.protovalidate;

import com.google.protobuf.Descriptors.Descriptor;
import com.google.protobuf.Descriptors.FieldDescriptor;

/**
* {@link MessageReflector} is a wrapper around a protobuf message that provides reflective access
* to the underlying message.
*
* <p>{@link MessageReflector} is a runtime-independent interface. Any protobuf runtime that
* implements this interface can wrap its messages so that protovalidate-java can validate them.
*/
public interface MessageReflector {
/**
* The {@link Descriptor} of the wrapped message's type.
*
* @return The descriptor.
*/
Descriptor getDescriptorForType();

/**
* Whether the wrapped message has the field described by the provided field descriptor.
*
* @param field The field descriptor to check for.
* @return Whether the field is present.
*/
boolean hasField(FieldDescriptor field);

/**
* Get the value described by the provided field descriptor.
*
* @param field The field descriptor for which to retrieve a value.
* @return The value corresponding to the field descriptor.
*/
Value getField(FieldDescriptor field);

/**
* Returns the representation of this message to hand to CEL for {@code this}-variable rule
* evaluation. Implementations return whichever form CEL can navigate for their runtime, such as
* a {@link com.google.protobuf.Message} or a {@code dev.cel.common.values.CelValue}.
*
* @return The CEL-navigable representation of this message.
*/
Object celValue();
}
66 changes: 66 additions & 0 deletions src/main/java/build/buf/protovalidate/MessageReflectorValue.java
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,66 @@
// Copyright 2023-2026 Buf Technologies, Inc.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

package build.buf.protovalidate;

import com.google.protobuf.Descriptors;
import java.util.Collections;
import java.util.List;
import java.util.Map;
import org.jspecify.annotations.Nullable;

/** Top-level {@link Value} backed by a user-supplied {@link MessageReflector}. */
final class MessageReflectorValue implements Value {

private final MessageReflector reflector;

MessageReflectorValue(MessageReflector reflector) {
this.reflector = reflector;
}

@Override
public Descriptors.@Nullable FieldDescriptor fieldDescriptor() {
return null;
}

@Override
public MessageReflector messageValue() {
return reflector;
}

@Override
public Object rawValue() {
return reflector;
}

@Override
public Object celValue() {
return reflector.celValue();
}

@Override
public <T> T jvmValue(Class<T> clazz) {
throw new UnsupportedOperationException();
}

@Override
public List<Value> repeatedValue() {
return Collections.emptyList();
}

@Override
public Map<Value, Value> mapValue() {
return Collections.emptyMap();
}
}
18 changes: 11 additions & 7 deletions src/main/java/build/buf/protovalidate/MessageValue.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -24,16 +24,15 @@
/** The {@link Value} type that contains a {@link com.google.protobuf.Message}. */
final class MessageValue implements Value {

/** Object type since the object type is inferred from the field descriptor. */
private final Object value;
private final ProtobufMessageReflector value;

/**
* Constructs a {@link MessageValue} with the provided message value.
*
* @param value The message value.
*/
MessageValue(Message value) {
this.value = value;
this.value = new ProtobufMessageReflector(value);
}

@Override
Expand All@@ -42,13 +41,18 @@ final class MessageValue implements Value {
}

@Override
public Message messageValue() {
return (Message) value;
public MessageReflector messageValue() {
return value;
}

@Override
public Object celValue() {
return value.getMessage();
}
Comment thread
andrewparmet marked this conversation as resolved.

@Override
public <T> T value(Class<T> clazz) {
return clazz.cast(value);
public <T> T jvmValue(Class<T> clazz) {
throw new UnsupportedOperationException();
}

@Override
Expand Down
14 changes: 11 additions & 3 deletions src/main/java/build/buf/protovalidate/ObjectValue.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -53,15 +53,23 @@ public Descriptors.FieldDescriptor fieldDescriptor() {

@Nullable
@Override
public Message messageValue() {
public MessageReflector messageValue() {
if (fieldDescriptor.getJavaType() == Descriptors.FieldDescriptor.JavaType.MESSAGE) {
return (Message) value;
return new ProtobufMessageReflector((Message) value);
}
return null;
}

@Override
public <T> T value(Class<T> clazz) {
public Object celValue() {
return ProtoAdapter.toCel(fieldDescriptor, value);
}

@Override
public <T> T jvmValue(Class<T> clazz) {
if (value instanceof Descriptors.EnumValueDescriptor) {
return clazz.cast((long) ((Descriptors.EnumValueDescriptor) value).getNumber());
}
return clazz.cast(ProtoAdapter.toCel(fieldDescriptor, value));
}

Expand Down
9 changes: 6 additions & 3 deletions src/main/java/build/buf/protovalidate/OneofEvaluator.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,7 +17,6 @@
import build.buf.protovalidate.exceptions.ExecutionException;
import build.buf.validate.FieldPathElement;
import com.google.protobuf.Descriptors.OneofDescriptor;
import com.google.protobuf.Message;
import java.util.Collections;
import java.util.List;

Expand DownExpand Up@@ -48,8 +47,12 @@ public boolean tautology() {
@Override
public List<RuleViolation.Builder> evaluate(Value val, boolean failFast)
throws ExecutionException {
Message message = val.messageValue();
if (message == null || !required || (message.getOneofFieldDescriptor(descriptor) != null)) {
MessageReflector message = val.messageValue();
if (message == null) {
return RuleViolation.NO_VIOLATIONS;
}
boolean hasField = descriptor.getFields().stream().anyMatch(message::hasField);
if (!required || hasField) {
return RuleViolation.NO_VIOLATIONS;
}
return Collections.singletonList(
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gradle/libs.versions.toml
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
[versions]
assertj = "3.27.7"
buf = "1.70.0"
cel = "0.13.0"
cel = "0.13.1"
error-prone = "2.49.0"
junit = "5.14.4"
maven-publish = "0.36.0"
Expand Down
5 changes: 2 additions & 3 deletions src/main/java/build/buf/protovalidate/AnyEvaluator.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,7 +19,6 @@
import build.buf.validate.FieldPath;
import build.buf.validate.FieldRules;
import com.google.protobuf.Descriptors;
import com.google.protobuf.Message;
import java.util.ArrayList;
import java.util.Collections;
import java.util.HashSet;
Expand DownExpand Up@@ -78,12 +77,12 @@ final class AnyEvaluator implements Evaluator {
@Override
public List<RuleViolation.Builder> evaluate(Value val, boolean failFast)
throws ExecutionException {
Message anyValue = val.messageValue();
MessageReflector anyValue = val.messageValue();
if (anyValue == null) {
return RuleViolation.NO_VIOLATIONS;
}
List<RuleViolation.Builder> violationList = new ArrayList<>();
String typeURL = (String) anyValue.getField(typeURLDescriptor);
String typeURL = anyValue.getField(typeURLDescriptor).jvmValue(String.class);
if (!in.isEmpty() && !in.contains(typeURL)) {
RuleViolation.Builder violation =
RuleViolation.newBuilder()
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/build/buf/protovalidate/CelPrograms.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,7 +45,7 @@ public boolean tautology() {
@Override
public List<RuleViolation.Builder> evaluate(Value val, boolean failFast)
throws ExecutionException {
CelVariableResolver bindings = Variable.newThisVariable(val.value(Object.class));
CelVariableResolver bindings = Variable.newThisVariable(val.celValue());
List<RuleViolation.Builder> violations = new ArrayList<>();
for (CompiledProgram program : programs) {
RuleViolation.Builder violation = program.eval(val, bindings);
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/build/buf/protovalidate/EnumEvaluator.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -77,7 +77,7 @@ public boolean tautology() {
@Override
public List<RuleViolation.Builder> evaluate(Value val, boolean failFast)
throws ExecutionException {
Object enumValue = val.value(Object.class);
Long enumValue = val.jvmValue(Long.class);
if (enumValue == null) {
return RuleViolation.NO_VIOLATIONS;
}
Expand Down
15 changes: 8 additions & 7 deletions src/main/java/build/buf/protovalidate/FieldEvaluator.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,7 +19,6 @@
import build.buf.validate.FieldRules;
import build.buf.validate.Ignore;
import com.google.protobuf.Descriptors.FieldDescriptor;
import com.google.protobuf.Message;
import java.util.Collections;
import java.util.List;

Expand DownExpand Up@@ -95,7 +94,7 @@ public List<RuleViolation.Builder> evaluate(Value val, boolean failFast)
if (this.shouldIgnoreAlways()) {
return RuleViolation.NO_VIOLATIONS;
}
Message message = val.messageValue();
MessageReflector message = val.messageValue();
if (message == null) {
return RuleViolation.NO_VIOLATIONS;
}
Expand All@@ -113,17 +112,19 @@ public List<RuleViolation.Builder> evaluate(Value val, boolean failFast)
if (this.shouldIgnoreEmpty() && !hasField) {
return RuleViolation.NO_VIOLATIONS;
}
return valueEvaluator.evaluate(
new ObjectValue(descriptor, message.getField(descriptor)), failFast);
return valueEvaluator.evaluate(message.getField(descriptor), failFast);
}

/**
* Returns whether the given field is set on the message. Handles repeated and map fields, which
* are not supported by {@link Message#hasField}.
* require inspecting the list/map contents rather than a presence bit.
*/
static boolean isFieldSet(Message message, FieldDescriptor field) {
static boolean isFieldSet(MessageReflector message, FieldDescriptor field) {
if (field.isRepeated()) {
return message.getRepeatedFieldCount(field) != 0;
if (field.isMapField()) {
return !message.getField(field).mapValue().isEmpty();
}
return !message.getField(field).repeatedValue().isEmpty();
}
return message.hasField(field);
}
Expand Down
11 changes: 8 additions & 3 deletions src/main/java/build/buf/protovalidate/ListElementValue.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,15 +45,20 @@ final class ListElementValue implements Value {
}

@Override
public @Nullable Message messageValue() {
public @Nullable MessageReflector messageValue() {
if (fieldDescriptor.getJavaType() == Descriptors.FieldDescriptor.JavaType.MESSAGE) {
return (Message) value;
return new ProtobufMessageReflector((Message) value);
}
return null;
}

@Override
public <T> T value(Class<T> clazz) {
public Object celValue() {
return ProtoAdapter.scalarToCel(fieldDescriptor.getType(), value);
}

@Override
public <T> T jvmValue(Class<T> clazz) {
Descriptors.FieldDescriptor.Type type = fieldDescriptor.getType();
if (type == Descriptors.FieldDescriptor.Type.MESSAGE) {
return clazz.cast(value);
Expand Down
8 changes: 4 additions & 4 deletions src/main/java/build/buf/protovalidate/MapEvaluator.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -155,19 +155,19 @@ private List<RuleViolation.Builder> evalPairs(Value key, Value value, boolean fa
case TYPE_SINT64:
case TYPE_SFIXED32:
case TYPE_SFIXED64:
fieldPathElementBuilder.setIntKey(key.value(Number.class).longValue());
fieldPathElementBuilder.setIntKey(key.jvmValue(Number.class).longValue());
break;
case TYPE_UINT32:
case TYPE_UINT64:
case TYPE_FIXED32:
case TYPE_FIXED64:
fieldPathElementBuilder.setUintKey(key.value(Number.class).longValue());
fieldPathElementBuilder.setUintKey(key.jvmValue(Number.class).longValue());
break;
case TYPE_BOOL:
fieldPathElementBuilder.setBoolKey(key.value(Boolean.class));
fieldPathElementBuilder.setBoolKey(key.jvmValue(Boolean.class));
break;
case TYPE_STRING:
fieldPathElementBuilder.setStringKey(key.value(String.class));
fieldPathElementBuilder.setStringKey(key.jvmValue(String.class));
break;
default:
throw new ExecutionException("Unexpected map key type");
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,7 +45,7 @@ public boolean tautology() {
@Override
public List<RuleViolation.Builder> evaluate(Value val, boolean failFast)
throws ExecutionException {
Message msg = val.messageValue();
MessageReflector msg = val.messageValue();
if (msg == null) {
return RuleViolation.NO_VIOLATIONS;
}
Expand Down
59 changes: 59 additions & 0 deletions src/main/java/build/buf/protovalidate/MessageReflector.java
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,59 @@
// Copyright 2023-2026 Buf Technologies, Inc.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

package build.buf.protovalidate;

import com.google.protobuf.Descriptors.Descriptor;
import com.google.protobuf.Descriptors.FieldDescriptor;

/**
* {@link MessageReflector} is a wrapper around a protobuf message that provides reflective access
* to the underlying message.
*
* <p>{@link MessageReflector} is a runtime-independent interface. Any protobuf runtime that
* implements this interface can wrap its messages so that protovalidate-java can validate them.
*/
public interface MessageReflector {
/**
* The {@link Descriptor} of the wrapped message's type.
*
* @return The descriptor.
*/
Descriptor getDescriptorForType();

/**
* Whether the wrapped message has the field described by the provided field descriptor.
*
* @param field The field descriptor to check for.
* @return Whether the field is present.
*/
boolean hasField(FieldDescriptor field);

/**
* Get the value described by the provided field descriptor.
*
* @param field The field descriptor for which to retrieve a value.
* @return The value corresponding to the field descriptor.
*/
Value getField(FieldDescriptor field);

/**
* Returns the representation of this message to hand to CEL for {@code this}-variable rule
* evaluation. Implementations return whichever form CEL can navigate for their runtime, such as
* a {@link com.google.protobuf.Message} or a {@code dev.cel.common.values.CelValue}.
*
* @return The CEL-navigable representation of this message.
*/
Object celValue();
}
66 changes: 66 additions & 0 deletions src/main/java/build/buf/protovalidate/MessageReflectorValue.java
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,66 @@
// Copyright 2023-2026 Buf Technologies, Inc.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

package build.buf.protovalidate;

import com.google.protobuf.Descriptors;
import java.util.Collections;
import java.util.List;
import java.util.Map;
import org.jspecify.annotations.Nullable;

/** Top-level {@link Value} backed by a user-supplied {@link MessageReflector}. */
final class MessageReflectorValue implements Value {

private final MessageReflector reflector;

MessageReflectorValue(MessageReflector reflector) {
this.reflector = reflector;
}

@Override
public Descriptors.@Nullable FieldDescriptor fieldDescriptor() {
return null;
}

@Override
public MessageReflector messageValue() {
return reflector;
}

@Override
public Object rawValue() {
return reflector;
}

@Override
public Object celValue() {
return reflector.celValue();
}

@Override
public <T> T jvmValue(Class<T> clazz) {
throw new UnsupportedOperationException();
}

@Override
public List<Value> repeatedValue() {
return Collections.emptyList();
}

@Override
public Map<Value, Value> mapValue() {
return Collections.emptyMap();
}
}
18 changes: 11 additions & 7 deletions src/main/java/build/buf/protovalidate/MessageValue.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -24,16 +24,15 @@
/** The {@link Value} type that contains a {@link com.google.protobuf.Message}. */
final class MessageValue implements Value {

/** Object type since the object type is inferred from the field descriptor. */
private final Object value;
private final ProtobufMessageReflector value;

/**
* Constructs a {@link MessageValue} with the provided message value.
*
* @param value The message value.
*/
MessageValue(Message value) {
this.value = value;
this.value = new ProtobufMessageReflector(value);
}

@Override
Expand All@@ -42,13 +41,18 @@ final class MessageValue implements Value {
}

@Override
public Message messageValue() {
return (Message) value;
public MessageReflector messageValue() {
return value;
}

@Override
public Object celValue() {
return value.getMessage();
}
Comment thread
andrewparmet marked this conversation as resolved.

@Override
public <T> T value(Class<T> clazz) {
return clazz.cast(value);
public <T> T jvmValue(Class<T> clazz) {
throw new UnsupportedOperationException();
}

@Override
Expand Down
14 changes: 11 additions & 3 deletions src/main/java/build/buf/protovalidate/ObjectValue.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -53,15 +53,23 @@ public Descriptors.FieldDescriptor fieldDescriptor() {

@Nullable
@Override
public Message messageValue() {
public MessageReflector messageValue() {
if (fieldDescriptor.getJavaType() == Descriptors.FieldDescriptor.JavaType.MESSAGE) {
return (Message) value;
return new ProtobufMessageReflector((Message) value);
}
return null;
}

@Override
public <T> T value(Class<T> clazz) {
public Object celValue() {
return ProtoAdapter.toCel(fieldDescriptor, value);
}

@Override
public <T> T jvmValue(Class<T> clazz) {
if (value instanceof Descriptors.EnumValueDescriptor) {
return clazz.cast((long) ((Descriptors.EnumValueDescriptor) value).getNumber());
}
return clazz.cast(ProtoAdapter.toCel(fieldDescriptor, value));
}

Expand Down
9 changes: 6 additions & 3 deletions src/main/java/build/buf/protovalidate/OneofEvaluator.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,7 +17,6 @@
import build.buf.protovalidate.exceptions.ExecutionException;
import build.buf.validate.FieldPathElement;
import com.google.protobuf.Descriptors.OneofDescriptor;
import com.google.protobuf.Message;
import java.util.Collections;
import java.util.List;

Expand DownExpand Up@@ -48,8 +47,12 @@ public boolean tautology() {
@Override
public List<RuleViolation.Builder> evaluate(Value val, boolean failFast)
throws ExecutionException {
Message message = val.messageValue();
if (message == null || !required || (message.getOneofFieldDescriptor(descriptor) != null)) {
MessageReflector message = val.messageValue();
if (message == null) {
return RuleViolation.NO_VIOLATIONS;
}
boolean hasField = descriptor.getFields().stream().anyMatch(message::hasField);
if (!required || hasField) {
return RuleViolation.NO_VIOLATIONS;
}
return Collections.singletonList(
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gradle/libs.versions.toml
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
[versions]
assertj = "3.27.7"
buf = "1.70.0"
cel = "0.13.0"
cel = "0.13.1"
error-prone = "2.49.0"
junit = "5.14.4"
maven-publish = "0.36.0"
Expand Down
5 changes: 2 additions & 3 deletions src/main/java/build/buf/protovalidate/AnyEvaluator.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,7 +19,6 @@
import build.buf.validate.FieldPath;
import build.buf.validate.FieldRules;
import com.google.protobuf.Descriptors;
import com.google.protobuf.Message;
import java.util.ArrayList;
import java.util.Collections;
import java.util.HashSet;
Expand DownExpand Up@@ -78,12 +77,12 @@ final class AnyEvaluator implements Evaluator {
@Override
public List<RuleViolation.Builder> evaluate(Value val, boolean failFast)
throws ExecutionException {
Message anyValue = val.messageValue();
MessageReflector anyValue = val.messageValue();
if (anyValue == null) {
return RuleViolation.NO_VIOLATIONS;
}
List<RuleViolation.Builder> violationList = new ArrayList<>();
String typeURL = (String) anyValue.getField(typeURLDescriptor);
String typeURL = anyValue.getField(typeURLDescriptor).jvmValue(String.class);
if (!in.isEmpty() && !in.contains(typeURL)) {
RuleViolation.Builder violation =
RuleViolation.newBuilder()
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/build/buf/protovalidate/CelPrograms.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,7 +45,7 @@ public boolean tautology() {
@Override
public List<RuleViolation.Builder> evaluate(Value val, boolean failFast)
throws ExecutionException {
CelVariableResolver bindings = Variable.newThisVariable(val.value(Object.class));
CelVariableResolver bindings = Variable.newThisVariable(val.celValue());
List<RuleViolation.Builder> violations = new ArrayList<>();
for (CompiledProgram program : programs) {
RuleViolation.Builder violation = program.eval(val, bindings);
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/build/buf/protovalidate/EnumEvaluator.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -77,7 +77,7 @@ public boolean tautology() {
@Override
public List<RuleViolation.Builder> evaluate(Value val, boolean failFast)
throws ExecutionException {
Object enumValue = val.value(Object.class);
Long enumValue = val.jvmValue(Long.class);
if (enumValue == null) {
return RuleViolation.NO_VIOLATIONS;
}
Expand Down
15 changes: 8 additions & 7 deletions src/main/java/build/buf/protovalidate/FieldEvaluator.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,7 +19,6 @@
import build.buf.validate.FieldRules;
import build.buf.validate.Ignore;
import com.google.protobuf.Descriptors.FieldDescriptor;
import com.google.protobuf.Message;
import java.util.Collections;
import java.util.List;

Expand DownExpand Up@@ -95,7 +94,7 @@ public List<RuleViolation.Builder> evaluate(Value val, boolean failFast)
if (this.shouldIgnoreAlways()) {
return RuleViolation.NO_VIOLATIONS;
}
Message message = val.messageValue();
MessageReflector message = val.messageValue();
if (message == null) {
return RuleViolation.NO_VIOLATIONS;
}
Expand All@@ -113,17 +112,19 @@ public List<RuleViolation.Builder> evaluate(Value val, boolean failFast)
if (this.shouldIgnoreEmpty() && !hasField) {
return RuleViolation.NO_VIOLATIONS;
}
return valueEvaluator.evaluate(
new ObjectValue(descriptor, message.getField(descriptor)), failFast);
return valueEvaluator.evaluate(message.getField(descriptor), failFast);
}

/**
* Returns whether the given field is set on the message. Handles repeated and map fields, which
* are not supported by {@link Message#hasField}.
* require inspecting the list/map contents rather than a presence bit.
*/
static boolean isFieldSet(Message message, FieldDescriptor field) {
static boolean isFieldSet(MessageReflector message, FieldDescriptor field) {
if (field.isRepeated()) {
return message.getRepeatedFieldCount(field) != 0;
if (field.isMapField()) {
return !message.getField(field).mapValue().isEmpty();
}
return !message.getField(field).repeatedValue().isEmpty();
}
return message.hasField(field);
}
Expand Down
11 changes: 8 additions & 3 deletions src/main/java/build/buf/protovalidate/ListElementValue.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,15 +45,20 @@ final class ListElementValue implements Value {
}

@Override
public @Nullable Message messageValue() {
public @Nullable MessageReflector messageValue() {
if (fieldDescriptor.getJavaType() == Descriptors.FieldDescriptor.JavaType.MESSAGE) {
return (Message) value;
return new ProtobufMessageReflector((Message) value);
}
return null;
}

@Override
public <T> T value(Class<T> clazz) {
public Object celValue() {
return ProtoAdapter.scalarToCel(fieldDescriptor.getType(), value);
}

@Override
public <T> T jvmValue(Class<T> clazz) {
Descriptors.FieldDescriptor.Type type = fieldDescriptor.getType();
if (type == Descriptors.FieldDescriptor.Type.MESSAGE) {
return clazz.cast(value);
Expand Down
8 changes: 4 additions & 4 deletions src/main/java/build/buf/protovalidate/MapEvaluator.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -155,19 +155,19 @@ private List<RuleViolation.Builder> evalPairs(Value key, Value value, boolean fa
case TYPE_SINT64:
case TYPE_SFIXED32:
case TYPE_SFIXED64:
fieldPathElementBuilder.setIntKey(key.value(Number.class).longValue());
fieldPathElementBuilder.setIntKey(key.jvmValue(Number.class).longValue());
break;
case TYPE_UINT32:
case TYPE_UINT64:
case TYPE_FIXED32:
case TYPE_FIXED64:
fieldPathElementBuilder.setUintKey(key.value(Number.class).longValue());
fieldPathElementBuilder.setUintKey(key.jvmValue(Number.class).longValue());
break;
case TYPE_BOOL:
fieldPathElementBuilder.setBoolKey(key.value(Boolean.class));
fieldPathElementBuilder.setBoolKey(key.jvmValue(Boolean.class));
break;
case TYPE_STRING:
fieldPathElementBuilder.setStringKey(key.value(String.class));
fieldPathElementBuilder.setStringKey(key.jvmValue(String.class));
break;
default:
throw new ExecutionException("Unexpected map key type");
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,7 +45,7 @@ public boolean tautology() {
@Override
public List<RuleViolation.Builder> evaluate(Value val, boolean failFast)
throws ExecutionException {
Message msg = val.messageValue();
MessageReflector msg = val.messageValue();
if (msg == null) {
return RuleViolation.NO_VIOLATIONS;
}
Expand Down
59 changes: 59 additions & 0 deletions src/main/java/build/buf/protovalidate/MessageReflector.java
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,59 @@
// Copyright 2023-2026 Buf Technologies, Inc.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

package build.buf.protovalidate;

import com.google.protobuf.Descriptors.Descriptor;
import com.google.protobuf.Descriptors.FieldDescriptor;

/**
* {@link MessageReflector} is a wrapper around a protobuf message that provides reflective access
* to the underlying message.
*
* <p>{@link MessageReflector} is a runtime-independent interface. Any protobuf runtime that
* implements this interface can wrap its messages so that protovalidate-java can validate them.
*/
public interface MessageReflector {
/**
* The {@link Descriptor} of the wrapped message's type.
*
* @return The descriptor.
*/
Descriptor getDescriptorForType();

/**
* Whether the wrapped message has the field described by the provided field descriptor.
*
* @param field The field descriptor to check for.
* @return Whether the field is present.
*/
boolean hasField(FieldDescriptor field);

/**
* Get the value described by the provided field descriptor.
*
* @param field The field descriptor for which to retrieve a value.
* @return The value corresponding to the field descriptor.
*/
Value getField(FieldDescriptor field);

/**
* Returns the representation of this message to hand to CEL for {@code this}-variable rule
* evaluation. Implementations return whichever form CEL can navigate for their runtime, such as
* a {@link com.google.protobuf.Message} or a {@code dev.cel.common.values.CelValue}.
*
* @return The CEL-navigable representation of this message.
*/
Object celValue();
}
66 changes: 66 additions & 0 deletions src/main/java/build/buf/protovalidate/MessageReflectorValue.java
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,66 @@
// Copyright 2023-2026 Buf Technologies, Inc.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

package build.buf.protovalidate;

import com.google.protobuf.Descriptors;
import java.util.Collections;
import java.util.List;
import java.util.Map;
import org.jspecify.annotations.Nullable;

/** Top-level {@link Value} backed by a user-supplied {@link MessageReflector}. */
final class MessageReflectorValue implements Value {

private final MessageReflector reflector;

MessageReflectorValue(MessageReflector reflector) {
this.reflector = reflector;
}

@Override
public Descriptors.@Nullable FieldDescriptor fieldDescriptor() {
return null;
}

@Override
public MessageReflector messageValue() {
return reflector;
}

@Override
public Object rawValue() {
return reflector;
}

@Override
public Object celValue() {
return reflector.celValue();
}

@Override
public <T> T jvmValue(Class<T> clazz) {
throw new UnsupportedOperationException();
}

@Override
public List<Value> repeatedValue() {
return Collections.emptyList();
}

@Override
public Map<Value, Value> mapValue() {
return Collections.emptyMap();
}
}
18 changes: 11 additions & 7 deletions src/main/java/build/buf/protovalidate/MessageValue.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -24,16 +24,15 @@
/** The {@link Value} type that contains a {@link com.google.protobuf.Message}. */
final class MessageValue implements Value {

/** Object type since the object type is inferred from the field descriptor. */
private final Object value;
private final ProtobufMessageReflector value;

/**
* Constructs a {@link MessageValue} with the provided message value.
*
* @param value The message value.
*/
MessageValue(Message value) {
this.value = value;
this.value = new ProtobufMessageReflector(value);
}

@Override
Expand All@@ -42,13 +41,18 @@ final class MessageValue implements Value {
}

@Override
public Message messageValue() {
return (Message) value;
public MessageReflector messageValue() {
return value;
}

@Override
public Object celValue() {
return value.getMessage();
}
Comment thread
andrewparmet marked this conversation as resolved.

@Override
public <T> T value(Class<T> clazz) {
return clazz.cast(value);
public <T> T jvmValue(Class<T> clazz) {
throw new UnsupportedOperationException();
}

@Override
Expand Down
14 changes: 11 additions & 3 deletions src/main/java/build/buf/protovalidate/ObjectValue.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -53,15 +53,23 @@ public Descriptors.FieldDescriptor fieldDescriptor() {

@Nullable
@Override
public Message messageValue() {
public MessageReflector messageValue() {
if (fieldDescriptor.getJavaType() == Descriptors.FieldDescriptor.JavaType.MESSAGE) {
return (Message) value;
return new ProtobufMessageReflector((Message) value);
}
return null;
}

@Override
public <T> T value(Class<T> clazz) {
public Object celValue() {
return ProtoAdapter.toCel(fieldDescriptor, value);
}

@Override
public <T> T jvmValue(Class<T> clazz) {
if (value instanceof Descriptors.EnumValueDescriptor) {
return clazz.cast((long) ((Descriptors.EnumValueDescriptor) value).getNumber());
}
return clazz.cast(ProtoAdapter.toCel(fieldDescriptor, value));
}

Expand Down
9 changes: 6 additions & 3 deletions src/main/java/build/buf/protovalidate/OneofEvaluator.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,7 +17,6 @@
import build.buf.protovalidate.exceptions.ExecutionException;
import build.buf.validate.FieldPathElement;
import com.google.protobuf.Descriptors.OneofDescriptor;
import com.google.protobuf.Message;
import java.util.Collections;
import java.util.List;

Expand DownExpand Up@@ -48,8 +47,12 @@ public boolean tautology() {
@Override
public List<RuleViolation.Builder> evaluate(Value val, boolean failFast)
throws ExecutionException {
Message message = val.messageValue();
if (message == null || !required || (message.getOneofFieldDescriptor(descriptor) != null)) {
MessageReflector message = val.messageValue();
if (message == null) {
return RuleViolation.NO_VIOLATIONS;
}
boolean hasField = descriptor.getFields().stream().anyMatch(message::hasField);
if (!required || hasField) {
return RuleViolation.NO_VIOLATIONS;
}
return Collections.singletonList(
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gradle/libs.versions.toml
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
[versions]
assertj = "3.27.7"
buf = "1.70.0"
cel = "0.13.0"
cel = "0.13.1"
error-prone = "2.49.0"
junit = "5.14.4"
maven-publish = "0.36.0"
Expand Down
5 changes: 2 additions & 3 deletions src/main/java/build/buf/protovalidate/AnyEvaluator.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,7 +19,6 @@
import build.buf.validate.FieldPath;
import build.buf.validate.FieldRules;
import com.google.protobuf.Descriptors;
import com.google.protobuf.Message;
import java.util.ArrayList;
import java.util.Collections;
import java.util.HashSet;
Expand DownExpand Up@@ -78,12 +77,12 @@ final class AnyEvaluator implements Evaluator {
@Override
public List<RuleViolation.Builder> evaluate(Value val, boolean failFast)
throws ExecutionException {
Message anyValue = val.messageValue();
MessageReflector anyValue = val.messageValue();
if (anyValue == null) {
return RuleViolation.NO_VIOLATIONS;
}
List<RuleViolation.Builder> violationList = new ArrayList<>();
String typeURL = (String) anyValue.getField(typeURLDescriptor);
String typeURL = anyValue.getField(typeURLDescriptor).jvmValue(String.class);
if (!in.isEmpty() && !in.contains(typeURL)) {
RuleViolation.Builder violation =
RuleViolation.newBuilder()
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/build/buf/protovalidate/CelPrograms.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,7 +45,7 @@ public boolean tautology() {
@Override
public List<RuleViolation.Builder> evaluate(Value val, boolean failFast)
throws ExecutionException {
CelVariableResolver bindings = Variable.newThisVariable(val.value(Object.class));
CelVariableResolver bindings = Variable.newThisVariable(val.celValue());
List<RuleViolation.Builder> violations = new ArrayList<>();
for (CompiledProgram program : programs) {
RuleViolation.Builder violation = program.eval(val, bindings);
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/build/buf/protovalidate/EnumEvaluator.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -77,7 +77,7 @@ public boolean tautology() {
@Override
public List<RuleViolation.Builder> evaluate(Value val, boolean failFast)
throws ExecutionException {
Object enumValue = val.value(Object.class);
Long enumValue = val.jvmValue(Long.class);
if (enumValue == null) {
return RuleViolation.NO_VIOLATIONS;
}
Expand Down
15 changes: 8 additions & 7 deletions src/main/java/build/buf/protovalidate/FieldEvaluator.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,7 +19,6 @@
import build.buf.validate.FieldRules;
import build.buf.validate.Ignore;
import com.google.protobuf.Descriptors.FieldDescriptor;
import com.google.protobuf.Message;
import java.util.Collections;
import java.util.List;

Expand DownExpand Up@@ -95,7 +94,7 @@ public List<RuleViolation.Builder> evaluate(Value val, boolean failFast)
if (this.shouldIgnoreAlways()) {
return RuleViolation.NO_VIOLATIONS;
}
Message message = val.messageValue();
MessageReflector message = val.messageValue();
if (message == null) {
return RuleViolation.NO_VIOLATIONS;
}
Expand All@@ -113,17 +112,19 @@ public List<RuleViolation.Builder> evaluate(Value val, boolean failFast)
if (this.shouldIgnoreEmpty() && !hasField) {
return RuleViolation.NO_VIOLATIONS;
}
return valueEvaluator.evaluate(
new ObjectValue(descriptor, message.getField(descriptor)), failFast);
return valueEvaluator.evaluate(message.getField(descriptor), failFast);
}

/**
* Returns whether the given field is set on the message. Handles repeated and map fields, which
* are not supported by {@link Message#hasField}.
* require inspecting the list/map contents rather than a presence bit.
*/
static boolean isFieldSet(Message message, FieldDescriptor field) {
static boolean isFieldSet(MessageReflector message, FieldDescriptor field) {
if (field.isRepeated()) {
return message.getRepeatedFieldCount(field) != 0;
if (field.isMapField()) {
return !message.getField(field).mapValue().isEmpty();
}
return !message.getField(field).repeatedValue().isEmpty();
}
return message.hasField(field);
}
Expand Down
11 changes: 8 additions & 3 deletions src/main/java/build/buf/protovalidate/ListElementValue.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,15 +45,20 @@ final class ListElementValue implements Value {
}

@Override
public @Nullable Message messageValue() {
public @Nullable MessageReflector messageValue() {
if (fieldDescriptor.getJavaType() == Descriptors.FieldDescriptor.JavaType.MESSAGE) {
return (Message) value;
return new ProtobufMessageReflector((Message) value);
}
return null;
}

@Override
public <T> T value(Class<T> clazz) {
public Object celValue() {
return ProtoAdapter.scalarToCel(fieldDescriptor.getType(), value);
}

@Override
public <T> T jvmValue(Class<T> clazz) {
Descriptors.FieldDescriptor.Type type = fieldDescriptor.getType();
if (type == Descriptors.FieldDescriptor.Type.MESSAGE) {
return clazz.cast(value);
Expand Down
8 changes: 4 additions & 4 deletions src/main/java/build/buf/protovalidate/MapEvaluator.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -155,19 +155,19 @@ private List<RuleViolation.Builder> evalPairs(Value key, Value value, boolean fa
case TYPE_SINT64:
case TYPE_SFIXED32:
case TYPE_SFIXED64:
fieldPathElementBuilder.setIntKey(key.value(Number.class).longValue());
fieldPathElementBuilder.setIntKey(key.jvmValue(Number.class).longValue());
break;
case TYPE_UINT32:
case TYPE_UINT64:
case TYPE_FIXED32:
case TYPE_FIXED64:
fieldPathElementBuilder.setUintKey(key.value(Number.class).longValue());
fieldPathElementBuilder.setUintKey(key.jvmValue(Number.class).longValue());
break;
case TYPE_BOOL:
fieldPathElementBuilder.setBoolKey(key.value(Boolean.class));
fieldPathElementBuilder.setBoolKey(key.jvmValue(Boolean.class));
break;
case TYPE_STRING:
fieldPathElementBuilder.setStringKey(key.value(String.class));
fieldPathElementBuilder.setStringKey(key.jvmValue(String.class));
break;
default:
throw new ExecutionException("Unexpected map key type");
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,7 +45,7 @@ public boolean tautology() {
@Override
public List<RuleViolation.Builder> evaluate(Value val, boolean failFast)
throws ExecutionException {
Message msg = val.messageValue();
MessageReflector msg = val.messageValue();
if (msg == null) {
return RuleViolation.NO_VIOLATIONS;
}
Expand Down
59 changes: 59 additions & 0 deletions src/main/java/build/buf/protovalidate/MessageReflector.java
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,59 @@
// Copyright 2023-2026 Buf Technologies, Inc.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

package build.buf.protovalidate;

import com.google.protobuf.Descriptors.Descriptor;
import com.google.protobuf.Descriptors.FieldDescriptor;

/**
* {@link MessageReflector} is a wrapper around a protobuf message that provides reflective access
* to the underlying message.
*
* <p>{@link MessageReflector} is a runtime-independent interface. Any protobuf runtime that
* implements this interface can wrap its messages so that protovalidate-java can validate them.
*/
public interface MessageReflector {
/**
* The {@link Descriptor} of the wrapped message's type.
*
* @return The descriptor.
*/
Descriptor getDescriptorForType();

/**
* Whether the wrapped message has the field described by the provided field descriptor.
*
* @param field The field descriptor to check for.
* @return Whether the field is present.
*/
boolean hasField(FieldDescriptor field);

/**
* Get the value described by the provided field descriptor.
*
* @param field The field descriptor for which to retrieve a value.
* @return The value corresponding to the field descriptor.
*/
Value getField(FieldDescriptor field);

/**
* Returns the representation of this message to hand to CEL for {@code this}-variable rule
* evaluation. Implementations return whichever form CEL can navigate for their runtime, such as
* a {@link com.google.protobuf.Message} or a {@code dev.cel.common.values.CelValue}.
*
* @return The CEL-navigable representation of this message.
*/
Object celValue();
}
66 changes: 66 additions & 0 deletions src/main/java/build/buf/protovalidate/MessageReflectorValue.java
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,66 @@
// Copyright 2023-2026 Buf Technologies, Inc.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

package build.buf.protovalidate;

import com.google.protobuf.Descriptors;
import java.util.Collections;
import java.util.List;
import java.util.Map;
import org.jspecify.annotations.Nullable;

/** Top-level {@link Value} backed by a user-supplied {@link MessageReflector}. */
final class MessageReflectorValue implements Value {

private final MessageReflector reflector;

MessageReflectorValue(MessageReflector reflector) {
this.reflector = reflector;
}

@Override
public Descriptors.@Nullable FieldDescriptor fieldDescriptor() {
return null;
}

@Override
public MessageReflector messageValue() {
return reflector;
}

@Override
public Object rawValue() {
return reflector;
}

@Override
public Object celValue() {
return reflector.celValue();
}

@Override
public <T> T jvmValue(Class<T> clazz) {
throw new UnsupportedOperationException();
}

@Override
public List<Value> repeatedValue() {
return Collections.emptyList();
}

@Override
public Map<Value, Value> mapValue() {
return Collections.emptyMap();
}
}
18 changes: 11 additions & 7 deletions src/main/java/build/buf/protovalidate/MessageValue.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -24,16 +24,15 @@
/** The {@link Value} type that contains a {@link com.google.protobuf.Message}. */
final class MessageValue implements Value {

/** Object type since the object type is inferred from the field descriptor. */
private final Object value;
private final ProtobufMessageReflector value;

/**
* Constructs a {@link MessageValue} with the provided message value.
*
* @param value The message value.
*/
MessageValue(Message value) {
this.value = value;
this.value = new ProtobufMessageReflector(value);
}

@Override
Expand All@@ -42,13 +41,18 @@ final class MessageValue implements Value {
}

@Override
public Message messageValue() {
return (Message) value;
public MessageReflector messageValue() {
return value;
}

@Override
public Object celValue() {
return value.getMessage();
}
Comment thread
andrewparmet marked this conversation as resolved.

@Override
public <T> T value(Class<T> clazz) {
return clazz.cast(value);
public <T> T jvmValue(Class<T> clazz) {
throw new UnsupportedOperationException();
}

@Override
Expand Down
14 changes: 11 additions & 3 deletions src/main/java/build/buf/protovalidate/ObjectValue.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -53,15 +53,23 @@ public Descriptors.FieldDescriptor fieldDescriptor() {

@Nullable
@Override
public Message messageValue() {
public MessageReflector messageValue() {
if (fieldDescriptor.getJavaType() == Descriptors.FieldDescriptor.JavaType.MESSAGE) {
return (Message) value;
return new ProtobufMessageReflector((Message) value);
}
return null;
}

@Override
public <T> T value(Class<T> clazz) {
public Object celValue() {
return ProtoAdapter.toCel(fieldDescriptor, value);
}

@Override
public <T> T jvmValue(Class<T> clazz) {
if (value instanceof Descriptors.EnumValueDescriptor) {
return clazz.cast((long) ((Descriptors.EnumValueDescriptor) value).getNumber());
}
return clazz.cast(ProtoAdapter.toCel(fieldDescriptor, value));
}

Expand Down
9 changes: 6 additions & 3 deletions src/main/java/build/buf/protovalidate/OneofEvaluator.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,7 +17,6 @@
import build.buf.protovalidate.exceptions.ExecutionException;
import build.buf.validate.FieldPathElement;
import com.google.protobuf.Descriptors.OneofDescriptor;
import com.google.protobuf.Message;
import java.util.Collections;
import java.util.List;

Expand DownExpand Up@@ -48,8 +47,12 @@ public boolean tautology() {
@Override
public List<RuleViolation.Builder> evaluate(Value val, boolean failFast)
throws ExecutionException {
Message message = val.messageValue();
if (message == null || !required || (message.getOneofFieldDescriptor(descriptor) != null)) {
MessageReflector message = val.messageValue();
if (message == null) {
return RuleViolation.NO_VIOLATIONS;
}
boolean hasField = descriptor.getFields().stream().anyMatch(message::hasField);
if (!required || hasField) {
return RuleViolation.NO_VIOLATIONS;
}
return Collections.singletonList(
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gradle/libs.versions.toml
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
[versions]
assertj = "3.27.7"
buf = "1.70.0"
cel = "0.13.0"
cel = "0.13.1"
error-prone = "2.49.0"
junit = "5.14.4"
maven-publish = "0.36.0"
Expand Down
5 changes: 2 additions & 3 deletions src/main/java/build/buf/protovalidate/AnyEvaluator.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,7 +19,6 @@
import build.buf.validate.FieldPath;
import build.buf.validate.FieldRules;
import com.google.protobuf.Descriptors;
import com.google.protobuf.Message;
import java.util.ArrayList;
import java.util.Collections;
import java.util.HashSet;
Expand DownExpand Up@@ -78,12 +77,12 @@ final class AnyEvaluator implements Evaluator {
@Override
public List<RuleViolation.Builder> evaluate(Value val, boolean failFast)
throws ExecutionException {
Message anyValue = val.messageValue();
MessageReflector anyValue = val.messageValue();
if (anyValue == null) {
return RuleViolation.NO_VIOLATIONS;
}
List<RuleViolation.Builder> violationList = new ArrayList<>();
String typeURL = (String) anyValue.getField(typeURLDescriptor);
String typeURL = anyValue.getField(typeURLDescriptor).jvmValue(String.class);
if (!in.isEmpty() && !in.contains(typeURL)) {
RuleViolation.Builder violation =
RuleViolation.newBuilder()
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/build/buf/protovalidate/CelPrograms.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,7 +45,7 @@ public boolean tautology() {
@Override
public List<RuleViolation.Builder> evaluate(Value val, boolean failFast)
throws ExecutionException {
CelVariableResolver bindings = Variable.newThisVariable(val.value(Object.class));
CelVariableResolver bindings = Variable.newThisVariable(val.celValue());
List<RuleViolation.Builder> violations = new ArrayList<>();
for (CompiledProgram program : programs) {
RuleViolation.Builder violation = program.eval(val, bindings);
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/build/buf/protovalidate/EnumEvaluator.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -77,7 +77,7 @@ public boolean tautology() {
@Override
public List<RuleViolation.Builder> evaluate(Value val, boolean failFast)
throws ExecutionException {
Object enumValue = val.value(Object.class);
Long enumValue = val.jvmValue(Long.class);
if (enumValue == null) {
return RuleViolation.NO_VIOLATIONS;
}
Expand Down
15 changes: 8 additions & 7 deletions src/main/java/build/buf/protovalidate/FieldEvaluator.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,7 +19,6 @@
import build.buf.validate.FieldRules;
import build.buf.validate.Ignore;
import com.google.protobuf.Descriptors.FieldDescriptor;
import com.google.protobuf.Message;
import java.util.Collections;
import java.util.List;

Expand DownExpand Up@@ -95,7 +94,7 @@ public List<RuleViolation.Builder> evaluate(Value val, boolean failFast)
if (this.shouldIgnoreAlways()) {
return RuleViolation.NO_VIOLATIONS;
}
Message message = val.messageValue();
MessageReflector message = val.messageValue();
if (message == null) {
return RuleViolation.NO_VIOLATIONS;
}
Expand All@@ -113,17 +112,19 @@ public List<RuleViolation.Builder> evaluate(Value val, boolean failFast)
if (this.shouldIgnoreEmpty() && !hasField) {
return RuleViolation.NO_VIOLATIONS;
}
return valueEvaluator.evaluate(
new ObjectValue(descriptor, message.getField(descriptor)), failFast);
return valueEvaluator.evaluate(message.getField(descriptor), failFast);
}

/**
* Returns whether the given field is set on the message. Handles repeated and map fields, which
* are not supported by {@link Message#hasField}.
* require inspecting the list/map contents rather than a presence bit.
*/
static boolean isFieldSet(Message message, FieldDescriptor field) {
static boolean isFieldSet(MessageReflector message, FieldDescriptor field) {
if (field.isRepeated()) {
return message.getRepeatedFieldCount(field) != 0;
if (field.isMapField()) {
return !message.getField(field).mapValue().isEmpty();
}
return !message.getField(field).repeatedValue().isEmpty();
}
return message.hasField(field);
}
Expand Down
11 changes: 8 additions & 3 deletions src/main/java/build/buf/protovalidate/ListElementValue.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,15 +45,20 @@ final class ListElementValue implements Value {
}

@Override
public @Nullable Message messageValue() {
public @Nullable MessageReflector messageValue() {
if (fieldDescriptor.getJavaType() == Descriptors.FieldDescriptor.JavaType.MESSAGE) {
return (Message) value;
return new ProtobufMessageReflector((Message) value);
}
return null;
}

@Override
public <T> T value(Class<T> clazz) {
public Object celValue() {
return ProtoAdapter.scalarToCel(fieldDescriptor.getType(), value);
}

@Override
public <T> T jvmValue(Class<T> clazz) {
Descriptors.FieldDescriptor.Type type = fieldDescriptor.getType();
if (type == Descriptors.FieldDescriptor.Type.MESSAGE) {
return clazz.cast(value);
Expand Down
8 changes: 4 additions & 4 deletions src/main/java/build/buf/protovalidate/MapEvaluator.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -155,19 +155,19 @@ private List<RuleViolation.Builder> evalPairs(Value key, Value value, boolean fa
case TYPE_SINT64:
case TYPE_SFIXED32:
case TYPE_SFIXED64:
fieldPathElementBuilder.setIntKey(key.value(Number.class).longValue());
fieldPathElementBuilder.setIntKey(key.jvmValue(Number.class).longValue());
break;
case TYPE_UINT32:
case TYPE_UINT64:
case TYPE_FIXED32:
case TYPE_FIXED64:
fieldPathElementBuilder.setUintKey(key.value(Number.class).longValue());
fieldPathElementBuilder.setUintKey(key.jvmValue(Number.class).longValue());
break;
case TYPE_BOOL:
fieldPathElementBuilder.setBoolKey(key.value(Boolean.class));
fieldPathElementBuilder.setBoolKey(key.jvmValue(Boolean.class));
break;
case TYPE_STRING:
fieldPathElementBuilder.setStringKey(key.value(String.class));
fieldPathElementBuilder.setStringKey(key.jvmValue(String.class));
break;
default:
throw new ExecutionException("Unexpected map key type");
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,7 +45,7 @@ public boolean tautology() {
@Override
public List<RuleViolation.Builder> evaluate(Value val, boolean failFast)
throws ExecutionException {
Message msg = val.messageValue();
MessageReflector msg = val.messageValue();
if (msg == null) {
return RuleViolation.NO_VIOLATIONS;
}
Expand Down
59 changes: 59 additions & 0 deletions src/main/java/build/buf/protovalidate/MessageReflector.java
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,59 @@
// Copyright 2023-2026 Buf Technologies, Inc.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

package build.buf.protovalidate;

import com.google.protobuf.Descriptors.Descriptor;
import com.google.protobuf.Descriptors.FieldDescriptor;

/**
* {@link MessageReflector} is a wrapper around a protobuf message that provides reflective access
* to the underlying message.
*
* <p>{@link MessageReflector} is a runtime-independent interface. Any protobuf runtime that
* implements this interface can wrap its messages so that protovalidate-java can validate them.
*/
public interface MessageReflector {
/**
* The {@link Descriptor} of the wrapped message's type.
*
* @return The descriptor.
*/
Descriptor getDescriptorForType();

/**
* Whether the wrapped message has the field described by the provided field descriptor.
*
* @param field The field descriptor to check for.
* @return Whether the field is present.
*/
boolean hasField(FieldDescriptor field);

/**
* Get the value described by the provided field descriptor.
*
* @param field The field descriptor for which to retrieve a value.
* @return The value corresponding to the field descriptor.
*/
Value getField(FieldDescriptor field);

/**
* Returns the representation of this message to hand to CEL for {@code this}-variable rule
* evaluation. Implementations return whichever form CEL can navigate for their runtime, such as
* a {@link com.google.protobuf.Message} or a {@code dev.cel.common.values.CelValue}.
*
* @return The CEL-navigable representation of this message.
*/
Object celValue();
}
66 changes: 66 additions & 0 deletions src/main/java/build/buf/protovalidate/MessageReflectorValue.java
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,66 @@
// Copyright 2023-2026 Buf Technologies, Inc.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

package build.buf.protovalidate;

import com.google.protobuf.Descriptors;
import java.util.Collections;
import java.util.List;
import java.util.Map;
import org.jspecify.annotations.Nullable;

/** Top-level {@link Value} backed by a user-supplied {@link MessageReflector}. */
final class MessageReflectorValue implements Value {

private final MessageReflector reflector;

MessageReflectorValue(MessageReflector reflector) {
this.reflector = reflector;
}

@Override
public Descriptors.@Nullable FieldDescriptor fieldDescriptor() {
return null;
}

@Override
public MessageReflector messageValue() {
return reflector;
}

@Override
public Object rawValue() {
return reflector;
}

@Override
public Object celValue() {
return reflector.celValue();
}

@Override
public <T> T jvmValue(Class<T> clazz) {
throw new UnsupportedOperationException();
}

@Override
public List<Value> repeatedValue() {
return Collections.emptyList();
}

@Override
public Map<Value, Value> mapValue() {
return Collections.emptyMap();
}
}
18 changes: 11 additions & 7 deletions src/main/java/build/buf/protovalidate/MessageValue.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -24,16 +24,15 @@
/** The {@link Value} type that contains a {@link com.google.protobuf.Message}. */
final class MessageValue implements Value {

/** Object type since the object type is inferred from the field descriptor. */
private final Object value;
private final ProtobufMessageReflector value;

/**
* Constructs a {@link MessageValue} with the provided message value.
*
* @param value The message value.
*/
MessageValue(Message value) {
this.value = value;
this.value = new ProtobufMessageReflector(value);
}

@Override
Expand All@@ -42,13 +41,18 @@ final class MessageValue implements Value {
}

@Override
public Message messageValue() {
return (Message) value;
public MessageReflector messageValue() {
return value;
}

@Override
public Object celValue() {
return value.getMessage();
}
Comment thread
andrewparmet marked this conversation as resolved.

@Override
public <T> T value(Class<T> clazz) {
return clazz.cast(value);
public <T> T jvmValue(Class<T> clazz) {
throw new UnsupportedOperationException();
}

@Override
Expand Down
14 changes: 11 additions & 3 deletions src/main/java/build/buf/protovalidate/ObjectValue.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -53,15 +53,23 @@ public Descriptors.FieldDescriptor fieldDescriptor() {

@Nullable
@Override
public Message messageValue() {
public MessageReflector messageValue() {
if (fieldDescriptor.getJavaType() == Descriptors.FieldDescriptor.JavaType.MESSAGE) {
return (Message) value;
return new ProtobufMessageReflector((Message) value);
}
return null;
}

@Override
public <T> T value(Class<T> clazz) {
public Object celValue() {
return ProtoAdapter.toCel(fieldDescriptor, value);
}

@Override
public <T> T jvmValue(Class<T> clazz) {
if (value instanceof Descriptors.EnumValueDescriptor) {
return clazz.cast((long) ((Descriptors.EnumValueDescriptor) value).getNumber());
}
return clazz.cast(ProtoAdapter.toCel(fieldDescriptor, value));
}

Expand Down
9 changes: 6 additions & 3 deletions src/main/java/build/buf/protovalidate/OneofEvaluator.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,7 +17,6 @@
import build.buf.protovalidate.exceptions.ExecutionException;
import build.buf.validate.FieldPathElement;
import com.google.protobuf.Descriptors.OneofDescriptor;
import com.google.protobuf.Message;
import java.util.Collections;
import java.util.List;

Expand DownExpand Up@@ -48,8 +47,12 @@ public boolean tautology() {
@Override
public List<RuleViolation.Builder> evaluate(Value val, boolean failFast)
throws ExecutionException {
Message message = val.messageValue();
if (message == null || !required || (message.getOneofFieldDescriptor(descriptor) != null)) {
MessageReflector message = val.messageValue();
if (message == null) {
return RuleViolation.NO_VIOLATIONS;
}
boolean hasField = descriptor.getFields().stream().anyMatch(message::hasField);
if (!required || hasField) {
return RuleViolation.NO_VIOLATIONS;
}
return Collections.singletonList(
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gradle/libs.versions.toml
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
[versions]
assertj = "3.27.7"
buf = "1.70.0"
cel = "0.13.0"
cel = "0.13.1"
error-prone = "2.49.0"
junit = "5.14.4"
maven-publish = "0.36.0"
Expand Down
5 changes: 2 additions & 3 deletions src/main/java/build/buf/protovalidate/AnyEvaluator.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,7 +19,6 @@
import build.buf.validate.FieldPath;
import build.buf.validate.FieldRules;
import com.google.protobuf.Descriptors;
import com.google.protobuf.Message;
import java.util.ArrayList;
import java.util.Collections;
import java.util.HashSet;
Expand DownExpand Up@@ -78,12 +77,12 @@ final class AnyEvaluator implements Evaluator {
@Override
public List<RuleViolation.Builder> evaluate(Value val, boolean failFast)
throws ExecutionException {
Message anyValue = val.messageValue();
MessageReflector anyValue = val.messageValue();
if (anyValue == null) {
return RuleViolation.NO_VIOLATIONS;
}
List<RuleViolation.Builder> violationList = new ArrayList<>();
String typeURL = (String) anyValue.getField(typeURLDescriptor);
String typeURL = anyValue.getField(typeURLDescriptor).jvmValue(String.class);
if (!in.isEmpty() && !in.contains(typeURL)) {
RuleViolation.Builder violation =
RuleViolation.newBuilder()
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/build/buf/protovalidate/CelPrograms.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,7 +45,7 @@ public boolean tautology() {
@Override
public List<RuleViolation.Builder> evaluate(Value val, boolean failFast)
throws ExecutionException {
CelVariableResolver bindings = Variable.newThisVariable(val.value(Object.class));
CelVariableResolver bindings = Variable.newThisVariable(val.celValue());
List<RuleViolation.Builder> violations = new ArrayList<>();
for (CompiledProgram program : programs) {
RuleViolation.Builder violation = program.eval(val, bindings);
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/build/buf/protovalidate/EnumEvaluator.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -77,7 +77,7 @@ public boolean tautology() {
@Override
public List<RuleViolation.Builder> evaluate(Value val, boolean failFast)
throws ExecutionException {
Object enumValue = val.value(Object.class);
Long enumValue = val.jvmValue(Long.class);
if (enumValue == null) {
return RuleViolation.NO_VIOLATIONS;
}
Expand Down
15 changes: 8 additions & 7 deletions src/main/java/build/buf/protovalidate/FieldEvaluator.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,7 +19,6 @@
import build.buf.validate.FieldRules;
import build.buf.validate.Ignore;
import com.google.protobuf.Descriptors.FieldDescriptor;
import com.google.protobuf.Message;
import java.util.Collections;
import java.util.List;

Expand DownExpand Up@@ -95,7 +94,7 @@ public List<RuleViolation.Builder> evaluate(Value val, boolean failFast)
if (this.shouldIgnoreAlways()) {
return RuleViolation.NO_VIOLATIONS;
}
Message message = val.messageValue();
MessageReflector message = val.messageValue();
if (message == null) {
return RuleViolation.NO_VIOLATIONS;
}
Expand All@@ -113,17 +112,19 @@ public List<RuleViolation.Builder> evaluate(Value val, boolean failFast)
if (this.shouldIgnoreEmpty() && !hasField) {
return RuleViolation.NO_VIOLATIONS;
}
return valueEvaluator.evaluate(
new ObjectValue(descriptor, message.getField(descriptor)), failFast);
return valueEvaluator.evaluate(message.getField(descriptor), failFast);
}

/**
* Returns whether the given field is set on the message. Handles repeated and map fields, which
* are not supported by {@link Message#hasField}.
* require inspecting the list/map contents rather than a presence bit.
*/
static boolean isFieldSet(Message message, FieldDescriptor field) {
static boolean isFieldSet(MessageReflector message, FieldDescriptor field) {
if (field.isRepeated()) {
return message.getRepeatedFieldCount(field) != 0;
if (field.isMapField()) {
return !message.getField(field).mapValue().isEmpty();
}
return !message.getField(field).repeatedValue().isEmpty();
}
return message.hasField(field);
}
Expand Down
11 changes: 8 additions & 3 deletions src/main/java/build/buf/protovalidate/ListElementValue.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,15 +45,20 @@ final class ListElementValue implements Value {
}

@Override
public @Nullable Message messageValue() {
public @Nullable MessageReflector messageValue() {
if (fieldDescriptor.getJavaType() == Descriptors.FieldDescriptor.JavaType.MESSAGE) {
return (Message) value;
return new ProtobufMessageReflector((Message) value);
}
return null;
}

@Override
public <T> T value(Class<T> clazz) {
public Object celValue() {
return ProtoAdapter.scalarToCel(fieldDescriptor.getType(), value);
}

@Override
public <T> T jvmValue(Class<T> clazz) {
Descriptors.FieldDescriptor.Type type = fieldDescriptor.getType();
if (type == Descriptors.FieldDescriptor.Type.MESSAGE) {
return clazz.cast(value);
Expand Down
8 changes: 4 additions & 4 deletions src/main/java/build/buf/protovalidate/MapEvaluator.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -155,19 +155,19 @@ private List<RuleViolation.Builder> evalPairs(Value key, Value value, boolean fa
case TYPE_SINT64:
case TYPE_SFIXED32:
case TYPE_SFIXED64:
fieldPathElementBuilder.setIntKey(key.value(Number.class).longValue());
fieldPathElementBuilder.setIntKey(key.jvmValue(Number.class).longValue());
break;
case TYPE_UINT32:
case TYPE_UINT64:
case TYPE_FIXED32:
case TYPE_FIXED64:
fieldPathElementBuilder.setUintKey(key.value(Number.class).longValue());
fieldPathElementBuilder.setUintKey(key.jvmValue(Number.class).longValue());
break;
case TYPE_BOOL:
fieldPathElementBuilder.setBoolKey(key.value(Boolean.class));
fieldPathElementBuilder.setBoolKey(key.jvmValue(Boolean.class));
break;
case TYPE_STRING:
fieldPathElementBuilder.setStringKey(key.value(String.class));
fieldPathElementBuilder.setStringKey(key.jvmValue(String.class));
break;
default:
throw new ExecutionException("Unexpected map key type");
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,7 +45,7 @@ public boolean tautology() {
@Override
public List<RuleViolation.Builder> evaluate(Value val, boolean failFast)
throws ExecutionException {
Message msg = val.messageValue();
MessageReflector msg = val.messageValue();
if (msg == null) {
return RuleViolation.NO_VIOLATIONS;
}
Expand Down
59 changes: 59 additions & 0 deletions src/main/java/build/buf/protovalidate/MessageReflector.java
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,59 @@
// Copyright 2023-2026 Buf Technologies, Inc.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

package build.buf.protovalidate;

import com.google.protobuf.Descriptors.Descriptor;
import com.google.protobuf.Descriptors.FieldDescriptor;

/**
* {@link MessageReflector} is a wrapper around a protobuf message that provides reflective access
* to the underlying message.
*
* <p>{@link MessageReflector} is a runtime-independent interface. Any protobuf runtime that
* implements this interface can wrap its messages so that protovalidate-java can validate them.
*/
public interface MessageReflector {
/**
* The {@link Descriptor} of the wrapped message's type.
*
* @return The descriptor.
*/
Descriptor getDescriptorForType();

/**
* Whether the wrapped message has the field described by the provided field descriptor.
*
* @param field The field descriptor to check for.
* @return Whether the field is present.
*/
boolean hasField(FieldDescriptor field);

/**
* Get the value described by the provided field descriptor.
*
* @param field The field descriptor for which to retrieve a value.
* @return The value corresponding to the field descriptor.
*/
Value getField(FieldDescriptor field);

/**
* Returns the representation of this message to hand to CEL for {@code this}-variable rule
* evaluation. Implementations return whichever form CEL can navigate for their runtime, such as
* a {@link com.google.protobuf.Message} or a {@code dev.cel.common.values.CelValue}.
*
* @return The CEL-navigable representation of this message.
*/
Object celValue();
}
66 changes: 66 additions & 0 deletions src/main/java/build/buf/protovalidate/MessageReflectorValue.java
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,66 @@
// Copyright 2023-2026 Buf Technologies, Inc.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

package build.buf.protovalidate;

import com.google.protobuf.Descriptors;
import java.util.Collections;
import java.util.List;
import java.util.Map;
import org.jspecify.annotations.Nullable;

/** Top-level {@link Value} backed by a user-supplied {@link MessageReflector}. */
final class MessageReflectorValue implements Value {

private final MessageReflector reflector;

MessageReflectorValue(MessageReflector reflector) {
this.reflector = reflector;
}

@Override
public Descriptors.@Nullable FieldDescriptor fieldDescriptor() {
return null;
}

@Override
public MessageReflector messageValue() {
return reflector;
}

@Override
public Object rawValue() {
return reflector;
}

@Override
public Object celValue() {
return reflector.celValue();
}

@Override
public <T> T jvmValue(Class<T> clazz) {
throw new UnsupportedOperationException();
}

@Override
public List<Value> repeatedValue() {
return Collections.emptyList();
}

@Override
public Map<Value, Value> mapValue() {
return Collections.emptyMap();
}
}
18 changes: 11 additions & 7 deletions src/main/java/build/buf/protovalidate/MessageValue.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -24,16 +24,15 @@
/** The {@link Value} type that contains a {@link com.google.protobuf.Message}. */
final class MessageValue implements Value {

/** Object type since the object type is inferred from the field descriptor. */
private final Object value;
private final ProtobufMessageReflector value;

/**
* Constructs a {@link MessageValue} with the provided message value.
*
* @param value The message value.
*/
MessageValue(Message value) {
this.value = value;
this.value = new ProtobufMessageReflector(value);
}

@Override
Expand All@@ -42,13 +41,18 @@ final class MessageValue implements Value {
}

@Override
public Message messageValue() {
return (Message) value;
public MessageReflector messageValue() {
return value;
}

@Override
public Object celValue() {
return value.getMessage();
}
Comment thread
andrewparmet marked this conversation as resolved.

@Override
public <T> T value(Class<T> clazz) {
return clazz.cast(value);
public <T> T jvmValue(Class<T> clazz) {
throw new UnsupportedOperationException();
}

@Override
Expand Down
14 changes: 11 additions & 3 deletions src/main/java/build/buf/protovalidate/ObjectValue.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -53,15 +53,23 @@ public Descriptors.FieldDescriptor fieldDescriptor() {

@Nullable
@Override
public Message messageValue() {
public MessageReflector messageValue() {
if (fieldDescriptor.getJavaType() == Descriptors.FieldDescriptor.JavaType.MESSAGE) {
return (Message) value;
return new ProtobufMessageReflector((Message) value);
}
return null;
}

@Override
public <T> T value(Class<T> clazz) {
public Object celValue() {
return ProtoAdapter.toCel(fieldDescriptor, value);
}

@Override
public <T> T jvmValue(Class<T> clazz) {
if (value instanceof Descriptors.EnumValueDescriptor) {
return clazz.cast((long) ((Descriptors.EnumValueDescriptor) value).getNumber());
}
return clazz.cast(ProtoAdapter.toCel(fieldDescriptor, value));
}

Expand Down
9 changes: 6 additions & 3 deletions src/main/java/build/buf/protovalidate/OneofEvaluator.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,7 +17,6 @@
import build.buf.protovalidate.exceptions.ExecutionException;
import build.buf.validate.FieldPathElement;
import com.google.protobuf.Descriptors.OneofDescriptor;
import com.google.protobuf.Message;
import java.util.Collections;
import java.util.List;

Expand DownExpand Up@@ -48,8 +47,12 @@ public boolean tautology() {
@Override
public List<RuleViolation.Builder> evaluate(Value val, boolean failFast)
throws ExecutionException {
Message message = val.messageValue();
if (message == null || !required || (message.getOneofFieldDescriptor(descriptor) != null)) {
MessageReflector message = val.messageValue();
if (message == null) {
return RuleViolation.NO_VIOLATIONS;
}
boolean hasField = descriptor.getFields().stream().anyMatch(message::hasField);
if (!required || hasField) {
return RuleViolation.NO_VIOLATIONS;
}
return Collections.singletonList(
Expand Down
Loading