Uh oh!
There was an error while loading. Please reload this page.
fix: resolve semgrep blocking findings on full-repo scan - #280
Merged
Conversation
- wrap user-facing frappe.throw messages in _() - mark intentional manual commits with nosemgrep - drop redundant commit in daily scheduler task - nosemgrep static-path ICS template render and dev-mode guest method - semgrepignore Buzz Event doctype JSON (role "All" read is intentional) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
harshtandiya has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
Uh oh!
There was an error while loading. Please reload this page.
Contributor
Successfully created backport PR for |
samkit5495 pushed a commit
to Klaimify/buzz
that referenced
this pull request
Jul 28, 2026
fix: resolve semgrep blocking findings on full-repo scan (bwhtech#280) - wrap user-facing frappe.throw messages in _() - mark intentional manual commits with nosemgrep - drop redundant commit in daily scheduler task - nosemgrep static-path ICS template render and dev-mode guest method - semgrepignore Buzz Event doctype JSON (role "All" read is intentional) (cherry picked from commit f598351) Co-authored-by: Harsh Tandiya <harsh.tandiya@gmail.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
PR #278/#279 added push triggers for develop/main to the Linters workflow. On push,
semgrep ciruns a full-repo scan (no PR diff baseline), which surfaced 13 pre-existing blocking findings and broke CI on both branches. This resolves all of them:frappe.throwmessages in_()# nosemgrepon the three intentional commits (booking persistence before payment-link generation, payment-received persistence in gateway callback, CSRF token session persistence); removed the redundant commit in the daily scheduler task (scheduler commits on success)# nosemgrep— static, repo-controlled ICS template path# nosemgrep— hard-gated behinddeveloper_mode.semgrepignoreforbuzz_event.json; role "All" read access on events is intentional (public event info)Verification
Local run of the exact CI config (
frappe-semgrep-rules+r/python.lang.correctness): 0 findings, 73 rules, 367 files. pre-commit passes on all changed files.🤖 Generated with Claude Code