Uh oh!
There was an error while loading. Please reload this page.
fix: prefill "To" when composing email on proposal doctypes - #293
Merged
Conversation
Frappe's communication composer resolves the recipient from the form's get_email_recipients handler, which none of the proposal doctypes defined, so the "To" field opened empty. Talk Proposal sources recipients from the speakers child table, the only place emails are stored. Event Proposal and Sponsorship Enquiry carry no contact email, so both fall back to the submitting user. Closes#246 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
Contributor
Successfully created backport PR for |
samkit5495 pushed a commit
to Klaimify/buzz
that referenced
this pull request
Jul 28, 2026
) fix: prefill "To" when composing email on proposal doctypes (bwhtech#293) Frappe's communication composer resolves the recipient from the form's get_email_recipients handler, which none of the proposal doctypes defined, so the "To" field opened empty. Talk Proposal sources recipients from the speakers child table, the only place emails are stored. Event Proposal and Sponsorship Enquiry carry no contact email, so both fall back to the submitting user. Closesbwhtech#246 (cherry picked from commit a79850b) Co-authored-by: Harsh Tandiya <harsh.tandiya@gmail.com> Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#246
Clicking "New Email" on a proposal doctype opened the composer with an empty "To" field.
Frappe's composer resolves the default recipient through the form's
get_email_recipients(frm, fieldname)handler (frappe/public/js/frappe/views/communication.js), falling back tofrm.email_field/doc.email_id/doc.email. The proposal doctypes define none of these, so nothing was prefilled.Each doctype now defines the handler:
speakerschild table, the only place addresses are stored.Proposal Speaker.emailis mandatory, so there is always at least one.owneras"Guest", which is skipped.No schema changes, no patch, no migration.
Verified manually in desk: the composer opens with "To" populated.
🤖 Generated with Claude Code