Uh oh!
There was an error while loading. Please reload this page.
refactor(api): split buzz/api into typed domain packages - #307
Merged
Conversation
Contributor
Too many files changed for review. ( Bypass the limit by tagging |
harshtandiyaforce-pushed
the
backport/api-refactor-to-main
branch
from
July 29, 2026 18:35
a4f52b2 to
9ae0e7fCompareUh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The per-PR backport flow stalled after #294, so
mainis missing the wholebuzz/apirefactorseries plus the CI work that went with it. The individual backport PRs (#304, #306) were closed
rather than merged, and cherry-picking the rest one at a time doesn't work — everything from #296
onward edits the package layout that #295 created, so each one conflicts without its base.
Batching them into a single PR instead.
git log --cherry-pick --left-only main...developisempty — every commit on
mainalready has a patch-equivalent ondevelop— so this is a contentsuperset, not a merge exercise.
Pointing the branch at
developHEAD directly still conflicted, though: the merge base isc6cb341, and because past backports landed onmainas fresh cherry-picks, a three-way mergesees both sides adding the same changes (
buzz/api/forms.pyreads as "deleted in develop, modifiedin main"). None of it is real divergence. So this branch is one commit parented on
mainwhosetree is byte-identical to
developata4f52b2—git diff <branch> developis empty. Since itsquash-merges anyway,
mainends up with exactly the same commit either way.What lands (109 files, +5751 / −2524), folding in:
a08b6c7709481366396adbuzz/apiinto domain packages11e7d6f30c669814cecdc8f7653de218c1e36eb7bf6de3cd0a4f52b2Worth knowing before merging:
buzz/hooks.pyhas two live changes:require_type_annotated_api_methods = True, and the appscreen's
has_permissionmoves tobuzz.api.account.has_app_permission. Deployments trackingmainneed abench migrate+ restart to pick up the new path.buzz.api.*import paths change shape. In-repo callers are all carried here; anything outsidethis repo importing
buzz.api.<name>directly will break.ci.ymlandui-tests.ymlare rewritten around the new.github/actions/setup-benchcompositeaction, so this PR is validating its own CI changes.
No schema patches, no version bumps, no dependency changes —
patches.txt,pyproject.tomlandboth
package.jsonfiles are untouched. Squash-merging to keepmain's one-commit-per-backporthistory.