Uh oh!
There was an error while loading. Please reload this page.
fix(proposals): confirm before accepting a talk proposal - #309
Merged
Conversation
"Accept and Create Talk" fired on a single click and did real work: it creates an Event Talk and, for every speaker without an account, a User and a Speaker Profile. Move it into the Actions dropdown and put a confirmation in front of it. The status change moves server-side into create_talk. It used to happen in the browser as an un-awaited frm.save() followed straight away by frm.refresh() and a route change, which left two responses racing: the second one hit frappe.hide_msgprint() while the first dialog was still fading out, and the late hidden.bs.modal handler emptied the dialog body after the new message had been appended. The visible result was a blank "Message" box. Doing both writes in one request removes the race, and makes the two writes atomic -- previously a failed save left the talk created but the proposal still un-accepted, and the retry hit "Talk already created for this proposal!" with no way forward. Speaker Users are now created as Website Users. They sign in to the dashboard, not the desk, same as the booking flow. Co-authored-by: Claude Opus 5 <noreply@anthropic.com> (cherry picked from commit 063e518)
harshtandiya
approved these changes
Jul 29, 2026
harshtandiya
enabled auto-merge
July 29, 2026 19:26
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated backport of #308 to
main.