Uh oh!
There was an error while loading. Please reload this page.
chore(dashboard): convert vite config to TypeScript - #386
Merged
Conversation
* chore(dashboard): convert vite config to TypeScript `tsconfig.json` included only `src/` and `tests/`, so the vite config was checked by nothing. Renaming it and adding it to `include` puts it under `yarn typecheck`. The conversion needs `frappe-ui/vite` to have types, which it does not ship — it is plain JavaScript with no declarations. The ambient declaration added here covers only the options its plugins actually read, which is what makes this worth doing: passing a key frappe-ui ignores is now a type error instead of config that looks applied and is not. Re-adding the `target` key removed in the previous commit fails typecheck with TS2353. `tailwind.config.js` and `postcss.config.js` are still unchecked. They would need `allowJs` or their own conversion, and neither is carrying dead config. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * chore(dashboard): trim vite config comments Drops the link-to-docs line and cuts the two optimizeDeps comments to the part that is not recoverable from the code: why frappe-ui is excluded and why its nested feather-icons is not. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com> (cherry picked from commit fa49530)
Resolves the conflict with #384, which dropped the dead chunkSizeWarningLimit and target keys from the build config now living in vite.config.ts.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated backport of #383 to
main.