Fix various tests to pass CI again

[kubkon]

Fixes path_open_read_without_rights test making the CI green again. :-) The bug must have snuck in #770.

[kubkon]

cc @marmistrz

[marmistrz]

Whoops, sorry and thanks for the swift fix!

[kubkon]

Whoops, sorry and thanks for the swift fix!

No probs! It seems that there were a couple more issues not related to #770 that needed fixing :-) This should now hopefully green the CI again :-)

[peterhuene]

Beat you by 4 seconds :)

[kubkon]

Beat you by 4 seconds :)

Haha, nice one! You get the 🐎 then :-D

[kubkon]

@peterhuene The funny thing is, you've manage to beat not only me but also Github which now reckons you haven't approved the PR even though you did ;-)

[peterhuene]

👍

[sunfishcode]

And y'all beat me to uploading my own version of this PR :-}. Thanks for fixing this!

[kubkon]

@sunfishcode There is still chance to collaborate on this PR though. Help with fixing this would be highly appreciated:

---- tests::test_custom_signal_handler_single_instance stdout ----
memory: base=0x299e9d000, length=65536
calling read...
Hello from instance signal handler!
signal handled: true
calling read_out_of_bounds...
Hello from instance signal handler!
signal handled: false
thread 'tests::test_custom_signal_handler_single_instance' panicked at 'assertion failed: trap.root_cause().to_string().starts_with("trapped: Ref(Trap { message: \"wasm trap: out of bounds memory access")', tests/custom_signal_handler.rs:106:13
stack backtrace:
0: <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt
1: core::fmt::write
2: std::io::Write::write_fmt
3: std::io::impls::<impl std::io::Write for alloc::boxed::Box<W>>::write_fmt
4: std::panicking::default_hook::{{closure}}
5: std::panicking::default_hook
6: std::panicking::rust_panic_with_hook
7: std::panicking::begin_panic
8: custom_signal_handler::tests::test_custom_signal_handler_single_instance
9: <alloc::boxed::Box<F> as core::ops::function::FnOnce<A>>::call_once
10: __rust_maybe_catch_panic

[peterhuene]

Looks like a starts_with assertion needs fixing to the new format (presumably removing Ref().

[kubkon]

Looks like a starts_with assertion needs fixing to the new format (presumably removing Ref().

Oh, cool. If you point me to the line, I can fix it. Alternatively, if you want to push a commit to this PR , feel free! :-)

[peterhuene]

I believe Ref( should be removed from this line:

wasmtime/tests/custom_signal_handler.rs

Line 107 in 61f9b8a

"trapped: Ref(Trap { message: \"wasm trap: out of bounds memory access"

[kubkon]

I believe Ref( should be removed from this line:

wasmtime/tests/custom_signal_handler.rs

Line 107 in 61f9b8a

"trapped: Ref(Trap { message: \"wasm trap: out of bounds memory access"

Ah, of course, well spotted! Thanks!

[sunfishcode]

Trap messages updated!

[kubkon]

@sunfishcode What do you know, now you've beat me to it! :-}

[peterhuene]

Merging to unblock CI.