Uh oh!
There was an error while loading. Please reload this page.
Use --release on tests in CI - #1201
Conversation
I have a hunch this is why C# is so slow (the modules are big and there's a lot of them and unoptimized Cranelift is very slow).
jsturtevant
commented
Mar 11, 2025
The windows runtime tests also build in debug mode, with might slow it down too? wit-bindgen/tests/runtime/main.rs Line 744 in d73c073 |
alexcrichton
commented
Mar 11, 2025
Looks like C# on windows was 32m53s before this change and 25m37s after this change. Good wins, but just building the rust test harness took 8m35s in debug mode and 16m03s in release mode, so looks like this is +8m to rust build time but -15m to C# testing time. Overall seems like a good win! With #1192 this should only get better since we basically won't have to build Wasmtime in CI any more. |
alexcrichton
commented
Mar 11, 2025
Oh also wanted to mention: good point! I'll try evaluating this in a future PR |
pchickey
commented
Mar 11, 2025
Do you want this approved to land? Unsure how to interpret "Test out" in title |
--release on tests in CI--release on tests in CIalexcrichton
commented
Mar 11, 2025
Oh sorry, yes, given that this shaves off a nontrivial chunk of time with C# I think it'd be good to land (updated title to be more confident) |
I have a hunch this is why C# is so slow (the modules are big and there's a lot of them and unoptimized Cranelift is very slow).