Uh oh!
There was an error while loading. Please reload this page.
Add an example tcp_echo_server_non_blocking - #32
Conversation
pchickey
commented
Nov 27, 2024
Thanks for submitting this. We will want to exercise this with a test like we do for the tcp_echo_server. As far as the style, this uses |
Heap-Hop
commented
Nov 28, 2024
Done. It does need a test, but due to bytecodealliance/wasmtime#9667, I haven’t found a good way to write one yet. |
| futures_lite::future::poll_fn(|cx| { | ||
| if let Poll::Ready(_) = listening_task.as_mut().poll(cx) { | ||
| return Poll::Ready(()); |
There was a problem hiding this comment.
I don't think we want to return as Ready until both the Listener is ready and the stream tasks are all complete.
There was a problem hiding this comment.
Sorry, I didn't quite understand what you meant. Could you please tell me your thoughts directly?
pchickey
commented
Dec 28, 2024
pchickey
commented
Sep 11, 2025
With #86, this example has been changed to use tasks, and so it no longer has the blocking behavior. |
Heap-Hop
commented
Sep 12, 2025
Cool! |
#25