Skip to content

Implement an HTTP server framework. - #52

Merged
pchickey merged 19 commits into
bytecodealliance:mainfrom
sunfishcode:sunfishcode/http-server
Jan 13, 2025
Merged

Implement an HTTP server framework.#52
pchickey merged 19 commits into
bytecodealliance:mainfrom
sunfishcode:sunfishcode/http-server

Conversation

@sunfishcode

@sunfishcodesunfishcode commented Jan 10, 2025

Copy link
Copy Markdown
Member

Add a wstd API for creating HTTP server applications, wrapping the WASI proxy world trait and macro.

This is split out from #34 to separate it from the client API changes for easier reviewing.

@sunfishcode
Implement an HTTP server framework.
083dc21
Add a wstd API for creating HTTP server applications, wrapping the
WASI proxy world trait and macro.
Compiling the example with `RUSTFLAGS="-Clink-arg=--wasi-adapter=proxy"`
produces a program that runs in `wasmtime serve`.
@sunfishcode
Add a way to consume trailers from an IncomingBody.
7f23b8f
@sunfishcode
Add an HTTP server test.
9441f82
@sunfishcode
Update to wasi 0.14.0, eliminating .to_owned() calls.
77b097e
@sunfishcode

This comment was marked as resolved.

Sign in to view
pchickey
pchickey reviewed Jan 11, 2025
View reviewed changes

@pchickeypchickey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a lot of really great work! Various quibbles.

Comment threadexamples/http_server.rs Outdated
Comment threadtest-programs/artifacts/tests/http_server.rs Outdated
Comment threadsrc/http/server.rs Outdated
Comment threadmacro/src/lib.rs Outdated
Comment threadmacro/src/lib.rs Outdated
Comment threadsrc/http/fields.rs
Comment threadsrc/http/request.rs Outdated
.map_err(|_| WasiHttpErrorCode::HttpRequestMethodInvalid)?;
let scheme = match incoming.scheme() {
Some(scheme) => Some(
from_wasi_scheme(scheme).expect("TODO: what shall we do with an invalid uri here?"),

@pchickeypchickeyJan 10, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's a good answer to all of these expect/todos when using wstd::error::Error so can we clean all those up before landing?

Comment threadsrc/http/fields.rs Outdated
Comment threadCargo.toml Outdated
Comment threadexamples/http_server.rs Outdated
pchickey
pchickey reviewed Jan 11, 2025
View reviewed changes
Comment threadsrc/time/duration.rs
pchickey
pchickey approved these changes Jan 13, 2025
View reviewed changes

@pchickeypchickey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to go, if needed we can golf on some of the error TODOs later without changing any interfaces, so we can land this whenever you are ready.

@pchickey
pchickey merged commit 35f28d2 into bytecodealliance:mainJan 13, 2025
@sunfishcode
sunfishcode deleted the sunfishcode/http-server branch January 14, 2025 17:24
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pchickeypchickeypchickey approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sunfishcode@pchickey