Skip to content

fix: trim routes for android - no more then 6 tabs - #38

Merged
okwasniewski merged 5 commits into
callstack:mainfrom
mrpmohiburrahman:mrp/no-more-then-6-tabs-android
Oct 14, 2024
Merged

okwasniewski merged 5 commits into
callstack:mainfrom
mrpmohiburrahman:mrp/no-more-then-6-tabs-android

Conversation

@mrpmohiburrahman

@mrpmohiburrahman mrpmohiburrahman commented Oct 12, 2024

Copy link
Copy Markdown
Contributor

This PR fixes issue #13

Right now it will show a warning if there are more than 6 tabs on android and will only show 6 tabs and trims the other tabs.

warning-when-more-than-6-tabs.mp4

Comment thread src/TabView.tsx Outdated
Comment thread src/TabView.tsx Outdated
Comment thread src/TabView.tsx Outdated
@mrpmohiburrahman

Copy link
Copy Markdown
Contributor Author

Hi, @okwasniewski ,
Thanks for the reviews.
I fixed those.

@okwasniewski okwasniewski left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Great work 🙌

@mrpmohiburrahman

Copy link
Copy Markdown
Contributor Author

Thanks! Great work 🙌

I'm excited to contribute further.

Please let me know if there are any other issues I can assist with.

@okwasniewski
okwasniewski merged commit caa5e7b into callstack:main Oct 14, 2024
@okwasniewski

okwasniewski commented Oct 14, 2024

Copy link
Copy Markdown
Collaborator

Thanks! Great work 🙌

I'm excited to contribute further.

Please let me know if there are any other issues I can assist with.

Awesome! This could be a good issue to work on next: #15 I'll try to create more soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants