Uh oh!
There was an error while loading. Please reload this page.
fix(722): revert not working back navigation gesture in favour of PagerView inside ScrollView - #933
Conversation
…gerView inside ScrollView
MrRefactor
commented
Nov 28, 2024
@MateWW please update recordings as we dont use |
troZee
commented
Nov 28, 2024
@kkafar could you check, if this change is still needed to |
I encountered an issue while using 'react-native-yamap' (version 4.x) inside a tab navigator implemented with '@react-navigation/material-top-tabs' (version 7.x) on a project running Expo SDK 52 (React Native 0.76). Specifically, starting from 'react-native-pager-view' version 6.2.0, the map stopped responding to gestures on iOS. Applying the patch from this PR to version 6.7.0 fixed the issue for me. @MateWW, thanks for this solution. |
Summary
Resolves#722!
Issue
Currently scroll over legacy pager view is not working while nested inside scroll view.
Nesting might be necessary while we have big header which you don't want to be visible while you are swiping pages.
Root cause
The issue arise with 6.2.0 version and support for navigate back gesture.
Solution
I've tested that navigate back gesture and it didn't worked for me as you may see on attached video.
I've also checked if basic react native ScrollView supports that for horizontal mode and it's not.
Based on all above I believe it's not worth to block users and I reverted that change.
I think we can revisit that use case later and fix that long living regression.
Test Plan
2-pager-view-bug-fabric-ios.mp4
2-pager-view-fix-fabric-ios.mp4
2-pager-view-bug-paper-ios.mp4
2-pager-view-fix-paper-ios.mp4
Compatibility
Checklist