Uh oh!
There was an error while loading. Please reload this page.
chore: deprecate some a11y queries - #1226
Conversation
4fae1c7 to
2078fa5CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| }, | ||
| 'AccessibilityState', | ||
| 'Role(role, { disabled, selected, checked, busy, expanded }) query or expect(...).toHaveAccessibilityState(...) matcher' | ||
| 'Use {queryPrefix}ByRole(role, { disabled, selected, checked, busy, expanded }) query or expect(...).toHaveAccessibilityState(...) matcher instead.' |
pierrezimmermannbam
left a comment
There was a problem hiding this comment.
Looks very good ! Great deprecation warnings and documentation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Codecov ReportBase: 95.98% // Head: 96.04% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@## main #1226 +/- ##
==========================================
+ Coverage 95.98% 96.04% +0.06%
==========================================
Files 47 49 +2 Lines 3240 3290 +50 Branches 489 494 +5 ==========================================
+ Hits 3110 3160 +50
Misses 130 130
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Summary
Make
*ByA11yStateand*ByA11yValuequeries deprecated, redirecting user to use*ByRolequeries ortoHaveAcessbibilityState/Value()matchers.When doing any of the mentioned queries, user will received following warning to console:
Resolves#1208
Test plan
Add tests for deprecation messages warnings.