Organise a11y queries by predicate

[MattAgn]

Summary

This PR aims to continue solving this issue by using makeQueries for all a11yQueries.

Tasks:

• group all a11y queries by their predicate type (byRole, byA11yState...) by using makeQueries instead of makeA11yQueries
• split the tests for each query as well
• remove the old makeA11yQueries helper

Warning

• The API has changed, I aligned the error messages to the same ones used for the other (non A11y) queries

Test plan

No tests should be added since the API does not change, they only need to be moved to be grouped by predicate type

[MattAgn]

Hi @mdjastrzebski, I'm mostly done with this PR, just got a couple questions for you:

• What do you think about extracting the helpers matchString and matchObject in the helpers folder? We use them respectively 3 and 2 times
• Now that we've split all the tests in their separate files, I think it could be nice to split them a little bit more by use case scenarios. I've done an example here. I think it makes the API and the tests clearer, what do you think?

[mdjastrzebski]

Great job @MattAgn! This is exactly what I was looking for! 💯

There are some small missing parts like aliased exports, please check comments.

Re moving matchString, etc to helpers: I think it's a good idea. I'd suggest helpers/machers.ts or similar for that purpose.

Re re-organizing tests a bit: I would suggest doing it in a separate PR, in order to reduce change surface area. This PR should just split existing tests into separate files without modifications. You're welcome re-organise them a little bit more in the follow-up PR :-)

[MattAgn]

Great job @MattAgn! This is exactly what I was looking for! 💯

There are some small missing parts like aliased exports, please check comments.

Re moving matchString, etc to helpers: I think it's a good idea. I'd suggest helpers/machers.ts or similar for that purpose.

Re re-organizing tests a bit: I would suggest doing it in a separate PR, in order to reduce change surface area. This PR should just split existing tests into separate files without modifications. You're welcome re-organise them a little bit more in the follow-up PR :-)

Thanks!

Re moving matchString, etc to helpers: got it, will do so

Re re-organizing tests a bit: sure I'll do that :)

[mdjastrzebski]

@MattAgn let me know if you need any help with this PR.

[MattAgn]

@mdjastrzebski sure thanks! for now I'm good, sorry I did not have much time to work on it the past 2 weeks, but I have some time this weekend. I'll let you know how it goes :)

[mdjastrzebski]

Looks good

[mdjastrzebski]

Weird stuff tests work fine on my local machine but timeout on CI.

[thymikee]

@mdjastrzebski Try increasing the timeout then

[mdjastrzebski]

@thymikee actually is not ma matter of timeout, I've tried to increase that but this is not the cause. Normally tests run around 1,5 minutes (other PR runs checked in Circle CI), but for this particular PR they run most of the tests (but not all) and then Jest gets stuck, no output, etc. It will wait till Circle CI no output limit and then timeout after 10 minutes or so.

[thymikee]

Awesome work @MattAgn and @mdjastrzebski 🚀

[MattAgn]

@mdjastrzebski thanks for the finishing touches! :)