Skip to content

Ninja makefile fallback - #108

Draft
kraenhansen wants to merge 3 commits into
mainfrom
kh/ninja-makefile-fallback
Draft

Ninja makefile fallback#108
kraenhansen wants to merge 3 commits into
mainfrom
kh/ninja-makefile-fallback

Conversation

@kraenhansen

Copy link
Copy Markdown
Collaborator

This fixes#95 by adding a check and a fallback to Unix Makefiles.

Currently in draft because it building weak-node-api fails when the fallback is used:

image

@kraenhansenkraenhansen self-assigned this May 22, 2025
@kraenhansenkraenhansen added the enhancement New feature or request label May 22, 2025
@changeset-bot

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: aba1cde

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@shirakaba

shirakaba commented Jun 21, 2025

Copy link
Copy Markdown
Collaborator

Does the fact that Chromium is dropping Ninja in favour of Siso have any impact on this?

@kraenhansen

Copy link
Copy Markdown
CollaboratorAuthor

Does the fact that Chromium is dropping Ninja in favour of Siso have any impact on this?
Likely not.

Using Ninja by default is just to get the fastest builds possible and CMake doesn't support Siso:
https://cmake.org/cmake/help/latest/manual/cmake-generators.7.html#command-line-build-tool-generators

This suggested change is just a simple way to degrade gracefully, in case the Ninja is not installed, to not force library authors into using Ninja - if they absolutely doesn't want to install it.

@kraenhansen
kraenhansenforce-pushed the main branch 4 times, most recently from 90dd405 to 8dac805CompareJuly 7, 2025 12:30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancementNew feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

build-weak-node-api requires Ninja

2 participants

@kraenhansen@shirakaba