Skip to content

feat: add init command - #206

Open
dougg0k wants to merge 30 commits into
callstackincubator:mainfrom
dougg0k:add-generate-command
Open

feat: add init command#206
dougg0k wants to merge 30 commits into
callstackincubator:mainfrom
dougg0k:add-generate-command

Conversation

@dougg0k

@dougg0kdougg0k commented Jul 25, 2025

Copy link
Copy Markdown
Contributor
  • Created init command to generate / scaffold the project.
  • Replacing ferric-example with app-test, scaffolding the project there.
  • Added Cargo.toml optimizations for size. Reduce native files size #196

Ideally merge #205 first.

@changeset-bot

changeset-botBot commented Jul 25, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: efab2cb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
NameType
ferric-cliMinor
@react-native-node-api/test-appMinor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dougg0kdougg0k closed this Jul 25, 2025
@dougg0kdougg0k reopened this Jul 25, 2025
@dougg0kdougg0k mentioned this pull request Jul 26, 2025

@shirakabashirakaba left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial thoughts. I'm not too familiar with the Ferric stuff, so I defer to others.

Comment threadpackages/ferric/src/template.ts Outdated
Comment threadpackages/ferric/src/template.ts Outdated
Comment threadpackages/ferric/src/template.ts Outdated
Comment threadpackages/ferric/src/template.ts Outdated
Comment threadpackages/ferric-example/package.json
Comment threadpackages/ferric/package.json Outdated
Comment threadpackages/ferric/src/templates/Cargo.toml Outdated
Comment threadpackages/ferric/package.json Outdated
@dougg0kdougg0k changed the title feat: add generate commandfeat: add init commandJul 26, 2025
@dougg0k
dougg0k marked this pull request as ready for review July 26, 2025 22:16
@dougg0k

dougg0k commented Sep 1, 2025

Copy link
Copy Markdown
ContributorAuthor

I fixed conflicts multiple times in these PRs, will there be a merge?

If not, better to close them.


As for bad commit messages, you can squash merge, always cleaner to have one based on PR title. I doubt rollbacks ever happens, most likely fixes are done on top of what is done.

@kraenhansen

kraenhansen commented Sep 8, 2025

Copy link
Copy Markdown
Collaborator

I hope to be looking into adding an init command to ferric in the coming weeks (I could use it myself to bisect a regression across React Native versions). I don't know yet if that will be based off this PR or something written from scratch, but I'll make sure to take a thorough look here before I get started 👍

Generally speaking, briefly looking over this PR it has too many unrelated changes IMO and is very unlikely to merge as is. We want smaller, increments based off issues with s clear scope and at least some upfront design discussion (which I expect the contributor to drive) 💙

@dougg0k

Copy link
Copy Markdown
ContributorAuthor

Well, the changes are still in the context of it. Unless you mean something more than ferric-example, not sure what that would be.

The replacing were due to leaving it accordingly to the init. Hence still in the context.

@kraenhansenkraenhansen mentioned this pull request Nov 1, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@dougg0k@kraenhansen@shirakaba