Skip to content

Dynamic Configs - #199

Draft
antonleviathan wants to merge 7 commits into
mainfrom
197-request-dynamic-config-store-based-for-settings
Draft

Dynamic Configs#199
antonleviathan wants to merge 7 commits into
mainfrom
197-request-dynamic-config-store-based-for-settings

Conversation

@antonleviathan

Copy link
Copy Markdown
Contributor

Description

Refactor to use a mix of file and db stored config values

Related Issue

#197

Motivation and Context

This will make it easier to manage, specifically update, config values,

How Has This Been Tested?

TODO

Types of changes

  • Non-functional change (docs, style, minor refactor)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [x ] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my code changes.
  • All new and existing tests passed.

@antonleviathanantonleviathan added the enhancement New feature or request label Feb 12, 2023
@antonleviathan
antonleviathan marked this pull request as draft February 12, 2023 07:07
@coveralls

coveralls commented Feb 12, 2023

Copy link
Copy Markdown
Collaborator

Pull Request Test Coverage Report for Build 4184263694

  • 1 of 20(5.0%) changed or added relevant lines in 2 files are covered.
  • 9 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.4%) to 58.556%

Changes Missing CoverageCovered LinesChanged/Added Lines%
src/repositories/config-repository.ts0190.0%
Files with Coverage ReductionNew Missed Lines%
src/handlers/request-handlers/root-request-handler.ts913.79%
TotalsCoverage Status
Change from base Build 4148256062:-0.4%
Covered Lines:1168
Relevant Lines:1971

💛 - Coveralls

Comment threadseeds/initial-configs.js Outdated
@sonarqubecloud

Copy link
Copy Markdown

Comment threadseeds/configs.json Outdated
Comment threadseeds/initial-configs.js Outdated
Comment threadsrc/app/app.ts Outdated
Comment threadsrc/utils/settings.ts Outdated
Comment threadtest/integration/features/shared.ts Outdated
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancementNew feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@antonleviathan@coveralls@cameri