Skip to content

fix: lnbits broken after lnurl-pay support - #310

Merged
cameri merged 1 commit into
mainfrom
306-bug-lnbits-is-no-longer-working-in-version-123
May 19, 2023
Merged

fix: lnbits broken after lnurl-pay support#310
cameri merged 1 commit into
mainfrom
306-bug-lnbits-is-no-longer-working-in-version-123

Conversation

@cameri

@camericameri commented May 19, 2023•
edited
Loading

Copy link
Copy Markdown
Owner

Description

  1. Fix getting invoice from payment processor when given an lnbits invoice's payment hash

Related Issue

#306

Motivation and Context

LNURL-Pay support broke getting lnbit's invoice given a payment hash

How Has This Been Tested?

JohnOnChain kindly tested this branch and confirmed the fix worked.

Screenshots (if appropriate):

Types of changes

  • Non-functional change (docs, style, minor refactor)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my code changes.
  • All new and existing tests passed.

@camericameri linked an issue May 19, 2023 that may be closed by this pull request
[BUG] Lnbits is no longer working in version 1.23 #306
Closed
@sonarqubecloud

sonarqubecloudBot commented May 19, 2023

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed! Quality Gate passed

BugA0 Bugs
VulnerabilityA0 Vulnerabilities
Security HotspotA0 Security Hotspots
Code SmellA0 Code Smells

25.0%25.0% Coverage
0.0%0.0% Duplication

@camericameri self-assigned this May 19, 2023
@cameri
cameri merged commit 018f9a1 into mainMay 19, 2023
@cameri
cameri deleted the 306-bug-lnbits-is-no-longer-working-in-version-123 branch May 19, 2023 14:10
github-actionsBot pushed a commit that referenced this pull request May 19, 2023
@semantic-release-bot
chore(release): 1.24.1 [skip ci]
054b110
## [1.24.1](v1.24.0...v1.24.1) (2023-05-19)
### Bug Fixes
* lnbits broken after lnurl-pay support ([#310](#310)) ([018f9a1](018f9a1))
@github-actions

github-actionsBot commented May 19, 2023

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 1.24.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@camericameri

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] Lnbits is no longer working in version 1.23

1 participant

@cameri