Issue #432: Migrate linting and formatting to Biome - #452
Conversation
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
There was a problem hiding this comment.
Pull request overview
Migrates the project’s JavaScript/TypeScript linting + formatting workflow from ESLint (and related tooling) to Biome, updating developer docs and CI to use the new toolchain.
Changes:
- Added
biome.jsonand@biomejs/biomedev dependency; updated npm scripts to run Biome for linting/formatting. - Updated GitHub Actions CI checks to run the new lint command.
- Updated documentation and removed legacy ESLint config/ignore files.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Documents the new Biome lint/format commands under the Tests section. |
| package.json | Replaces ESLint scripts with Biome scripts; adds Biome as a dev dependency; removes ESLint-related deps. |
| CONTRIBUTING.md | Updates contributor guidance to reference Biome for code-quality checks. |
| biome.json | Introduces Biome configuration (formatter + linter rules). |
| .github/workflows/checks.yml | Updates the lint job step name and runs npm run lint (now Biome-based). |
| .eslintrc.js | Removed legacy ESLint configuration. |
| .eslintignore | Removed legacy ESLint ignore file. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
…ration # Conflicts: # package-lock.json # package.json
Priyanshubhartistm
commented
Apr 16, 2026
hi @cameri , @phoenix-server |
cameri
commented
Apr 18, 2026
@Priyanshubhartistm since we've upgraded to latest version of ESLint, do you mind addressing conflicts? |
…ration # Conflicts: # .eslintrc.js # package-lock.json # package.json
cameri
commented
Apr 18, 2026
@Priyanshubhartistm could you capture the speed and dependency disk cost improvements by migrating to Biome? I'm interested in the absolute values before/after and the % relative change to understand the impact. If you do, could you update the PR description with it or add it as a comment to the issue? Either works! |
…ration # Conflicts: # package.json
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
* chore(tooling): migrate npm tooling scripts to biome * chore(biome): add biome configuration * ci: switch lint workflow to biome * docs: update contribution and readme for biome * chore(lint): remove legacy eslint config files * docs: update lint tooling wording to biome * fix(lint): address Copilot review feedback
Priyanshubhartistm
commented
Apr 18, 2026
@cameri Here are the before/after measurements: Performance & Disk Usage
Summary: Linting is now ~7.8x faster. node_modules size increased a bit, likely due to dependency updates. Let me know if anything else is needed! |
cameri
commented
Apr 18, 2026
@Priyanshubhartistm thank you! |
Description
Related Issue
Closes#432
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
N/A
Types of changes
Checklist:
Performance & Disk Usage
node_modulessizeSummary:
Linting speed improved dramatically (~7.8 times faster).
Note: node_modules size increased slightly due to dependency changes during migration.