Skip to content

fix: check payments.enabled in callback route middleware - #616

Merged
cameri merged 1 commit into
cameri:mainfrom
Anshumancanrock:fix/callback-middleware-check-payments-enabled
May 9, 2026
Merged

fix: check payments.enabled in callback route middleware#616
cameri merged 1 commit into
cameri:mainfrom
Anshumancanrock:fix/callback-middleware-check-payments-enabled

Conversation

@Anshumancanrock

Copy link
Copy Markdown
Collaborator

Description

The requireProcessor middleware now also checks settings.payments.enabled before allowing callback requests through. Previously it only verified the processor name matched, which meant a relay with payments disabled but a processor configured could still accept callbacks.

Related Issue

Follow-up to #597

Motivation and Context

A relay operator might have payments.enabled: false with a processor still configured (e.g. during setup or after disabling payments). Without this check, callback endpoints would still accept and process requests so the middleware should reject early in that case.

How Has This Been Tested?

  • All 1261 unit tests passing
  • Updated route unit test stub to set enabled: true
  • Updated OpenNode integration test setup to set enabled: true

Types of changes

  • Bug fix

@changeset-bot

changeset-botBot commented May 8, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 5563256

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
nostreamPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coveralls

coveralls commented May 8, 2026

Copy link
Copy Markdown
Collaborator

Coverage Status

coverage: 65.086% (+0.1%) from 64.937% — Anshumancanrock:fix/callback-middleware-check-payments-enabled into cameri:main

@Anshumancanrock
Anshumancanrock marked this pull request as draft May 8, 2026 19:42
@Anshumancanrock
Anshumancanrockforce-pushed the fix/callback-middleware-check-payments-enabled branch from a629acd to 7006b40CompareMay 8, 2026 19:52
@Anshumancanrock
Anshumancanrock marked this pull request as ready for review May 8, 2026 19:58
@cameri
cameri merged commit f9f6d64 into cameri:mainMay 9, 2026
17 checks passed
@camericameri mentioned this pull request May 9, 2026
@cameri

Copy link
Copy Markdown
Owner

Thank you @Anshumancanrock !

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Anshumancanrock@coveralls@cameri