Skip to content

feat: wot#1 config - #623

Merged
cameri merged 4 commits into
cameri:mainfrom
saniddhyaDubey:feat/wot#1-config
May 24, 2026
Merged

feat: wot#1 config#623
cameri merged 4 commits into
cameri:mainfrom
saniddhyaDubey:feat/wot#1-config

Conversation

@saniddhyaDubey

Copy link
Copy Markdown
Contributor

Description

Closes (#621)

Adds the WotSettings interface and a wot: config block with safe defaults (enabled: false). This is purely additive — no runtime behaviour changes. Subsequent PRs for the graph service, worker process, and admission guard all depend on these types existing.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my code changes.
  • I added a changeset, or this is docs-only and I added an empty changeset.
  • All new and existing tests passed.

@changeset-bot

changeset-botBot commented May 22, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 1c39acc

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@saniddhyaDubeysaniddhyaDubey changed the title Feat/wot#1 configfeat: wot#1 configMay 22, 2026
@coveralls

coveralls commented May 22, 2026

Copy link
Copy Markdown
Collaborator

Coverage Status

coverage: 65.119% (+0.01%) from 65.108% — saniddhyaDubey:feat/wot#1-config into cameri:main

@cameri
cameri requested a review from CopilotMay 24, 2026 00:55

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an initial Web-of-Trust (WoT) configuration surface to the settings types and default config so follow-up WoT implementation PRs have a stable schema to build on.

Changes:

  • Introduces WoTSettings and adds wot?: WoTSettings to the main Settings interface.
  • Adds a wot: block with disabled-by-default values to resources/default-settings.yaml.
  • Adds unit tests asserting the presence of the WoT defaults and basic default/override merging behavior.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

FileDescription
src/@types/settings.tsAdds the WoTSettings interface and exposes it via Settings.wot.
resources/default-settings.yamlAdds default wot configuration values (disabled by default) and inline documentation.
test/unit/utils/settings.spec.tsAdds tests verifying WoT defaults exist and merge as expected.
.changeset/lemon-views-know.mdDeclares a minor release for the new user-facing config field.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment threadresources/default-settings.yaml
Comment threadsrc/@types/settings.ts
Comment threadtest/unit/utils/settings.spec.ts Outdated
@cameri
cameri merged commit 54139ed into cameri:mainMay 24, 2026
18 checks passed
@camericameri mentioned this pull request May 24, 2026
@saniddhyaDubey
saniddhyaDubey deleted the feat/wot#1-config branch May 24, 2026 22:36
@saniddhyaDubeysaniddhyaDubey mentioned this pull request Jun 7, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@saniddhyaDubey@coveralls@cameri